GitLab

https://skia.googlesource.com/skia/+log/57493ba62a7ec6a6038e64afa891b3c98a7cc15d..0925a5784c8424e3f9d75dbf4612ada12dc37131

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/418183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285504 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/411253011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285503 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=393046,354261

Review URL: https://codereview.chromium.org/412423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285502 0039d316-1c4b-4281-b951-d872f2087c98

* Correct spelling in several places.
* Add handling of the error during onMountCompleted event so that the
  volume shows up in UI and users can format it.

BUG=396531

Review URL: https://codereview.chromium.org/409353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285501 0039d316-1c4b-4281-b951-d872f2087c98

Attempt to fix the flakiness by making sure the server handler doesn't exit
before the client closes.

BUG=389084
R=jgraettinger,yhirano

Review URL: https://codereview.chromium.org/410383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285500 0039d316-1c4b-4281-b951-d872f2087c98

This patch puts in a heuristic that earlies out from analysis when
we have more than one draw op. The intent here is that in most cases,
if we see more than one draw operation, then analysis is likely not
to be solid.

It also removes HasText from analysis canvas, since the only
remaining use for this was a previous early out heuristic.

BUG=397198
R=enne

Review URL: https://codereview.chromium.org/418093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285499 0039d316-1c4b-4281-b951-d872f2087c98

Upstream added SSL_get0_certificate_types while we added
SSL_get_client_certificate_types in parallel. Switch to upstream's API.

BUG=388000

Review URL: https://codereview.chromium.org/415853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285498 0039d316-1c4b-4281-b951-d872f2087c98

Sync with one in the LayoutTests directory to include the code to
wait for a close frame from the client.

BUG=396399
R=jgraettinger,ricea

Review URL: https://codereview.chromium.org/415953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/415423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285496 0039d316-1c4b-4281-b951-d872f2087c98

Different orderings of notifications could previously trip up the finder.
They don't now.

BUG=397229
R=shess@chromium.org

Review URL: https://codereview.chromium.org/418103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285495 0039d316-1c4b-4281-b951-d872f2087c98

Based on the NSS implementation and loosely on the original OpenSSL code at
https://chromium.googlesource.com/chromiumos/platform/shill/+/master/shims/crypto_util.cc

BUG=393023

Review URL: https://codereview.chromium.org/396463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285494 0039d316-1c4b-4281-b951-d872f2087c98

The drive status is shown in Files.app now.
We can remove the status from the ash try.

BUG=379979
TEST=None

Review URL: https://codereview.chromium.org/410333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285493 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390624
TEST=Load the sample manifest from the bug, comment #9. It should fail to load.

Review URL: https://codereview.chromium.org/416263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396398

Review URL: https://codereview.chromium.org/411793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285491 0039d316-1c4b-4281-b951-d872f2087c98

* Breaks major steps out into functions
* Adds additional tests
* Adds support for command line flags defined in benchmarks
* Calls the PageTest RunPage directly, rather than kinda sorta reimplementing parts ourselves
* Fixes running benchmarks with record_wpr.py (crbug.com/378064)
* Page sets are referenced via class name on the command line, rather than by filename.

Other minor changes:
* Output will be different for failed pages at the end, using the default results PrintSummary() rather than a separate implementation (in this case GTestTestResults).

BUG=378064,367292

Review URL: https://codereview.chromium.org/374793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285490 0039d316-1c4b-4281-b951-d872f2087c98

Is also in chrome_browser_extensions_chromeos_sources.

BUG=354261

Review URL: https://codereview.chromium.org/420623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285489 0039d316-1c4b-4281-b951-d872f2087c98

We should allow, the read back while view is active and hold
the frame till, readback gets processed. Dont process a
readback request when the view is hidden.

BUG=376769

Review URL: https://codereview.chromium.org/418853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285488 0039d316-1c4b-4281-b951-d872f2087c98

This prevents an empty Voice section from being shown.

BUG=395509

Review URL: https://codereview.chromium.org/418693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285487 0039d316-1c4b-4281-b951-d872f2087c98

This changes the logic in the AVFoundation support check to always respect
the force-qtkit flag.

Note: This CL was only tested on OS X 10.9, and should be verified on 10.6.

BUG=396767,396764

Review URL: https://codereview.chromium.org/411983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285486 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285485 0039d316-1c4b-4281-b951-d872f2087c98

See https://webrtc-codereview.appspot.com/13059004/ for the relevant change (and revision number).

BUG=397313
NOTRY=true

Review URL: https://codereview.chromium.org/415363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334889

Review URL: https://codereview.chromium.org/398043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285483 0039d316-1c4b-4281-b951-d872f2087c98

The extensions module should not be listening to Chrome notifications.
Move the observation to ChromeProcessManagerDelegate.

BUG=396083
TEST=browser_tests ProcessManager* and unit_tests ProcessManager*

Review URL: https://codereview.chromium.org/415933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349655

TEST=Find a windows xp sp2 machine, install chrome, go to twitter.com, verify the message looks right

Review URL: https://codereview.chromium.org/336273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285481 0039d316-1c4b-4281-b951-d872f2087c98

Tests failed on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32148

> Log the certificate subjects from the server certificate sent via QUIC.
> 
> Review URL: https://codereview.chromium.org/418723002

TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/415333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285480 0039d316-1c4b-4281-b951-d872f2087c98

In a lot of filters in media code, Stop() has been folded into the dtor.
This model doesn't apply directly to DataSource because DataSource::Stop()
is called by the FFmpegDemuxer, but the DataSource is owned by
WebMediaPlayerImpl.

TBR=gbillock@chromium.org
BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/413243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285479 0039d316-1c4b-4281-b951-d872f2087c98

This should help Linux users trigger this unintentionally less often.

BUG=397359
TEST=On Linux, you should be able to drag your mouse at least 130 px away from the scrollbar before it snaps back.

Review URL: https://codereview.chromium.org/417053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285478 0039d316-1c4b-4281-b951-d872f2087c98

As a results, kill now unused results_are_the_same_on_every_page.

This unfortunately changes the behaviors in the following ways:

1) Streaming Csv/Block results output on per page run (e.g., one
output per page repeat), the streaming mode merges like values for the
same page (in case of page repeat, it merges results across repeat).

2) Ordering of output rows may change.

BUG=346956,392901

Review URL: https://codereview.chromium.org/394953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285477 0039d316-1c4b-4281-b951-d872f2087c98

Flip this back to true.  IdleHandlers should certainly be being scheduled when the content renderer client is hidden.

BUG=381820

Review URL: https://codereview.chromium.org/412143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285476 0039d316-1c4b-4281-b951-d872f2087c98

dbus::Property<std::vector<uint8> > isn't instantiated in libdbus in non-ChromeOS build + latest clang.
That causes instantiation of the template in dbus_unittests, and causes link failure.

Review URL: https://codereview.chromium.org/408143012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285475 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/414143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285474 0039d316-1c4b-4281-b951-d872f2087c98

This means that by default, Chrome will honor headers like:
  Alternate-Protocol: 80:quic
  Alternate-Protocol: 80:quic,p=1
But not:
  Alternate-Protocol: 80:quic,p=.5
Eventually we need to switch to a dynamic threshold, but on step at a time.

Review URL: https://codereview.chromium.org/411423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396403

Review URL: https://codereview.chromium.org/412033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285472 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396877

Review URL: https://codereview.chromium.org/415043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285463 0039d316-1c4b-4281-b951-d872f2087c98

Make the Linux implementation of FontRenderParams force full
hinting (along with disabling subpixel rendering and
positioning) when antialiasing is disabled. Cairo also
forces full hinting in this case.

BUG=396239

Review URL: https://codereview.chromium.org/417003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285462 0039d316-1c4b-4281-b951-d872f2087c98

I hit this building views_examples_exe on Mac with TOOLKIT_VIEWS=1.

error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]

Added in r264669.

BUG=NONE
TEST=NONE
TBR=sadrul@chromium.org,hshi@chromium.org

Review URL: https://codereview.chromium.org/413303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285461 0039d316-1c4b-4281-b951-d872f2087c98

The CL:

 * Add rotation property to the Viewport class.
 * Update the rotation property by the TouchHandler class.
 * Reset Viewport properties when changing the image.

BUG=390695
TEST=on link
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/416023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285460 0039d316-1c4b-4281-b951-d872f2087c98

PrintPreviewPdfGeneratedBrowserTest now properly reads from |std::cin| removing an edge case where |std::cin.eof()| is false, but |input.empty()| is true. The test also properly exits and doesn't wait for SIGKILL anymore.
BUG=388517

Review URL: https://codereview.chromium.org/414623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285459 0039d316-1c4b-4281-b951-d872f2087c98

They were previously enabled in shared_library builds for historical reasons.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Previous attemps failed due to:
- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/420593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285458 0039d316-1c4b-4281-b951-d872f2087c98