- 16 Mar, 2018 40 commits
-
-
Karan Bhatia authored
BUG=822752 TBR=guidou@chromium.org Change-Id: I5a2c60b22df4953c8aa207abd90650b86628edf4 Reviewed-on: https://chromium-review.googlesource.com/967019Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543798}
-
Charlie Reis authored
BUG=822635 Change-Id: Ic3966f502e8d8ee5937a96b1a006f62c73d70230 Reviewed-on: https://chromium-review.googlesource.com/967062Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#543797}
-
Charles Harrison authored
This CL makes the V4 Store perftest a bit faster by: 1. Using a smaller # of hashes in debug builds 2. Using one big string instead of a vector of full hashes, to avoid allocating and de-allocating many small strings. To get this working, needed to slightly modify V4Store to allow querying by StringPiece. (2) improved local performance on my release build by 25-30% Bug: 822624 Change-Id: I646af2b0ccfb6447ccbb94ce68b661bd235587d1 Reviewed-on: https://chromium-review.googlesource.com/965931 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#543796}
-
Chris Harrelson authored
This was an oversight in a previous CL. Bug: 818709 Change-Id: I2697d136be7af56e00f342f77451b765a37c8eaa Reviewed-on: https://chromium-review.googlesource.com/966796Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543795}
-
Marijn Kruisselbrink authored
EncodedFormData already (optionally) contains a blink::BlobDataHandle, so rather than looking up the same blob again by uuid just use that handle if we have it. This should ensure no races are possible between a blob being dereferenced (in blink) and the blob being converted into a DataPipeGetter (as looking up the blob by UUID is an async operation). Bug: 740744, 821878 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic8464b778ec91d10fdbd7688e2b680b9464fe1dc Reviewed-on: https://chromium-review.googlesource.com/964716 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#543794}
-
Corentin Wallez authored
TBR=kbr@chromium.org BUG=822733 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d8b0b6c411b8974b130e40776591897cd41760e Reviewed-on: https://chromium-review.googlesource.com/966884Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543793}
-
yiyix authored
Add RenderWidgetHost(RWH) to the RenderWidgetHostViewBase(RWHVB) constructor, so that each child class does not need to store its own RWH. Bug:716911 Change-Id: I10728cef663807e687a986f0f131f9decb067b67 Reviewed-on: https://chromium-review.googlesource.com/959456 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543792}
-
Xianzhu Wang authored
Similar to https://chromium-review.googlesource.com/961861, we should also apply paint offset with a transform operation during painting. The added tests don't work with --site-per-process yet because of crbug.com/822372. Bug: 821486 Change-Id: I83f2fd7cb1d71e2639b9c37a4e139cf274be422d Reviewed-on: https://chromium-review.googlesource.com/964728Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543791}
-
edchin authored
This CL moves magic numbers to constants files: - Various dimensions in GridCell - Margins and height of TabGridTopToolbar - Margins and height of TabGridBottomToolbar This CL also changes the toolbar classes to use |-willMoveToSuperview:| to setup views instead of |-init|. Bug: 818198, 822524 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4dcfd344c29c3e0ccee103b6002dd6e1d14fb30 Reviewed-on: https://chromium-review.googlesource.com/965576 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543790}
-
Anna Offenwanger authored
For VR UKM Metrics recording. Bug: 808584 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I98418d91b0df01c265683362349cff6365d375c8 Reviewed-on: https://chromium-review.googlesource.com/959440 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543789}
-
Karan Bhatia authored
TBR=chongz@chromium.org, kinuko@chromium.org BUG=822585 Change-Id: I926212903064753268cc217ab8ef3be4e9dfaf4c Reviewed-on: https://chromium-review.googlesource.com/967009 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Before MR2, a ThreadLocal was used to store the currentActivityThread. I don't think there are any existing calls to getProcessName() off of the main thread, so this isn't fixing an existing crash. Change-Id: If4cf17dbfe4f1cead2cc5a4ec043405ec665e922 Reviewed-on: https://chromium-review.googlesource.com/962866 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543787}
-
Tarun Bansal authored
blink-dev i2s thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/8RBFue7RMXQ/discussion Change-Id: I5595b3aed72ea0cece88948f69f480f5808fce6b Bug: 735518,782381,816661 TBR: raymes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/957265Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Tommy C. Li authored
It seems to "just work". Tested on: - Windows 10 - Windows 10 with --disable-gpu - Windows 7 - Windows 7 Classic mode (Aero disabled) Bug: 713359 Change-Id: I04466aab7e978ad51e5e579488e29789cda9ab72 Reviewed-on: https://chromium-review.googlesource.com/961552 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#543785}
-
Marijn Kruisselbrink authored
The comment incorrectly asserted that the method was only called by PingLoader. In fact the method is called for every request by devtools. So instead just ignore data pipes in the size calculation for now, just like blobs without blob data handle are ignored. If we do want actual size information for these elements at some point we'd probably just want to add an explicit size field along with the DataPipeGetter, just like network::DataElement already does for almost every other type of element. Bug: 821878 Change-Id: I6a64aaeffbcf0e22bf90bcf44c38367bf682cf3e Reviewed-on: https://chromium-review.googlesource.com/964612Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
The root PRESUBMIT.py contains _CheckNoProductionCodeUsingTestOnlyFunctions which checks against including a call to a 'for testing only' method in production code. That check has not been tested. This CL adds two tests for it. Additionally, the CL also fixes two issues in the presubmit tests: * FilterSourceFile in PRESUBMIT_test_mocks.py did not match the production version from tools/depot_tools/presubmit_support.py: the production requires the filename to be in the whitelist, while the mock version was OK with just not being in the blacklist. The CL modifies the mock version to match the production. * The test for _CheckAndroidTestJUnitInheritance did not adhere to the whitelisted filename pattern (*Test.java). This CL changes the names of the fake files to match the pattern. Bug: 821981 Change-Id: I65edf07ddb2ae26ad7d08ceb7cf4d51b482b5e56 Reviewed-on: https://chromium-review.googlesource.com/966605Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543783}
-
https://skia.googlesource.com/skia.git/+log/8b858526faf4..16c1196ea6ba $ git log 8b858526f..16c1196ea --date=short --no-merges --format='%ad %ae %s' 2018-03-16 ethannicholas fix SkSL SPIR-V geometry shaders' entry point declaration 2018-03-16 rmistry Remove Android Framework bot from CQ while server is being upgraded 2018-03-16 ethannicholas we now complain if an SkSL program tries to override the default output 2018-03-16 egdaniel Fix vulkan layout barriers when we are doing in line uploads. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I24f30c0216c31dd6705f3287bac5baeb82ffe6a2 Reviewed-on: https://chromium-review.googlesource.com/966941 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543782}
-
Chris Harrelson authored
LayoutBox::ScrolledContentOffset can be much simpler for LayoutViews, and also for LayoutBoxes that are not LayoutFlexibleBox. To tease this apart, this patch makes ScrolledContentOffset virtual to provide the more expensive implementation only when needed. Also, check for fixed-position in IsFixedPositionObjectInPagedMedia before finding the View(), which may be expensive because it involves ping- ponging through Document. Bug:818709 Change-Id: I8470b7c1487b3fbf4f227aad21e8f9da81c1e9bb Reviewed-on: https://chromium-review.googlesource.com/964933Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543781}
-
mark a. foltz authored
Disables two more tests found to be flaky. TBR=zhaobin Bug: 822231 Change-Id: I0c6a36a7d448e942ffd191ea12471f33c2729c81 Reviewed-on: https://chromium-review.googlesource.com/966983Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543780}
-
Charles Harrison authored
This CL adds a variation parameter which encodes a threshold for the Site Engagement score [1] required to do tab-unders. By default, we allow tab-unders to origins that have any non-zero engagement. This moves the Tab.TabUnder.EngagementScore metric as the last check of IsSuspiciousClientRedirect, to simulate the scores blocked tab-unders would have if we removed that check. [1]: https://www.chromium.org/developers/design-documents/site-engagement Bug: 661629 Change-Id: I48ba83ab8cc58641cc21dcad062c313f1d1290ef Reviewed-on: https://chromium-review.googlesource.com/965403Reviewed-by:
-
Ria Jiang authored
1. Clients used to submit local_surface_id in hit-test data; however, this can be racy because we have primary_surface_id and fallback_surface_id and we can use any of the latest one in that range. Change it to not using local_surface_id submitted from clients, but instead asking SurfaceAggregator at HitTestAggregator ::Aggregator() time for the latest local_surface_id to use - this is done by adding LatestLocalSurfaceIdLookupDelegate in surfaces to talk to viz::Display, where we have access to the surfaces SurfaceAggregator used at aggregation time. Add FrameSinkIdMap in SurfaceAggregator to keep track of previously contained frame sinks. 2. Keep track of the list of child regions we've aggregated so far in HitTestAggregator to prevent cycles. 3. When preparing hit-test data, skip the quad if its FrameSinkId has changed between fallback and primary because we don't know which FrameSinkId would be used to draw this quad. 4. Add viz::TestLatestLocalSurfaceIdLookupDelegate to be used in tests. Bug: 819057, 819435 Test: viz_unittests, content_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I35ec40ae00af1ba4e3937002c1c0d261dae8b136 Reviewed-on: https://chromium-review.googlesource.com/957881 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/6733f341991f..16322a374abb $ git log 6733f3419..16322a374 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 perezju [Telemetry] Remove Cherry_Mobile_Android_One condition Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0e17eb56979559a363dcb76f40a2e1e755d20768 Reviewed-on: https://chromium-review.googlesource.com/966584Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543777}
-
Daniel Murphy authored
Bug: 822723 Change-Id: Ifdfe9ac1a72c39fd9a65a82da25f27b1ec246b9c Reviewed-on: https://chromium-review.googlesource.com/966865Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#543776}
-
Julia Tuttle authored
...and take the opportunity to prune and reorder enums. Change-Id: I260f24bbe33781f27d41cf37296be0b84070f26f Reviewed-on: https://chromium-review.googlesource.com/957163 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
Add the app_shell_linux_symbols target to gn_all for official Linux desktop buliders. Bug: 818078 Change-Id: I3af605e18fe5fb85ab87f70ee3131d5176de8dde Reviewed-on: https://chromium-review.googlesource.com/963754Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543774}
-
Marijn Kruisselbrink authored
Which means that we abort transporting bytes for blobs we don't need. Also fixes a memory leak if blob is dereferenced while allocating quota. Bug: 740596 Change-Id: I03a32b920f4e213adf59b54745c2d5fe071b3132 Reviewed-on: https://chromium-review.googlesource.com/965243 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#543773}
-
Mikhail Atuchin authored
1. Fix the destruction order in extensions_tests; 2. Declare the explicit dependency: AlarmManager => ExtensionRegistry. Change-Id: Ibe734d3b39ba9a0d3dfae7c233c82c77336ec4bd Reviewed-on: https://chromium-review.googlesource.com/964144Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#543772}
-
Corentin Wallez authored
BUG=chromium:811827 BUG=chromium:811806 BUG=chromium:811790 BUG=chromium:811825 BUG=chromium:811872 BUG=chromium:811829 BUG=chromium:811819 BUG=chromium:811810 BUG=chromium:811808 BUG=chromium:811832 BUG=chromium:811797 Change-Id: Ib535f9792b3534553614617db6db976542f49201 Reviewed-on: https://chromium-review.googlesource.com/963605Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#543771}
-
liberato@chromium.org authored
Previously, DialogOverlayImpl did not close the overlay client when cleaning up. This caused the mojo router in |mClient| to be closed only when the client was GC'd, and issued warnings in logcat. Now, DialogOverlayImpl closes |mClient| properly. AndroidOverlayProviderImpl also closes the client if it fails before providing the client to a DialogOverlayImpl. Bug: 822798 Change-Id: I57657b4e1bc77e07e79a1182c5467e243d947002 Reviewed-on: https://chromium-review.googlesource.com/966868Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#543770}
-
Leonard Grey authored
Bug: 804950 Change-Id: I931bfdeefeefbbdbda626905dd14afe83e438821 Reviewed-on: https://chromium-review.googlesource.com/966929Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#543769}
-
Michael Giuffrida authored
This fixes deps and enables gn check for: //extensions/shell:app_shell //extensions/shell:app_shell_lib //extensions/shell:app_shell_unittests //extensions/shell/browser/system_logs which lets us specify //extensions/shell/* in //.gn. Some headers (esp. for NaCl) need to be annotated with // nogncheck because gn doesn't run the preprocessor: https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#what-gets-checked Bug: 367595 Change-Id: If37c5935cb993aa13f7586ee8ff17cdb23dddfc3 Reviewed-on: https://chromium-review.googlesource.com/958282Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543768}
-
Tommy Steimel authored
This CL adds 'poster' to the list of attributes that the MediaElementMutationCallback listens for. When changed, the CSS classes of the media controls are updated. This fixes a bug where a poster added after page load would not show up because it was hidden behind the default poster. Bug: 814956 Change-Id: I4b39e6995ddb35829d886e138fe8a1d573dd8036 Reviewed-on: https://chromium-review.googlesource.com/965589Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543767}
-
Stephen Chenney authored
This reverts commit c0a946a4. Reason for revert: Breaks content all over the web. Bug: 820163, 822673, 820561, 812148, 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944, 793715, 796804, 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#543766}
-
Sahel Sharifymoghaddam authored
This reverts commit f2bf009a. Reason for revert: There has been a few bug fixes related to oopif and latching, I will enable the latching flag to see if the failing tests are fixed or not. If not I will disable the tests again addressing crbug.com/822764 bug as well. Original change's description: > Disable wheel scroll latching in failing content_browsertests. > > I cannot reproduce the test failures on my local official windows build, > in this cl I force wheel scroll latching to be disabled in the tests to > see if it changes the test results on Win official or not. > > Bug: 800822 > Change-Id: Ife07a29617ca5e0142e75f926967685cb61e2a08 > Reviewed-on: https://chromium-review.googlesource.com/895842 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533347} TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 800822, 822764 Change-Id: I563672dfbcb01298324a2b884cbed0e69c220339 Reviewed-on: https://chromium-review.googlesource.com/966687Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543765}
-
Chris Palmer authored
Bug: None Change-Id: Ie37f3a53bbdde9db917e8687778a2fcb5f9c402c Reviewed-on: https://chromium-review.googlesource.com/966863 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#543764}
-
Peter Kotwicz authored
Invalid share targets will now be ignored, rather than showing up in the picker and being rejected at launch time. This brings the implementation in line with the spec: https://wicg.github.io/web-share-target/ This CL: - Makes manifest_parser.cc check the share target url_template placeholder syntax. - Refactors ReplacePlaceholders() so that it does no string copying when called with url_template_filled==nullptr BUG=694380, 788191 Change-Id: Icd2a5af5e3100fd93a3fa3cd9ba00a23905355b7 Reviewed-on: https://chromium-review.googlesource.com/927581 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
-
Karan Bhatia authored
TBR=ntfschr@chromium.org BUG=822753 Change-Id: I0ff8b5d2b1a9d5abe930e80d8a21e886ab32c457 Reviewed-on: https://chromium-review.googlesource.com/966866Reviewed-by:
-
Raphael Kubo da Costa authored
Commit 8d49c506 ("DevTools: implement a URLLoader-based request interception proxy") introduced code that triggers GCC bug 71882: declaring a class from an unnamed namespace as a friend of a class inside a named namespace does not work. ../../content/browser/devtools/devtools_url_loader_interceptor.cc: In member function ‘void content::{anonymous}::InterceptionJob::NotifyClient(std::unique_ptr<content::InterceptedRequestInfo>)’: ../../content/browser/devtools/devtools_url_loader_interceptor.cc:907:36: error: ‘content::{anonymous}::RequestInterceptedCallback content::DevToolsURLLoaderInterceptor::Impl::request_intercepted_callback_’ is private within this context base::BindOnce(interceptor_->request_intercepted_callback_, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../content/browser/devtools/devtools_url_loader_interceptor.cc:342:30: note: declared private here RequestInterceptedCallback request_intercepted_callback_; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../content/browser/devtools/devtools_url_loader_interceptor.cc: In member function ‘void content::{anonymous}::InterceptionJob::Shutdown()’: ../../content/browser/devtools/devtools_url_loader_interceptor.cc:913:32: error: ‘void content::DevToolsURLLoaderInterceptor::Impl::RemoveJob(const string&)’ is private within this context interceptor_->RemoveJob(id_); ^ ../../content/browser/devtools/devtools_url_loader_interceptor.cc:339:8: note: declared private here void RemoveJob(const std::string& id) { jobs_.erase(id); } ^~~~~~~~~ Work around the issue by fully specifying |InterceptionJob|'s namespace when declaring it a friend of |DevToolsURLLoaderInterceptor::Impl|. Change-Id: I565e169586ae0ce6ce1cd0ddbc36bd404847b386 Reviewed-on: https://chromium-review.googlesource.com/966601Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543761}
-
Mark Pilgrim authored
BUG=714018 TBR=nick@chromium.org Change-Id: Ic30f482175460a71c0a5cd78796bf9296ebc13c7 Reviewed-on: https://chromium-review.googlesource.com/963084 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#543760}
-
Farah Charab authored
Add RendererScheduler.TaskDurationPerUseCase histogram to record time we spend running tasks split per RendererScheduler's UseCase. Change-Id: I0f9a2cf0976d6a8531bc2b9f4483aa0a511b01ec Reviewed-on: https://chromium-review.googlesource.com/960821 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543759}
-
