- 10 Jan, 2020 40 commits
-
-
kylechar authored
Add some temporary member variables to BeginFrameTracker that stores the total sent/received and the last 10 sent/received BeginFrameIds. Despite adding logic to stop sending OnBeginFrame() to unresponsive clients it didn't help with the large number of unread messages in mojo message queue. This information will do a better job of verifying if client is in fact reading (and responding to) the OnBeginFrame() messages. The |begin_frame_tracker_| is included in a few minidumps I looked at it, so this information should be available in crash reports. Otherwise we'll have to copy the information into the stack in OnBeginFrame(). Bug: 1011441 Change-Id: I44112d933fb4470fb037e7bfd2d9dc05dd826a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994093Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#730310}
-
Alexander Timin authored
Our previous approach of disabling back-forward cache proved to be too aggressive. Instead, this patch adds a check that the popups would not be shown on behalf of the inactive frames and removes the old blocklist logic. R=sreejakshetty@chromium.org,vasilii@chromium.org,fhorschig@chromium.org BUG=1031076,1017693 Change-Id: I220eab19c17f9821d86b7be5ee83a7af7e674c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995166 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#730309}
-
Robbie McElrath authored
This reverts commit 5e8d35cf. Reason for revert: Caused a possible seed freshness regression. Original change's description: > [AW] Always schedule variations seed download jobs when a seed is requested > > We don't currently schedule a seed download in WebView if the previous > download occurred less than 24 hours ago, which can add an additional 24 > hours to the time between seed downloads. This CL reimplements the 24 > hour throttle to be a delay in the scheduled job, meaning a job will > always be scheduled when a new seed is requested, but Android will only > run the job once 24 hours have past since the last download. > > This CL also adds a missing hamcrest dependency to > //aw/test:webview_instrumentation_test_apk > > Test: ninja -C out/aw webview_instrumentation_test_apk > Test: out/aw/bin/run_webview_instrumentation_test_apk -f 'AwVariationsSeedFetcherTest#*' > Bug: 979075 > Change-Id: I0ea1cc8197f66b77634e8de2b145fe4228c74067 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906121 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716305} TBR=changwan@chromium.org,ntfschr@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979075 Change-Id: Iac6d048bdad48ae4bad004c5e6d27d37335cdb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994645Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#730308}
-
Kelvin Jiang authored
Introduce a new parameter to getMatchedRules which allows the extension to specify a minimum timestamp, and all matched rules more recent than that timestamp will be returned. BUG=983761 Change-Id: I55a0f4fc9ffc2be53502930b7ac2695ca4d6c905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966375 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730307}
-
Eric Orth authored
Adds some extra randomization to probe timing in anticipation of adding per-context probe runners. Mitigates issues with multiple simultaneous probe runners sending many requests around the same time when the server or network are potentially broken. Bug: 1022059 Change-Id: I59262aee4811a55050db0037b0a67a53cd4becea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993756 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#730306}
-
Karan Bhatia authored
Introduce an allowAllRequests action which will allow extensions to allow-list all requests within a frame hierarchy. This CL only adds the relevant indexing code. A follow-up CL will add the evaluation logic for these rules. BUG=1038831 Change-Id: I82004c3396f8d41241c338f970ad933d30499466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990187Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#730305}
-
Klaus Weidner authored
Change-Id: I3cc6dce5a4db4ff1d858be5cc291b17080acbc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987289 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#730304}
-
Piotr Bialecki authored
This reverts commit cd842897. Reason for revert: https://crbug.com/1040950 Original change's description: > Move away from using DFM to distribute AR-related code > > This change will make Chrome for Android stop using DFM to ship the > ARCore SDK. This is done to enable us to provide AR experiences for > apps using WebView. The changes are introduced in a way to enable us to > switch back to using AR DFM if need be. > > Changes summary: > - chrome_java target (defined in chrome/android/BUILD.gn) now also > compiles ArCoreShimImpl.java (see java_sources.gni) - this means that > java parts from ARCore SDK have to be added to its deps > - libarcore_sdk_c.so needs to be listed in loadable modules - this is > done in monochrome_public_common_apk_or_module_tmpl (only if target > is a base module when ARCore is enabled) > - AndroidManifest.xml no longer needs to contain the min_apk_version > and InstallActivity entries explicitly - they will be brought in > auto-magically by the build system and were needed only because > manifest merging did not work for DFMs > - ArCoreInstallUtils (java) should never report that we can request > installation of AR DFM > - ArCoreConsentPrompt (native) should never think it needs to request > installation of AR DFM > - Added a DCHECK and graceful handling of null jstring for java_path > (path to ARCore SDK .so) - it can be null if loadable_modules do not > contain correct entry - with the DCHECK, debug builds will still > crash but the release builds should just report that the WebXR > specified session configuration (session mode == "immersive-ar") is > not supported > > Binary-Size: Tracked in crbug/1040289 > Bug: 1031623, 1040289 > Change-Id: Ia2f305d1685f1c7207cc187d253f59a6331c36fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988834 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Auto-Submit: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729818} TBR=agrieve@chromium.org,bialpio@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1031623, 1040289 Change-Id: Ie71baf8604ae81db447a3d8b4d110ee7e4f17c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995470Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#730303}
-
danakj authored
It can go away from the process dying (a crash) or from a navigation where the main frame moves to another RenderView but the current RenderView is kept alive for another frame. R=avi@chromium.org Bug: 419087 Change-Id: Ib184e3737db46bafc3fdfc363c13c47a6e570272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995460Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#730302}
-
danakj authored
Use this method when making a new RenderWidget, either through making a RenderView or a RenderFrame. This method will reset the stored old_visual_properties_ as if SynchronizeVisualProperties() was called since the properties are being queried to send to the new RenderWidget. R=avi@chromium.org Bug: 419087 Change-Id: I71c3950dcec11444fd4cc267d8d0833fff397482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993391Reviewed-by:
-
Chris Letnick authored
This provides the owner of AvSettings to identify if HDMI specific behavior is available. Bug: internal 146016184 Test: Verified on device and cast tryjobs. Change-Id: I5eeec50e19e73c10a41205d26ff77ce15aa9daf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993654Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Chris Letnick <cletnick@google.com> Cr-Commit-Position: refs/heads/master@{#730300}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the AndroidPaymentAppFinderUnitTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: Ib3aa7908dac169f702fd0d723add1704d807561e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993422 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#730299}
-
Gavin Williams authored
This reverts commit 5c202a24. Reason for revert: Regression for printer selection dropdowns http://crbug/1036242 Original change's description: > Prevent user from saving invalid printer configuration input > > -Add a flag to cr-searchable-dropdown so we can track whether the user's > current text input in the dropdown matches the previously saved value. > We use this flag to disable the printer add button if the user typed > invalid input into either the Manufacturer or Model dropdown. > > Fixed: 950887 > Change-Id: I1f632b80fd8619718f13f8a5f5332ad7a62eb69e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880181 > Commit-Queue: Gavin Williams <gavinwill@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710888} TBR=stevenjb@chromium.org,gavinwill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9971d9505faa95492a247c0fceea9f0de46b4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994060 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#730298}
-
Randy Rossi authored
Recent changes to allow gzipped messages.json message bundles caused ChromeVox to fail on chromecast. This CL passes the proper gzip permission flag to the LoadExtension file_util routine and also makes the default locale handler aware that .gz files are also allowed when validating the bundles. Test: Local display assistant with screen reader Bug: 1038715 Change-Id: I90bf043060d243fc617acfc6760fe3a0247feee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985135Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#730297}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/3f24b6829b3e..dc2172c083f6 git log 3f24b6829b3e..dc2172c083f6 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 rharrison@google.com Implement Reflection API needed by Dawn (#950) Created with: gclient setdep -r src/third_party/shaderc/src@dc2172c083f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ib99e012ff45a0edf101cb44ed42878caf8a5e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730296}
-
Peter Kasting authored
This makes the omnibox/toolbar contrast ratio 1.3 by default. Theme authors can manually override the default colors. Bug: 878664 Change-Id: I24b95e8d225fd375b573b48e403fbf147013e940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986244 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730295}
-
Matt Mueller authored
In a future change the source id space may be partitioned to allow different processes to create netlog events with non-overlapping ids. Sorting on the source start time will allow the events to be sorted in a manner than is mostly equivalent to sorting on source id. (Aside from any minor clock differences that might exist between processes.) When starting a netlog where some events are already in progress, it would also allow one to see when the event actually started / how long it actually took. Bug: 1040681 Change-Id: Id5e0b731524b5b95d8675c5075b1a0cba3a9f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993755Reviewed-by:
-
David Bokan authored
This is a small cleanup that stores the passed in input source type for the duration of a scroll latch. We can use this to replace the |wheel_scrolling_| bit in LTHI and remove it as a param from ScrollUpdate. Bug: 1016229 Change-Id: I42c62e8b257ae7ffd91982676a722cf31b7da860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982242Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#730293}
-
Manu Cornet authored
This makes it more shareable, and will eventually allow swapping items from context menu and not just from the shelf view class. Bug: 1011130 Change-Id: I91fe03031c0c1356def1c1380616f62fa570ceee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995506Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#730292}
-
Demetrios Papadopoulos authored
That UI is already unreachable in Browser settings, and can only be reached from the CrOS OS Settings. Bug: 986596 Change-Id: I042961cb83338b9ba6729e47eb40520be873029e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993751 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#730291}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f6d3cbb28303..df913b911262 git log f6d3cbb28303..df913b911262 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 ianelliott@google.com Change sampledImageIntegerSampleCounts to sampleCounts Created with: gclient setdep -r src/third_party/swiftshader@df913b911262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1ed0f93e51048ba08229a87ac3e2829b59ee38ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995357Reviewed-by:
-
Zhongyi Shi authored
This test is flaky on both android and cronet bots. It is currently the top flaky test on android-cronet-arm-dbg. Bug: 894599 Change-Id: I548c5fcfb764f85f5b5204c5d41751cb4e59b025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994170 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#730289}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccb2c9dc1358..a6d4c99b62d8 Created with: gclient setdep -r src-internal@a6d4c99b62d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040973 Tbr: jbudorick@google.com Change-Id: I906d33930239a12071cff606e8c54686e6f4106d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995587Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730288}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d11cba30bb52..a2970bdcff53 git log d11cba30bb52..a2970bdcff53 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 lalitm@google.com Merge "Revert "perfetto: merge TaskRunnerThread and base::ThreadTaskRunner"" 2020-01-10 fmayer@google.com Merge "Disambiguate post-fork logging message." 2020-01-10 nuskos@google.com Merge "Add build support for iOS and NaCl for libperfetto." 2020-01-10 lalitm@google.com Merge "trace_processor: some cleanup from old CLs" 2020-01-10 hjd@google.com Merge "perfetto: Add subscription-id to UUID" 2020-01-10 lalitm@google.com Merge "trace_processor: close all descendent slices of slice with invalid dur" 2020-01-10 lalitm@google.com Merge "trace_processor: migrate thread and process tables to db tables" 2020-01-10 lalitm@google.com Merge "perfetto: merge TaskRunnerThread and base::ThreadTaskRunner" Created with: gclient setdep -r src/third_party/perfetto@a2970bdcff53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8e0489483029e7409af64fb840f7a14584579b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995585Reviewed-by:
-
Stephen Chenney authored
The new libxml git hash is a7fe7ee45938c53a8dd028dd40baa461191a2fd2 The new libxslt git hash is 3653123f992db24cec417d12600f4c67388025e3 Unfortunately we don't have the old hashes. Bug: 1020745 Change-Id: I04ca286b3d9f880f970296c6f6e6b63d6df58267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906950Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#730286}
-
Kramer Ge authored
Skia now has an API that creates GrBackendTexture with compressed data. Use this to give ownership of backend texture to Chrome. Bug: 1033140 Change-Id: Ib9200b552322e1d580f875003d988c4b0465025c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988734 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#730285}
-
Sophie Chang authored
This also changes it to use the hint's max cache duration if it's provided. This value has been populated from the server for awhile. Bug: 1024236 Change-Id: I0d5fde6572cf76f6a72357d55e1875245d1e9c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994414Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#730284}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I2ffe6a622c9a02c467d45dcb7a62c4b097b23251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993483 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#730283}
-
evliu authored
Bug: 1033227 Change-Id: Ib7d6630860f11237639f46023788adabe1273138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988377Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#730282}
-
Dave Tapuska authored
Move tracking of DidAccessInitialDocument into frame loader. Add a HasAccessedInitialDocument API to WebLocalFrame to maintain state data for dispatching unload message. This may be removed if we move the logic into blink instead of the content layer at a later time. BUG=1008432 Change-Id: Ifbdaa53931cf0824678618275ec39723918e0c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951576Reviewed-by:
-
Mason Freed authored
The CL [1] caused several perf regressions (see [2] for example). Basically the only change in [1] was to convert this: RuntimeEnabledFeatures::FormControlsRefreshEnabled() to this: features::IsFormControlsRefreshEnabled() This CL attempts to reduce the overhead of checking the feature flag. [1] https://chromium.googlesource.com/chromium/src/+/6da8104d37c254c842a7fd6dfffb208bd303788d [2] https://crbug.com/1039272 Bug: 1039272 Change-Id: I47213d88a64f33ad3eddc3fd2fefb921d377395e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993672 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730280}
-
Eric Stevenson authored
Downstream usages have been deleted. Change-Id: If677937e97efc7686d07b56a787d781d1bc0c318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992349 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#730279}
-
Livvie Lin authored
This CL adds a ScriptCommandSubscription to IOSSSLErrorTabHelper to manage the command listener for SSL interstitials. This subscription will listen for JS commands that come from the interstitial (for which JS has been updated to properly pass messages for iOS) and forward commands to the security interstitial subclass, which has a command handler method implemented for the specific relevant cases. Most of the commands re-use logic from non-committed interstitials, except for IOSSSLBlockingPage's proceed command. This CL also makes SessionCertificatePolicyCacheImpl::RegisterAllowedCertificate public so that it can be used for allowlisting a cert when a user proceeds on an SSL interstitial. This method is also updated to handle AllowCertForHost so that only one method needs to be called for allowlisting. Bug: 987407 Change-Id: I5b216cca66f2aebf0df8cec293b60ed0f862fae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937853 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730278}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2ef3661d276c..d01eb543e70e git log 2ef3661d276c..d01eb543e70e --date=short --first-parent --format='%ad %ae %s' 2020-01-10 kahinds@microsoft.com Animation Timeline keyboard focus and interactivity Created with: gclient setdep -r src/third_party/devtools-frontend/src@d01eb543e70e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd06e3f5ff9d3fd20b90595247585872752aef9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995356Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6f813d450e5..164f811b2cf6 git log f6f813d450e5..164f811b2cf6 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 jbudorick@chromium.org devil: introduce autoformatting and format devil/android. Created with: gclient setdep -r src/third_party/catapult@164f811b2cf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040208 Tbr: crouleau@google.com Change-Id: I9ae7f231ee4b6b41d33677cd7cf5240d01820a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995352Reviewed-by:
-
Charlie Hu authored
- Advertise required document policy on out-going requests. - Parse and initialize document policy in security context. - Replace with page with empty document when incoming document policy is incompatible with required policy. - A boolean flag body_loader_finished is added to SimRequestBase::Finish because when testing page blocked by document policy situation in document_loader_test.cc, body_loader.Finish will be called twice, once in WebNavigationParams::FillStaticResponse, once in test framework, which will crash the test because of a DCHECK. Bug: 993790 Change-Id: I823675408a0d52e8048172ae23d409a5f14e8eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947187 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#730275}
-
Matthew Mourgos authored
With this change, the padding between the edge of the screen and the status area widget no longer has anything to do with the hotseat state. This edge padding will now only ever have two possible values, one value in tablet mode and another value in clamshell mode. This is a reland of crrev.com/c/1977025, which was reverted because of a test failure when the hotseat flag was enabled. The addition of UpdateIsDense() in OnAppListVisibilityWillChange() fixes the test failure. UpdateIsDense() has been changed to help minimize the number of times OnShelfConfigUpdated() will be called. Bug: 1035716 Change-Id: Iddf1e13928d73f6783d33bddfd6cc1796d0abe31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990513Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#730274}
-
Tibor Goldschwendt authored
That way the background color will be correct as soon as the page loads and we prevent a white flicker. Bug: 1039393 Change-Id: Ia857a259e3e8d46a3231012f5efaf4996d411fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994419 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#730273}
-
Jimmy Gong authored
- This change will allow any printer setting dialog to have a custom height - Adjusts make and model dialog height to have less white space, which results in a smaller dialog. - Allow any newly introduced dialog to have a non-350px height. Bug: 1015628 Test: end to end manual Change-Id: Ib7ba28aced27d2cb7a576e1edf9a6d24fa1fb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955024Reviewed-by:
-
Tom Anderson authored
This is needed after [1] used weak undefined symbols to test feature support in libgbm. The dependencies for the Chrome debian package are unchanged before/after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1988382 BUG=1031269 R=thestig,thakis CC=spang Change-Id: I760033d5883bf65a5a39316ea382766ae3754088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992340Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730271}
-
