GitLab

Improve handling conversion between a byte and a CtapDeviceResponseCode:
* Fix undefined behaviour from static_cast'ing a byte before verifying
  it's in the CtapDeviceResponseCode enum.
* Log the byte we actually received when we get an error, instead of
  converting the response code back into a byte. This way, we log codes
  we don't know about and save me some emabarrassment when reporting
  bugs to authenticator vendors.
* Convert the list of codes into a shiny new constexpr flat_set. Now we
  don't have to manually increase the array size to avoid the compiler
  yelling at us.
* Add some missing CTAP codes.
* Add a logging for bad GetInfo responses.

Fixed: 1148479
Change-Id: Ic8966f4c881d4a6c7872ed8dc6cbf1a5fd05377a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562973
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#832121}

A previous fix attempted to remove some warnings. Some source_sets were
not using the private_config needed to build. Adding the private_config.

Bug: 1152807
Test: CQ
Change-Id: I8f8f4a74affd161e7a39a99e43a8060d8421b4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566371
Auto-Submit: Andres Medina <medinaandres@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832120}

Integrate the core logic into AwContents for Android P and above.

Note that we are now using DisplayMode to check the fullscreen status.

Adding basic instrumentation tests require some plumbing into test
activity and its rule since we need to hide action bar *before* setting
the content view.

Bug: 1094366
Change-Id: I7296038f894861f68c57c025caa6a70ea9b69ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299461Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832119}

Never queue audio data, and limit to only one copy of other messages.

In particular, if a loopback receiver stopped receiving messages, the
mixer's send queue (for the audio data) could grow without bound,
leading to OOM.

Merge-With: eureka-internal/492543

Bug: internal b/165017599
Test: on device

Change-Id: Ib66c9f00fd4f451e8bba66e6586f9023cd1bc668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555726Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832118}

git grep -l '12b5035g' | xargs sed -i '' -e 's/12b5035g/12b5044c/g'

Bug: 1148325
Change-Id: Ifa509da0edd67c3666bf09345c8793d63274338f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566736Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832117}

This patch gets rid of unused function |VisibleSelection::
CreateWithoutValidationDeprecated()| for improving code health.

Change-Id: I17802935d39859369c62630c91e26acaa95fa8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563389
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832116}

Bug: 1144325
Change-Id: I59caaf4c860adce66fcda090c46a6dd91dc37ce5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533284Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832115}

ServiceWorkerStorageControl::ApplyPolicyUpdates() is changed to
return a response so that ServiceWorkerRegistry can check whether the
call is finished or not.

ServiceWorkerStorage::ApplyPolicyUpdates(), the implementation, is also
updated to initialize the internal storage if it's not initialized yet.
It is because ApplyPolicyUpdates() updates a list to specify which
resources should be purged on shutdown, and the internal storage needs
to be initialized before purging starts in the destructor of
ServiceWorkerStorage.

Bug: 1133143
Change-Id: Ibf9badedac78d946baed200dd84f826d9b0d26de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563187
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832114}

R=johnchen@chromium.org
CC=mlippautz@chromium.org,bikineev@chromium.org

Bug: v8:11180
Change-Id: I51056fe537f442cb266ad6c550e44149a93a0642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560596
Auto-Submit: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832113}

* Moves some platform-specific includes behind build flag
* Cleans up imports
* Deletes copy constructor and assignment operator (removes old macro)

Bug: 1147967
Change-Id: I4c7a69ed7999b66f0d3ae4b63542103f96a5293c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560532Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832112}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I117bde55d6a9b2ddbf2cfd05e6938a9cdc8d00ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832111}

Add the tabUpdate option to the setExtensionActionOptions API which
provides a way for extension developers to manually increase or decrease
the action count for a given tab.

Skipping presubmit since this seems to be hitting crbug.com/956368.

Bug: 1123296
No-Presubmit: True
Change-Id: Ie235f12841029aa45f92ed61b2e300d78d4d0fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489913
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832110}

When tab switcher return "immediate" is enabled, we shouldn't show the
Incognito Start surface (single) when resuming Chrome. Instead, we will
show the Incognito tab switcher.

Bug: 1153713
Change-Id: I2710e1bad9bca3f577354367e2b1363e72561812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565730
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832109}

Renames "PhoneHub.Connectivity.Success" to "PhoneHub.Connection.Result"
according to the metrics doc.

Bug: 1150634
Change-Id: I33cb9ab52c7d0011fb81fdfd98eef2ec7ee30876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559616
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832108}

Bug: 1152873
Test: CQ
Change-Id: Ib7bb8a862e8e72862a01d1e2087b567e09ddf3cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560812Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832107}

Bug: 1138344,1138343,1138342,1138330,1138299
Change-Id: I888b5628cb2eb2703211a52c941d7da3d4eb128c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556698Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832106}

This reverts commit 411f55ec.

Reason for revert: New icons are slated for M-89

Original change's description:
> Revert "[CrOS Customization] Update app icons"
>
> This reverts commit dc1d693f.
>
> Reason for revert: No longer wanted in M-87
>
> Original change's description:
> > [CrOS Customization] Update app icons
> >
> > Includes icons for the Settings, Wallpapers, and Keyboard Shortcuts
> > apps.
> >
> > Screenshot: https://screenshot.googleplex.com/7KdMiBkMFH7fuxh.png
> >
> > Change-Id: I6cf1d45d78f36caeb1429629cc0067b1cbd57daa
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429395
> > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#810376}
>
> Bug: 1138609
> Change-Id: Iaa04c22814b3d8cd1ddc06ceb7a7beb14ad8d030
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472346
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817236}

TBR=jamescook@chromium.org,khorimoto@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138609
Change-Id: I1a21c836fe342ec5adc74978723a077a77a45071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561020
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832105}

Every time I change the declarative Shadow DOM syntax, I forget
to update this perf test. Sorry to the sheriffs. I wish there was
a CQ bot to test this.

Bug: 1042130
Change-Id: If3ba921ce72d30d8c66f71489d2c46272a78c042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565591
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832104}

Bug: 1153264
Change-Id: I82cb51a3f03ba9e8c7ad0f1e156f1f4ede680393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565713Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832103}

The maximum size allow for canvas initialization is 2147483647 (2^31-1).
When such a canvas is created, it requires 2^62 * (byte per pixel)
memory, or more than 1 terabyte of memory, to be allocate. It's not
reasonable to update canvas memory usage based on this number. In this
cl, I added a upper limit for the canvas size for memory usage
calculation only.

Bug: 1150554

Change-Id: I326a86fb804212b7f41f0f1cad153de35861b399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562825Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832102}

//components/f... also removed duplicated metadata from OWNERS files

Bug: 1113033
Change-Id: I058eb222183a54f03a78c2215e9b261f598937e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566453Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#832101}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Ib6ae23e3f1f302ea46213f0b713a1a1e59993ad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832100}

NSDisableScreenUpdates() is deprecated starting in 10.11.

Bug: 1153883
Change-Id: I0a807292e5faa868d873fa7f3167a1a1e9e8d2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565661Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832099}

This has been replaced with a tab in the Help App.

Bug: b/171516802
Change-Id: I4ec4ec23a33238ae389c666e0a25c872fcf437c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558080
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832098}

Fix alwaysUv AuthenticatorImpl tests. The test for MakeCredential was
verifying that even if the RP discourages UV, we created a credential
with UV. But since by default the virtual authenticator does not support
U2F, that's what we would do even if we did not respect the alwaysUv
flag at all. This patch makes alwaysUv test virtual authenticators
support U2F to make sure we're actually respecting the flag.

I also fixed up the virtual authenticator behaviour when attempting to
use U2F with the alwaysUv flag on to what the spec says.

Fixed: 1149712
Change-Id: Ic92ee6d67d328fb6c746157463dc8ed17ef7b1db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564003
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832097}

Bug: 1152592
Change-Id: I009feade446113d8beb213f50a1f2755488ba68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559584
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832096}

This CL updates PendingAppManager to return an InstallResult struct
instead of just an InstallResultCode. This struct contains an additional
bool to indicate whether the app installation uninstalled and replaced
an old app.

This is in preparation to add a
WebApp.Preinstalled.UninstallAndReplaceCount UMA histogram:
https://chromium-review.googlesource.com/c/chromium/src/+/2561999

There are three refactors and no behavioural changes in this CL:
 - PendingAppManager::InstallResult struct added to replace
   InstallResultCode.
 - PendingAppInstallTask::Result removed in favour of passing
   base::Optional<AppId> app_id, PendingAppManager::InstallResult result
   params.
 - WebAppUiManager::UninstallAndReplaceIfExists() now returns a bool
   indicating whether it did anything.

Bug: 809304, 1058265
Change-Id: I4d46052be13f86122215d3ef93eddcadc5f2fa2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563148Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832095}

When there is no favicon in real tab grid card, we should also get rid
of the favicon in the animation card to make the animation consistent.

Bug: 1153923
Change-Id: I8886d0b9f3c58063a0d9c13b86b556114b33a7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565636Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832094}

Otherwise, enabling both feature flags PartitionAllocPCScan and
PartitionAllocPCScanBrowserOnly fails.

Bug: 11297512
Change-Id: I9a9fb0f9a59a05d6dfc1ed46180cf772300b865d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565439
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832093}

Follow-up on code review:
https://chromium-review.googlesource.com/c/chromium/src/+/2553082

Bug: none
Change-Id: I4ebf6d7aff430d53c15dfc52df3d9de9d82b33f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566512Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832092}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f819411f2a3c..1af7968d686d

2020-11-30 siggi@chromium.org Reduce git cl split oversplitting.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I2e2e011da4e69dea5c8e34f9885a56a2670077e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832091}

The old progress center isn't in use any more. This CL removes the code
supporting it.

Remove the UI test that was testing the old progress center.

Change test transferFromDownloadsToDownloads() to check the new feedback
panel.

Bug: 1027012
Change-Id: Ifab607ecbeff9456181c5a3f9f3ed4b41c63b8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563528
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832090}

Find and replace wrongly the first time.
Actual phrasing is in http://go/cros-input-methods-naming

Bug: None
Change-Id: I0b6ad6865ebf3b43f1924486482a2494b07048bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565225Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832089}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/779fa622..f1e2bbd8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8d4e31a7eb399b05b7b33efcf94454853bbb288a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564531Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832088}

This patch adds the virtual methods to the uninstallation path, and adds
corresponding tests for those in the unittests file.

R=phillis@chromium.org

Change-Id: I316145e6030d16ff3a28bf7fecb3d2cdbac940d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545864
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832087}

This is a reland of 32cf67c4

Reason for overlay-popup-ad browsertest failure on Mac 10.15: in the
original patch the popup ad was given a fixed 300x300 size. This is
sufficiently large relative to the window area on regular tryjob bots;
however, the window area on the Mac 10.15 bot is bigger, so the ad will
be skipped as it's too small compared to the window's dimension.

This patch fixed the problem by specifying a size relative to the
window's dimension, i.e. 0.5 * window_width X 0.5 * window_height.

Original change's description:
> Sticky and Overlay-popup ads recorded in ads intervention manager
>
> This change propagates signals for sticky ad and overlay-popup ad
> detection from the renderer to the ads intervention manager through
> the subresource filter component.
>
> As the ads intervention manager is running in dry run mode and
> does not block ads, this allows us to record intervention behavior
> when triggered by one of these two interventions. Understanding
> the intervention behavior is a precursor to the ads intervention
> manager intervening to actively intervening on sites with better
> ads standard violations.
>
> Add base::Feature flags to allow disabling the frequency capping from
> either web_tests and browsertests. Move relevant tests into a virtual
> test suite that has the flag disabled.
>
> Bug: 1099741
> Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Reviewed-by: Eric Robinson <ericrobinson@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829547}

Bug: 1099741
Change-Id: I6fed9cb2e4ad223a05e150b67811141b72124202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553977
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832086}

The functions VideoCaptureDeviceMac::ReceiveFrame and then
VideoCaptureDeviceClient::OnIncomingCapturedData accept a data pointer,
but not stride information. These functions assume that all video frame
data provided is tightly packed. This is not a valid assumption.

When processing a CVPixelBuffer, retrieve the layout of the buffer, and
compute the layout of a tightly-packed version of the buffer. If they
do not match up, copy the CVPixelBuffer to a tightly-packed temporary
buffer and use that.

         naturally and are okay with the fix,
         Manually forced testing of NV12 frames

Testing: Logi 4k pro capture at 360x249 and BRIO 4K 240p hits this
Bug: 1151936
Change-Id: I1ce74629717316ae9387881d70dfb43186e3e906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566094Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832085}

This enforces the invariant that CertVerifyResult::verified_cert should
always be non-null for the case when a MojoCertVerifier is disconnected,
and also adds a check to CertAndCTVerifier to only perform CT
verification if the underlying CertVerifier succeeded. This fixes a
crash where the CT verification step would assume there was a cert in
the CertVerifyResult, but MojoCertVerifier had been disconnected and
reset the CertVerifyResult in its disconnect handler.

Bug: 1153484
Change-Id: I6039ea4e28715a5c6d5e9a2878c538ddf4d5aa8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565537Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832084}

This is to ensure that "command" is displayed at the top
of the summary html. Find the context from
https://chromium-review.googlesource.com/c/chromium/src/+/2561625/7#message-af6e8ef9b88c4031353ca71fd5f90a5861a57d69

R=robertma@chromium.org
CC=chanli@chromium.org,nodir@chromium.org

Change-Id: I0d8df947b56a83b69db88241e2ea1b5acab46b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565397Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832083}

This patch changes |TypingCommand::DeleteKeyPressed()| to handle
anonymous placeholder instead of |ComputeAdjustedSelection()| to limit
scope of special handling for improving code health.

* Anonymous placeholder is a <br> in anonymous block having only it.
* Placeholder is represented by <div><br></div>.

Example of special handling:
<div contenteditable><img style="display:block"><br></div>

Before this patch, |ComputeAdjustedSelection()| returns range selection:
After:<img>, Before:<br> even if both positions specify equivalent
position <div>@1. After this patch |ComputeAdjustedSelection()| returns
caret selection Before:<br>.

Note: |TypingCommand::DeleteKeyPressed()| basically does extend
selection backward in character then applies |DeleteSelectionCommand|.

Bug: 1143292
Change-Id: I33879d0fa8598b5c26b41ecbdaf134029b240cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564140
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832082}