- 26 Jul, 2018 40 commits
-
-
Ben Pastene authored
If it fails in a trybot run, the "without patch" rerun will add the gtest arg, which the test runner doesn't like: https://chromium-swarm.appspot.com/task?id=3eecdd4cb9de5f10 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If3dbee3dc5e37589f8f143edfb935d1870f45c9b Reviewed-on: https://chromium-review.googlesource.com/1150962 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2428efd5..c55015f7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icfdad279dad6d3d3d68063283c91ccee2ccc2b1b Reviewed-on: https://chromium-review.googlesource.com/1151102Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578363}
-
Jonathan Ross authored
There are two remaining Mac Fling tests which fail under Viz. Work is ongoing to land a fix, but there was flakiness if the resolution. This change updates the failing tests to exit early when it is Viz on Mac. This will unblock removing our filter files. TEST=BrowserSideFlingBrowserTest.TouchpadFling BrowserSideFlingBrowserTest.TouchscreenFling Bug: 842325 Change-Id: I67e7c6165d821c9df4907ebf8803fe22fbdf1663 Reviewed-on: https://chromium-review.googlesource.com/1151392Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#578362}
-
Robert Ma authored
Previously, optimize-baselines assumes all all-PASS testharness.js results are the same, partly to avoid special-casing the implicit all-PASS results. However, in scenarios demonstrated in https://crbug.com/866802#c4, we do need to differentiate different all-PASS results to allow us to update all-PASS baselines (that are kept to prevent fallback). This CL implements a ResultDigest class with special equality comparitors which treat implicit all-PASS results specially (equal to any all-PASS results). Thanks to the abstraction, the call sites are still kept simple. Bug: 866802 Change-Id: Ic6a361caa86f12598f29ad7693711d527f63006f Reviewed-on: https://chromium-review.googlesource.com/1150629 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#578361}
-
Weidong Guo authored
App list is always shown in homecher mode, so tapping on the app icon of active window on shelf will not minimize the window due to a piece of code. And this piece of code will not be reached in non-homecher mode, since launcher window will get closed when it loses focus. So remove that code. Bug: 865156 Change-Id: Iec5c0df445d5ee5f379398069659ebe2f6dcd264 Reviewed-on: https://chromium-review.googlesource.com/1103151Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578360}
-
Danyao Wang authored
This DCHECK is meant to assert that placeholder navigation never fails. However, webView.URL may have reverted to the previous entry when a failure happens so is not always the URL that triggers the error. The correct approach is to check the error URL. Bug: 864525 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4efb01041a39f87c4c1ac36115c93364bd41aff9 Reviewed-on: https://chromium-review.googlesource.com/1151391Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578359}
-
wutao authored
This patch adds metrics to record how many times the internal apps have been shown in the launcher as search results and how many times they have been clicked. Bug: 843839 Test: can see numbers in histogram. Change-Id: Ia68fc36dbbf9aadf8b067c8a012748d08fc96e60 Reviewed-on: https://chromium-review.googlesource.com/1141221Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578358}
-
Tonko Sabolčec authored
This CL include following changes: - Added method to LoginDatabase that deleted entries which fail decryption process on MacOS. - Added tests for the above changes. - Added method SetBackendLocked to OSCryptMocker to test behavior when Keychain on Mac is locked. Change-Id: I2173467771457d32d2b2d953d4e27d888965e475 Bug: 791541 Reviewed-on: https://chromium-review.googlesource.com/1146642 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578357}
-
Daniel Nicoara authored
Cache the properties and apply them on commit on DRM Atomic. This works around the need to waste a vsync interval to applying the atomic properties. BUG=839487 TEST=Ran unittests Change-Id: I23a300d98648c5f7dff86019c8f8b9cb11129fb8 Reviewed-on: https://chromium-review.googlesource.com/1108561 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#578356}
-
chrome://accessibilityJames Wallace-Lee authored
HandleAccessibilityRequestCallback crashes if the chromevox view does not have an AXPlatformNodeDelegate. This fixes the crash by ignoring views without delegates in that call. Change-Id: Iadc20f60ed6c3b6c1f351628ab408ab283abe08f Reviewed-on: https://chromium-review.googlesource.com/1150859 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578355}
-
Brian Osman authored
This now matches behavior from before m68 (when we used a different ICC parser that rejected these profiles). In the longer term, I'd like to evaluate what Windows is doing with these profiles (ignoring them, or white point correcting them). Bug: chromium:847024 Change-Id: I662ea9217423d5c9a922ba1735d9de627133de12 Reviewed-on: https://chromium-review.googlesource.com/1150677Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#578354}
-
Evan Stade authored
Immersive fullscreen for an app window almost works aside from the fact that the normal frame remains when the app window is fullscreened. This is a result of not updating the client area inset when the window show state changes (e.g. from restored to fullscreen). The client area is updated when the window bounds change, as they would when entering fullscreen, but the bounds change comes through just before the state change. Thus, when ClientSideNonClientFrameView checks fullscreen state during layout, it still finds the widget is restored and calculates the wrong bounds. The solution is to explicitly kick off a layout when entering or exiting fullscreen. after launching with --enable-features=Mash --ash-dev-shortcuts Test: enter and exit fullscreen on an app window with ctrl+shift+F Bug: 640365 Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f Reviewed-on: https://chromium-review.googlesource.com/1150618Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#578353}
-
Tiger Oakes authored
Adds `generate_milestone_report.py`, a script to generate milestone reports then upload the results to GCS. A new page for selecting a milestone was also created, which directs the user to Super Size with a certain data_url set. Bug: 847599 Change-Id: I718e14814b021c7810e94a0b95bf55e1ed381be6 Reviewed-on: https://chromium-review.googlesource.com/1150738 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578352}
-
Pete Williamson authored
To make the Resource Percentage work easier, we are splitting the snapshot controller into a foreground and a background version. Bug: 699313 Change-Id: Ideeea7d644a903290d9eeae2d7ab700ab0ff50b6 Reviewed-on: https://chromium-review.googlesource.com/1136023Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#578351}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/893e730d5c4d..2daa06ab9596 git log 893e730d5c4d..2daa06ab9596 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 hnakashima@chromium.org Remove font cache from CFGAS_DefaultFontManager. 2018-07-26 delphick@chromium.org Fix usage of deprecated V8 Value::ToString method Created with: gclient setdep -r src/third_party/pdfium@2daa06ab9596 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I535a3a0ebed172aa240f25d09711265adb9799d1 Reviewed-on: https://chromium-review.googlesource.com/1151548Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578350}
-
Gauthier Ambard authored
This CL adds a unit test for the force touch gesture recognizer added to the toolbar buttons, triggering the popup menu. Bug: 864430 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc2524f7e8e58bf20fb4b1381913cb82c57206a8 Reviewed-on: https://chromium-review.googlesource.com/1150142Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#578349}
-
Pedro Amaral authored
This CL creates a bottom toolbar button slot that is used for the first two buttons in the bottom toolbar (home/clear tab and search accelerator). The Change-Id: I6442d22498959c80b5cde8125550feb98c742dd9 Reviewed-on: https://chromium-review.googlesource.com/1139034Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578348}
-
Ian Vollick authored
This is a reland of 58e4a081 Original change's description: > [ar] Do not refer to ARCore shim in APK merger > > This hard-coding should no longer be required. > > Bug: 839191 > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843 > Reviewed-on: https://chromium-review.googlesource.com/1147706 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577662} Bug: 839191 Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d Reviewed-on: https://chromium-review.googlesource.com/1151567Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578347}
-
Tom Anderson authored
This is a reland of 43a48785 After [1], the RPATH is no longer set for sanitizer builds. Also, after [2], the setuid bit is no longer set on chrome_sandbox anyway. [1] https://chromium.googlesource.com/chromium/src.git/+/f002a96e9b788fe71fd1c773a4bc891940c409d8 [2] https://chromium.googlesource.com/chromiumos/chromite.git/+/de3a6f421ec7e32c45fd4131f50d2c0a98fcdd56 Original change's description: > Stop removing rpath_for_built_shared_libraries from chrome_sandbox > > For instrumented builds like tsan, this causes chrome_sandbox to reference the > wrong libc++.so due to a missing RPATH. > > Since all configurations we ship don't set RPATH, we don't have to worry about > security vulnerabilities introduced by RPATH=$ORIGIN. There's also a check to > enforce this in chrome/installer/linux/common/installer.include. > > BUG=850682 > > Change-Id: I25307bd9de388009acffdbb8de6717210873655b > Reviewed-on: https://chromium-review.googlesource.com/1092077 > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566099} Bug: 850682 Change-Id: I82fda0bd5b8f0222d64dcf6c4b7d1199c7e5e585 Reviewed-on: https://chromium-review.googlesource.com/1150254Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#578346}
-
xlou authored
When N-up feature is enabled, we need to pass the pagesPerSheet value to the pdf plugin, so that it can compute the number of Nup pages and append appropriate number of blank pages. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Id8efc03c997ed7e2c643ec53f80747c2efa4719b Reviewed-on: https://chromium-review.googlesource.com/1148989 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578345}
-
Jérôme Lebel authored
Adding user event data type to sync on iOS. Available only if unified consent is enabled. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8c01a40dd10e2aa61df65cad9ddfa6bb8881774 Reviewed-on: https://chromium-review.googlesource.com/1150140 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#578344}
-
Friedrich Horschig authored
This is a reland of https://chromium-review.googlesource.com/1126244 which was reverted because it promoted a legacy bug which triggered a 2D keyboard in VR mode. The keyboard accessory is not enabled in VR mode. There is a test to ensure that resetting that the sheet doesn't trigger the keyboard unnecessarily anymore. Original change's description: > This CL causes the accessory sheet to close when a user selected a valid > filling suggestions. > There is no indicator of the negative case yet (i.e. error during > filling). TBR=rouslan@chromium.org Bug: 856026, 857592, 865749 Change-Id: I71abca9366cfa96789ffe7538204f5435332e4ac Reviewed-on: https://chromium-review.googlesource.com/1146361 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#578343}
-
nednguyen authored
Bug:867836 Change-Id: I8fb770d92f6a87bc3a69e56d019341d58e7781b0 TBR=kouhei@chromium.org, ksakamoto@chromium.org NOTRY=true Change-Id: I8fb770d92f6a87bc3a69e56d019341d58e7781b0 Reviewed-on: https://chromium-review.googlesource.com/1151615 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#578342}
-
Mike West authored
Added tests for: - object, embed, - font - style - redirect - report - xslt - sharedworker - worker - serviceworker - track - audio, video tests are unstable and will be available in my GH repo (https://github.com/mtrzos/wpt/tree/sec-metadata-media/fetch/sec-metadata) Bug: 860710, 860715 Change-Id: I177dfe39629fb704e4e66a90981c279f4d8d8eb1 Reviewed-on: https://chromium-review.googlesource.com/1129238Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#578341}
-
Etienne Bergeron authored
This CL is adding a trigger that randomly collect a sample memlog report. These reports are used to compare high-memory usage reports with common memory usage reports. R=erikchen BUG=867921 Change-Id: I2a05e0dac1184f34ffc32978cbcfc41170a5b665 Reviewed-on: https://chromium-review.googlesource.com/1151406 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578340}
-
Jialiu Lin authored
Move all the UMA logging logic into a separate util file. And make all relevant enums to enum classes. No behavior changes. Bug: 854314 Change-Id: If6035cc1ee86faa4f1aaf003318f72dc44660814 Reviewed-on: https://chromium-review.googlesource.com/1145768Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578339}
-
sunxd authored
It is very common that iframes get clipped by a container on the web. We previously marked any clipped iframes to require the slow path. This CL checks if all transforms applied to an iframe preserve isothetic alignment so that we can use a single accumulated clip region as the hit test rect. Bug: 825817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ide233736b1cd375bc1b96172a3fa4cba5afc9a42 Reviewed-on: https://chromium-review.googlesource.com/1000135 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578338}
-
Javier Ernesto Flores Robles authored
This object will be in charge to fetch the passwords for Manual Fill. A Passwords Mediator will be the delegate and owner of it. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7e15656c4d9979aff5c86d79bab7a42e5161408b Reviewed-on: https://chromium-review.googlesource.com/1148813Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#578337}
-
James Hawkins authored
The target chrome/installer/linux:calculate_deb_dependencies is broken in the cros chrome-sdk shell build because is_linux is true in addition to is_chromeos. This change prevents the linux installer from being enabled when is_chromeos is true. R=gab@chromium.org Bug: 867013 Test: none Change-Id: I1596177528c35a4670fad52e62d56ad0ba104a16 Reviewed-on: https://chromium-review.googlesource.com/1150443Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578336}
-
bsheedy authored
Adds automated versions of VR manual tests involving Incognito tabs. Bug: 861925 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I197b2940755ec92d648c35fb77a1f213e2b402f5 Reviewed-on: https://chromium-review.googlesource.com/1134508Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#578335}
-
Elly Fong-Jones authored
Change-Id: Ife1da1c63b1c2cd2b373c2aa6e349e82e1c6ee7b Reviewed-on: https://chromium-review.googlesource.com/977949Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#578334}
-
Jan Krcal authored
This CL implements the functions to load the data of the model type. In particular, the function GetAllDataForDebugging() unblocks writing unit-tests for further changes. Bug: 853688 Change-Id: I6705ed3fd76b83fc59538c2d9e5b4f4a12b57436 Reviewed-on: https://chromium-review.googlesource.com/1151298 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578333}
-
sebsg authored
This code changes no behavior. It's simply in preparation for changing the autofill dropdown in the next CLs. Change-Id: I682c245d728c8bf3e8d5c57139b02e28a326111a Reviewed-on: https://chromium-review.googlesource.com/1147428 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#578332}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3ac64df1741..b5093bc9ede3 git log f3ac64df1741..b5093bc9ede3 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 benjaminwagner@google.com [infra] Add Metal to no_upload. 2018-07-26 robertphillips@google.com Maybe fix numStencilBits TSAN crash 2018-07-26 caryclark@skia.org avoid uninitialized under fuzzer Created with: gclient setdep -r src/third_party/skia@b5093bc9ede3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867314 TBR=benjaminwagner@chromium.org Change-Id: I8b846218bf68424526b235de8dc3e9c415b76257 Reviewed-on: https://chromium-review.googlesource.com/1151212Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578331}
-
Mark Pearson authored
to point to the histogram with the higher maximum Bug: 856467 Change-Id: Ie16d5190e008c7188ef4c9e4c60ef56a1c62d21f Reviewed-on: https://chromium-review.googlesource.com/1148885 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#578330}
-
Andrew Moylan authored
The is just testing that ServiceConnection::BindModelProvider returns successfully. The Mojo invitation won't go anywhere beyond the no-op FakeMachineLearningClient D-Bus client. To make this test compile, I had to fix an #include from an overlooked file rename in an earlier CL ... Bug: 863794 Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b Reviewed-on: https://chromium-review.googlesource.com/1139942 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#578329}
-
Aleksei Loshkarev authored
If SetFirstSetupComplete was called before engine initialization, we'd record wrong UMA histograms and called DataTypeManager::Configure with wrong configure reason. The Yandex Browser wants to able to do this because in some signin scripts, for example corporate browser, user do not need to change sync channels. In this scenario RequestStart and SetFirstSetupComplete calls happpens simultaneously. Bug: 867451 Change-Id: Iec326c542476adf42c291cf2e002fc52e0a7b99d Reviewed-on: https://chromium-review.googlesource.com/1150175 Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578328}
-
tzik authored
TimeZoneMonitorLinuxImpl is a ref counted type, and its first reference used to be made by base::Bind implicitly. The reference was passed to |file_task_runner_| and released on the task destruction. However, if the PostTask failed or the posted task ran soon before the ctor of TimeZoneMonitorLinuxImpl has finished, the instance is destroyed immediately, and `new TimeZoneMonitorLinuxImpl` returns a stale pointer. This CL adds a static constructor to move the problematic ref count manipulation out of the constructor. Bug: 866456 Change-Id: I5000cfa493cabe8858f20517328fe1d6e27795ff Reviewed-on: https://chromium-review.googlesource.com/1150959Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578327}
-
tzik authored
//chrome/browser/profiling_host/chrome_browser_main_extra_parts_profiling.cc includes chrome/common/chrome_switches.h, which needs an generated //chrome/common/buildflags.h, but corresponding BUILD.gn entry doesn't have the deps to the //chrome/common target that generates buildflags.h. As the result, chrome_browser_main_extra_parts_profiling.cc may be compiled before buildflags.h is generated, and that causes a flaky build failure. This CL adds a necessary target to chrome/browser/profiling_host deps to deflake the build. Change-Id: Ia1938e682a1f4dd5a52d4d00993d0877000532ce Reviewed-on: https://chromium-review.googlesource.com/1151044Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578326}
-
Achuith Bhandarkar authored
Don't need OS_CHROMEOS since this is only built on chromeos. Bug: 777356 Test: this is the test. Change-Id: I3088890e2ff8e5d11da1a487517c68c8e1eec720 Reviewed-on: https://chromium-review.googlesource.com/1144438Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#578325}
-