- 10 May, 2019 40 commits
-
-
Tanmoy Mollik authored
This CL replaces the deprecated base::SharedMemoryHandle used to hold the crash information in nacl:: classes with new shared memory api. The plugin side writes to the shared memory region using base::WritableSharedMemoryRegion and sends a read only version of the region to the renderer process through the browser. The renderer side reads the crash info using base::ReadOnlySharedMemoryRegion. Change-Id: I335040a9884d6dc79f107070c954a3ff250458a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565974Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#658493}
-
Sergio Villar Senin authored
Most of the code uses "loading" but there were a few samples of code using "loader". Unifying both under the "loading" umbrella. Bug: 954854 Change-Id: I9fa3c7ecb6f342a30614ea3485bcb7eb0eea2475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594587Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#658492}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3d622d6e5c42..952b571a4ac7 git log 3d622d6e5c42..952b571a4ac7 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 nisse@webrtc.org Delete unused class InsecureCryptStringImpl 2019-05-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a91b44f5..5f38b3b2 (658232:658382) Created with: gclient setdep -r src/third_party/webrtc@952b571a4ac7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c96569ea6adc8e64f5ff6f089a19e27618a0ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658491}
-
Javier Ernesto Flores Robles authored
Creates a consumer to set up an alert. This effectively isolates the view from the business logic and is to be used with the new alert view controller. Bug: 951300, 951710, 951303 Change-Id: I8516de2eca6016a30ed5b6d6f0435981c12c5562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583796 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658490}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7b08d381fd67..5dc689c12028 git log 7b08d381fd67..5dc689c12028 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 89fe836fe22c..f6d9a1784313 (1 commits) Created with: gclient setdep -r src/third_party/angle@5dc689c12028 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I655de39be1c839fbdc8f80747a359fada5ee1e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605207Reviewed-by:
-
Dominic Battre authored
See bug for details. TBR=kristipark@chromium.org Bug: 960622 Change-Id: I95db78214255faf9f41623c65856458c199413c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605681Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#658488}
-
Dominic Battre authored
TBR=ricea@chromium.org Bug: 960623 Change-Id: I6bcd438d73dc1a795290f1c4541bb8c52989e6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604265Reviewed-by:
-
Dominik Röttsches authored
Replace manual memory management of FontConfig options with unique_ptr's and address a container-overflow issue in the unit test. Bug: 961018 Change-Id: Ief6a44abb98a4d48372440bc62cb801bfddabeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604263 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#658486}
-
Roman Aleksandrov authored
Reuse existing in ash warning message. Bug: 927331 Change-Id: I7632787964b124c3dcce649a504634c6182698ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572352Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#658485}
-
Hugo Holgersson authored
Background: SpatNav compares activeElement's bounding rect with all other focusables' bounding rects. Example (snav-fragmented-link.html): A multi-line ("fragmented") link has focus. xxxxxxLINK L INKLINKxx #A Here LINK's bounding box's area is bigger than the the combined area of its two fragments. The box, returned by NodeRectInRootFrame(), even overlaps another focusable, #A. We can say that LINK's bounding box "contains" #A. Problem: Spatial navigation searches _from_ the focused element's bounding box (but not inside of it). Here LINK's rect completely contains A's rect so #A will never be considered as a focus candidate. Solution: Give priority to focusables inside the current focus rect. This also solves the generic case, crbug.com/798102, where one focusable lays "under" another one, i.e where a focus rect "contains" (or is positioned behind) another focusable. I test this case in snav-focus-rect-contains-links.html. Previously, such containers where unreachable because of 86d40f3d's (anno 2010): "... if there are 2 overlapping focusable nodes, we do a hit test and only the node on top can get focus." Now, when two focusables overlap, SpatNav first goes go the outer box. From there, focus can go to the "on-top", or "inner" (thinking in 2D) focusables. Related CLs: Search scrollers from their edges: crrev.com/589502. This CL uses the same approach as crrev.com/589502; when a "container" is focused, we first search inside of it, from one of its edges. Distance calculation fixup: OppositeEdge()'s returned slice will now be "just outside" the box it is slicing. This change helps us avoid if-logic to cover cases when focusables sit at the very top of their container. Bonus cleanup: AreElementsOnSameLine() can now be removed. It was introduced back in 2011 at 3568f132 to support [some] line-broken links but it didn't fix 956900. Bug: 798102, 956900 Change-Id: I00aaba88a7846b36275f9913034145679576e410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587559 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658484}
-
Martin Robinson authored
These are typically caused by ATK GObjects that are reffed, but then never unreffed. Bug: 961578 Change-Id: I6455044685f7253b6088ddaf32e611eaa97971f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605402Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#658483}
-
Evan Shrubsole authored
Bug: 952831 Change-Id: I12800e6db741632617af859a7852565e6da99d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599624Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#658482}
-
Julie Jeongeun Kim authored
This CL uses DocumentInterfaceBroker to stop passing frame ID over mojo from WebApplicationCacheHostImpl for the render frame path and moves AppCacheHost registration and |host_| from AppCacheBackendImpl to AppCacheServiceImpl. Now AppCacheBackend is only used for workers and it registers AppCacheHost through AppCacheServiceImpl. Bug: 950159 Change-Id: Ic1ba441a6a4bb7f430cf8fce8267ba69a7a4c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589478 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658481}
-
Alex Danilo authored
CL:1593885 adds scrolling of the tree to support tabbing around selections so the focused item comes into view. A side-effect of that CL is that if focus is taken away from the tree by clicking in the file list area, followed by clicking on a folder in the tree, the tree view will scroll as focus returns and in turn, can select the wrong folder due to delivery order of the 'focus' and 'click' events. This CL removes the scrolling behavior to match what other file managers do. Bug: 955172 Change-Id: I209eb4ba61964928c064f711be3c2e0fca9b51e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605660Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658480}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4135885cfde9..6bf102206a6c Created with: gclient setdep -r src-internal@6bf102206a6c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I6327247c66e1ae7f5bbfd2f3debe05eca6bb7b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658479}
-
Christos Froussios authored
The long tail of clients is still migrating. We are keeping the migration on and will continue to monitor adoption. Change-Id: I0d48a87d3022fd1828b159078420cec062f261c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598810Reviewed-by:
-
Lutz Justen authored
Adds a handler for the Kerberos Accounts settings page. Some methods are already implemented like HandleRemoveKerberosAccount(), but others are stubs, e.g. HandleAddKerberosAccount() does not have the UI yet to enter credentials for a new account. The code is largely similar to AccountManagerUIHandler. PS1 in the code review tool contains the vanilla Account Manager code. Please diff to PS1 for the code review. BUG=chromium:952237 TEST=None Change-Id: I521eac1a8aa6733a6b643971d75a555694f74e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590096 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
Ting Shao authored
In a register job, it's also possible to perform update check. The old script comparison should be skipped to use the new byte to byte script update check when ServiceWorkerImportedScriptUpdateCheck is enabled. Bug: 648295 Change-Id: I54338f117a87dd4d4ec6ffd52adb3ff3d94e561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552495 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658476}
-
Bruce Dawson authored
In crrev.com/c/1450414 I removed the last usage of re. This removes the import, for cleanliness. Change-Id: Ibf18551aeb048ee889d6db093a66d9f4cbf47d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591665 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#658475}
-
Mario Sanchez Prada authored
This is a necessary temporary step in order to move push_provider.* and push_messaging_client.* from //content/renderer to Blink. It's a bit sad to copy the file instead of moving it to a shared location that can be used both from content/renderer/push_messaging/push_messaging_client.cc and blink/renderer/modules/push_messaging/push_provider.cc, but since this is a brief temporary state it's perhaps cleaner and simpler than putting things in a shared location, only to move it again right afterwards. Once both files are inside Blink, push_messaging_utils.* from //content will be removed and only the one under blink/renderer/modules will remain. Bug: 939943 Change-Id: Iaa24cabe8f4c38215c86a0e82b5cc3d9c945cdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594518Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/04aa79d0edfc..2dd4ab3a4acb git log 04aa79d0edfc..2dd4ab3a4acb --date=short --no-merges --format='%ad %ae %s' 2019-05-10 cepheus@frii.com SPV: Move to the SPIR-V 1.4 header. Created with: gclient setdep -r src/third_party/glslang/src@2dd4ab3a4acb The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I1b463bd71058ac5208ae6b26e4b5e117ea9f0c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604191Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib7bd171dd8f7e6832d323443b28eeb0fdfddd486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604190Reviewed-by:
-
Dominic Battre authored
Bug: 961196 Change-Id: Ie42250c6cc09e99eef540d54cef55c6f2028878f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601047 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#658471}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65043e3e..6e959bcf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1bdef14bc90a2428eb0634f2a9e49937b8911cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605603Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658470}
-
Jeevan Shikaram authored
This CL hides the Notifications view button from the Main View, and makes the app list fully expanded. Bug: 948936 Change-Id: I4dece86b79bf1ca9211dc47188fe46026653f661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601018 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658469}
-
Luciano Pacheco authored
This reverts commit ffcd9342. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Reland] Change ActionsController to only update DOM when displaying a menu > > Previously ActionsController would calculate the additional actions for > Drive (share, create-shortcut, etc) and FSP [1] like change directory, > selection changed, and metadata updated. When these events arrive in > FilesApp, they update the <command> and <cr-menu> DOM state. > > However, that can cause flickering in visible menus and also flakes in > browser tests based on menus, since these events can happen while the > menu is displayed for an entry or set of entries (selection) or affect > entries other than those associated with the menu. > > This CL changes ActionsController to store state in an internal map, > rather than in the DOM, and to only update the menu DOM state when a > user-action shows the menu. > > Change CommandHandler to set the visibility for Drive actions/commands > synchronously to avoid flickering the size of the menu - it still can > flicker the disabled state and pinned check-mark, but these are softer > to human eyes than the change in size. > > Change ToolbarController to update its refresh button disabled state. > The button relied on FileManagerCommands to update the |refresh| state > command, which was not correct because the refresh button always acts > on the current directory, whereas the command was being evaluated for > different entries. > > Change Action models and derived classes to have a |getEntries| method > so that ActionsController can get the entries that it is acting upon > to invalidate the state prior to executation. > > Change ActionsSubMenu.setActionsModel to forward the target element, > so the <command> can be updated to the correct target element. > > [1] > https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested > > Bug: 889153, 875446, 961244 > Change-Id: I059f4516f0b64426a7570a88d8eff7e48b435454 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605383 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658458} TBR=noel@chromium.org,lucmult@chromium.org Change-Id: I67d21f2794ed17279b52f4c4fc90f80936abe881 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889153, 875446, 961244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605662Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba57a5dc. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iecc0cc57ee346dad6b0d4563b36a57eb71b99223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604057Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658467}
-
Eric Willigers authored
Values like "x proximity" are serialized as "x" in the computed value. If no strictness value is specified, proximity is assumed. Spec: https: //drafts.csswg.org/css-scroll-snap-1/#scroll-snap-type Change-Id: Ic0e0b73b62b17740452562d1aac0a52915db9fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605243Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#658466}
-
Marina Ciocea authored
This change is needed for switching ConfirmInfoBar to using StyledLabel instead of Label in a follow up CL. Bug: 927949 Change-Id: I4cc9b4a23af85be716c4c48148e59a6aaddf5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599462 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/006b29556dad..980d615e7e5d git log 006b29556dad..980d615e7e5d --date=short --no-merges --format='%ad %ae %s' 2019-05-10 tikuta@chromium.org [bootstrap/win] Upgrade Python to 2.7.13. Created with: gclient setdep -r src/third_party/depot_tools@980d615e7e5d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:741001 TBR=agable@chromium.org Change-Id: I6c9283cd734067778028104c4da4c8e9992cb797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605351Reviewed-by:
-
Marina Ciocea authored
The default behavior remains the same, with InfoBarView having a close button. This change is needed for implementing the tab sharing infobar (see bug). Bug: 927949 Change-Id: I795c868508148b5a8a1647768474b0d1dc89cd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599689 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
Change fake backend apps to have descriptive titles to allow for better testing. Bug: 906508 Change-Id: I749d2d7e0f25771cfbed462d6778deb12b8afb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601017 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3cde57769c2..4135885cfde9 Created with: gclient setdep -r src-internal@4135885cfde9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I101cb4f46278b1b1d106ac6db56a5b8dcb587114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604188Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1bc7731e4c72..0b8234b45e2e git log 1bc7731e4c72..0b8234b45e2e --date=short --no-merges --format='%ad %ae %s' 2019-05-10 swiftshader.regress@gmail.com Regres: Update test lists @ 1bc7731e Created with: gclient setdep -r src/third_party/swiftshader@0b8234b45e2e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ib797143066fbb1342bda91c01f693783450cd066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605350Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Id50f49662f363c9f55d80dc901a34b7ca3c114e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600948 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658459}
-
Luciano Pacheco authored
Previously ActionsController would calculate the additional actions for Drive (share, create-shortcut, etc) and FSP [1] like change directory, selection changed, and metadata updated. When these events arrive in FilesApp, they update the <command> and <cr-menu> DOM state. However, that can cause flickering in visible menus and also flakes in browser tests based on menus, since these events can happen while the menu is displayed for an entry or set of entries (selection) or affect entries other than those associated with the menu. This CL changes ActionsController to store state in an internal map, rather than in the DOM, and to only update the menu DOM state when a user-action shows the menu. Change CommandHandler to set the visibility for Drive actions/commands synchronously to avoid flickering the size of the menu - it still can flicker the disabled state and pinned check-mark, but these are softer to human eyes than the change in size. Change ToolbarController to update its refresh button disabled state. The button relied on FileManagerCommands to update the |refresh| state command, which was not correct because the refresh button always acts on the current directory, whereas the command was being evaluated for different entries. Change Action models and derived classes to have a |getEntries| method so that ActionsController can get the entries that it is acting upon to invalidate the state prior to executation. Change ActionsSubMenu.setActionsModel to forward the target element, so the <command> can be updated to the correct target element. [1] https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested Bug: 889153, 875446, 961244 Change-Id: I059f4516f0b64426a7570a88d8eff7e48b435454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605383Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658458}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I952fe2ad0c0e12f10e0a64ef2bee0406b541ff3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599808 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c11e3156af22..04aa79d0edfc git log c11e3156af22..04aa79d0edfc --date=short --no-merges --format='%ad %ae %s' 2019-05-10 johnkslang@users.noreply.github.com Merge pull request #1765 from KhronosGroup/update-knowngood-tools-SPIR-V_1.4 Created with: gclient setdep -r src/third_party/glslang/src@04aa79d0edfc The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I9f1fbc5137df10819c9dc8ff653ee5ce96a44603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605465Reviewed-by:
-
Alice Boxhall authored
This reverts commit f9d8f7f6. Reason for revert: Apologies, this test seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913896950441933072/+/steps/browser_tests/0/logs/Deterministic_failure:_TimeToFirstPresentRecorderTest.VerifyTimeCalculated__status_TIMEOUT_/0 Original change's description: > chromeos: removes time_to_first_present.mojom > > And instead has ash directly access the startup time. > > BUG=958213 > TEST=covered by tests > TBR=tsepez@chromium.org > > Change-Id: I146c27edef79ff8fb69ca7cdd7f230ad77f040a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602854 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658315} TBR=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org Change-Id: I272066f1adc2866821a5195dca1907a6f077069a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605255Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#658455}
-
Christopher Lam authored
Bug: 938695 Change-Id: I90600729c8a356632fe2de593cade87b52c4195c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510622Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658454}
-
