GitLab

ServiceWorker needs the information.

Bug: 845408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I138d02f7bf3cf69b1949be785fb0e57c596d8c06
Reviewed-on: https://chromium-review.googlesource.com/1077880Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563156}

Allow managed users logging into their own device to use their
login password for automatically authenticating to networks.

BUG=chromium:386606
TEST=run unit tests, manual test on kevin

Change-Id: I023472e12abaa39a03ea445358f68a7c1afa9391
Reviewed-on: https://chromium-review.googlesource.com/1058598Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563155}

So:
Include chromeos_switches.h instead of chromeos_switches.cc
Include base_event_utils.h instead of base_event_utils.cc

Typo made a test include a cc file instead of the more commonly
included header file. This patch changes to include the header file.

There are no known bad side effects of this, but it was found
when looking for similar instances of a piece of code that did
cause problems.


Change-Id: I33105752517ba4e423dcae7c1ea0186fc7613127
Reviewed-on: https://chromium-review.googlesource.com/1005065Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#563154}

Additional test for fileManagerPrivate.mountCrostiniContainer
will be added to these files next.

Bug: 845075, 822130
Change-Id: I8e4fbb840764e975b5d670556905f3b4b411f2da
Reviewed-on: https://chromium-review.googlesource.com/1075878
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563153}

Bug: 824130, 847842
Change-Id: I40015be2f20ffb10ea0b95d5dc670a40002d9afc
Reviewed-on: https://chromium-review.googlesource.com/1078917
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563152}

Change-Id: If6df3e805891d319fb48c51fed9652c0020d8cd6
Reviewed-on: https://chromium-review.googlesource.com/1079957Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563151}

Add missing argument to mutateStruct/Union calls.

Bug: 607649
Change-Id: Ie2a3732e3295ac513a9c0ca6f4a3d5742a58cc63
Reviewed-on: https://chromium-review.googlesource.com/1077874Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563150}

This is change #1 of 3 reducing context switching during WebGL
rendering. On tiled rendering GPUs context switches are slow and can
even cause multisampling artifacts. Every time the command buffer is
flushed, a context switch is possible.

Before, the command buffer helper would always autoflush eventually if
no explicit flush was received. Commands would accumulate across
multiple frames until the autoflush threshold was reached. Implicit
flushes caused by ordering barriers were not taken into account.

Now the autoflush decision is based on the last ordering barrier instead
of the last explicit flush. Since there's an ordering barrier at least
once a frame, autoflush will only happen if the threshold is reached
within a single frame.

Bug: 828363,835353
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I168be6892620b1813c598a912e59147f9c45896f
Reviewed-on: https://chromium-review.googlesource.com/1077435Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563149}

Bug: 847738
Change-Id: I49a8cbcaad484f8044a0196901b8cf6140b39388
Reviewed-on: https://chromium-review.googlesource.com/1080357
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563148}

snake_case() and enum_type_name() are not used. Remove them and their
dependent.

Bug: 843927
Change-Id: If93fcb25e1cf26299ed06dc65a9de387c528b15b
Reviewed-on: https://chromium-review.googlesource.com/1080351Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563147}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia9b7794733fef726c08e40cafed69e1672b071ab
Reviewed-on: https://chromium-review.googlesource.com/1079811Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563146}

Bug: None
Change-Id: I04d5fb2959d5e0eb59dfede19c2b9037ae7f8b3f
Reviewed-on: https://chromium-review.googlesource.com/1080355Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563145}

Apply PageZoomFactor to image div width for use-zoom-for-dsf
When use-zoom-for-dsf enabled, the visual viewport doesn't have
the device scale factor (DSF) applied, so we need to apply
PageZoomFactor when decide image container size.

This change doesn't need to be under the flag, because when the flag
is disabled, PageZoomFactor is 1.

Bug: 844461
Change-Id: I1e23cafdef387b97f2c446438668a500225c0deb
Reviewed-on: https://chromium-review.googlesource.com/1065145
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563144}

container. Just move items to the end of the range.

std: :remove_if does not actually remove the selected element from the
Change-Id: I3868f83b027e85b36f9097e1325c69cb1a067875
Reviewed-on: https://chromium-review.googlesource.com/1078028Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563143}

The REVOKED status can trigger some of the difference-ignorers that
will be added in followups.

Bug: 649026
Change-Id: I099402d188a7819aaee229a52327187620146434
Reviewed-on: https://chromium-review.googlesource.com/1079705Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563142}

This is the final CL implementing the DNR page whitelisting API. This does the
following:

- The set of whitelisted pages for an extension are passed to the RulesetManager
  which lives on the IO thread. This happens whenever an extension is loaded
  (through RulesMonitorService) or when the set of whitelisted pages is updated
  (through a call to chrome.declarativeNetRequest.[add/remove]WhitelistedPages).
- For each pair of (network request, extension ruleset), RulesetManager checks
  if the request is whitelisted as per the page whitelisting API. This happens
  if the top level frame url corresponding to the request has been whitelisted
  by the extension using the page whitelisting API.

BUG=811460, 696822
Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I910c5b481dc8f0b3283374a37c1351a7d7574372
Reviewed-on: https://chromium-review.googlesource.com/1041279
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563141}

 - Add ExecuteWrite to device to commit or abort changes
   in different characteristic
 - Add PrepareWriteValue() in remote characteristic API

A relevant patch is crrev.com/c/1065067

BUG=b:78650442
CQ-DEPEND=CL:1079668
TEST=Pass CtsVerifier test for reliable write on client side. Unittest.

Change-Id: Ibd1a68b9a3a1973c5287b46d41ec652f9d9f8352
Reviewed-on: https://chromium-review.googlesource.com/1065080
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563140}

- Combine ApplyPaintOffsetTranslation into the method. This avoids
  the ambiguous function name.

- Remove unrelated context_.absolute_position.paint_offset and
  context_.fixed_position.paint_offset updates for LayoutView from
  the function. They will be done by existing code in
  UpdateOutOfFlowContext().

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3cd103cf5d7614f144ebfcf30c3aaa7a75db76f6
Reviewed-on: https://chromium-review.googlesource.com/1080014Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563139}

- create fragments for repeating table sections instead of the old
  SPv1 repeating painting path. The old path changes paint offset
  which didn't work for descendants with paint offset translations.

- Let SVG find the proper fragment to paint.

Bug: 847307
Change-Id: Iae4509885885a784afeed2c34fb932201549d630
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1079454Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563138}

This CL adds a couple of missing null checks in permissions code to
handle the case where a RenderFrameHost has already been destroyed.

Bug: 754585
Change-Id: I1d009b8ec5776421462cba05ecfb499a51034b10
Reviewed-on: https://chromium-review.googlesource.com/1077878Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563137}

This is always set to false nowdays.

Bug: 789577
Change-Id: Ic52082fe3c0f4a82e9e602a028a2f0c042f559fe
Reviewed-on: https://chromium-review.googlesource.com/1069799
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563136}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I61efbd5d0e3670efc8d998f69fd29012d2feec76
Reviewed-on: https://chromium-review.googlesource.com/1080251Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563135}

This change is necessary because GcmDeviceInfoProviderImpl::GetInstance()
returns a const pointer.

Bug: 824568, 752273
Change-Id: I92b84b071e1cd3c782e6b5b0d1e7e25d539da1bf
Reviewed-on: https://chromium-review.googlesource.com/1079645Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563134}

Following a proposed spec change[1], this CL changes the number of entries
buffered by default before the Resource Timing buffer is full.

[1] https://github.com/w3c/resource-timing/pull/155

Bug: 847689
Change-Id: Id93bfea902b0cf049abdac12a98cc4fba7ff1dd3
Reviewed-on: https://chromium-review.googlesource.com/1078107Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#563133}

BUG=848092

Change-Id: Icd1ff5e9929f6bed9c7ff657dbcc8a75b39feb35
Reviewed-on: https://chromium-review.googlesource.com/1079806Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563132}

In some cases, the pipeline will not be ready when trying to enter
Picture-in-Picture. It will happen if the video has preloaded its
metadata and has a poster. In this case, the Picture-in-Picture request
will be delayed until the pipeline has started and there is a surface.

Bug: 847671
Change-Id: I56b0560db37ac2e6466abbd3f089973777c49f0f
Reviewed-on: https://chromium-review.googlesource.com/1077453Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563131}

This patch adds histogram logging to the text services context menus,
based on how the simple menu model does histogram logging.

Bug: 838710
Change-Id: I090a02860ea64972386042b3e656fd8534b28d9e
Reviewed-on: https://chromium-review.googlesource.com/1067519Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563130}

SuggestBox determines its preferred width by taking the character
length of the longest item, which includes whitespace. However,
whitespace is not preserved without 'white-space: pre', so
measurements are incorrect.

Screenshot: https://imgur.com/a/LcQEQ

Furthermore, preferred width measurements do not factor in the
scrollbar width.

Screenshot: https://imgur.com/a/x8MEF

Bug: 825386
Change-Id: I785dfca5d6a75832c62f41fa8140fb5f8c0dd3f1
Reviewed-on: https://chromium-review.googlesource.com/978937
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563129}

This change will add an icon on the tab that appears when a user
is playing a video in picture-in-picture mode, similar to what
exists currently with audio playing and other similar features.

Per discussion, this icon will take precedent only over the audio
playing and audio_muted icons, while others (bluetooth, usb
connected, etc.) will stay at a higher level for security concerns.

Bug: 842742
Change-Id: I9d8d7bf7764b156054838ffb5b02116fd78fbc38
Reviewed-on: https://chromium-review.googlesource.com/1068109
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563128}

The implementation was based on a PR that has now been merged.

TBR=aboxhall@chromium.org,haraken@chromium.org

Bug: 844540
Change-Id: I9daec3930c465428c38c52cfc1c107b30005721e
Reviewed-on: https://chromium-review.googlesource.com/1080216Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563127}

This CL has one major behavior change:
Forcing activation via the devtools setting simulates the current
site being on the blacklist. This means it will get full UI and
settings treatment.

Fallout from this change is:
1. Remove the driver factory entirely, and put the SubresourceFilterClient
   in the throttle manager
2. Refactor the SubresourceFilterClient to make its activation overriding
   more flexible (and put devtools stuff there). This moves all devtools
   knowledge out of //components layer.

TBR=avi@chromium.org
Bug: 717590, 846733

Change-Id: Ifeff329499f9d39f1140b4c34643e67d6a79d0ab
Reviewed-on: https://chromium-review.googlesource.com/1066898Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563126}

We use a different icon on the system tray from the one used in the
notification center window.

Bug: 845804
Change-Id: I08fd9b32385786a7cc468ff4a7c023b950205bec
Reviewed-on: https://chromium-review.googlesource.com/1074582Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563125}

These tests have been running on our FYI bot and are stable. Add them to the waterfalls in preparation for canary tests.

Bug: 839419
Change-Id: I4d14803f068f76aec693247994dfaf41b41a636c
Reviewed-on: https://chromium-review.googlesource.com/1076768
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563124}

The flaky expectation for shaderoperator_common_functions was
insufficient and the test was still flakily failing. See issue for
more details.

Bug: 820225
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie30e47e8ffaa44ebade9723742c541f3571a3aee
Tbr: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1079793Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563123}

- Expand/Collapse button should be in the fixed size.
- Secure minumum gap between Expand/Collapse and other buttons.
- Shring gap between other buttons when there's not enough space

Bug: 847100
Change-Id: I295126c63ed2702ca7e10906f6d4ca599485e904
Reviewed-on: https://chromium-review.googlesource.com/1078031
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563122}

This reverts commit 28abe780.

Bug: 772558, 846211,846551
Change-Id: Ib782b1fb5ee737f31deaa94630fb2bb1021b579b
Reviewed-on: https://chromium-review.googlesource.com/1077597Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563121}

Removes the --enable-gamepad-extensions flag from the WebVrInputTest
class since all its tests should work without it. Also adds DDView/
Cardboard tests for the following scenarios.

1. WebXR enabled, WebXRGamepadSupport disabled -> no gamepads available
2. WebXR enabled, WebXRGamepadSupport enabled -> gamepad available
3. WebXR disabled, WebXRGamepadsupport disabled -> no gamepads available

Bug: 832399
Change-Id: Ic73a7d312faad19b33020fc790bc22f0b33ede43
Reviewed-on: https://chromium-review.googlesource.com/1038442Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563120}

This CL moves BluetoothDetailedView from tray_bluetooth.cc to
a dedicated bluetooth_detailed_view.cc.

TrayBluetooth will be removed with UnifiedSystemTray, but
BluetoothDetailedView will remain.

TEST=ash_unittests, manual
BUG=none

Change-Id: I759e4882d3b5aadbfaf274127960a1795a207696
Reviewed-on: https://chromium-review.googlesource.com/1073170Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563119}

Change-Id: I9236f428c4186a09eff5ec1212dd8e5315a4ed75
Reviewed-on: https://chromium-review.googlesource.com/1079899Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563118}

Bug: 756689
Change-Id: Icea2b1366362c1d5ff37b2dd9917183db0fafe3b
Reviewed-on: https://chromium-review.googlesource.com/1080272
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563117}