- 05 Jun, 2020 40 commits
-
-
Stephen Roe authored
Bug: 1042511 Change-Id: If15c4d9afa07f9f0d7d467f32a49cd92986a5e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233006Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#775794}
-
Sorin Jianu authored
Without the change, the prefs changes made by the update client were never persisted, since the process terminated before such changes were lazily committed by the prefs service. With the change, the prefs are committed with each update complete notification for any app. They are also committed when the Stop() function is called. Since the ComServer is a leaky singleton, the implementation of Stop() acts like a finalizer, and resets the members of the ComServer instance. Bug: 1091532 Change-Id: I07dd0b3d989ad383a0a39e43ed6d47164c389d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233609Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775793}
-
Ionel Popescu authored
This CL updates the select behavior for Enter key to pre-M83 where: 1. on Mac, Enter key submits the form 2. on other platforms, Enter key opens the popup Bug: 1087503 Change-Id: Id3ca7171cc752e01db3c8c9bc23bbbb0a067d650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231456 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#775792}
-
Joey Arhar authored
I added this test to fast/ without thinking about it, and it got flagged for being a new test not in wpt. The -crash.html should make wpt recognize it as a "crash test": https://web-platform-tests.org/writing-tests/crashtest.html Change-Id: Ia424f0f407dba48b0a7bf87331a6843fb3b13e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231867Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#775791}
-
Fergal Daly authored
- make some things constructor parameters previous were poked in after construction - move nav_entry_id_ so that all the entry-dependent initializers were together - drive-by fix 1 typo - move things around a little for initiator_routing_id_ - use make_unique instead of new in 1 spot I'm pretty sure this is a no-op although there may be ordering issues that I didn't spot. Change-Id: Ice1e0d53f2351795da109047d4d16fd1776d3db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230181 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775790}
-
Rainhard Findling authored
* When navigating to a Settings subpage from safety check, clear the search term so that content on the subpage is not hidden by it. Bug: 1085422 Change-Id: I8caf29cc417e7af69fa2981d444e580c0963bac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230483 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#775789}
-
Xing Liu authored
This CL passes download later data through DownloadDialogBridge. Bug: 1078454 Change-Id: Idd2cbbded85ce25e630bf37ad523254cfec9265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233361Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775788}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63973bb2e9cc540e0295a0a94482977ed91e0b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775787}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e32669d4cb17..ca8f75a8db60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,tbansal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085525 Tbr: yigu@google.com,tbansal@google.com Change-Id: Ifb54c8700ae9680d35e7f7f9c75cbe05dc2f0aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232796Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775786}
-
James Cook authored
This is the "V1" feature. It: - Creates a new "Sync your settings" section in Chrome OS settings - Moves app, wallpaper and Wi-Fi sync to OS settings - Provides a separate toggle for OS preferences, distinct from browser preferences - Makes the OS ModelTypes run in sync transport mode, controlled by a master pref for the OS sync feature - Updates the OOBE sync consent screen NOTE: The feature is rolling out via a client-side Finch trial, so the actual state will vary. See config in chrome/browser/chromeos/sync/split_settings_sync_field_trial.cc Bug: 1013466 Change-Id: Ie84b193cd7c298387245f1c32f868b04731fb0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#775785}
-
Erik Chen authored
Previously, the log was dumped to a file with the current timestamp. This proved unwieldy. Now we always log to the same file, and delete it if lacros is launching for the first time. Change-Id: I1a5d321abf14e62e1cc8464b0d3a36647f0cdd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227438 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#775784}
-
Finnur Thorarinsson authored
UX designer (after review meeting) requested a few things changed with regards to how the overlay controls animate. - Animation timings and delays should be according to spec. Most importantly, controls should be brought into view fast and fade out of view somewhat slower with one exception: - Play button should animate away much faster than the other controls in cases where the user's focus is on the video playing. - Tapping on the video area should show the controls if hidden and hide them if showing (current implementation always brings overlay controls into view on tap, or extends their time on-screen if already showing). BUG: 895776, 656015 Change-Id: I88ec9078a6546c1eea3adf43d8cf7f027d921159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210232 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#775783}
-
Yi Gu authored
The test is flaky on Linux MSAN build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/6163 TBR=aaronhk@chromium.org NOTRY=TRUE Bug: 1091948 Change-Id: I8d5318ec259677167818323082259dde2f7f12a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233720Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775782}
-
Xianzhu Wang authored
The filter-with-PaintOffsetTranslation (crrev.com/c/2227621) broke http/tests/devtools/layers/layer-compositing-reasons.js because the element with reflection containing composited descendant now has a different transform node. BTW remove expectation entries for tests that are passing. Change-Id: I5d2e8af77d0d559c5e24f5983c380810d0c36d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232748Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775781}
-
danakj authored
The test seems to not be flaky any more with improvements made to the web test harness for site isolation. If wrong.. we can revert and investigate. Local run of 50 runs had 0 failures and TestExpectations claims it was very flaky. R=vmpstr@chromium.org Bug: 891427 Change-Id: I79ff5e5ed81745dfde6f34d584f4baa1ce0bcd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233498Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#775780}
-
Richard Townsend authored
Removes a section of code which was creating a new Tokenizer. Later attempts to retrieve content from the BackgroundHTMLParser were possibly asserting based on this. Also improves scheduling check to make sure that the parser doesn't accidentally defer work when it shouldn't. Bug: 901056, 1087325, 1087032 Change-Id: I9b6de16748a713196bf26438eb4f1bfe001cb999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230491Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#775779}
-
danakj authored
The test is marked as failing only on mac, but also has mac-only expectations with FAIL lines in them. Recent failure on the mac bot have been of the test passing. R=vmpstr@chromium.org NOTRY=true Bug: 891427 Change-Id: I252e50e365bda896ddd1157c576faf8ac7fac581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232770 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775778}
-
dpapad authored
Bug: None Change-Id: Idb023af45e88fe91e841ee2b1c13ac3c44925145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232825Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#775777}
-
Samuel Huang authored
ToGNString() in gn_helpers.py prints (nested) lists as a one-liners. This can create every long lines, which are difficult to diff across versions. This CL reimpements ToGNString(), and adds a "pretty" option to print list each leaf elements on a separate line, with indent. Details: * Keep pretty print off by default, and preserve existing output. * Reason: ToGNString() outputs may be committed into code base. We want each caller to make its own decisions regarding pretty print. * Allow new line to appear in string (GN expresses this as "$0x0A"). * Fix Unicode representation (after UTF-8 encoding need "$0xXX"). * Add stricter checks for GN identifiers for {'identifier': 'value'}. * gn_helpers_unittest.py: * Add many more tests, for outputs without and with pretty print. * Make script compatible with Python 2 and Python 3. Bug: 1074446 Change-Id: I7a5e0174bdebf8bfb03cdcf42aed7c26ae56f120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231505 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#775776}
-
Miguel Casas authored
This reverts commit 07199ff1. Said commit inadvertently instructed the compositor to use the EDID-provided ColorSpace as target for rastering, causing colours to be accurate, but washed out. Original Commit description ---------------------------------------- This CL adds code for populating the necessary gfx::DisplayColorSpaces in CreateManagedDisplayInfo for supporting SDR and HDR target color spaces (depending on the monitor capabilities and the big hdr flag). It needs a sibling CL to allow AR/B30 FBs on CrOs crrev.com/c/2078655, Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 958166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072621Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#745461} Bug: b:158126931, 958166 Change-Id: Iee5c9a431a9c0f9f6a5b4d229ab70183c264ad9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232761 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#775775}
-
Yulun Wu authored
unchanged. Bug: 1005539 Change-Id: Icb089f71cdd35f8b7c6005e83322a997270a4753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225379Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775774}
-
David Black authored
In v1, timer notifications are *not* pinned. In v2, timer notifications *are* pinned. Bug: b:156642368 Change-Id: Ia9e7ac972e64a50e3eacd71c50096793feaddb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231093 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#775773}
-
Sahel Sharify authored
This cl moves the helpers needed for building the Pay intent from WebPaymentIntentHelper.java to WebPaymentIntentHelperType. This is to reuse the same functions for building PaymentDetailsUpdate bundle. Bug: 1026667 Change-Id: I77f00f79b1025ab96fc92914e707c5e0ba0f6024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230223Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#775772}
-
John Williams authored
Bug: 1078435, b/155777247 Change-Id: Ic5ed0bd7766e367ca7526e9b95b461885d4bf8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220909Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Auto-Submit: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#775771}
-
Ian Wells authored
Bug: 1044139 Change-Id: Ia0d837c2c5d568d23d8dd53f97124c4fc61dc5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233601 Commit-Queue: Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#775770}
-
Miguel Casas authored
crrev.com/c/2226774 enabled VP9 Profile 2 and 3 Hw decoding on VA-API platforms supporting it, e.g. kohaku, but forgot to update the unittest, provoking sadness in the ChromeOS CQ. This CL fixes that. Test: Verified locally building and deploying vaapi_unittest on kohaku. Bug: 911754, 1091786 Change-Id: I902026b2a1ed38595efb80c42979082c8e348acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233580Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#775769}
-
Adithya Srinivasan authored
Currently, after portal activation, the notification persists, but clicking any buttons in the notification causes a crash. The crash happens because the media session observer was cleaned up after portal activation (the webcontents are swapped during portal activation and the previous java webcontents gets destroyed, but the native counterpart is kept alive). This CL is a band-aid fix that causes the notification to be removed after portal activation (to match the media session observer being cleaned up), and avoids the crash. It doesn't fix the underlying issue of the media playback notification not correctly handling inner web contents and so portals playing media will not display a notification. Bug: 1078400 Change-Id: I533f7ab079c0e8e21927279cf85321b7f1f400a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199730Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#775768}
-
Robert Liao authored
Google Now has been removed from the build for quite some time. Fixed: 1088810 Change-Id: Id156fd6745a5ba13f404c7848b8ba1271b8ba049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231879 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#775767}
-
Alexander Cooper authored
Anything that actually used this code was removed a while ago, but a few references remained. Fixed: 840346 Change-Id: Ic5c42dd85dcfa446757a45be8e82a16179080a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233600 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#775766}
-
Yue Zhang authored
Currently, the undo closure snack bar is disabled when accessibility mode is enabled, and undo closure is handled in accessibility tab switcher. Since conditional tab strip allows users to close a tab when overview mode is not showing, this CL enables undo closure snack bar for accessibility users with this feature. Bug: 1090067 Change-Id: I4427c8305f5706c4fc99f09393de1b323612a8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231899 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#775765}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be04c04729df..17b4a877e7ff 2020-06-05 jmadill@chromium.org Vulkan: Pass API version to VMA. 2020-06-05 ianelliott@google.com Fix FramebufferVk::getScissoredRenderArea() for pre-rotation 2020-06-05 timvp@google.com Reduce dependency on ProgramExecutable::mProgram[Pipeline]State 2020-06-05 nguyenmh@google.com Fill in missing GL methods for MemorySizeTest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Build/CQTest: Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_fragment_ops_depth_stencil_* Change-Id: I736afbacfcee38a1ced9159234536dfc1834e0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775764}
-
Luis G Garcia authored
Added a CAMERA_ACCESS value to the XRSessionFeature enum, and updated several methods which use this enum. This is in preparation for allowing the user to request raw camera access when creating a immersive-ar session. I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4kMGCyCUIao/5vjPk4tuAQAJ Change-Id: Ic0ab7c4893472d7ed5d65cc4103772b42abdb3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225637 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#775763}
-
Liquan (Max) Gu authored
This reverts commit 098a1118. Reason for revert: This reland CL is still flaky[1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.payments.ExpandablePaymentHandlerTest Original change's description: > [Reland][ExpandablePaymentHandler] Test UI appearance and user interaction > > original CL: crrev.com/c/2227512 > revert CL: crrev.com/c/2231122 > revert reason: > showPaymentHandlerUi was flaky. It's very likely because the animation > took so long to finish that that it hits the timeout. Many screenshots > prove that because the payment sheet still had a thin scrim on it. > > change: > Compared to the original CL, the new one removes the animation. > > Bug: 1042892, 1084705, 1084707, 1084708, 1084711, 1084721, 1068741 > Change-Id: Ib3401e3e422e37a733f85eb56e6d08598d3ade1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232679 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775685} TBR=rouslan@chromium.org,maxlg@chromium.org Change-Id: I59ddce5a193b105e8d2e9f99a3891efbf6a0f178 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042892, 1084705, 1084707, 1084708, 1084711, 1084721, 1068741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233682 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#775762}
-
Carlos IL authored
The pref used for the EnableStricterMixedContentTreatment enterprise policy had its logic accidentally inverted as part of a refactor in crrev.com/c/2151841. This inverts the logic back. Bug: 1091033 Change-Id: Id14e89a304514b923cabecf6c4da982b0f60924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229241 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#775761}
-
Scott Violet authored
AFAICT this class doesn't depend upon AwContents. BUG=none TEST=none Change-Id: I0a0427986e71e31625d58aaa6b6c6840597d1ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232762 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#775760}
-
Jon Mann authored
All fields are not required in manual proxy settings, and when any optional fields were omitted it was crashing. This adds guards to only serialized the provided fields. Bug: 966270 Fixed: 1091405 Change-Id: I9e5aef0b6181c9e766f4779389437d2677a4fc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232824Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#775759}
-
Gabriel Marin authored
dTLB and iTLB miss cycle events generate a high number of samples at current rates, which cause large spikes in memory use while the profile is in memory. Lower their sampling rates by a factor of 10. Also lower slightly the sampling rate for cache misses. BUG=1088476,b:157930353 Change-Id: I54fa18a6c28c5c600e42db81b2bb86c5d77dbaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232745Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#775758}
-
Jun Kokatsu authored
This change removes innerHTML usage in various WebUI pages. Bug: 41905 Change-Id: I195b7d0bbf040f0bf1443222da75cb8a1734c16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226302 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#775757}
-
Stephen Chenney authored
These tests have somehow got their baselines wrong, and are failing with and without try job patches. Change-Id: I1496dd6b0158e9b2bdfb959a6d7f09b5f46a215c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232799 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#775756}
-
Anastasia Helfinstein authored
The onscreen keyboard needs to be displayed when Switch Access is enabled, despite the switch device appearing as a keyboard input, to allow the user to enter text. It also adds an externs file for the virtual_keyboard_private API, automatically generated from the existing file extensions/common/api/virtual_keyboard_private.json AX-Relnotes: n/a. Bug: 1091032 Change-Id: Ia2770485b2a2679812105c52761597776fd349a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229437Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#775755}
-