- 15 Dec, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Jd9IBDXrEmKkgb_A4oF9p3iMEi3gg3iptnwf_dbG_RgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ia2da8ce09acf58e915e7b910c949cd77dca285e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837141}
-
Fredrik Söderqvist authored
When an HTMLImageElement's 'src' is set to the empty string, the state of the image request will be 'broken', and thus the promise should be rejected with an InvalidStateError exception per the rules at [1]. Move the intrinsic size check below the image existence check, and use a more direct method of getting at the size (no need to go through the BitmapImageSource interface when we're already fiddling with internals). Also add a check for IsLoaded() to better match the spec wording 'fully decodable'. [1] https://wicg.github.io/shape-detection-api/#image-sources-for-detection Bug: 789511 Change-Id: I69ac4a9081cfff7f9c7c8f7edf39667e3dd1eb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587165Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837140}
-
Andrey Logvin authored
It was missed at https://crrev.com/c/2584603 Bug: 1155269 Change-Id: I7e0ac2e75210d909cba3905b2fae1aa39dbeeb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592997 Auto-Submit: Andrey Logvin <landrey@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837139}
-
Joe Downing authored
This CL adds a flag which will allow the website to request the 'elevated' It2Me host (with the UiAccess manifest value) is used instead of the base It2Me host which does not have access to elevated windows. The flag is overridden by the Chrome policy so if a network admin has specified that they do not want to allow elevated remote support hosts, this new flag is ignored. Change-Id: Ic84968f432db6ab041a5b4afdc38a2ac7be27a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586967 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#837138}
-
David Bienvenu authored
When session restore rebuilds the session restore commands, it was losing the workspace because it wasn't adding the workspace command to the list of rebuilt commands. This is most noticeable if you have a lot of windows open on different workspaces/virtual desktops. This CL also makes BrowserDesktopWindowTreeHostWin update the workspace on ::Show, if the workspace isn't set. This makes opening a new browser window immediately update the workspace, so it will be restored on session restore without the user having to focus the window. Bug: 1150225 Change-Id: I38ab861147041f4557e5ae8b62ec0c04763f1f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585990 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837137}
-
Peter Johnston authored
This change crrev.com/c/2380329 added an index to the interface name, following this now-deleted comment: // Interfaces with more than one IPv6 address will yield multiple // NetworkInterface objects, with friendly names to distinguish the // different IPs (e.g. "wlan" with three IPv6 IPs yields wlan-0, // wlan-1, wlan-2). This comment was incorrectly describing the previous behavior, and clients relied on `interface_name` not including an index. Bug: b/171599542 Bug: fuchsia:21155 Change-Id: Ied6972f15546a8f022f486e8c049bdf1dfb1e819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586317 Commit-Queue: Peter Johnston <peterjohnston@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837136}
-
Andrew Grieve authored
This reverts commit 06e0fcb1. Reason for revert: No longer necessary. Original change's description: > Android: Fix cronet proguard failure when enable_chrome_android_internal=true > > Tested that all targets now build via: > autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled) > > Bug: 1155547 > Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833824} TBR=pauljensen@chromium.org,agrieve@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1155547 Change-Id: I0361ac731d01e97012e21547201969cb3a492cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593769Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#837135}
-
David Maunder authored
FilePersistedTabDataStorageTest: 6744 ms -> 2003 ms (70% improvement) PersistedTabDataTest: 1621 ms -> 178 ms (89% improvement) Bug: 1158487 Change-Id: Ibe1c998aa4269955582c4a3d0548f61f5e939e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590344Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837134}
-
Jarryd authored
Bug: 1158461 Change-Id: Ifcf9beca09381e26f866f57c4be6a22225b2cccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590710Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837133}
-
Henrique Ferreiro authored
This is a reland of 1208732e Original change's description: > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > guarantees that the platform cursor has been set. > > Bug: 1097556 > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810120} Bug: 1097556 Change-Id: I89b742a80ddd9fee7a77b5af1bee07b58c18f39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445550Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#837132}
-
Jarryd authored
Replace deprecated DISALLOW_COPY_AND_ASSIGN macro with deleted copy constructor and assignment operator on the base class. Change-Id: Id6ce85518a1db717784a9a6d5f38ea2f191a1d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590691Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837131}
-
Aga Wronska authored
Shows setup for Family Link users on tablet and clamshell if the device supports PIN for login. Does not change the behavior for other users. Bug: 1156890 Test: PinForLoginSetupScreenTest Change-Id: I2e1f8a29ae6fa2739ee57ade6f1351d46254da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580402Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#837130}
-
Clark DuVall authored
This will also allow converting the remaining providers in //clank. Moving providers to the base module gives more time for the chrome split preload to work, see http://crrev.com/c/2577546 for more info. Note I removed the onCreate method from ChromeBrowserProvider, because it just calls ensureNativeSideInitialized(). Every method which uses native already calls canHandleContentProviderApiCall() which internally will call ensureNativeSideInitialized(), so it seems unnecessary to call from onCreate. This simplifies things a bit. Review from Patchset 1 on for better diffs, Patchset 1 just moves ChromeBrowserProvider.java to ChromeBrowserProviderImpl.java. Bug: 1150600 Change-Id: I98134425b32173211293a4306f7e962934ed47c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591879 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#837129}
-
Eric Lawrence [MSFT] authored
The comment referenced a function that no longer exists. Fix it. Change-Id: Id4b9b1107a07c14bc6e0a7d7283ed0aa67f72557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590405 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837128}
-
Evan Stade authored
Add webapps:: namespace to InstallableAmbientInfoBar code, since it will soon be moved to //components/webapps. Change banners:: namespace to webapps::, since a lot of that code will soon be moved to //components/webapps. Bug: 1147276,1147268,1151772 Change-Id: I089cbffb789993095e90ce6ceb7c84e0419a0e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586961Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#837127}
-
Yi Gu authored
Bug: 1152282 Change-Id: I05adec0b83f58387694b0443e8bdfc9a1d4ecfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592007Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837126}
-
Alice Wang authored
This CL moves AccountPickerDelegate to signin.ui target. Bug: 1158335 Change-Id: Ibd61670d9ef1ac098b3ba826b9239ece9dd2c283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592994Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837125}
-
Alex Ilin authored
This CL prepares the profile picker to work with the force signin policy. The list of changes: - Propagate IsSigninRequired() value from ProfileAttributesEntry to the WebUI - Modify the profile card to display "Sign in [lock]" prompt on profiles that require sign-in - Remove asserts checking that the force signin policy is disabled - Add native handlers for launching a locked profile and creating a new profile when the force signin policy is enabled Screenshot: https://drive.google.com/file/d/1Y03Kpe_4CoO5DWLbJ79Fu5j-hjjz0xzz/view?usp=sharing Bug: 1156096 Change-Id: I8aa315c4459ecf3e9d0faed331a3590aa92a0169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584002 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#837124}
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: I385d767ae4aee2160f85904afa5bac1da1c7923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593607Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#837123}
-
Peng Huang authored
The crash in vkGetPhysicalDeviceProperties2() which is supported by Vulkan 1.1.0. The Vulkan loader may support 1.1.0, but the device may not support 1.1.0, so we need check device API version before calling it. Bug: 1158768 Change-Id: Ib306feda2c4b790ef06e5802e4777744bf1c4892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593548 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837122}
-
John Abd-El-Malek authored
Bug: 1156663 Change-Id: I0ca8c2a2882c627780f94dae09b0e19a65bd04a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591708Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#837121}
-
Ossama Mahmoud authored
Bug: 1156668 Change-Id: I5ab27202a535c829304291ac53dc9545eeb292da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588909 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#837120}
-
Shengfa Lin authored
ChromeDriver python expecting pid in constructor Bug: chromedriver:3681 Change-Id: Icb1e56720ca3c8231442628254f965d675df1696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592807Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#837119}
-
Alex Turner authored
Currently, it creates a copy of the map, which means no metrics should be recorded. Change-Id: I8d00d464e448fa364cfd47dd8657b3c4f650fff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590384 Auto-Submit: Alex Turner <alexmt@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#837118}
-
Scott Violet authored
My intention is to merge this to 88. This adds the following changes to cct: 1. context menu when in incognito mode no longer shows 'open in chrome'. As the app menu explicitly doesn't show 'open in chrome' I'm assuming it's an over site that 'open in chrome' is shown in the context menu. If this isn't an over site, I can hide this behind the flag I previously added. 2. Makes it possible for first parties to use this regardless of the feature state if an extra is present. Reason for this is I plan to merge this to 88, in which the feature is disabled. 3. Makes it possible for colors to come from the intent. This is only enabled if an extra is present in the bundle and restricted to first parties. 4. Makes it possible for not show the incognito icon. This is only enabled if an extra is present in the bundle and restricted to first parties. BUG=1157916 TEST=Various tests in CustomTabActivityIncognitoTest Change-Id: I812f46e935dcae01b8d161893059ecf81c146522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582643 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837117}
-
Joe Downing authored
The current PolicyWatcher exposes a set of 'current' policies which is actually the default policies with overrides from any platform policy which is actually set. This works fine for driving behavior but in some cases we actually want to know whether a policy value we receive is the 'default' or if an admin has set it explicitly. To allow this, the PolicyWatcher will now store the set of platform policies on the machine and provide it on request. I plan to use this for logging (to get an idea of policy usage and popularity) and for cases where we want to provide a flag from the website to the NMH but also want admins to override the value if needed. Since the PolicyWatcher provides the platform policies now, I renamed GetCurrentPolicies() to GetEffectivePolicies() as I think that name reflects the fact that it is a merged set of policies. Change-Id: Id2fd578ac42d925922e8beb5f028374d7bcdcbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587614Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837116}
-
Yao Xiao authored
This is a reland of b5ab6427 Seems this CL shouldn't be the cause for the test failure that the reverted CL is referring to. Based on https://ci.chromium.org/p/chromium/builders/ci/android-asan, the android_sync_integration_tests also failed before (#9128). It also succeeded (#9148) after the recent mass failures (#9146), and the successful build occurred without the revert. Besides, this CL simply renamed a struct field / some APIs. Any potential errors should be caught by the compiler. Original change's description: > Rename publicly_routable field in the history APIs to floc_allowed > > What: Rename publicly_routable field in the history APIs to > floc_allowed. The database schema is left unchanged to save the > migration cost. Updated the comment for VisitRow::floc_allowed. > > Why: This bit is expected to be used only for floc. We've decided to > incorporate another opt-out status, and may introduce more status in > the future. Therefore it makes sense to rename to floc_allowed. > > Bug: 1157761 > Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836815} Bug: 1157761 Change-Id: I4d9329f953f3ee4d3707c2a4e06e27a8542c2bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592194Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#837115}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hggko_uXuyxm_pLSASRkHELwYPxwaBF969K75Dw8z_MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/161823671,b/169023690,b/174201860,b/174536568,b/175517195,b/175636714,b/175638149 Tbr: media-app@grotations.appspotmail.com Change-Id: I22450ce53bfefbd560ed610a48ec42cab73a4ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593422Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837114}
-
Joshua Pawlicki authored
This standardizes the updater at waiting at most 5 seconds for launchctl to reflect changes. Bug: 1151333 Change-Id: I7b15048b44a894b0244eea4fb265f59ee764e7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593550 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837113}
-
Marc Treib authored
Tbr: chrisha@chromium.org Bug: 1158715 Change-Id: Ib60e031f87da6d6e81759cb7461248a6ccd5556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593628Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#837112}
-
Matt Menke authored
The test had assumed connection partitioning was enabled. This CL makes it run with partitioning both enabled and then disabled. Bug: 963480 Change-Id: I7ee0d035969f7b0eaa3759080258cef53147a992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587350Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837111}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9efbf74cf61..e0eb7753ae75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: treib@google.com Change-Id: I0b18974e1503dc01137a8636f545e9eacc53def4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593415Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837110}
-
Lubo Ivanov authored
Chrome's perfetto producers. This is done to reduce the overhead of tracing. The batching period of 1s was determined using https://chromium-review.googlesource.com/c/chromium/src/+/1835498 in Chrome on gLinux, but with 4KB Chunk size (which corresponds to the chunk size on Android, where batching would have the most pronounced effect). The effects of various delays on overhead can be seen at https://drive.google.com/file/d/1Og9cSTaNmsSy1P6k0nfoyHK8n094HMrW/view?usp=sharing. A spreadsheet with the full perfstat results, on which this graph is based, can be found at https://docs.google.com/spreadsheets/d/15wxYJaR2hvUVY2MtqI29gPYwdkGxDZVqrUkSOZWspPs/edit?usp=sharing. Since all affected producers already set will_notify_on_stop=true, we can just flush commits while stopping a datasource to avoid losing any batched data. Related changes in perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/1260461 https://android-review.googlesource.com/c/platform/external/perfetto/+/1309414/13 https://android-review.googlesource.com/c/platform/external/perfetto/+/1450696/14 Bug: 1029298 Change-Id: I880cb2e49c169bcf6e216eb12ce52b8bd40ba4ad Change-Id: I880cb2e49c169bcf6e216eb12ce52b8bd40ba4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149648 Commit-Queue: Lyubomir Ivanov <lri@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837109}
-
Guido Urdaneta authored
This makes this method pure virtual and implements it in all derived classes. Prior to this CL, MediaStreamVideoSource had a weak pointer factory, which was incorrect as derived classes define more data fields which could become invalid before the factory invalidated outstanding weak pointers. Bug: 1158227 Change-Id: I31e6e0f624e9ba81b74e234b72c58f9dc5dbd585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588928 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837108}
-
Victor Hugo Vianna Silva authored
These histograms have nothing to do with components/sync, they were mistakenly added to the sync histograms file. Bug: None Change-Id: I5d22799a2a4c20534db04de3ff8531cef781a38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590036 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#837107}
-
Dominic Farolino authored
Before this CL, MockAgentSchedulingGroup would always invoke the AgentSchedulingGroup base class constructor which is now reserved for the kLegacy MBI feature mode. This caused the ctor to DCHECK in tests when MBI mode was enabled. After this CL, MockAgentSchedulingGroup conditionally invokes the right AgentSchedulingGroup constructor given the flag. Consequently, MockRenderThread::GetIOTaskRunner() needs to be able to return a non-null TaskRunner. This CL gives MockRenderThread the ability to set a new IOTaskRunner manually so that it can be returned when necessary. While we're here we also remove PrintMockRenderThread_set_io_thread_for_testing() since the base class MockRenderThread now handles that. We also entirely remove ChromeMockRenderThread. Bug: 1158656 Change-Id: I1ab1231048ecc1b798549634811706f86a7bafb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591929 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#837106}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I5a379fb181f277cd3cd67c193912e29a0b949836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566738 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#837105}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7808f1c464a..cf8ec1f68676 2020-12-15 mbonadei@webrtc.org Introduce empty rtc_base:async_resolver target. 2020-12-15 mbonadei@webrtc.org Add TBR to the WebRTC code freshness updater and send to CQ. 2020-12-15 natim@webrtc.org Using absl::optional for round trip time return type handling. 2020-12-15 deadbeef@webrtc.org Get rid of recently added rtc_openssl_is_boringssl build argument. 2020-12-14 mbonadei@webrtc.org Add WebRTC code freshness version string. 2020-12-14 ilnik@webrtc.org Use a task queue for call interaction in video_replay tool 2020-12-14 mbonadei@webrtc.org Fix order-dependent tests. 2020-12-13 sprang@webrtc.org Extend LibvpxInterface with VP9 support and use it from LibvpxVp9Encoder 2020-12-11 natim@webrtc.org Enforcing return type handling on VoIP API. 2020-12-11 hta@webrtc.org Add tests for adding many transceivers and renegotiating. 2020-12-11 hmaniar@nvidia.com Reland "Enable FlexFEC as a receiver video codec by default" 2020-12-11 deadbeef@webrtc.org Reland: Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL. 2020-12-11 deadbeef@webrtc.org Do all BaseChannel operations within a single Thread::Invoke. 2020-12-10 sprang@webrtc.org Splits vp9_impl into libvpx_vp9_encoder and libvpx_vp9_decoder. 2020-12-10 philipel@webrtc.org Remove EncodedFrame::inter_layer_predicted. 2020-12-10 philipel@webrtc.org Remove use of inter_layer_predicted in FrameBuffer2. 2020-12-10 landrey@webrtc.org Rename UNIT_TEST to WEBRTC_UNIT_TEST 2020-12-10 saza@webrtc.org Revert "Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL." 2020-12-10 deadbeef@webrtc.org Use CRYPTO_BUFFER APIs instead of X509 when building with BoringSSL. 2020-12-09 philipp.hancke@googlemail.com sdp: add missing continue after parsing b= lines 2020-12-09 devicentepena@webrtc.org Erle metric: avoid the decreasing of the metric when there is no render activity. 2020-12-09 philipel@webrtc.org Stop using inter_layer_predicted flag for VP9. 2020-12-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a89d00b3..708cc13d (834813:835045) 2020-12-09 alessiob@webrtc.org RNN VAD: FC layer simplified 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2be5b61c..a89d00b3 (834670:834813) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88d50e234435b85c641c616bbaebfc3724291749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837104}
-
Liquan (Max) Gu authored
This CL does not cause behaviour change. Changes: * Renamed "continueShow" to "continueShowWithUpdatedDetails" * In onPaymentDetailsUpdated(), replaced mSpec.getPaymentDetails() with details because they are the same object. Bug: 1149936 Change-Id: Icea9f313b513861d4655e3f66f053c015c6f775f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590059Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837103}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4baf1b64..6b82504a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If0b95f4643334edac638242f497abc0bb1f29682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593588Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837102}
-