- 06 Aug, 2018 40 commits
-
-
Patrick Noland authored
Bug: 834001 Change-Id: I4f21239a17fa91d824f143a8043a1114e6853e2f Reviewed-on: https://chromium-review.googlesource.com/1159000 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#580938}
-
Aga Wronska authored
demo mode setup flow. * Change DemoSetupController delegate into callback passed to Enroll() * Pass info about enrollment type separately from Enroll() request * Store DemoSetupController instance in WizardController instead of DemoSetupScreen for easier storage and access to demo setup flow status Change-Id: I43f2f28dfc2daea519849d222ea5a73561522516 Bug: 862445 Test: Run DemoSetupTest, DemoSetupControllerTest and wizard_controller_browsertest. Reviewed-on: https://chromium-review.googlesource.com/1155152 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#580937}
-
Ryan Hamilton authored
A future CL will rename this to FakeClock. Change-Id: I105d1d0278eb15eb0601fd40b45f738cd9cad7ff Reviewed-on: https://chromium-review.googlesource.com/1163832 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580936}
-
Jialiu Lin authored
Advanced Protection (Titanium) service flag is included in client ID token if user is in this program. This CL parses client ID token to determine if Advanced Protection serice flag is available. Very similar to how we get the child account bit for unicorn. Service side of work is tracked in b/109872750. Change-Id: Iaf9490fb2bd16b61480bbf1c875ba451d25f853d Bug: 866620 Reviewed-on: https://chromium-review.googlesource.com/1155813Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#580935}
-
Tao Wu authored
This reverts commit b3a65a61. Reason for revert: Need to write a service to demux and decode. Original change's description: > Add assistant audio decoder > > This cl creates a mojo service for assistant audio decoder. The decoder > is running in utility process. This is a temporary solution until > MediaService for Chrome OS is implemented. > > Bug: b/80315134 > Test: manual tested can create the audio decoder for assistant. > Change-Id: Ib4d1a8d3e6d38b0cbb436e20e6d12033d74ed7cf > Reviewed-on: https://chromium-review.googlesource.com/1137020 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577713} TBR=dcheng@chromium.org,dalecurtis@chromium.org,kinuko@chromium.org,xhwang@chromium.org,sandersd@chromium.org,xiaohuic@chromium.org,tguilbert@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/80315134 Change-Id: I9e7636a9f1e809bc35cbefda5d4183718a5ef240 Reviewed-on: https://chromium-review.googlesource.com/1162546Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580934}
-
Maks Orlovich authored
... It's not going to keep much cached if the process gets OOM killed, after all. Bug: 845639 Change-Id: Ic3e8ac616e2b511f995410a5aa54c1342cef0b63 Reviewed-on: https://chromium-review.googlesource.com/1110155 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580933}
-
Matt Menke authored
The class is reference counted, and makes a mojo call, with a callback, on the UI thread. The callback was passed a raw pointer to the class, but when it was invoked, it grabbed a reference to the class. When the class's last reference is released, it posts a delete task to the UI thread. So if the class's last reference was released, and then it received a a Mojo callback, there would be a pending delete task, we'd grab a new ref (Increasing the refcount from 0 to 1), the delete task would run, and then a new delete task would be posted when the reference went to 0 again, resulting in a double-delete. This CL fixes that by making the class keep a reference to itself whebever there's a pending mojo callback. MessageFilters are designed to be able to call Send() after the class they want to send messages to has been deleted, so the increased lifetime is completely safe. Bug: 870675 Change-Id: I64f6656e61dc9222a67cd40555d3dd73fb48e208 Reviewed-on: https://chromium-review.googlesource.com/1161967 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580932}
-
Min Chen authored
event->target() is different from GetTopLevelWidgetForNativeView(event->target()))->GetNativeWindow() for arc apps, but the same for chromeos apps. Use native window of target's top level widget instead, then CanDrag can get the correct value for arc apps, then we can drag the arc apps from the top. Bug: 847587 Change-Id: I9b0df4021b5872b823130450af43d93c0c97f6c8 Reviewed-on: https://chromium-review.googlesource.com/1157561Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#580931}
-
Xiaohui Chen authored
Added two very infreqent vlog for debug auth issues. Bug: b:111370621 Test: locally build Change-Id: I77d3f6cc23a8c0cd9d5ab30c59989d1f2d80b464 Reviewed-on: https://chromium-review.googlesource.com/1162879Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580930}
-
Lukasz Anforowicz authored
Bug: 846346 Change-Id: I943bbecdd669c6e7c4eb5d3c5de6331dd35e0b1e Reviewed-on: https://chromium-review.googlesource.com/1159269 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580929}
-
Scott Violet authored
ShouldOpenAshOnStartup() is no longer called. BUG=none TEST=none Change-Id: I489e5376be048c8078f4c4659f336bbb82b85f57 Reviewed-on: https://chromium-review.googlesource.com/1163825Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580928}
-
gogerald authored
Bug: 866996 Change-Id: I0c6a73956a2f31fe51bba193ec5348c2ef05bc5b Reviewed-on: https://chromium-review.googlesource.com/1163634Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#580927}
-
Elad Alon authored
Some helper functions in the unit test suite accepted two int-s, instead of a PeerConnectionKey. That: 1. Made things longer, and therefore harder to read. 2. Introduced some risk of a typo, by which the wrong two int-s would be given. This CL solves the problem. Bug: 775415 Change-Id: Iaf45ce04779ff9a56dcdd00407afaf6c35b16749 Reviewed-on: https://chromium-review.googlesource.com/1153250 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#580926}
-
erikchen authored
Renderers never go to sleep. If the browser goes to sleep, IPC messages will queue up. When the browser finally wakes up, it can stall for 30min+ processing those IPC messages. This CL disables AppNap for the browser process, which will make sure that IPC messages get processed in a timely fashion. This CL does not set the Info.plist option NSSupportsAppNap to false, as that has no effect. To test: 1) Run /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -f <path_to_chrome> if changing the Info.plist. 2) Launch Chrome from the finder. 3) Switch to a different virtual desktop [no chrome windows showing]. 4) Launch Activity Monitor, switch to "energy" view, make sure Chrome/Chromium is visible. 5) Launch Safari and make sure it's the active app. 6) Wait 10 minutes Expected results: Chrome/Chromium does not enter AppNap. Previous results: Chrome/Chromium does enter AppNap. Bug: 871235 Change-Id: I9af05e38b7706c9e61a99316a88fd4ea5fada997 Reviewed-on: https://chromium-review.googlesource.com/1163726Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580925}
-
Elad Alon authored
A Chrome policy is introduced, by which remote-bound WebRTC event logging may be enabled. This policy may be configured for desktop platforms and for ChromeOS, beginning with Chrome M70. A Chrome feature is retained, to serve as a Finch-driven kill-switch for the feature. The network annotations will be updated by CL #1163706. Bug: 775415 Change-Id: Ia423d848b09001539dbe265d03e0c3826bf4beea Reviewed-on: https://chromium-review.googlesource.com/1152974 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580924}
-
Becky Zhou authored
Add presubmit checks to detect Android text attributes defined outside text appearance style, and text appearance style must be prefixed by "TextAppearance.". Bug: 775198, 819142 Change-Id: I3492b8845bb6c0bf46debf242e90defb8a532010 Reviewed-on: https://chromium-review.googlesource.com/1152424 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580923}
-
Matthew Cary authored
Future changes to shared memory introduce an implicit dependency on mojo, which must be initialized in unittests. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I13de882b7f995ac33385d2f6d5f49b5ac44bb2c4 Reviewed-on: https://chromium-review.googlesource.com/1156588Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#580922}
-
Weilun Shi authored
By setting the last selected directory to the user profile after the user select a custom background image, the user can go to the last directory instead of going to "This PC" or home directory. Bugs: 867758 Change-Id: I6b6fb1296a2f1ffb60148522cdd25a1f027f630e Reviewed-on: https://chromium-review.googlesource.com/1162712Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#580921}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/79eccf98e8fd..93f9ef7fc26f git log 79eccf98e8fd..93f9ef7fc26f --date=short --no-merges --format='%ad %ae %s' 2018-08-06 nednguyen@google.com Remove --experimental-story-shard-* flags 2018-08-06 perezju@chromium.org [long term health] Tweak gsutil url and ignore output dirs Created with: gclient setdep -r src/third_party/catapult@93f9ef7fc26f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866095,chromium:863390 TBR=sullivan@chromium.org Change-Id: If56e39209b541bb82681b8e5d5b438e9b50ac46e Reviewed-on: https://chromium-review.googlesource.com/1163115Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580920}
-
Lei Zhang authored
Previously, all supported distros had it except for RHEL 7. Now RHEL 7 has it too. https://access.redhat.com/errata/RHEA-2018:0817 Change-Id: I667ac877c76efd3369ce634da5be5e2d6c86ee9e Reviewed-on: https://chromium-review.googlesource.com/1159995Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#580919}
-
Mohamed Amir Yosef authored
This is a reland of a445460b after splitting it into 2 patches. This will help find out the source of the problem that caused the original CL to be revered. The original CL caused once integration test to be flaky. In addition we added special handling for a corner case that could be the reason of the flakiness introduced. Original change's description: > Reland "[Sync::USS] Bookmark sync conflict resolution" > > This is a reland of 553ec6da > > Original change's description: > > [Sync::USS] Bookmark sync conflict resolution > > > > This patch addresses the problem of conflict in bookmarks upon > > receiving a remote update for a node that has local changes. > > > > The general polic that is implemented is that server wins except in > > case of deletion. > > > > Bug: 516866 > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > > Reviewed-on: https://chromium-review.googlesource.com/1157006 > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580436} > > Bug: 516866 > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e > Reviewed-on: https://chromium-review.googlesource.com/1161861 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580496} Bug: 516866 Change-Id: I8371c2347aa1396115e83a35d56f4198ff5c30ba Reviewed-on: https://chromium-review.googlesource.com/1163081 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580918}
-
Joel Einbinder authored
Previously, mac-style context menus were used everywhere that we could not use a native context menu. With this patch, there are now three context menus: A standard context menu for windows/linux. The old style context menus for mac. A dark theme context menu, which is used in place of native menus on all platforms. https://i.imgur.com/DRDp1E2.png Change-Id: Ic3be0e7ac1661ef1eaeecdc473bdef7dc015314b Reviewed-on: https://chromium-review.googlesource.com/1161282Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#580917}
-
Ramya Nagarajan authored
Images are requested at the exact resolution required for tiles in the custom background selection dialog, reducing the overall data loaded. Bug: 851990 Change-Id: I2e29e6d8f7e888ef4c02fdaf156a360471662435 Reviewed-on: https://chromium-review.googlesource.com/1163293Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580916}
-
Mao Huang authored
Original CL: - https://codereview.chromium.org/1294001 Fix a few more places where we need to use our own allocator. Make tcmalloc compatible with the seccomp sandbox by avoiding making direct system calls from within tcmalloc. BUG=38973 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42667 BUG=724399,b:70905156 Change-Id: Idd3d2c4c9cace62e6d5aad32302193e19548e998 Reviewed-on: https://chromium-review.googlesource.com/1130787Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580915}
-
Sarah Hu authored
Bug: 835357 Change-Id: I61be44e86f85175a3472669aecf630ddb5bb2fa2 Reviewed-on: https://chromium-review.googlesource.com/1159383Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580914}
-
Kuo-Hsin Yang authored
Bug: chromium:869762 Change-Id: I85a0b5f35465c5e2974248426dfb874e13259c8e Reviewed-on: https://chromium-review.googlesource.com/1163045 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#580913}
-
Ramya Nagarajan authored
Removing the fakebox bottom margin (per spec) eliminates the scrollbar. There's still a margin above custom links, separating them from the fakebox. Before & after screencast: https://drive.google.com/file/d/1IvcCIm1keZPfQzSYMDYHd0xRJfo9YCMp/view?usp=sharing Bug: 863445, 869659, 867763 Change-Id: Ibd0edbb3a4a5b1a0a17e544b5a9cc072dc3ffe60 Reviewed-on: https://chromium-review.googlesource.com/1163200Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580912}
-
Clark DuVall authored
The error event was not being sent when the client was reset. Bug: 721414 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I951422061022d50644d8453900af14be27bb9eaf Reviewed-on: https://chromium-review.googlesource.com/1150403 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580911}
-
Jérôme Lebel authored
Updating the Google services commands to have the data type as a parameter to toggle each data type to sync, instead of having one command per data type. When a data type switch is toggled, the mediator enable/disable the data type with the sync setup service. The mediator listens to the sync setup service notifications. It reloads the sync switchs only if when the notifications don't come from a UI changes (to let the switch animation goes to the end). The EarlGrey tests will be done in another patch. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7586af0591a30956df7c635e025d045c1b3648be Reviewed-on: https://chromium-review.googlesource.com/1148571 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580910}
-
nednguyen authored
This is to validate whether they are causing the failures Bug: 868675 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I3ccdb25614fbfddfc77224b3df9314a79970fc57 Reviewed-on: https://chromium-review.googlesource.com/1163638 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580909}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12fb9cfeee07..439da2812f74 git log 12fb9cfeee07..439da2812f74 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd4c8631343f..02956e4cced0 (1 commits) 2018-08-06 benjaminwagner@google.com Update remaining Mac bots to 10.13.6, except iOS builds. 2018-08-06 caryclark@skia.org clean up includes 2018-08-06 jvanverth@google.com More SkOffsetSimplePolygon optimizations. 2018-08-06 bsalomon@google.com Store GrMeshDrawOps' meshes in GrOpFlushState's arena. 2018-08-06 egdaniel@google.com Start adding support for some base extensions which others build on. Created with: gclient setdep -r src/third_party/skia@439da2812f74 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862292 TBR=djsollen@chromium.org Change-Id: I5bbbf92917eb2917d6cb9214fcf78f070934fa22 Reviewed-on: https://chromium-review.googlesource.com/1163117Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580908}
-
Sarah Hu authored
Fingerprint enrollment session is ended automatically when it is complete. Local object path needs to be reset for this case. Bug: 834448 Change-Id: Ieedf5f2f9fbf6ef7b3519414ef792b5cb54ba163 Reviewed-on: https://chromium-review.googlesource.com/1162906Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580907}
-
Dale Curtis authored
This removes passing of the origin and is_top_frame values from the (untrusted) renderer. Instead we retrieve them from the render frame host at the time the MediaMetricsProvider is created. BUG=800610 TEST=updated test still pass. Change-Id: I70abbd5a98b574d0bbbc0d64d9fd194c4fb82e90 Reviewed-on: https://chromium-review.googlesource.com/1161186Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580906}
-
Olga Sharonova authored
This is a reland of eab3705f Original change's description: > Delay audio service launch on the browser startup. > > (see the bug) From the traces the service/process creation gets posted to the > IO thread during startup. > It may be delaying startup for some other services needed for the first paint, or it may be > just eating up CPU when the load is already quite high. We'll experiment with delaying > the service launch. > > Bug: 867461 > Change-Id: I048e33d049e665d8e9489046c5813918d8077524 > Reviewed-on: https://chromium-review.googlesource.com/1153248 > Commit-Queue: Olga Sharonova <olka@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579460} Bug: 867461,870171 Change-Id: Ia1a0c31ccc6c643ad10fb250862a9d1fb408c216 Reviewed-on: https://chromium-review.googlesource.com/1162184 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#580905}
-
Gabriel Marin authored
sys_{mmap|munmap|mremap}(...) calls are replaced with syscall(SYS_{mmap|munmap|mremap}, ...), as the former are not allowed by Chromium's sandbox. BUG=724399,b:70905156 Change-Id: I04d87567a7c6194a0619140ffd5d4449c73a398b Reviewed-on: https://chromium-review.googlesource.com/1130786Reviewed-by:Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580904}
-
Toni Barzic authored
Most of the callers to CrOSComponentManager::Load expect the callback to be called on the UI thread (the same as the thread from which the method was called)- the only exception is CrostiniManager, which does not assume the callback is called on the UI thread, but still just relays the callback result back to UI thread. Currently, callbacks are run using base::PostTask, which post the callback to the task runner. To make the behavior of the method match the expectations, use ThreadTaskRunnerHandle::Get to get the current task runner, and use it to asynchronously run the callback. Bug: None Change-Id: I9f365a11ba2634154488c580615ceede59e2a9d3 Reviewed-on: https://chromium-review.googlesource.com/1163071 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#580903}
-
Thomas Tangl authored
Add metric to record the suppress reason when the consent bump should not be shown. Additional changes: - Don't show consent bump when any on-by-default privacy setting was off during migration. Bug: 858870, 863948 Change-Id: Iac7bbb6b8d1d332db3439b2f96c6035ed255e6b3 Reviewed-on: https://chromium-review.googlesource.com/1162233 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#580902}
-
Peter Beverloo authored
Change-Id: I980ed5d43a3afef2d96a3702bc9f7129c68950ab Reviewed-on: https://chromium-review.googlesource.com/1163605Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580901}
-
Weidong Guo authored
1. Flip the feature flag. 2. Fix test errors. Bug: 865139 Change-Id: Ibbb7c5e6fa1f94a419015591c318a2b2a1905809 Reviewed-on: https://chromium-review.googlesource.com/1142441 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580900}
-
Balazs Engedy authored
The test was observed to be flaky. Bug: 870852 Change-Id: I3163111ba26e30d0864ff3a52a1ab21e64137725 TBR: nednguyen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1163678Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580899}
-