- 12 Dec, 2020 8 commits
-
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //ui. Bug: 1113033 Change-Id: Id5922f2b2a0a870048107d653cb78c2f05e942d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583126Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#836324}
-
Chan Li authored
Bug: 1139149 Change-Id: I5c30134bd5467fa9e68d65605b23f72edc7cece2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587570Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#836323}
-
Dale Curtis authored
Per discussion on https://crrev.com/c/2527025 no decoder used by Chrome requires this. Also, our current checks are incorrect while our test data uses non-compliant streams... so just remove! https://chromium-review.googlesource.com/c/chromium/src/+/2527025 R=wolenetz Change-Id: Ie10199182f4dcae18ea221a14623040517605173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587688 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836322}
-
Yi Gu authored
We plan to ship the new CodeBrowser backend of WebOTP via Finch. This patch adds necessary code on the client side. Bug: 1153880 Change-Id: I550ff16d34ec638a0275007b2e1481dec8295115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580539 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#836321}
-
Ben Pastene authored
crrev.com/i/3462032 allocated 100 machines for this pool: http://shortn/_z6nSkdF9st That should be about enough according to http://shortn/_PPwEhxY2rU, especially since cache hit-ratios should be much better now after this. Bug: 1140727 Change-Id: Ic48d4f7fccde6aca434ffb1d7e1fc0f3381d757c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587558Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
dpapad authored
Bug: 844820,525224 Change-Id: I6f2f40c2dd7e03a570eba8e08654eb38c9897776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586100 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836319}
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/ui/views/frame from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: I77fce1eabfc0652828547d9b59c2517e74fc629f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585815Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836318}
-
Guillaume Jenkins authored
Adds the remaining strings needed to finish the BrowserSignin policy implementation on iOS. Bug: 1155745 Change-Id: I530b4e23af0340d2851f0adb8b0f865d14bcd0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586325 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#836317}
-
- 11 Dec, 2020 32 commits
-
-
Will Harris authored
Also, change a loop to range-based. Bug: 842296 Change-Id: I5bf10c0b3997e3ab7899217b68e9c06d265d3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586848 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#836316}
-
Alex Moshchuk authored
This test is failing on Mac and Win bots with an image diff, following the import at https://chromium-review.googlesource.com/c/chromium/src/+/2584498. Sample: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/11475 Looks like the failure is due to "/opt" vs the expected "/b" in paths that appear in the error image. Bug: 626703 Change-Id: I4fe0f1a309bd397c9a1509e1d01010aec9512f3b Notry: true Tbr: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587654Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836315}
-
John Lee authored
The previous failure of this test was caused by a tab that was not the pinned tab being tested changing its tracked status. The only way a tab element changes tracked status is because it intersects with the threshold in the IntersectionObserver, changes pinned state, or is added or removed from the DOM. This CL removes all tabs besides the tab being tested so to hopefully make the test more reliable. Fixed: 1156948 Change-Id: I36aae0861a8c4fb5f5520c229ee586c66c5727e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586092Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836314}
-
Scott Lee authored
ResultDB for junit_tests was enabled on chromium.android at 30%, and 100% of the builds succeeded with resultdb. https://screenshot.googleplex.com/BvHH2VDXm7hGvCh There are only 3 builder groups with junit_tests in chromium. - chromium.fyi - chromium.android - chromium.clang If all builds on android and clang succeed after this CL, the next CL will enable ResultDB for junit tests on all builders at 100% rate. (Dec 14) R=gbeaty@chromium.org,chanli@chromium.org Bug: 1084332 Change-Id: Ie8aa34868b58a64e0f88e2099cb6ceef01256af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587495Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836313}
-
Brian Sheedy authored
Adds support to mb.py for cases where an args.gn file uses import(...) to reference GN args in a .gni file, such as how board-specific CrOS args are specified. Change-Id: If11ad05cbc9605e89cc743e72f9178de016bdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587552 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836312}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I71515dc3a742b119269953bd3faf696d5ce79212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836311}
-
Kyle Horimoto authored
Records a metric upon connection via Bluetooth, then another metric upon bandwidth upgrade to WebRTC. Will be used to verify the success rate of WebRTC upgrades for the feature. Bug: 1150634, 1106937 Change-Id: I8a7e8b1ee26aa47fd681e089ab0bf13450754f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586374 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836310}
-
Dale Curtis authored
This adds a SurfaceLayerForMediaStreams feature that is enabled by default. The expectation is that the Meet team will use this to evaluate the CPU usage and other performance characteristics. To disable surface layer for media streams you should launch Chrome with --disable-features=SurfaceLayerForMediaStreams R=liberato Bug: 1157671 Test: http://apprtc.appspot.com/ Change-Id: I89cca10f8a81939d4a742be4352dcd2075edc6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586513 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836309}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40dbba6dda38..0bf3f26cf343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: I4c77bcc6813db587e897fdf402db5e213e264519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586965Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836308}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7542517e29ce..0991ca17bab3 2020-12-11 ericlaw@microsoft.com [NetLog Viewer] Enable import of .ZIP files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057782 Tbr: wenbinzhang@google.com Change-Id: I3eb60c8ef9b33f230c855b0685d2e6232aa8e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587220Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74ccf7b62fc6..778b2c216924 2020-12-11 fmayer@google.com Merge "Default symbolizer to nullptr." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If8d244c11b4d38feec1c760a3ca98a204184db19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587391Reviewed-by:
-
Andre Le authored
PhoneHub will only be available for primary user of the device. Bug: 1106937 Change-Id: Ic903a0f9d97bcd0a65afab8f5fd8a3ae8ed18d73 Fixed: 1155361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581691 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836305}
-
David Dorwin authored
The tests fail in component builds because of the way the Safe Search code is built. Disable the tests in component builds until this can be resolved. Bug: 1147231, 1157909 Change-Id: Idac5bb566377d387bd0332d8d32e00bff8c742ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587492Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836304}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_UpdateHitTestData IPC message to LocalMainFrameHost interface because the IPC message has been used by 2 functions. So, this CL adds the message to LocalMainFrameHost interface instead of handling it as a reply callback. To support the parameter, this CL moves AwHitTestData struct and HitTestDataType enum to Mojo. - AwHitTestData -> android_webview::mojom::HitTestData - Type -> android_webview::mojom::HitTestDataType Then, all uses of the native struct and enum are replaced by the Mojo struct and type. Bug: 1146495 Change-Id: I906e00f1f5f3e18556613b39eedb90bf845b164c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574560Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#836303}
-
Guillaume Jenkins authored
When browser sign-in is disabled by policy, replaces the sign-in promo in the "Other devices" section of the Recent Tabs views with a message indicating that the feature has been disabled by the managing organization / administrator. Bug: 1155745 Change-Id: I496e7f7ec53d721748e8a49c9a01228aa9b43548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575260 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836302}
-
David Black authored
Finishes the holding space view hierarchy refactor by renaming: - HoldingSpaceItemViewsContainer --> HoldingSpaceItemViewsSection - PinnedFilesContainer --> PinnedFilesBubble - RecentFilesContainer --> RecentFilesBubble Bug: 1154998 Change-Id: I621a8c76daf142ced35503fe78801dbfd09d4570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587611 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836301}
-
Anqing Zhao authored
KioskAppExternalLoader is used to load apps and extensions for a Chrome App Kiosk session. It registers a callback and wait until app info is updated. This class should be only used in Chrome App Kiosk, but not in other two Kiosk types. But according to the current implementation, the loader is enabled unexpectedly and blocks the uninstallation of force-installed extensions when they are removed by admins. Therefore, the check logic should be limited to a proper scope. Bug: 1153440 Change-Id: I8bf79fa553dfbea5e271b7f06fc6ff0dffb33495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575118Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#836300}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1152698 Change-Id: I55879a551671b5b9a87ad83c59cc10a055b4cf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585814 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836299}
-
Etienne Pierre-doray authored
Sampling profiler uses TimeTicks::Now in signal handler to get a timestamp associated with the sample. When called from signal handler, TimeTicks::Now occasionally crashes the following check: CHECK(clock_gettime(clk_id, &ts) == 0) In order to get good time precision in profiler, we'd like to get a timestamp while the sampled thread is paused. Since failures are rare, a solution is to allow clock_gettime to fail, and fallback to getting an 'async' timestamp after resume. To reuse some of the ConvertTimespecToMicros boilerplate common with TimeTicks::Now, this CL exposes subtle::MaybeTimeTicksNowIgnoringOverride() on posix, used in stack_coper_signal. Bug: 1155269 Change-Id: I4d8f5a3e050f5285b87297f13dfd29e888e40257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584603 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836298}
-
Evan Stade authored
Bug: 1152276 Change-Id: I44471424b6f6a106a029a87b54b30eca1e17229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582818 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836297}
-
Martin Barbella authored
Change-Id: If076a5431ed62f498f3098a29d65f5d616acd892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587357Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836296}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607666365-8ac3b41b3fd6b7cdefcffd3f36f49fc644306c58.profdata to chrome-win32-master-1607698715-1a3a3061a3079200d5a916fef636afe5df338f1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic50324a2663a8f89b91ff7af0abe51a14a0cac0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586527Reviewed-by:
-
Min Qin authored
BUG=1157734 Change-Id: I419951b1c9880054f98d59eddaa681f02bb0359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586223Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836294}
-
Patrick Noland authored
This changes moves dispatchKeyEvent, onConfigurationChanged, showUrlBarCursorWithoutFocusAnimations, and updateStatusIcon to LocationBarMediator. To enable this, it adds a getter and setter for mUrlFocusedWithoutAnimations. Some unused methods are removed. Since onKey logic has changed structure, unit tests are added for this. Bug: 1147581, 746660 Change-Id: I4715a156d02b8e9c3a4c63109c0cc521251f5cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585444 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#836293}
-
Stephen Roe authored
Bug: 1126177 Change-Id: I7a092787449f01318f31f408adc80173e6f4f07d Ignore-Goma-Freeze: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580442Reviewed-by:
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/ui/views/extensions from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: Ie6c0e8002710c9fe895f65dc60b9a4ec1e8f71d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586120Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836291}
-
Finnur Thorarinsson authored
The bottom-sheet UI is a hybrid between the PWA install infobar and the install dialog and serves as a direct replacement when the feature is enabled. Bug: 1146450 Change-Id: I3c31659017e7872a1ab5f5df5c445d40b249ffc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550820 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836290}
-
Josh Imbriani authored
Bug: 169173203 Change-Id: I6afeb402e91399a529916f041b16f0964e8f4e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572776Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Josh Imbriani <joshimbriani@google.com> Cr-Commit-Position: refs/heads/master@{#836289}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c94b21d60ca4..99399caeacf6 2020-12-11 gavinmak@google.com [owners] Add BatchListOwners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Icc53e8c2aa44590e835f80b66b5f9079f023fe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587219Reviewed-by:
-
Noel Gordon authored
After CL:2515787, the SWA main.html auto-generator generates an error Did you mean print(line + ' ' + _SWA) ? and stops a gn clean simple chrome flow ChromeOS build. Apply the fix suggested to fix build error (works before and after CL:2515787). Tbr: lucmult Bug: 1113981 Change-Id: I454674756ab2bcf24c65d4ca1b815fc2e5b30201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585261Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#836287}
-
Majid Valipour authored
Previously we would access the IDP web contents which was leading to crash. Bug: 1141125 Change-Id: I5943d38e51f8e14fbf0488d0a104cd56b39ea5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586112 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836286}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5912ded0c19b3a7db52efda609363d11a5ed7144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587217Reviewed-by:
-
