GitLab

1. Set WindowType to "control" in RWHVAura::InitAsChild().  Previously, the window type was not being set, and this caused a NOTREACHED() crash at ash/wm/stacking_controller.cc:101.

2. Infinite loop freezing the browser when entering fullscreen: In WebView, AttachWebContents() and DetachWebContents() were being indirectly called from FOR_EACH_OBSERVER().  Because they were calling WebContentsObserver::Observe(), the FOR_EACH_OBSERVER loop would never terminate.

3. Clean-up: Eliminated WebView::web_contents_ member since WebView inherits from WebContentsObserver, which already has it.

TEST=Run chrome with and without --embed-flash-fullscreen command-line arg, and test switching tabs, flash fullscreen, keyboard focus, etc.  Tested on Win and Linux Aura builds.

Review URL: https://codereview.chromium.org/120503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243725 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330084

Review URL: https://codereview.chromium.org/111853012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243724 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/129573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243723 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an app-style widget called app-drawer to the Silk page set. The
app-drawer widget comes from https://github.com/abarth/app-widgets and is based
on Android's navigation drawer:

http://developer.android.com/design/patterns/navigation-drawer.html

R=nduca@chromium.org
TBR=boliu@chromium.org
BUG=332439

Review URL: https://codereview.chromium.org/120753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243722 0039d316-1c4b-4281-b951-d872f2087c98

It's unnecessary to gate solid-color scrollbar properties on whether
the root container masks to bounds, since the vertical adjust should
resolve to zero in this case anyway.  It's necessary to set VisibleToTotalLengthRatio
for desktop overlay scrollbars to be sized correctly.

BUG=331605
TEST=None
R=aelias

Review URL: https://codereview.chromium.org/106733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331459
TBR=sehr@chromium.org

Review URL: https://codereview.chromium.org/126823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243720 0039d316-1c4b-4281-b951-d872f2087c98

The rest of aura targets do not reference cc/, so they don't need to
explicit list cc/ as a dependency.

BUG=None
TEST=aura_bench, aura_demo, aura_unittests, all three still links
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/124343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332175
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/129693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243717 0039d316-1c4b-4281-b951-d872f2087c98

This UI currently only displays battery charge percentage over time.
Later iterations will add more plots.

BUG=312956

Review URL: https://codereview.chromium.org/123713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243716 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r243708  which is causing a build failure:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/50092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243476

Review URL: https://codereview.chromium.org/128893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302852,275611
TEST=ImmediateInputRouterTest.GestureTypesIgnoringAck

Review URL: https://codereview.chromium.org/84653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331805
TEST=No visible change. Existing unit tests.

Review URL: https://codereview.chromium.org/128513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243712 0039d316-1c4b-4281-b951-d872f2087c98

Implementation CHECKs, so this is only needed for tests and ash, which
we're not worrying about yet.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/128743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TBR=asvitkine@chromium.org
TEST=With the --new-profile-management flag, start Chrome. Select
"Browse as guest" from the avatar menu. From the guest browser, select
"View all people" from the avatar menu. This shouldn't crash and should
show the User Manager.

Review URL: https://codereview.chromium.org/129103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330843

Review URL: https://codereview.chromium.org/128453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243709 0039d316-1c4b-4281-b951-d872f2087c98

Add the vulcanize node script to tools which will be used to combine
polymer elements during the chrome build process. Polymer is used (for
example) with the PDF extension.

R=cmp@chromium.org

Review URL: https://codereview.chromium.org/125733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243708 0039d316-1c4b-4281-b951-d872f2087c98

Previously Desktop Capture API allowed requests only from non-incognitor
tabs. The API might be useful in incognito tabs in some scenarios.

R=joi@chromium.org

Review URL: https://codereview.chromium.org/126433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243706 0039d316-1c4b-4281-b951-d872f2087c98

Streamlined Hosted App windows were having their location bar truncated
when maximized. This was due to using the popup-style location bar to
get the omnibox to be read-only.

This CL changes streamlined hosted apps to use the normal location bar
and sets the omnibox to be read only at a deeper level.

BUG=318607

Review URL: https://codereview.chromium.org/110413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243705 0039d316-1c4b-4281-b951-d872f2087c98

These methods should always return valid parameters, even if a device
doesn't exist.

Output code will automatically fall back to a fake path at a later time
if those parameters are used to open a stream.

Input code will fail because no input devices can be enumerated.

BUG=331675
TEST=no more crashes.

Review URL: https://codereview.chromium.org/127363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243704 0039d316-1c4b-4281-b951-d872f2087c98

This CL had the unintended side effect that Simulate Browser Restart no longer
works. Also, experimentation suggests that the original bug it was intended to
fix works without this change now.

> Make clicking the restart bubble for crashed apps work.
> 
> Previously AppLoadService listened for
> NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING before dispatching the
> onRestarted() event after a reload, but in the case of packaged apps, which use
> non-persistent background pages, that notification will never get fired. This
> is because reloading an app doesn't cause its background page to get loaded -
> only a relevant event causes the page to be woken up.
> 
> This patch fixes the issue by listening for NOTIFICATION_EXTENSION_LOADED
> instead, which is always fired after a reload. It also determines whether an
> extension is listening to an event by checking which events it has registered
> for, not which ones it currently has a listener for,
> NOTIFICATION_EXTENSION_LOADED is the notification that listeners get created
> on, and so to avoid raciness we check registered events (ie: the persisted
> list of events that an extension is interested in).
> 
> BUG=327964
> 
> Review URL: https://codereview.chromium.org/93593003

TBR=koz@chromium.org

Review URL: https://codereview.chromium.org/127843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243703 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332297

Review URL: https://codereview.chromium.org/127743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243702 0039d316-1c4b-4281-b951-d872f2087c98

WebMediaPlayerImpl needs to access the Decryptor object when a MediaKeys object is associated with a MediaElement (HTMLMediaElement.setMediaKeys()). These are the changes required on the Chromium side to WebMediaPlayerImpl to get a pointer to the Decryptor. Use of the Decryptor will come later.

BUG=329582
TEST=new layout test in the Blink side CL

Review URL: https://codereview.chromium.org/105143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243701 0039d316-1c4b-4281-b951-d872f2087c98

This adds a version of GrabWindowSnapshotAsync that behaves identically
to GrabWindowSnapshot except with a callback.  The snapshot aura unit
tests are updated to use this new async function instead of the sync
one.

In order to make the snapshot tests work properly, they also now have to
use a real gl context so that real drawing and readback can occur
through the compositor.

BUG=331410, 332167

Review URL: https://codereview.chromium.org/119753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297856

Review URL: https://codereview.chromium.org/24460002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243699 0039d316-1c4b-4281-b951-d872f2087c98

We already disable the artificial delaying of resources when connected
to a SPDY-capable host, this extends that to also include pages that are
served through a SPDY proxy.

As-implemented, as soon as any request for a given client completes and
was served using SPDY over a proxy connection, that client will be
treated as a SPDY-capable client.  Some resources will still be delayed
until the base page (or another request) completes but it is much better
than it was before.

BUG=324789

Review URL: https://codereview.chromium.org/99533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/129533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243696 0039d316-1c4b-4281-b951-d872f2087c98

- Change to use mojo::utility::RunLoop
- Move timer from gles2_client_impl to gles2_impl with added api.

BUG=None
TEST=None
R=darin

Review URL: https://codereview.chromium.org/128813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243695 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, layout tests that don't damage the entire view access
uninitialized memory.

BUG=332271
R=reed@google.com,thestig@chromium.org

Review URL: https://codereview.chromium.org/128443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243694 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332169
R=zea@chromium.org

Review URL: https://codereview.chromium.org/128193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243693 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/99113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243692 0039d316-1c4b-4281-b951-d872f2087c98

We access oobe here as it is going away: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py&q=oobe&l=343

BUG=chromium:332545
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/129343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243690 0039d316-1c4b-4281-b951-d872f2087c98

Change to use RunExtensionTest which is far less flaky than using RunExtensionSubtest

BUG=177163
TEST=these are tests

Review URL: https://codereview.chromium.org/129113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243689 0039d316-1c4b-4281-b951-d872f2087c98

Ozone is actually creating the VSyncProvider. The caller will also take
ownership of the VSyncProvider. Updating the method definition to better reflect
the intent.

BUG=

Review URL: https://codereview.chromium.org/102563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243688 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: ChromeOS bot failures, example http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19049

Failing lines:
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry                                   [  FAILED  ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry                                     FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry         [  FAILED  ]
/tmp/cbuildbotBRIADJ/test_harness/all/SimpleTestVerify/1_autotest_tests/results-16-login_CryptohomeTelemetry/login_CryptohomeTelemetry           FAIL: TabCrashException('Received a socket error in the browser connection and the tab no longer exists, assuming it crashed. Error=timed out',)


TBR=joi@chromium.org,rogerta@chromium.org,tfarina@chromium.org,thakis@chromium.org,blundell@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332107

Review URL: https://codereview.chromium.org/129253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243687 0039d316-1c4b-4281-b951-d872f2087c98

Seems the DTMF test didn't work well after all, when running with Opus.

The AEC tests were broken because they didn't force iSAC.

BUG=181069,332016

Review URL: https://codereview.chromium.org/128353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168996
TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane.

Review URL: https://codereview.chromium.org/128343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/126033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297480
R=aa@chromium.org,bauerb@chromium.org

Review URL: https://codereview.chromium.org/116163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243682 0039d316-1c4b-4281-b951-d872f2087c98

Adds arm version and some android configuration build flags.

This adds most of the logic from common.gypi to the Android GN build.

This is currently missing the crtbegin/end stuff and won't actually make real Android builds. The logic in this patch is just the initial conversion that will require testing and several more passes of fixes.

R=torne@chromium.org, torne

Review URL: https://codereview.chromium.org/121173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243681 0039d316-1c4b-4281-b951-d872f2087c98