GitLab

Currently does font size and line height.

Color is next. And there is still plumbing required to ensure more
controls/dialogs have access to views::style (and stop using
SetFontList). This CL establishes a core requirement to let us iterate
on layout for specific dialogs.

Example screenshots at https://crbug.com/691891#c10

BUG=691891

Review-Url: https://codereview.chromium.org/2765883004
Cr-Commit-Position: refs/heads/master@{#462676}

This is so all users must confirm sign in via "OK, GOT IT"
instead of clicking "Settings" link (which closes the dialog
without either of the "UNDO" or "OK, GOT IT" buttons being
clicked).

R=rogerta@chromium.org
BUG=709113
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2800683008
Cr-Commit-Position: refs/heads/master@{#462675}

BUG=703975
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801453002
Cr-Commit-Position: refs/heads/master@{#462674}

BUG=669108

Review-Url: https://codereview.chromium.org/2802113002
Cr-Commit-Position: refs/heads/master@{#462673}

When the available screen height is small the BottomSheet skips the half
state, so using #onTransitionPeekToHalf() is an unreliable way to make
the bottom nav visible. Use @onSheetOFfsetChanged() instead

BUG=

Review-Url: https://codereview.chromium.org/2800973003
Cr-Commit-Position: refs/heads/master@{#462672}

return a boolean so that synchronous error can be detected.

chromium: Remove QuicChromiumClientSession::ResumeCryptoConnect as well,
which is no longer used.

Merge internal change: 152398936

BUG=704949

Review-Url: https://codereview.chromium.org/2806553004
Cr-Commit-Position: refs/heads/master@{#462671}

https://pdfium.googlesource.com/pdfium.git/+log/deff61fe7368..c758d9dd3f94

$ git log deff61fe7..c758d9dd3 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 dalecurtis Remove stale gn arg to avoid undeclared argument warning.
2017-04-06 npm Cleanup CFX_BitmapComposer
2017-04-06 dsinclair Cleanup nits from previous XML Cl

Created with:
  roll-dep src/third_party/pdfium
BUG=645890

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2798063005
Cr-Commit-Position: refs/heads/master@{#462670}

Adds a new dialog class based on our current UX mocks. The intention
is to iterate with the UX team to come up with a UI for the Chrome
Cleanup tool.

Some functionality is currently missing and will be added in
subsequent CLs:
- Checkbox to ask for logs upload permissions
- Animation when the details section is expanded/folded

BUG=690020

Review-Url: https://codereview.chromium.org/2795133002
Cr-Commit-Position: refs/heads/master@{#462669}

BleConnectionManager: Check when receiving BLE advertisements if a SecureChannel already exists. Not doing so results in a crash.

BUG=706640

Review-Url: https://codereview.chromium.org/2804123002
Cr-Commit-Position: refs/heads/master@{#462668}

Otherwise it's possible the video could be loaded before this code runs,
in which case the canplaythrough event won't happen and the test will hang.

TBR=kbr@chromium.org
BUG=704389

Review-Url: https://codereview.chromium.org/2803823005
Cr-Commit-Position: refs/heads/master@{#462667}

It does the same thing (and has unit tests), so we can just use it
instead of rolling our own function.

BUG=None
TEST=content_unittests

Change-Id: I475a47ed460b808ecdb8c0218794b441d1e85e95
Reviewed-on: https://chromium-review.googlesource.com/465666Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462666}

This is a speculative fix for a crash bug on Android where the delegate
somehow ends up null. This CL adds a null check that skips interacting
with the delegate in this situation (if it is null, native must have
been freed).

BUG=708562

Review-Url: https://codereview.chromium.org/2805543004
Cr-Commit-Position: refs/heads/master@{#462665}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3680efbfbcc7..ea02aa5af9f1

$ git log 3680efbfb..ea02aa5af --date=short --no-merges --format='%ad %ae %s'
2017-04-06 maxlg [Tracing] Simplify breakdown generation API with Range; change breakdown tests

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2799253003
Cr-Commit-Position: refs/heads/master@{#462664}

This is in order to conform more closely to the ARIA standard and in order to fix a bug that prevented Jaws from reading the contents of ARIA grid cells in Forms Mode.
BUG=707810
R=dmazzoni@chromium.org, aboxhall@chromium.org, aleventhal@chromium.org
TESTED=manually with Jaws using snippet in the bug, browser tests

Review-Url: https://codereview.chromium.org/2797463002
Cr-Commit-Position: refs/heads/master@{#462663}

We use GetTempFileName Windows API to generate an unique temp file name
in some scenarios like downloading files.

It is mentioned on MSDN for this API that "Due to the algorithm used to
generate file names, GetTempFileName Windows API can perform poorly when
creating a large number of files with the same prefix. In such cases, it
is recommended that you construct unique file names based on GUIDs." The
reasons why it's doing poorly include it takes a long time to find an
unique name when a lot of names are already in use. This has been proved
by the fact we found this API call takes minutes for some users who have
lots of temp files in their default download directory. Note that the
temp files in the default download directory can be generated by any
software other than Chrome.

This CL retires GetTempFileName and uses GUID to generate unique temp
file names. With GUID, it is almost guaranteed that an unique temp file
name can be generated with a single attempt.

BUG=103737

Review-Url: https://codereview.chromium.org/2788483005
Cr-Commit-Position: refs/heads/master@{#462662}

This fix issue when running app for such apps does not have Chrome
badging. This CL does not apply AppWindow icon to shelf item if window
does not override its default icon. AppWindow might have its own icon
(sine M54), however if it is not set then app icon is used. From other
side shelf launcher controller has extra logic by applying additional
badging over the icon.

TEST=Manually
BUG=708830
BUG=b/35258599

Review-Url: https://codereview.chromium.org/2804623004
Cr-Commit-Position: refs/heads/master@{#462661}

This reverts commit f7080b8d.

On channel builds of Chrome, the PackageManager was failing to find
@mipmap/ic_launcher, but it has no trouble finding @drawable/ic_launcher.
A new values/ic_launcher_alias.xml create an alias from
@drawable/ic_launcher to the old @mipmap/app_icon.
drawable-v26/ic_launcher.xml provides an @drawable/ic_launcher version
for adaptive icons.

BUG=707449

Review-Url: https://codereview.chromium.org/2805083002
Cr-Commit-Position: refs/heads/master@{#462660}

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109

Review-Url: https://codereview.chromium.org/2804723003
Cr-Commit-Position: refs/heads/master@{#462659}

Currently we clone all the layers to do animation during screen
rotation, which is slow on some of the devices. The solution is using
compositor copy request to flatten the layer hierarchy and make
animations more efficient.

BUG=678763
R=oshima@chromium.org, bruthig@chromium.org
TEST=Unittest with ScreenRotationAnimatorTest and Manual

Review-Url: https://codereview.chromium.org/2780823002
Cr-Commit-Position: refs/heads/master@{#462658}

The original metrics used units instead of enum.

BUG=699226

Review-Url: https://codereview.chromium.org/2802923003
Cr-Commit-Position: refs/heads/master@{#462657}

BUG=

Review-Url: https://codereview.chromium.org/2800683004
Cr-Commit-Position: refs/heads/master@{#462656}

Lots of interfaces, so can take a while to run. Use the 'long' timeout
option.

BUG=709030

Review-Url: https://codereview.chromium.org/2806513002
Cr-Commit-Position: refs/heads/master@{#462655}

This CL changes how new custom spelling words are added in the settings.
Rather than adding to the bottom of the list and trying to scroll to the
new word, the new word is added to the top of the list. This also keeps
the input field visible on long lists of words (it's frustrating to need
to repeatedly scroll to the top to add the next word).

BUG=708425
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2797133007
Cr-Commit-Position: refs/heads/master@{#462654}

This creates a D-Bus service that extracts a "Kiosk app" related method
from LibCrosService. Clients have to be migrated to this before the
corresponding method may be removed from LibCrosService.

BUG=703229
TEST=deploy_chrome, manually sent a message to new method, got response.

Review-Url: https://codereview.chromium.org/2798703002
Cr-Commit-Position: refs/heads/master@{#462653}

v8_enable_inspector was removed recently. Clean up remnants.

Also fixes a dependent gn check issue which blocked submission,
http://crrev.com/462467 did not update GN deps for new header.

BUG=645890,708965
TEST=none

Review-Url: https://codereview.chromium.org/2801123002
Cr-Commit-Position: refs/heads/master@{#462652}

All answer text (other than the suggestion text and positive/negative
text) is now dimmed.

BUG=709101

Review-Url: https://codereview.chromium.org/2798223004
Cr-Commit-Position: refs/heads/master@{#462651}

This patch adds a debugging function which can be used to retrieve
the current state of tile manager. Specifically, it logs some general
information like tree priority and memory use/limits. As well, it logs
the current raster queue and required for activation queue to see if
there is a mismatch between what is being rasterized vs what is being
considered for activation.

R=sunnyps@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2797883002
Cr-Commit-Position: refs/heads/master@{#462650}

Also, a little bit of cleaning mojo interface registration in
gpu_process_host.

BUG=698284

Review-Url: https://codereview.chromium.org/2803743002
Cr-Commit-Position: refs/heads/master@{#462649}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Checkpoint| type
alias and a |checkpoint| accessor method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |Checkpoint| being the name of both the type and the
accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=japhet@chromium.org

Review-Url: https://codereview.chromium.org/2800963003
Cr-Commit-Position: refs/heads/master@{#462648}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e0c8d2c..126ec661

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2801993005
Cr-Commit-Position: refs/heads/master@{#462647}

Revert of cc: Always log shader compiler errors (patchset #2 id:20001 of https://codereview.chromium.org/2712033004/ )

Reason for revert:
Causes performance regression
BUG=699743

Original issue's description:
> cc: Always log shader compiler errors
>
> This is a catastrophic error, and should spam the console.
>
> BUG=695431
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2712033004
> Cr-Commit-Position: refs/heads/master@{#453019}
> Committed: https://chromium.googlesource.com/chromium/src/+/7d39070d75082cd35a08775dd792d67cd2beeb40

TBR=enne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695431

Review-Url: https://codereview.chromium.org/2799743005
Cr-Commit-Position: refs/heads/master@{#462646}

This patch starts removing script UISourceCodes when the parent
execution context gets destroyed.

Note: this patch removes only script-related UISourceCodes in
NetworkProject. The "debugger://" UISourceCodes, created by
DefaultScriptMapping, are kept intact. They come handy to reveal
location in old stacktrace/messages.

With this patch, all UISourceCodes created by networkProject have
a lifetime, defined by their parent model:
- DebuggerModel defines life-time for Script-related UISourceCodes
- CSSModel defines life time for CSS-related UISourceCodes
- SASSSourceMapping/CompilerScriptMapping define life-time of SourceMap
  Sources
- ResourceModel defines life-time for document/font/images
  UISourceCodes

For this reason, the NavigatorView no longer needs to listen to
FrameDetached/FrameNavigated events.

Drive-By: move DebuggerModel.scripts to the native Map.

R=dgozman
BUG=670180

Review-Url: https://codereview.chromium.org/2795193003
Cr-Commit-Position: refs/heads/master@{#462645}

1) Moved ComputeMarginsForChild to NGLayoutAlgorithm
2) Changed InlineLayoutAlgorithmTest to call ComputeMarginsForChild
   and pass them to NGFloatingObject

BUG=635619
TEST=NGInlineLayoutAlgorithmTest::PositionFloatsWithMargins

Review-Url: https://codereview.chromium.org/2798203002
Cr-Commit-Position: refs/heads/master@{#462644}

This was previously broken. Other input modalities were ignored during
multi-finger touch, and we incorrectly handled some of the multi-finger
cases as well, since we didn't update whether we were in a multi-finger
touch until the event ack.

BUG=None
TEST=RenderWidgetHostLatencyTrackerTest.WheelDuringMultiFingerTouch, MultiFingerTouchIgnored

Review-Url: https://codereview.chromium.org/2801043002
Cr-Commit-Position: refs/heads/master@{#462643}

virtual/gpu-rasterization/images/webp-color-profile-lossy.html
is passing, it seems, and needs new baselines.

virtual/gpu-rasterization/images/color-profile-filter.html
seems to be passing everywhere already.

virtual/gpu-rasterization/images/color-profile-background-clip-text.html
is no longer crashing and produces consistent result, but those results
are wrong due to crbug.com/670292. So rebaseline until we fix the bug.

TBR=noel@chromium.org
BUG=624709,587737,624233

Review-Url: https://codereview.chromium.org/2794403002
Cr-Commit-Position: refs/heads/master@{#462642}

For now we need to use the fake IME for both --mus and --mash.

There's still another startup crash, but that will take a little more
work to fix.

BUG=709097
TEST=manual
TBR=zork@chromium.org

Review-Url: https://codereview.chromium.org/2801923003
Cr-Commit-Position: refs/heads/master@{#462641}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style:
- attrNodeList
- constructionStack
- counterMaps
- harfBuzzFontCache
- infoMap
- intervalArena
- originAccessMap
- presentationAttributeCache
- selectionVisualRectMap
- styleSharingList
- weakHeapObjectSet
- worldMap
- wrapperTypeInfo

BUG=582312

Review-Url: https://codereview.chromium.org/2799803003
Cr-Commit-Position: refs/heads/master@{#462640}

This CL reverts two landed CLs, namely:

https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59
https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

(reviewed in https://crrev.com/2771703002 and
https://crrev.com/2765723002, resp.), because they
seemed to have introduced a flake in the associated
LayoutTests.

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org

BUG=665488, 707689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799153005
Cr-Commit-Position: refs/heads/master@{#462639}

This is in keeping with other chromium code, and will let me take
advantage of other code that expects these types.

BUG=None

Review-Url: https://codereview.chromium.org/2801073002
Cr-Commit-Position: refs/heads/master@{#462638}

BUG=672263

Review-Url: https://codereview.chromium.org/2799683004
Cr-Commit-Position: refs/heads/master@{#462637}