- 26 May, 2020 40 commits
-
-
Daniel Hosseinian authored
This reverts commit 146b9f1b. Reason for revert: These tests were actually failing because death tests weren't working on win-asan. That problem has been fixed as of r771124. Also win-asan is not accurately named as it does not define ADDRESS_SANITIZER. Original change's description: > [Sheriff] Disable SQLDatabaseTest on Windows ASAN because they are flaky > > Bug: 1027481 > Change-Id: I7fc1806eada39c58f3f6035736bf9d5c595fbb0b > TBR: pwnall@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946331 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720463} TBR=guidou@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027481 Change-Id: I91ab2178d555e7ee852d7a8bf6bb5b0ca90f806d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216358 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771889}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: Id2c599da0d3699312d667833238a86d7ef259ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212392Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771888}
-
Miyoung Shin authored
This reverts commit cb7f6c5d. Reason for revert: Enable whole Flash suite since the crash issue was fixed at https://crrev.com/c/2210488. Bug: 1081782 Change-Id: I655f846cd78f79b6c7451a87f6bad66d060e4742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214592 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#771887}
-
sauski authored
CL extends the representation of managed states for the newly introduced CookiePrimarySetting generated pref to cover all supported states. Bug: 1063265 Change-Id: Ib19b5bd82bf5c7b1acddd70e07e5e145ee16d144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209071 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#771886}
-
Finnur Thorarinsson authored
The video player has two large play buttons, one in the player itself and one in the zoomed in view on the tiles screen. They should be the same size. Bug: 895776, 656015 Change-Id: I193234b2619f27c5546df11a64e04eb9c8d6726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215815 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771885}
-
David Bertoni authored
The ExtensionSettingsApiTest.OnChangedNotificationsFromSyncCheck was disabled for flakiness and became stale. This CL fixes the test and cleans up the JavaScript code. The test passed 3000 iterations on the bots. Bug: 101110 Change-Id: Ia969ba620900382395d09ec28e8d8ea379c79d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211079 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Archana Simha <archanasimha@chromium.org> Cr-Commit-Position: refs/heads/master@{#771884}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 24 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-22. TBR=chromium-metrics-reviews@google.com Change-Id: I50a46e6f34284184a0956e528b9b3dc8de022831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212323Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#771883}
-
Toni Barzic authored
The test was timing out waiting for the auto-hidden shelf to get shown while hovering the mouse pointer over it. This changes the test to use swipe up gesture to show the shelf (which is used in other tests). BUG=1000463 Change-Id: I4270215be79239eb2861bb08bfae0fd3fc386f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214610Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#771882}
-
Olga Gerchikov authored
- Enabled pause(), reverse() and updatePlaybackRate() APIs for scroll animations. - Provided temporary fix for play animation procedure to accommodate reverse() and replaying finished animation cases. The fix reflects pending https://github.com/w3c/csswg-drafts/pull/5059. - Ported wpt/web-animations/timing-model/animations tests that exercise the APIs. - Implemented scroll animation specific tests. Bug: 916117 Change-Id: I689e7a6d1f220ee12e7f7a6f90e54340eaa33aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194586Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771881}
-
Mikel Astiz authored
The metric has served its purpose to monitor potential regressions during the rollout of the new implementation of bookmark sync (USS-based), and is no longer necessary. Change-Id: Iadd561e48d97d496e86df67cee5f25047e288894 Bug: 1070237,1017731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213565Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#771880}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b5a24e66f12..fac9f9e293cd 2020-05-26 ilkos@google.com Merge "Add unique_session_name to the metadata" 2020-05-26 primiano@google.com Merge "infra: Add redirect for {www,docs}.perfetto.dev -> perfetto.dev" 2020-05-26 ilkos@google.com Merge "Downgrade ringbuffer overruns to info" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I604d9d293736cb56acb7e730f5b0fc6912137c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771879}
-
Kevin Babbitt authored
Introduce unit tests validating the offsets generated by CSSParserImpl for dev tools These tests will ensure that upcoming refactoring to make further use of stream-based parsing does not change these offsets. Bug: 661854 Change-Id: I1461bdff5782d23921041a80d6ade6018e6f0983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209960Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771878}
-
Roger Tawa authored
Bug: 1069037 Change-Id: Id0144b4719af238dfee3070b55b93b612693afe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216272Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#771877}
-
Jongmok Kim authored
Change-Id: If8d7d91b9c5684d41bfaf2366a040f029bc191d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214865Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#771876}
-
Xing Liu authored
This CL does a minor clean up for TileManagerTest. Bug: 1078163 Change-Id: I453c8aab836ad09a5cb97f360cee16d379f695cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212514Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771875}
-
Tao Bai authored
Also included a refactorying to grouped all autofill features together. Bug: 949555 Change-Id: I9b72005db703677d71d03ff01f0e4c3322a4b603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212758Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#771874}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c33eeab2ca42..fe6a353ce47a 2020-05-26 philipp.hancke@googlemail.com fuzzers: fix isax typo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd962d156b5113fe0d5b9ba4884a1394102c42ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216355Reviewed-by:
-
Alexander Yashkin authored
Looking at suggest fuzzer code coverage I encounered that a lot of code is not covered at all. This is due to suggest answer being JSON with hardcoded expected structure. I have added several types of suggest server answers to seed corpus and locally it greatly enhanced coverage. I made sure that no personal info is contained in this data. Suggest parser coverage is here https://chromium-coverage.appspot.com/ reports/763373_fuzzers_only/linux/chromium/src/components/omnibox/ browser/search_suggestion_parser.cc.html Change-Id: Id025c80102747bdd4fb9a417fa42ed4db9811dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212170Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#771872}
-
Mike Klein authored
This guards https://skia-review.googlesource.com/c/skia/+/291876 for Blink rebaselines. Bug: skia:10000 Change-Id: I42b2318dff80c38de51ab0c87ed91266401171d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216350 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#771871}
-
Navid Zolghadr authored
This patch cleans up the early long press activation that so far can only be caused by a stylus button on CrOS with clear conditions. It adds the according checks to the logic to only run it for stylus pointers. So it should have no functional change. This helps to add a similar mechanism for touch pointers on Android in the later patches. Bug: 1086263 Change-Id: I0a4c5a802505ac22b6186b88d343143472850d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216310Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771870}
-
danakj authored
Pointer locking is a property of the widget, not a specific frame, nor the process. So we move it to the EventSender which is the per-widget web test javascript interface. This removes the last usage of TestRunnerForSpecificView, and we remove the class and all pointers to it. The pointer lock implementation is made a bit more clear and robust, tracking the state of pending locks/unlocks, as well as the final locked state. We use the default task runner, as these actions are tied to the widget and IPC, rather than to the requesting frame. R=avi@chromium.org TBR=dcheng Bug: 866140, 1069111 Change-Id: I90e6bfd336b4647fdead185012bf9b84b6617af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212928 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771869}
-
haozhe authored
By adding a type check for the sample interpolation, we handle the InvalidtableInterpolation type. Bug: 1084688, 1086167 Change-Id: Ifd2d04bdd298d239813c9f87772efdfcba9b227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210678Reviewed-by:
-
James Cook authored
SplitSettingsSync sometimes makes an untitled Play Store icon appear in the shelf due to app pin syncing code. This doesn't happen in production, but causes test failures in: ArcUserSessionServiceTest.FiresIntentOnSessionActiveTest AutotestPrivateApiTest.AutotestPrivate Pinned app sync isn't relevant to these tests, so skip it. Do this with a global because ChromeLauncherController initialization happens before the test runs SetUpOnMainThread(). Bug: 1085597 Change-Id: Iebd4e299872f1e79bdd388253256f1d7cec0dd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212931 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#771867}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 1 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-22. TBR=chromium-metrics-reviews@google.com Change-Id: I919739afc43d4a2f4cbae9b28cc308a35bb5d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212393Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590494094-4933e9898781e7babab5bec8654610960e408cf7.profdata to chrome-win32-master-1590508570-0988b56e609cb55046e696ff8ca55766d5b1565c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8a6462ffac6a46ea5602c57bc4d924e1bae0c865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216450Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590465515-28d774c5c7210687b1a5c5f3f06bd85a638d1e44.profdata to chrome-win64-master-1590508570-56b410f167fcfdeb6392e467837742983549ce30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I268bcd3ab819f31efa46328e041d88318c61fe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216451Reviewed-by:
-
Christian Biesinger authored
With a fixed-height single-line flex container, a stretched item should be considered to have a definite height and thus should have its aspect-ratio calculated from that: https://drafts.csswg.org/css-flexbox/#definite-sizes item 1 This patch limits this behavior to the CSS aspect-ratio property for now (as opposed to supporting it for everything with an aspect ratio, like images), to limit the behavior differences from pre-FlexNG Blink. Bug: 1083020 Change-Id: I2abe33d49a8727857a28e47ba6344ad3da860cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212984 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771863}
-
Nate Chapin authored
In cases where the LocalDOMWindow* is what we want, or where we just need to null-check the frame, use dom_window_ instead of frame_. All others now call GetFrame(). Bug: 1080735 Change-Id: Ib6b37e16f05d675e19212c38e474d5ad56e4c182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#771862}
-
Sophie Chang authored
Change-Id: I4e8a1ecf01a65a146ce4c35a16d277696cd1fb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216038 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771861}
-
Jeff Yoon authored
MB configs for the beta/stable trybots for PGO. Missed tryserver definition. Bug: 1081356,1085606 Change-Id: Ib17b5cab291ac9cbf8769c3622cb2793a60e584e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214002 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771860}
-
Scott Violet authored
As the renderer normally drives the offsets, once the renderer is hung that won't happen. BUG=1083513 TEST=still working out Change-Id: I866f6cedc28c5b617b74f070382a571c4b6897a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211066Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771859}
-
Philip Rogers authored
This patch adds a feature flag for respecting the MacOS subpixel anti-aliasing setting (called "LCD text" in chromium). MacOS 10.14 (Mojave) disabled LCD text by default and, by respecting this setting, scrolling performance can be improved. This is because composited scrolling no longer needs to be avoided for the purposes of maintaining LCD text, which is lost in the common case where the scrolling contents layer is not fully opaque (see [1] for details of this). The MacOS setting for LCD text can be controlled with: defaults write -g CGFontRenderingFontSmoothingDisabled -bool true ("true" is default, "false" overrides this). This patch uses a private API, CGFontRenderingGetFontSmoothingDisabled, which is used by Safari (see: https://trac.webkit.org/changeset/239306/webkit). Enabling this feature will expose the differences of composited scrolling which include minor pixel differences, less-minor stacking differences (the fundamental compositing bug: crbug.com/370604), as well as a few bugs. These differences are already present on all devices with device pixel ratios >= 1.5 (50% of MacOS), as well as Android and ChromeOS platforms which force-enable prefer-compositing-to-lcd-text. The web_test changes can be seen in the Mac10.14 trybot results at https://crrev.com/c/2207413/1. These have been triaged and non-rebaseline differences have been broken out as bugs blocking crbug.com/1079418. This patch does not enable the feature by default but a followup will, which will include these baseline updates. We have UMA data from the PreferCompositingToLCDText experiment that should match the effect of this feature for users that have not enabled LCD text via the command line: Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin4 95th: -5%, 99th: -12% EventLatency.GestureScrollUpdate.Wheel.TotalLatency 95th: -6%, 99th: -14% https://uma.googleplex.com/p/chrome/variations/?sid=a8cb2e0aa29593ad35baa33a2bee3f97 [1] Excellent explanation of why compositing forces greyscale AA: https://gankra.github.io/blah/text-hates-you/#subpixel-aa-isnt-composable Bug: 1079418 Change-Id: Ieca837912ec19f7a7b4378b989d86a4242108668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207413Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Lechner authored
The "type" option of the GATT Characteristic.WriteValue method was actually introduced in BlueZ v5.51 (as can be seen in the link below). https://github.com/bluez/bluez/commit/aa9f9b193c51d371b5d2a863f35a034ee0377b22 Change-Id: I0f7513582d91c98446d06148d1edbe9e2502ee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214411Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#771857}
-
Adam Langley authored
These strings appear in log messages, so nicer to avoid raw binary. Change-Id: Ide8b6bcbd57b8cec5d123a974243e74b2b40e511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214461 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#771856}
-
Michael Thiessen authored
Changes the test runner to add a status report to each test, reporting the duration in ms of the test. I've chosen to account for the overhead of starting instrumentation, etc. by adding the overhead duration to the runtime of the first test in the batch. This means that one unlucky test in the batch will seem really slow from looking at reported durations, but means the overall duration for the batch will be correct. See bot results for android-marshmallow-arm64-rel, chrome_public_test_apk, org.chromium.components.external_intents.ExternalNavigationHandlerTest to see what this looks like in practice. Bug: 989569 Change-Id: I93aae5e52ea51bb635bb13ce6b6db6e4e8bb55ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212491 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#771855}
-
Leonard Grey authored
On 10.12, the window server is fine initiating a drag without this, so we end up with two drags starting. This actually doesn't fix the teleporting windows bug, but it can't help! Bug: 897274 Change-Id: I2e181659c504c90db0a0928747f5485419728fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207980Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590494094-23904e540b881376a708d1584e8efd523290bbdf.profdata to chrome-mac-master-1590508570-a99506fab2213a01c13861c108d98c27cee7cc0b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae36f2b55da219314881fe9359e0c11b6c02522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216363Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0638b6b9527b..ba4e2b94289d 2020-05-26 msisov@igalia.com Type cast EGLNativeDisplayType to _XDisplay* in xcb and glx If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458 Tbr: ynovikov@google.com Change-Id: I7fe7d6417459eda95981c6818a318acd9f0bd359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216168Reviewed-by:
-
Peng Huang authored
Looks like the crash in https://crbug.com/1086428 is because GrContext is not initialized successfully, and then we are accessing the nullptr GrContext, and then segment fault happens. Fix the problem by making GetSharedContextState() return nullptr if GrContext cannot be initialized. Bug: 1086428 Change-Id: I288fc6832d6b0c838e16c119354e50db2ad2af80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214912 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771851}
-
jorgegil@google.com authored
Fixes issue where occlusion tracking could start sending updates before the surface state had been committed. In ARC, this meant that occlusion updates were sent before the surface bounds were first set, leading to incorrect "full occlusion (1.0f) updates". Bug: b:149229321 Test: exo_unittests Change-Id: Ia885a44cf38658cc82d87273f70395c8bc2fcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212921 Commit-Queue: Jorge Gil <jorgegil@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#771850}
-
