- 08 Aug, 2020 4 commits
-
-
Ken Rockot authored
Introduces a new PreemptiveMobileNetworkActivation feature. When this is enabled, the network stack will ask the OS to activate a connected mobile network whenever it suspects the current default (Wi-Fi) network has degraded connectivity. This also adds a new histogram when the feature is enabled, to capture how often this preemptive mobile network activation is imminently followed by a system-wide default network change to that same network or any other network. Bug: 1079396 Change-Id: Ib8b8294addb51c60b55cf512b293fa5418976452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339595Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#796179}
-
sczs authored
Bug: 1085419 Change-Id: Ic038ca854016a3d2ad460ab1133527bedbd0ff78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343636 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#796178}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2bab251279b1dee5de8492e4a6f1c621aa672e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343676Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796177}
-
Xiaohan Wang authored
These two functions are needed to notify the CDM about the last used key IDs during suspend and resume. Bug: 999747 Change-Id: I4f988784cc67d6e0699ec31ba2236de38c64615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331092 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796176}
-
- 07 Aug, 2020 36 commits
-
-
Justin Cohen authored
This reverts commit 2d01e3cc. Reason for revert: testInvocations isn't supported by test runner. Original change's description: > ios: Disable ARQuickLook tests on iOS12/Xcode12b4. > > XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4 > when running on the iOS 12 simulator. Disable until Xcode is fixed. > > Bug: 1114202 > Change-Id: Ib16458ee93e6821b5520cbd791e3ba8e6beccfe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341220 > Auto-Submit: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795982} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: Ic1ea153414e47bc0a3867dcf609a3313bd877623 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343551Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796175}
-
Nick Harper authored
Change-Id: I91fc22ca7f30912ed57e80837af7223a6263cd97 Bug: 815267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339452Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#796174}
-
Ilia Samsonov authored
This CL removes the blink Mac10.10 and Mac10.11 configurations. Requires https://chromium-review.googlesource.com/c/chromium/tools/build/+/2343182 Bug: 1107003 Change-Id: Ic4d82e7d0d76d7b60894d919e47c1e19122a0f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343310Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#796173}
-
Tommy Martino authored
This CL addresses a few comments that were received after landing https://chromium-review.googlesource.com/c/chromium/src/+/2337407 Bug: 1099268 Change-Id: Ieb8fa406f69fc28ab15ce89d79030d93b39cc8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341665 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#796172}
-
James Long authored
Convex hull buildtarget groupings in the class graph now contain a label above their highest node with the name of the target. Change-Id: I11509290940fc2540cbaf987d29b6cca7d58ecc0 Bug: 1109274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340067Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#796171}
-
Ethan Jimenez authored
1. Adding missing track sizing function flags in `GridTrackSize`; these new flags shouldn't regress legacy grid's functionality. 2. Implementing an iterator for every `NGGridSet` in a track collection. `TestNGGridLayoutAlgorithmTrackCollectionSetIterator` is updated to verify `NGGridLayoutAlgorithmTrackCollection::GetSetIterator`. 3. Introducing track size normalization in `NGGridSet`; this is done in order to guarantee consistency with the definitions from css-grid-1 in future steps of the track sizing algorithm. Also, adding a unit test that checks if the normalized track sizes match the https://drafts.csswg.org/css-grid-1/#algo-terms spec. 4. Setting up the track sizing algorithm in `NGGridLayoutAlgorithm`; this change comprises the "initialize track sizes" step of the algorithm (see https://drafts.csswg.org/css-grid-1/#algo-init). 5. Setting up column width and row height resolution steps for grid sizing (https://drafts.csswg.org/css-grid-1/#algo-overview). 6. Adding unit test for the straightforward case of resolving track sizes of a grid with tracks of fixed sizing functions. Since extra space distribution in `NGGridLayoutAlgorithm::ComputeUsedTrackSizes` is still missing, expectations for this test are temporary and are only meant to test initialization of base sizes and growth limits. Bug: 1045599 Change-Id: Ia3a4ee9ea0a7e3acdca3e3a7b9f80d5307584d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320128 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#796170}
-
Nasko Oskov authored
The NavigationThrottleRunner is tracing events related to the NavigationRequest, however using the delegate pointer does not work to associate the two logs together. This CL changes both NavigationRequest and NavigationThrottleRunner to use the navigation id as the common identifier to tie the tracing events together. Bug: 1043616 Change-Id: I84594851724f1026fa9c9a5409705a127347a251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343564 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796169}
-
Piotr Bialecki authored
The regression (crash) was introduced when fixing an issue with hit test source cancellation not getting propagated to the device. In addition, already-cancelled hit test sources should throw when they are cancelled yet again - this was also regressed. Changes: - fixes the crash when cancelling a hit test source on a session that has already ended - ensures that double-cancelling a hit test source throws InvalidStateError (as per spec) - add instrumentation test that would have caught the browser crash - add WPT that would have caught the double-cancel issue Bug: 1113461 Change-Id: I174c48d096faa902e2210e3660874dd48ca88545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341179Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#796168}
-
dpapad authored
This file is no longer shared between OS and Browser Settings, and can be fully migrated to JS modules. Also, did minor cleanups now that were possible as a result of dropping the Polymer2 codepath. Bug: 1069258 Change-Id: Ia0da4ac10f2858fa4fc5fe460de3b96c203bc733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343010 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796167}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55eebf450c36..06994a23acac 2020-08-07 changhaohan@chromium.org Clear Grid node map when document is updated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113878 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id5df70c7cb59f5c8333e108dcf1ce9cbf6c058db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343580Reviewed-by:
-
Brandon Wylie authored
The current behavior counts clients in the control group as ineligible which makes it difficult to compare control/experiment groups. Bug: 1106449 Change-Id: I3576319e98c9ef9bc7a624ed11b041e256a0742f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332982Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#796165}
-
Ahmed Fakhry authored
Forgot to hit save before I uploaded the previous CL at https://chromium-review.googlesource.com/c/chromium/src/+/2339902 This is the missing ASCII art as requested in the code review. TBR=jamescook@chromium.org BUG=1112919 Change-Id: Ia262cfeb319106308c3cf4b1762f5c232d615cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343768Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796164}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596475240-d93356acbdf692b1bcca469d15900f1aa84583f0.profdata to chrome-mac-master-1596834937-d362a0fc8a27d2c9c7a6f73e739d7f96eafd2751.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie19a98d7cceae032a3e483b09438d778d838e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343582Reviewed-by:
-
Matthias Körber authored
The types are not fillable because there are no heuristics and no server classifications for those types. Change-Id: I129aa69d1c18b190359c2519ada7d30a7bba3549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343329 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#796162}
-
Tim Song authored
BUG=1113296 Change-Id: Ied6cd6b2add72e261d7dd6c67954c753225933ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340849Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#796161}
-
Scott Violet authored
And simplifies the implementation a bit. BUG=none TEST=none Change-Id: I1464e636597952f94f5a960eccbefec810fb686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343786Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796160}
-
Toni Barzic authored
Active service pid should be unregistered from perfetto service when initial connection to traced process fails only if there are no existing connections to the process (in which case the disconnect will get handled by perfetto service). BUG=1113469 Change-Id: I4746bf1360f89881c6963c5f9e1eef0859107fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341144 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#796159}
-
Yu Han authored
Prior to this CL, the date, time and meter colors in dark mode don't match spec. Updated date, time and meter colors for dark mode. Bug: 1111922,1107290 Change-Id: I1b5aac854fd7fd99e9f2fbe236c4b7412debc249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340346Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796158}
-
Dana Fried authored
See go/newlabel for more information. This CL adds "this is a new feature" to the text read by the screen reader, after the hotkey but before the "item M of N" description. So for example, a tab context menu item might look like this: ... Add tab to Read Later [New] CTRL+SHIFT+Z Move tab to new group [New] ... As you scroll through, you will hear: "Add tab to read later, control plus shift plus Z, this is a new feature, item 4 of 7" "Move tab to new group, this is a new feature, item 5 of 7" Note: The screenshot in the associated png file is of the visual presentation of the badge, as the actual text read does not appear on-screen. Bug: 1114082 Change-Id: I758d0b6cb92856e62bde87f9cd55553feb281b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343008Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#796157}
-
Mark Pearson authored
Change-Id: I19c404a181555dcf8ca65b4efaedf2e74ac1533f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340269 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#796156}
-
Miguel Casas authored
VaapiVideoDecoder lives in a single SequencedTaskRunner, so this CL removes the comments' references to 'on [the] decoder thread'. Also s/decoder_sequence_checker_/sequence_checker_/ since there's only one TaskRunner. Finally, this CL also flips the DVLOG()s and the DCHECK_CALLED_ON_VALID_SEQUENCE() so that a potential CHECK happens after the printout, not before. No new code intended. Bug: b:162962069 Change-Id: I500acc380a0d3ac83fc5027217d6735198a2f1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340365 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24289f2e94f3..0fa91d0f3563 2020-08-07 saagarsanghavi@google.com ResultDB wrapping for CQ/CI builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I812c6d934f3de96d12acd1f6e416a7c21aac2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339944Reviewed-by:
-
yjliu authored
Removing the items from the container one by one is inefficient, and at shutting down, this can be done by emptying the container directly. Bug: 1112835 Change-Id: Ib7529963763b1e772b6ba330eda3a3a3e2f6d380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340319Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796153}
-
Xianzhu Wang authored
This makes them consistent to use the same skipping conditions as what we do during PrePaint, to avoid access of null or stale layer states. Bug: 1110232 Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796152}
-
Dan Harrington authored
- FEED_SCROLLED was mis-documented as being reported for every scroll, when it was actually being reported only once per chrome start. I changed this so that it's reported once per Feed 'visit', as the other engagement types are. This changes both the documentation and the reporting code in v1 and v2. Since this is a change in behavior, I'm using a new enumeration value, and no longer reporting the old one. - Use absolute value for scroll distance in feedv1, to match v2. Bug: 1044139 Change-Id: Iabea46a016f57ef6dec77932e0ff00f0cb5d0a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337235Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#796151}
-
Wan-Teh Chang authored
This bug was introduced in https://crrev.com/c/2321307. It was detected by the new Web platform test in my pending CL https://crrev.com/c/2304961. The following return statement in IsColorSpaceSupportedByPCVR() if (!image->alphaPlane) return true; actually elided a check that yuv_color_space was one of the four SkYUVColorSpace values supported by media::PaintCanvasVideoRenderer (PCVR). At that time (before https://skia-review.googlesource.com/c/skia/+/305596) SkYUVColorSpace had only those four values (except for kIdentity_SkYUVColorSpace) and our own GetSkYUVColorSpace() function returned only those four values on success, so it was fine to elide that check. After we switched from our own GetSkYUVColorSpace() function to gfx::ColorSpace::ToSkYUVColorSpace() in https://crrev.com/c/2321307, the newly added SkYUVColorSpace values may be returned, so it is no longer fine to elide the check. Also make two cleanup changes: 1. Replace the deprecated SkYUVColorSpace enumerators with the new more verbose ones. 2. Do not declare the yuv_color_space_ member as base::Optional. base::Optional made sense because our own GetSkYUVColorSpace() function returned base::Optional instead of using an output parameter. Since gfx::ColorSpace::ToSkYUVColorSpace() uses an output parameter, it is cumbersome to pass a base::Optional as an output parameter. Bug: 1108626 Change-Id: I96dba5c54dbe1b826be714141665adcaee47bccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343535Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#796150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63a1a8309814..e0dd3df0934a 2020-08-07 herb@google.com remove unused Arena reset() 2020-08-07 brianosman@google.com Revert "Untangle dependency cycle in sksl dehydration" 2020-08-07 bungeman@google.com Allow CoreText axis hidden value to be CFNumber. 2020-08-07 reed@google.com SkPathView for ownerless (can live on stack) SkPaths 2020-08-07 johnstiles@google.com Fix GrImprovedPerlinNoiseEffect::onIsEqual to compare properly. 2020-08-07 brianosman@google.com Untangle dependency cycle in sksl dehydration 2020-08-07 robertphillips@google.com Update how the GrSmallPathRenderer's cache entries are created and destroyed 2020-08-07 mtklein@google.com split getPaint() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1113444 Tbr: herb@google.com Change-Id: I4a68f9b5dcf29e497332574d90e33c8e3ab91516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343579Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I9e4b7c59e9edb04e7667b5c51b45b226991157ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343669 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Keren Zhu authored
Also remove static Create() in favor of a public constructor. Historically, MdTextButton had three factory methods and prohibited the direct use of the constructor. A recent cleanup unified three factories into one, and this one does no more than a constructor. This CL is part of the effort to make Views default constructible, allowing UI to be built in a declarative fashion. Bug: 1108460 Change-Id: Id1901dd2a96378927c94fc2663a53f14ea1b708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340880Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This prevents the developer from accidentally enabling use_gtk=true on the lacros/chrome build, and diverge from the ChromeOS environment. BUG=None R=jamescook@chromium.org Change-Id: Idc204d85b970d47fe96dc21dec55c1ac091b8484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343488 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Gang Wu authored
This CL add "Managed by your organization" menu item in the overflow menu if the users is an enterprise user and the profile is managed by the policies. Bug: 997053 Change-Id: I7fc9d7ea091a9ebfc5c9b3a25be848888c29d58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339280 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#796145}
-
rbpotter authored
The download button should be highlighted when the action menu is open, similar to the highlight on the bookmarks icon when the bookmarks menu is open. Also changing the menu to be light when the PDFViewerUpdate feature flag is not enabled, for the same reason (matching the bookmarks menu). Bug: 1113519 Change-Id: I86dc1b7a569688532a2bbce1b8b639e79932d325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340447 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#796144}
-
Brian Sheedy authored
Skips the expected crash check in Pixel_Video_Context_Loss_VP9 on Windows machines so that we can determine if the test is only failing because of the check. TBR=kbr@chromium.org Bug: 1061298 Change-Id: I06fc190f49cc106daca0fd794a1bbecc3cca6403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343628Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796143}
-
Matthias Körber authored
Change-Id: I5c7d6f2d2d33127b2e2b13b1b48c9213469a53c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339633Reviewed-by:
-
Numfor Mbiziwo-Tiapo authored
This is a reland of 051f1395 The perf test idb-put-all.html was failing because idb_request HandleResponse was checking to never receive empty blob handles. Fixing by clearing the blob handles instead of using a DCHECK. Original change's description: > Updating the putAll implementation to return one request. > > This change updates the existing putAll implementation to match > the explainer more. It does not yet support the put-all-or-none > behavior, but it does only return one request now. > > Design Doc: > https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit# > > Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 > > Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110 > Commit-Queue: Numfor Mbiziwo-tiapo <nums@google.com> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Olivier Yiptong <oyiptong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793656} Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 Change-Id: I26e977d2b307dde33a78fdb4869116a25c56dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335633 Auto-Submit: Numfor Mbiziwo-tiapo <nums@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796141}
-
ssid authored
BUG=1109349 Change-Id: I36b995847a37f20d32ab5892c580797f1436e0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328804 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796140}
-
