- 14 Jun, 2018 40 commits
-
-
François Beaufort authored
This makes sure Picture-in-Picture is disabled on Android Webview as there is no UI implemented. Bug: 852449 Change-Id: I526e02b0c2210fb5d71883f9db4ab05d76c56d2c Reviewed-on: https://chromium-review.googlesource.com/1100464Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#567341}
-
codeimpl authored
The values of the enum was updated in the spec[1]. [1] https://github.com/immersive-web/webxr/pull/370 Bug: 852520 Change-Id: I916943bee355936e7430aa4e36d0eeb6b76607d5 Reviewed-on: https://chromium-review.googlesource.com/1101118Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#567340}
-
Scott Violet authored
Currently ash and ui are bundled together by way of process groups. Process groups make it hard to have an explicit construction ordering. For OopAsh we need Ash to control creation of the UI Service. This patch removes progress-groups and instead uses ServiceFactory. Ash has two distinct ways to provide the 'Ash' service, which necessitates the change in two places. WindowManagerService will go away soon, and we will only have one way. BUG=837686 TEST=covered by tests Change-Id: Id871fe56331f99fcfb6225f4ebf59378a533600a Reviewed-on: https://chromium-review.googlesource.com/1098233Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#567339}
-
Francois Doray authored
TBR=fukino@chromium.org Bug: 852788 Change-Id: Ia8593011abcce487248bb8c394c0b431d31afec1 Reviewed-on: https://chromium-review.googlesource.com/1101063 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#567338}
-
Dirk Pranke authored
In order to roll GN 84176d72..a3bcd204 (r564007:r567268) and pick up the following changes: 3105b4b4 gn: Swap the order of two declarations. 44054a1e Fix quoting when writing defines on Windows. TBR=brettw@chromium.org Change-Id: I95798c4c5e45c8faaf249b162d7d5c8ef47e7be1 Reviewed-on: https://chromium-review.googlesource.com/1101164Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567337}
-
Wez authored
The 'launchpad' package has been removed from the Fuchsia SDK, with its functionality replaced by fdio_spawn(). The lingering definition will e.g. block Chromium dependency rolls into V8, so we need to remove it ASAP. TBR: jam Bug: 848028 Change-Id: Iac4ed84b65e9c077c9fe97d75c636f19ff597e74 Reviewed-on: https://chromium-review.googlesource.com/1098675 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#567336}
-
Ken Rockot authored
Switches all heap_profiling code to new public Mojo APIs which are replacing their EDK equivalents. No functional changes. This also includes appropriate DEPS and GN deps cleanup. Bug: 844763 Change-Id: Ica8969ae83d884e582025ddf92bf1f0104eb910e Reviewed-on: https://chromium-review.googlesource.com/1100077 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567335}
-
Ken Rockot authored
Replaces all EDK usage for ARC-related components with public Mojo API calls. No functional changes. Also cleans up relevant DEPS and GN deps. Bug: 844763 Change-Id: I1cab5ed08bcb08049b4648e3fb4c28664fb04bf7 TBR: jcliang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100041 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#567334}
-
Kyle Horimoto authored
Additionally, this CL adds new functionality to FakeBleScanner and FakeBleAdvertiser for providing access to their stored scan/advertisement requests. Bug: 824568, 752273 Change-Id: I0407021b62605e6feea745ce51ed4136013bce6d Reviewed-on: https://chromium-review.googlesource.com/1100479 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567333}
-
Koji Ishii authored
This test was added when we found Mac produces rare ShapeResult, by constructing the same run/glyph data artificially. During tweaking the tests, a character was added to runs, but forgot to update the NumCharacters(), which made Start/EndIndexForResult() incorrect. This patch fixes that, and also add CheckConsistency() and two new EXPECT() to ensure the aritificially built ShapeResult is good. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iea0189f370f9e3d4546f33582f6ad363929511cc Reviewed-on: https://chromium-review.googlesource.com/1100599Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#567332}
-
Edward Jung authored
chrome://dino modes Bug: 846473 Change-Id: I739b7e40e735da10cc7d7cd75cf808e770bf817e Reviewed-on: https://chromium-review.googlesource.com/1100455 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567331}
-
Ken Rockot authored
Migrates Mac app shim support and security key remoting code away from internal EDK APIs and over to newer, functionally equivalent public APIs. No functional changes here, just swapping out old types for new ones and updating dependencies appropriately. Note that this also duplicates some internal EDK code into the public Mojo platform library. This code is shared by a few unrelated parts of Chrome and really has nothing to do with Mojo, but there's not a better home for it yet. Bug: 844763 Change-Id: I40e7ff08f01d513fb046dc636ba3e4b1db1dbad2 Reviewed-on: https://chromium-review.googlesource.com/1099726 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#567330}
-
Stefan Zager authored
"Absolute" coordinates were a shim to ease the RLS transition. Get rid of them in favor of "Frame" and "Document" coordinates. BUG=823365 R=skobes@chromium.org,bokan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id82f7908c32b2b529a2259bb5e18339a5568458a Reviewed-on: https://chromium-review.googlesource.com/1100540 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567329}
-
Rune Lillesveen authored
Change-Id: I037e8144c82e3f29023ea47678a16d3680d3a103 Reviewed-on: https://chromium-review.googlesource.com/1100888Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#567328}
-
Robert Liao authored
This reverts commit 170f8510. Reason for revert: Causing some unit_test failures on Mac 10.10 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests starting around 33081 Original change's description: > Add Views DesktopMediaPicker into the Overall Views Build > > This moves the code into the toolkit_views source list and gates Aura > specific code behind build flags. > > BUG=726005,657883 > > Change-Id: I5e64ee0b16f2bfcb03da3bbc7c61486a786ee88d > Reviewed-on: https://chromium-review.googlesource.com/1097843 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566809} TBR=ellyjones@chromium.org,robliao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 726005, 657883 Change-Id: I4b8c6d38c1df4453ae1ee404f88a57046a908f35 Reviewed-on: https://chromium-review.googlesource.com/1101098Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567327}
-
Mark Pilgrim authored
Bug: 844964 Change-Id: I1b47ddad2856b8a92b4f8bd6f41b1d01b8706bac Reviewed-on: https://chromium-review.googlesource.com/1097196Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#567326}
-
Allen Vicencio authored
Stores the hosts found in NetworkScanner as lower case in order to do URL resolving Bug: 757625 Change-Id: I791072ecb07d9afb03aa2ba75aacedffcddcd5b0 Reviewed-on: https://chromium-review.googlesource.com/1097707 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#567325}
-
Zhenyao Mo authored
Plus some minor fixes. 1) consistently use gpu_preferences_ instead of gpu_preferences in case in the future we want to update gpu_preferences_ in the beginning. 2) change ShouldEnableSwiftShader() to EnableSwiftShaderIfNeeded(). I don't think this is the root cause why SwiftShader fails to fall back as reported in the bug, but still, it's good to fix this issue. BUG=852537 TEST=about:gpu R=piman@chromium.org TBR=rsesek@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I17ab4d26b4eea079bcd9f732e6689c76f002d584 Reviewed-on: https://chromium-review.googlesource.com/1100123Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567324}
-
Ken Rockot authored
Introduces a public IsolatedConnection helper as a replacement for the EDK PeerConnection type. A follow-up C will convert existing uses. Mojo multiprocess tests are converted to use the new type here, removing the last remnants of EDK dependency from the test multiprocess test support code. This also deletes some dead test code and opportunistically converts a few related uses of the internal EDK ScopedInternalPlatformHandle type to the newer public PlatformHandle type. Bug: 844763 Change-Id: Icad97f51d320381483e474c16077ef7844cc2b9d Reviewed-on: https://chromium-review.googlesource.com/1099269 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Change-Id: I6b8d9d9e1aa58e4a8e6d9a1067bf24fe4d101751 Reviewed-on: https://chromium-review.googlesource.com/1100735Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567322}
-
Tim Zheng authored
We want to release to dev/canary for version 67 and 68 and to release to all chanels since version 69. The beta/stable release is pushed back from 68 to 69. BUG=chromium:800120 TEST=manual test. Change-Id: I02851521a0b9266157be3c4eb510546637b538a1 Reviewed-on: https://chromium-review.googlesource.com/1100539Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#567321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b7910b8..7124db04 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If22570fceb3bfec7f7fb4d8692476a7d58907d1b Reviewed-on: https://chromium-review.googlesource.com/1100973Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567320}
-
Randy Rossi authored
Part of ongoing effort to enable ChromeVox in chromecast. This CL brings in the chrome.tabs api. Bug: 73383411 Test: None Change-Id: I4d6d666f56bcc535e30f617ac786b1f1da05a517 Reviewed-on: https://chromium-review.googlesource.com/1100970 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#567319}
-
Max Moroz authored
The flag is being used for all other configurations for a while. Looks like we've forgotten to add it for the Debug one when it's been implemented. Bug: 852391 Change-Id: I2f3fbd4639fdb81b304f0abdd0c8fe6f3d1dbcb3 Reviewed-on: https://chromium-review.googlesource.com/1100964Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567318}
-
spqchan authored
Bug: 852521 Change-Id: Ief55e563304cb2ea8677ef7914e1eb065ea1261a Reviewed-on: https://chromium-review.googlesource.com/1099733Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567317}
-
Kyle Milka authored
Allow users to interact with the custom backgrounds UI with only the keyboard. Bug: 851173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic442995e2a68d147942ad7625ea0e8a202e40137 Reviewed-on: https://chromium-review.googlesource.com/1097576 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567316}
-
erikchen authored
After a recent refactor, [cmd + left arrow] would perform history navigation instead of moving the cursor to the beginning of the Omnibox. This happens because the processing for the hotkey [triggering history navigation] has higher priority than the typical event handling flow. The hotkeys [cmd + left arrow] and [cmd + right arrow] are special, and should only trigger if the firstResponder is a WebContents, and the WebContents has chosen not to process the event. This CL removes handleExtraKeyboardShortcut:, which was dead code. Bug: 852332 Change-Id: Id03f5e22337a79d9ca4abfd20d995a8cf8976b2a Reviewed-on: https://chromium-review.googlesource.com/1099648Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567315}
-
Mounir Lamouri authored
Bug: 852212 Change-Id: I4ed79cc13f48aaaac4a68c33e976fdab834deb61 Reviewed-on: https://chromium-review.googlesource.com/1098467 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567314}
-
Hiroshige Hayashizaki authored
Preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1065061/. Bug: 845285, 841466 Change-Id: I502d296c05ad27a8d974daae5a004fbf58f8791d Reviewed-on: https://chromium-review.googlesource.com/1100537Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#567313}
-
dpapad authored
Tests affected: PDFExtensionTest.Basic PDFExtensionTest.Bookmark PDFExtensionTest.Elements PDFExtensionTest.ToolbarManager Most of the fixes involve adding Custom Elements to be tested in the document, otherwise their local DOM is not populated (unlike Polymer 1). Bug: 849476 Change-Id: Id953179142174cb5922bf53bcaa139011ea76ca9 Reviewed-on: https://chromium-review.googlesource.com/1100304Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#567312}
-
Sadrul Habib Chowdhury authored
With the change to using presentation-feedback for facilitating snapshot requests (crrev.com/c/1095562), the snapshot-specific code in gpu can now be removed. BUG=851504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25b563f879bb66c345ba541df736efc65a834f0d Reviewed-on: https://chromium-review.googlesource.com/1096669Reviewed-by:
-
Raphael Kubo da Costa authored
When the custom bindings were removed in commit 5b84e88a ("Remove custom bindings for CSSStyleDeclaration"), the new anonymous setter code added a check for ScriptState::ContextIsValid() to ensure it had received a valid |script_state|. It turns out this check is too strict, as in addition to verifying a ScriptState has an associated v8::Context it also asserts the ScriptState has a valid |per_context_data_|. This is valid in most cases, but when a node is moved across different documents and its previous document gets removed its |per_context_data_| is disposed of and ScriptState::ContextIsValid() fails. Since the anonymous setter is only invoked by the bindings layer, we can assume it is passed a ScriptState that is in a minimally usable state, so it is possible to relax the ContextIsValid() check and only make sure we can get a valid ExecutionContext from the ScriptState. Bug: 852190 Change-Id: I307de0e003e5258bf1f670b26f1dc86e4dae9286 Reviewed-on: https://chromium-review.googlesource.com/1100836 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#567310}
-
Ahmed Fakhry authored
Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=852387#c4 BUG=852387 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16227efb940473d3b7aa56d37760483c23d7b799 Reviewed-on: https://chromium-review.googlesource.com/1100158Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567309}
-
Marijn Kruisselbrink authored
Bug: 852249, 800898 Change-Id: Ic885db66683d40f259f4f8c0ddf82d6ea3b4c144 Reviewed-on: https://chromium-review.googlesource.com/1099361 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567308}
-
Chris Blume authored
Currently, building with Vulkan support is behind a gn flag (enable_vulkan). It would be easy to not build & test with this flag. As a result, it would also be easy to allow Vulkan support to bitrot. Enabling Vulkan building by default would keep the Vulkan code buildable. This patch does that. (You still need a command line parameter of --enable-vulkan when running Chrome to actually use the Vulkan codepath. This is just for the building.) BUG=848100 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I26fa03f9f6e2dc924691db913f723661b510f272 Reviewed-on: https://chromium-review.googlesource.com/1098117Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
-
Katie D authored
This removes a TODO for unnecessary work, and uses FireWebUIListener to send data to the frontend JS. For comments, see https://chromium-review.googlesource.com/c/chromium/src/+/1092071/2/chrome/browser/ui/webui/settings/tts_handler.cc. Bug: 850702 Change-Id: I3891d8d73af3e8f2f63a823b917910e2ee24dfdc Reviewed-on: https://chromium-review.googlesource.com/1099191Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567306}
-
Sky Malice authored
Bug: 831648 Change-Id: I1154abdb22295cac7f396dd61c2c4f833b56dccf Reviewed-on: https://chromium-review.googlesource.com/1093988 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#567305}
-
Nicolas Pena authored
This CL adds a DCHECK to make sure that PaintTiming::ReportSwapTime is called on the main thread. This is the method that should be called after a swap promise is concluded. This check is added in preparation of the change to PerformanceEntry strings to AtomicString. Bug: 852050 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc39c69b155c6e90fec32a3b3c0fae7fa987c378 Reviewed-on: https://chromium-review.googlesource.com/1100971Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#567304}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8e631772e342..e16ffd4fc3f2 git log 8e631772e342..e16ffd4fc3f2 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 art-snake@yandex-team.ru Simplify the calculation of Pages Offsets within CPDF_HintsTable. Created with: gclient setdep -r src/third_party/pdfium@e16ffd4fc3f2 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8356eb7aa7cb1496ea97cdb801a874a891ff6f9e Reviewed-on: https://chromium-review.googlesource.com/1101038Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567303}
-
Colin Blundell authored
PowerMonitorBroadcastSource suffers from raciness in that it can procress incoming Mojo messages on one thread while both it and the process-wide PowerMonitor instance are being destroyed on another thread. A previous CL introduced a mitigation for this problem by shutting down the processing of incoming Mojo messages in the PowerMonitorBroadcastSource destructor before proceeding with destruction (https://chromium-review.googlesource.com/1041215). However, that turns out not to be sufficient to eliminate the race: the PowerMonitorBroadcastSource instance can end up waiting for the lock in its destructor while on another thread it is holding the lock to process an incoming Mojo message. That second thread can then call back into the process-wide PowerMonitor instance while it is being torn down, resulting in crashes due to undefined state (specifically, the PowerMonitor instance has already set its PowerMonitorSource instance to nullptr, resulting in a crash when that instance is being accessed -- ironically, the very instance that is currently blocked in its destructor waiting for the processing of the incoming Mojo message to finish :). This CL removes the possibility of that race on shutdown by introducing a two-phase shutdown process for PowerMonitorSource. In PowerMonitor's destructor, it first invokes PowerMonitorSource::Shutdown() before proceeding. The contract of PowerMonitorSource::Shutdown() is that subclasses must take any necessary action to ensure that on return from that method, they will no longer call into PowerMonitor. PowerMonitorBroadcastSource fulfills this contract by stopping the process of incoming Mojo messages in PowerMonitorBroadcastSource::Shutdown(). In the above scenario, the broadcast source will end up waiting for the processing of the incoming Mojo message to finish *inside* PowerMonitorBroadcastSource::Shutdown(), which is safe by design as it is before PowerMonitor has done any teardown. Note that it is possible that there are still other kinds of raciness between PowerMonitorBroadcastSource and PowerMonitor; as I expressed on https://bugs.chromium.org/p/chromium/issues/detail?id=834312#c33, I am not confident about the overall threading model here. TBR=xjz@chromium.org, mmenke@chromium.org Bug: 809031 Change-Id: I9d0f291995b8185e16dff1f88564b6e5344439b2 Reviewed-on: https://chromium-review.googlesource.com/1098932Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
