- 18 Sep, 2018 40 commits
-
-
Takashi Toyoshima authored
This patch adds SharedCorsOriginAccessList class to the public content interface, so that Chrome Extension can access the interface via BrowserContext. SharedCorsOriginAccessList is managed to be per BrowserContext, and shared among multiple ResourceMessageFilter instances so that all created CORSURLLoaderFactory for these filters can refer its shared single network::cors::OriginAccessList instance. Access lists will be modified via BrowserContext interface on the UI thread, but all accesses to the OriginAccessList should be on the IO thread. SharedCorsOriginAccessList cares for this thread restriction. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iff894d8e1a831eb212fd00a8822a2c29ae9dcc2e Reviewed-on: https://chromium-review.googlesource.com/1196802 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#591968}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. In VRDisplay case, callbacks registered via requestAnimationFrame were called on the default task runner. This CL changes the task runner to per-frame task runners. Bug: 870606 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20067397f2114c53c516a0a10e897452d673219f Reviewed-on: https://chromium-review.googlesource.com/1226892 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#591967}
-
Jia authored
Bug: 881215 Change-Id: I41fcdde630cfb38606c1a3a1123d468dfffdfd19 Reviewed-on: https://chromium-review.googlesource.com/1229736 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#591966}
-
Chris Lu authored
This is in preparation of moving favicon logic in Bookmarks to FaviconLoader Bug: 856333 Change-Id: Idca0c1cf0537fd6012d6bdcd8cf6c44a7327ba2b Reviewed-on: https://chromium-review.googlesource.com/1194568Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#591965}
-
Guido Trotter authored
SupervisedUserContentProviderEnbaled policy is deprecated from M71 and will always default to false, so this class will have no action. Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Bug: 834488 Change-Id: Icf45b734507c16264a629260776099872386e288 Reviewed-on: https://chromium-review.googlesource.com/1224051Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#591964}
-
Toshiki Kikuchi authored
This CL introduce the support of notification-shell-unstable protocol defined in wayland-protocols repo. This allows create_notification requests used in notification support from Crostini apps, as initial support. BUG=chromium:838531 TEST=Emit requests from a client (e.g. notificationd) Change-Id: Ia9ca9e0ed77882e56a67cc1afa5f5915f19de626 Reviewed-on: https://chromium-review.googlesource.com/1220848 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#591963}
-
Kunihiko Sakamoto authored
Bug: 863305 Change-Id: I2af18b0efca1e02fd3a05e2e80f3300db7c4ea33 Reviewed-on: https://chromium-review.googlesource.com/1226487 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#591962}
-
Joel Hockey authored
This is a reland of 052bac3d ASAN/LSAN now OK. Changed VolumeManager::RemoveSshfsCrostiniVolume(const FilePath& path) to call DiskMountManager::UnmountPath(path.value()) before calling DoUnmountEvent since DoUnmountEvent will destroy the Volume object which owns the passed in 'path' arg. Original change's description: > CrOS FilesApp: Fix error messages in integration tests > > Mounted volume without a request: crostini:Crostini: > * This is basically what happens when you pull out a USB without > clicking unmount. This message is harmless, but the code is changed > to stop it anyway. > * Message fixed to state 'Unmounted ...' since the error happens at unmount. > * Changed test to call FMP.unmount and added logic into private_api_mount.cc > to remove crostini mount. > * Removed unmountCrostini test function which is no longer needed. > > Error in event handler: TypeError: Cannot read property 'volumeType' of null: > * This error happens when crostini is unmounted and the directory changes > back to Downloads. banners.js fixed to guard for the case where the > volume is now removed and VolumeManager.getLocationInfo returns null. > > Bug: 883571 > Change-Id: I13c0bee7f514dfc318eaa12f4c1ef1c2186e7a70 > Reviewed-on: https://chromium-review.googlesource.com/1227864 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591916} Bug: 883571 Change-Id: I2e1f23ec71cec9e0b47add912dbe0ee56fbfbc92 Reviewed-on: https://chromium-review.googlesource.com/1229735Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#591961}
-
Greg Thompson authored
This is a reland of https://crrev.com/586308 with a fix for macOS. ChromeViewsDelegate registers a KeepAlive while a menu is shown to prevent the browser from existing while a menu is up. This caused problems with the UninstallView since there was otherwise nothing keeping the browser alive, resulting in Chrome exiting when a menu was opened and closed (https://crbug.com/241366). This was dealt with by adding a leaked ref on the browser process to the UninstallView. In time, this turned into a leaked KeepAlive. This isn't so good for the KeepAliveRegistry, as it DCHECKs that there are no KeepAlives registered at shutdown. The underlying problem here is that BrowserProcessImpl doesn't own the lifetime of the browser process until the main loop is entered. There are various points during initialization where decisions are made to let the process exit without running the main loop. This CL moves ChromeBrowserMainParts's call of BrowserProcessImpl::SetQuitClosure into PreMainMessageLoopRunImpl when it's determined that the main loop will be run. BrowserProcessImpl observes but ignores KeepAlive transitions prior to this point. Due to the aforementioned change, the quit closure has not yet been set at the time that the Cocoa first-run dialog is shown. This dialog runs a substitute message loop that must be quittable via the Posix shutdown signal handlers, so it also uses SetQuitClosure to provide its run loop's quit closure to the BrowserProcessImpl. ClearQuitClosure is introduced so that this dialog can clear its quit closure in case it was terminated by the user having closed the dialog (which should not initiate browser shutdown). BUG=876640 Change-Id: I60ad6fae6e18118daf08fc490a589f0a9dfbce93 Reviewed-on: https://chromium-review.googlesource.com/1213143 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591960}
-
Yutaka Hirano authored
On forcible thread termination (i.e., when v8::Isolate::IsExecutionTerminating() returns true), we cannot run promise related functionalities. Fail such operations silently rather than crashing or reporting tha failure to callers, and make the behavior explicit on comments. Bug: 882378 Change-Id: I8b63746b1f25862aab2473f58dd05f0160e49ad5 Reviewed-on: https://chromium-review.googlesource.com/1229874Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#591959}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I3986f33bf3328a191588ea6eb1fe35df45e61947 Reviewed-on: https://chromium-review.googlesource.com/1220352Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#591958}
-
Marc Treib authored
Bug: 872360 Change-Id: Ieddcf7329310ab9772fd06e68860275f19f53f0a Reviewed-on: https://chromium-review.googlesource.com/1226634Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#591957}
-
Takashi Toyoshima authored
Update the console message. This is based on a user's feedback :) Bug: 883173 Change-Id: I197f44a52b13319e6da96a04bb09792f9dcce2cf Reviewed-on: https://chromium-review.googlesource.com/1226751Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#591956}
-
Dominik Röttsches authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1206337 plus a fix for flakiness due to timing issues when the page under DevTools test had not completed layout. Added a forced synchronous layout in the test HTML page to avoid running into incompletely laid out nodes on the DevTools side of the text. Avoiding complete test case crashes by introducing better assertions that capture when we get empty results from DevTools. Remaining existing functionally has been previously reviewed. Provide a new subclass for font unique name lookup for Linux. Connect via WebSandboxSupport to FontLoader which provides the out of process fontconfig calls for us. Tested by content_browsertests with a DevTools based test checking used fonts. This test was previously active on Android and is enabled for Linux in this CL. Bug: 880832 Change-Id: Icc67e3286002c82f2c47ba7c788b82a80b282f54 Reviewed-on: https://chromium-review.googlesource.com/1228119Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#591955}
-
Yuta Kitamura authored
Change-Id: Ibb2f6cd580a461b45709fcda387ca0f53ee142f7 Reviewed-on: https://chromium-review.googlesource.com/1225979Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#591954}
-
Yoshifumi Inoue authored
This patch makes |NGPaintFragment::next_for_same_layout_object_| to raw-pointer instead of |scoped_ref<NGPaintFragment>| to avoid leaf paint fragments to live longer than line box fragments for implementing reusing leaf paint fragments with marking dirty line box fragments. Bug: 874588 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I55db486d0dda7e539445463e962ad0e3451dc782 Reviewed-on: https://chromium-review.googlesource.com/1226486Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591953}
-
Takashi Toyoshima authored
Current KeywordOrderingAndDescriptions test does not use TestURLLoaderFactory and it results in making actual network requests. This causes a DCHECK failure that says network code runs not on the IO thread. This does not actually happen on TOT, but when OOR-CORS feature is enabled, it happens. This patch makes the test use TestAutocompleteProviderClient instead of ChromeAutocompleteProviderClient so to use TestURLLoaderFactory that avoid making actual requests. Bug: 870173 Change-Id: Ifb02d36b3c9be35c99037350e9676a671f948f6f Reviewed-on: https://chromium-review.googlesource.com/1226672Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#591952}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I3acc35c0639859e958247b9510b8cfbe1a71f680 Reviewed-on: https://chromium-review.googlesource.com/1217038 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#591951}
-
Findit authored
This reverts commit 052bac3d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 591916 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA1MmJhYzNkNWEzMDM0NTg2M2IwMTJhOTc4YTc4YWQ3N2JmY2RjNmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29026 Sample Failed Step: browser_tests Original change's description: > CrOS FilesApp: Fix error messages in integration tests > > Mounted volume without a request: crostini:Crostini: > * This is basically what happens when you pull out a USB without > clicking unmount. This message is harmless, but the code is changed > to stop it anyway. > * Message fixed to state 'Unmounted ...' since the error happens at unmount. > * Changed test to call FMP.unmount and added logic into private_api_mount.cc > to remove crostini mount. > * Removed unmountCrostini test function which is no longer needed. > > Error in event handler: TypeError: Cannot read property 'volumeType' of null: > * This error happens when crostini is unmounted and the directory changes > back to Downloads. banners.js fixed to guard for the case where the > volume is now removed and VolumeManager.getLocationInfo returns null. > > Bug: 883571 > Change-Id: I13c0bee7f514dfc318eaa12f4c1ef1c2186e7a70 > Reviewed-on: https://chromium-review.googlesource.com/1227864 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591916} Change-Id: I419e792b050f4a991bfe435907e7fc5b2d45311e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883571 Reviewed-on: https://chromium-review.googlesource.com/1229619 Cr-Commit-Position: refs/heads/master@{#591950}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/89652a35ebc4..95277a300f52 git log 89652a35ebc4..95277a300f52 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jie.a.chen@intel.com ES31: Add DispatchComputeIndirect support for D3D11 Created with: gclient setdep -r src/third_party/angle@95277a300f52 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2d1e1c7889ba0f534f86559da76e698e10026d80 Reviewed-on: https://chromium-review.googlesource.com/1229511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591949}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9789c75b1a6f..dfddc2d97596 $ git log 9789c75b1..dfddc2d97 --date=short --no-merges --format='%ad %ae %s' 2018-09-17 wl [pshinter] Handle numeric overflow. 2018-09-16 wl freetype.h: Add warning w.r.t. B/W hinting and rendering (#54589). 2018-09-15 wl [sfnt] Comment fix. 2018-09-13 wl [truetype] Some fixes for VF checks. 2018-09-13 wl * src/sfnt/sfdriver.c (sfnt_get_var_ps_name): Fix last commit. 2018-09-13 wl * src/sfnt/sfdriver.c (sfnt_get_var_ps_name): Check `result'. 2018-09-12 John.Tytgat [sfnt] Better PS name handling (#54629). 2018-09-12 wl [truetype] Improve VF check. 2018-09-12 wl * src/truetype/ttgxvar.c (ft_var_load_gvar): Check `glyphoffsets'. 2018-09-10 prince.cherusker * src/pshinter/pshrec.c (t2_hints_stems): Mask numeric overflow. 2018-09-09 wl [sfnt] Comment improvement. 2018-09-09 bungeman * builds/freetype.mk (refdoc-venv): Ensure python version (#54631). 2018-09-07 wl Typo. 2018-09-07 wl [truetype] Fix assertion failure. 2018-09-05 wl Synchronize `ftdebug.c' files. 2018-09-05 wl Synchronize `ftconfig' files. 2018-09-05 ramakrishnan.nikhil * docs/DOCGUIDE: Minor. 2018-09-05 ramakrishnan.nikhil Add documentation guidelines file. 2018-09-04 wl * devel/ftoption.h: Synchronize with master `ftoption.h'. 2018-09-04 wl Typo (#54618). Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1153 Change-Id: I7414d61999f20047d32949812511b1fc840e262e Reviewed-on: https://chromium-review.googlesource.com/1228613Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#591948}
-
Peter Wen authored
Use stability.gpu_crash_count in the system_profile proto to track gpu crash metrics rather than a variety of changing gpu histograms. This new proto value is only used on Android starting in M71 and tracks the same value as the histogram: "Stability.Android.ProcessedCrashCounts.All GPU process crashes" Thus this unifies our gpu metrics across stability proto, UMA histogram, and crash reports, since these all count the number of crashes with a valid crash dump (note that crash reports only include the number that are successfully processed and uploaded, so should be slightly reduced). Bug: 839017 Change-Id: If836b4fc8c8390ce008b7089a773af0b26ea6c10 Reviewed-on: https://chromium-review.googlesource.com/1228546 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#591947}
-
Rijubrata Bhaumik authored
This CL adds exposureTime to ImageCapture API. Spec discussion: https://github.com/w3c/mediacapture-image/issues/199 This was added to the spec in https://github.com/w3c/mediacapture-image/pull/200 Layout tests and mock tests are updated to support the same. Support for Android is added. TEST= run the demo in https://codepen.io/rijuB/pen/eKwLXB use slider to change exposureTime. BUG=823316 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ls3wQSoHOUY Change-Id: Ic3a546d734c02df31cd8ca08ece01f006ae8d906 Reviewed-on: https://chromium-review.googlesource.com/1136439Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#591946}
-
Darren Shen authored
There are some existing keyboard "end to end" tests, where a web page is loaded along with the open source keyboard extension. We refactor the tests a bit so that different web pages can be used for different tests and split/added a few more tests. Bug: 849995 Change-Id: I87e41b8df3b2210a95e233a9bc9f789c9181b5b3 Reviewed-on: https://chromium-review.googlesource.com/1214971Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#591945}
-
Shao-Chuan Lee authored
Bug: 866326 Change-Id: I8b9b65b4aee737707426ae3b103bd1ea8a866e27 Reviewed-on: https://chromium-review.googlesource.com/1223594 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#591944}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/460fd889fcdb..934a29ea903e git log 460fd889fcdb..934a29ea903e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 benjhayden@chromium.org Add expand-button for v2spa Created with: gclient setdep -r src/third_party/catapult@934a29ea903e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibdf83e3e91c43eb00ed8212abddb4aac073ff1f1 Reviewed-on: https://chromium-review.googlesource.com/1229775Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591943}
-
Kunihiko Sakamoto authored
Bug: 863305 Change-Id: Ifd46182aa91c9006b5881b3df8348fe47a1fa057 Reviewed-on: https://chromium-review.googlesource.com/1226757Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#591942}
-
Xiaohan Wang authored
These are not used after deprecating PPAPI CDM support. Bug: 772160 Change-Id: I95370a698773a7c27cc38ad331670263877c77e7 Reviewed-on: https://chromium-review.googlesource.com/1228509Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591941}
-
Xiaohan Wang authored
Conversion code is added to support multiple CDM interfaces that use different version of cdm::VideoDecoderConfig and cdm::VideoFrame. Bug: 854943 Change-Id: I235c12805aea3191f8a5153c9a124f6fe3b26a31 Reviewed-on: https://chromium-review.googlesource.com/1227489 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#591940}
-
Hayato Ito authored
Chromestatus entry is here: https://www.chromestatus.com/feature/5636327009681408 Per the discussion of https://github.com/whatwg/dom/issues/685, Blink will try to align the event dispatch behavior with other browsers; Call capture event listeners in capturing phase at shadow hosts. So far, Blink and WebKit call capture event listeners in *bubbling* phase, instead of *capturing* phase, at shadow hosts. Other browsers: - Safari: Will try to change the behavior in the next Safari Technical Preview. - Firefox: Already implemented the new behavior - Edge: Strong public support for the new behavior. This change is guard by CallCaptureListenersAtCapturePhaseAtShadowHosts flag, which is disabled at this moment, to confirm that this CL doesn't cause any behavior change when the flag is disabled. This CL adds a wpt for new behavior, which is now marked as [Failure] in Blink. After this CL lands, I will flip the flag in a follow-up CL, with rebasing a very few existing tests. BUG=883650 Change-Id: I29938840aed4f3430d8b749cd4843176b8668b5d Reviewed-on: https://chromium-review.googlesource.com/1212255 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#591939}
-
Tatsuhisa Yamaguchi authored
Bug: 870409 Test: manual test on device w/ enterprise enrollment Change-Id: I70e667c1ab4f6761a4cb32b73081b6c7fe2a50af Reviewed-on: https://chromium-review.googlesource.com/1215483 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#591938}
-
Krishna Govind authored
R=kariah@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ideaccacb4a2ab5db2ef9c6d2c212826c5a25d0b6 Reviewed-on: https://chromium-review.googlesource.com/1228996Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#591937}
-
David Tseng authored
Likely a typo. We don't want to just replace one occurance, but all occurances. Test: type inside of a Gmail content editable. At some point, type several spaces in succession. Observe nbsps being inserted by Gmail. Start arrowing around and verify characters are read. Change-Id: Ibd0629b5f99f5b7ba07f068ea6965fefc4f4b426 Reviewed-on: https://chromium-review.googlesource.com/1228992Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591936}
-
Noel Gordon authored
DOMContentLoaded can fire before the addEventListener is installed, so setup the listener per convention: test "document.readyState" and then install the event listener if needed. Per the HTML DOM spec, DOMContentLoaded fires on document, not window, so install the event listener on document. Test: browser_tests --gtest_filter="AudioPlayerBrowserTest*" Bug: 884963 Change-Id: I0c8168dd4869d16ccfdf7dd01513d3921fe45c9b Reviewed-on: https://chromium-review.googlesource.com/1229713Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591935}
-
Shao-Chuan Lee authored
Bug: 866326 Change-Id: I4832e39d9bd4e82ae70e47f24dc62c5d8d3aafa6 Reviewed-on: https://chromium-review.googlesource.com/1223553 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#591934}
-
Kunihiko Sakamoto authored
This will be used for UMA reporting. Design doc: https://docs.google.com/document/d/1kzQRLybaUk12UgG8YTyACwNZ7tpcXwdjzPXU3CV25J8/edit Bug: 863305 Change-Id: I5a302d833cb3f308ed9617819f65c6dd3f98ab70 Reviewed-on: https://chromium-review.googlesource.com/1226756Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#591933}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4c3b4aa6d1df..debba6d2124e git log 4c3b4aa6d1df..debba6d2124e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 thestig@chromium.org Roll third_party/freetype/src/ f8af8fba7..dfddc2d97 (14 commits) 2018-09-17 tsepez@chromium.org Make fxcrt::Retainable non-copyable. 2018-09-17 thestig@chromium.org Check for empty streams earlier in CPDF_StreamAcc::LoadAllData(). 2018-09-17 tsepez@chromium.org Replace CJS_GlobalVariableArray::Copy() with operator=(). Created with: gclient setdep -r src/third_party/pdfium@debba6d2124e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I79b1fc3fb7f8924c019172d294d8f6c00eac0fc6 Reviewed-on: https://chromium-review.googlesource.com/1229505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591932}
-
Anand K. Mistry authored
storage::ShareableFileReference is a non-threadsafe ref-counted object, and therefore all refcounts must be done on the IO thread. This change splits all file reference tracking into a helper class that lives on the IO thread, to ensure non-racy refcounting. BUG=None Change-Id: Icd3dad5ee6518a6476f5644ed8df222750cca562 Reviewed-on: https://chromium-review.googlesource.com/1220850Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#591931}
-
Sungguk Lim authored
As color strings used by themes renamed(kColorTable->kOverwritableColorTable), the corresponding theme doc should be updated. Bug: None Change-Id: I67684c050b92b52cf7914c6731b0fad593a0106f Reviewed-on: https://chromium-review.googlesource.com/1226719Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#591930}
-
Siddhartha authored
Bug: 859260 Change-Id: I808dd3fe090aa9ba346906160bcd2468841d07ff Reviewed-on: https://chromium-review.googlesource.com/1229195 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#591929}
-