- 19 Jun, 2018 40 commits
-
-
Jose Dapena Paz authored
Several chrome extensions namespace aliases are declared both in namespace extensions:: and extensions::(anonymous). This is not failing in non-jumbo build as on each unit it is declared one time. But on jumbo build same compilation unit includes both aliases, breaking compilation. Bug: 746956 Change-Id: Ic2255b204a832e7079bda24afb7e8769658dc2e4 Reviewed-on: https://chromium-review.googlesource.com/1105052Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#568503}
-
Annie Sullivan authored
Bug: 854239 Change-Id: If6d20625d0bacac7020c4729bba77491f2b435f4 TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1106430Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568502}
-
Allen Vicencio authored
Adds metrics for duration of ReadDirectory Bug: 757625 Change-Id: I03a30296a01db87fdc2c1133c512385d6a6bc967 Reviewed-on: https://chromium-review.googlesource.com/1099692Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568501}
-
Mohamed Amir Yosef authored
This CL introduces the main skeleton of the observer implementation, and the necessary wiring into the processor. Bug: 516866 Change-Id: I28059a6277d8e663183203ea3181b1aba1379783 Reviewed-on: https://chromium-review.googlesource.com/1104472 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568500}
-
Jinsuk Kim authored
The only thing the native CVC does now is (as an WebContentsObserver) adjust renderer view focus/screen info when renderer is updated. This CL moves that reponsibility to WebContentsAndroid, and deletes the entire class. There is no functional change. Bug: 598880 Change-Id: I9a1f3a2e0df5457439a27675d3786aa6703e06ac Reviewed-on: https://chromium-review.googlesource.com/1083911Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#568499}
-
Yue Li authored
- Add hotword listening settings entry - Update logic for enable Assistant Bug: b/78191741 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibeb5230e6a550c38a1d01ac4edee505ccf6db478 Reviewed-on: https://chromium-review.googlesource.com/1099717 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568498}
-
Matt Mueller authored
Nothing was receiving this yet so it should be safe to change. Bug: 649026 Change-Id: I964e91edab78f94f08b20dc89eeb2dd09879dc8c Reviewed-on: https://chromium-review.googlesource.com/1105465Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568497}
-
Jennifer Apacible authored
WebContents activates the "disable rendering" optimisation when the WebContents is hidden. This means that when a video is playing in Picture-in-Picture, then the WebContents is hidden, the video will stop playing in the Picture-in-Picture window. Similarly to content capturing (e.g. mirroring / tab capture), this optimisation should not be activated when in Picture-in-Picture mode. This will only affect one tab at a time, as users cannot enter Picture-in-Picture mode from multiple tabs. Bug: 848812 Change-Id: I98a0e769ad4c412ea50db4de2ab63e64f3b752f2 Reviewed-on: https://chromium-review.googlesource.com/1105339Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#568496}
-
Jérôme Lebel authored
Adding collapsableMode property in ListMode which can have 2 values: + ListModelCollapsableModeHeader + ListModelCollapsableModeFirstCell The header mode is used to when the header to collapse a section. When collapsed, a section contains no item. The first cell mode is used to when the first cell to collapse a section. When collapsed, a section contains the first item. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If46f85d5c412b1b799099635fefe7a8c8d11bbf2 Reviewed-on: https://chromium-review.googlesource.com/1101558 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568495}
-
Varun Khaneja authored
CL to enable on Dev and Canary: http://cl/200424143 Bug: 750327 Change-Id: Ica7ac69480d5739d4cc35d692b911c51f6547b15 Reviewed-on: https://chromium-review.googlesource.com/1104949Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568494}
-
Kevin Schoedel authored
This is used by Chromevox. Bug: b/110195060 Test: manual Change-Id: I9e22aacf0c3335d70eb92ea9b66f6e11a7ef2f7c Reviewed-on: https://chromium-review.googlesource.com/1105028 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#568493}
-
Daniel Bratell authored
interface is macro for struct in some Windows headers which causes problems when Windows headers get exposed to code that has named variables or functions interface. This happened with the newly added jumbo support in chrome/browser/extensions. Bug: 850484 Change-Id: I5d838bad5658bfe97542b32647e182348f63c4cc Reviewed-on: https://chromium-review.googlesource.com/1106339Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#568492}
-
Nick Burris authored
- Add a string to list extensions under items to be removed. - Modify confirmation message to clarify to users that their extensions were disabled because of the settings reset. Bug: 853339 Change-Id: Ie57d4434ab5aa89f287038a1d45e0840678991aa Reviewed-on: https://chromium-review.googlesource.com/1103220Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nick Burris <nburris@google.com> Cr-Commit-Position: refs/heads/master@{#568491}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f2030783094e..ba61029c5b49 git log f2030783094e..ba61029c5b49 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 caryclark@skia.org fix op fuzz timeout 2018-06-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2dabb4a367c3..7df52383cfdf (1 commits) 2018-06-19 fmalita@chromium.org Use SkJSONWriter for viewer UI serialization 2018-06-19 caryclark@skia.org fix bookmaker files 2018-06-19 caryclark@skia.org fix fuzzer bugs in pathops Created with: gclient setdep -r src/third_party/skia@ba61029c5b49 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:831647,chromium:853938 TBR=kjlubick@chromium.org Change-Id: I553b529db946ce58832e209af4315efcca790386 Reviewed-on: https://chromium-review.googlesource.com/1106100Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568490}
-
Tommy C. Li authored
This makes the 16 elevation shadow for the Omnibox match the specs given for MD Refresh. This CL also divorces the Omnibox shadows from the Aura window shadow drawing logic. Bug: 845305, 823535 Change-Id: Ibbda26b465b528805a1be591a23a20cc09df7643 Reviewed-on: https://chromium-review.googlesource.com/1100006Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#568489}
-
Douglas Creager authored
The NetworkService currently ignores all Reporting headers, since we haven't implemented the BACKGROUND_SYNC permissions check in a way that works across service/process boundaries. This adds a browser test that verifies this (and while we're at it, verifies that we _don't_ ignore Reporting headers when we're using the legacy non-service network stack). Bug: 845559 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e7c1ab446e067e7f8af6fd80d3abc9b2d5187ad Reviewed-on: https://chromium-review.googlesource.com/1067465 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568488}
-
rbpotter authored
Set the document title to the title of the tab being printed, so that the task manager will show the correct task title. Bug: 773928 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If8f7fec12bd81cca71bdccf3fb9f040ac17bc3f0 Reviewed-on: https://chromium-review.googlesource.com/1104985Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568487}
-
Daniel Murphy authored
This reverts commit 5916ae31. Bug: 854102 Reason for revert: Renderers still crashing - will have to investigate further. Original change's description: > Reland "[SessionStorageS13N] Enabling mojo SessionStorage by default" > > This is a reland of 1bd58466 > > Original change's description: > > [SessionStorageS13N] Enabling mojo SessionStorage by default > > > > Bug: 716490 > > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > > Reviewed-on: https://chromium-review.googlesource.com/1072918 > > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#563169} > > Bug: 716490 > Change-Id: I5c5911a5f98e84934837fb9025431a8f98bea6ba > Reviewed-on: https://chromium-review.googlesource.com/1104825 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568244} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org Change-Id: I5cb433aa9dd9acefb8cb34cb9cc7e5820b9931cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 716490 Reviewed-on: https://chromium-review.googlesource.com/1106398Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568486}
-
Olga Sharonova authored
[1] introduced AudioServiceLaunchOnStartup feature which we want to roll out with a new experiment group. Updating field trial to run the config on bots first. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681 Bug: 851611,853781 Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a Reviewed-on: https://chromium-review.googlesource.com/1105957Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568485}
-
Xi Cheng authored
Bug: 851163 Change-Id: I651da22403ba5597667549970b29d7d47a62f73b Reviewed-on: https://chromium-review.googlesource.com/1105491Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#568484}
-
Ken Rockot authored
Adapts dynamic mojo_core library thunking to use base::ProtectedMemory for function table storage and exempts the calls from cfi-icall checks. Bug: 850464 Change-Id: I8e7d8dbcb4d312e089bdee830e89ed973ae5727e Reviewed-on: https://chromium-review.googlesource.com/1105301Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568483}
-
danakj authored
And remove an empty method and the caller on MicroBenchmark. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9750cbcf1daebf365f8e5bd91022dedf32e49ec4 Reviewed-on: https://chromium-review.googlesource.com/1103137 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568482}
-
Becky Zhou authored
Bug: 851977 Change-Id: I99de0abe80ea536a23ecdca2401dd3fd6b816955 Reviewed-on: https://chromium-review.googlesource.com/1101699 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#568481}
-
Emircan Uysaler authored
This reverts commit e048eba0. Reason for revert: Speculative revert as a regression is detected in this range. https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ2ajFuAoM Original change's description: > Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource > > This CL cleans up this class in preparation for future types to be added. > > Bug: 853843 > Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 > Reviewed-on: https://chromium-review.googlesource.com/1104965 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568165} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Ic71cc3094e0e79572c2045a4c4464dd5b5bbd114 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853843 Reviewed-on: https://chromium-review.googlesource.com/1106397Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568480}
-
Kevin Bailey authored
Restores (dark) pressed color to tab switch button, which was unintentionally removed in prior CL. Also creates an ink drop mask for the tab switch button, due to discovering that ink drop was extending beyond border. (A more general solution is being worked on.) Bug: 780835 Change-Id: Id96f4c1695b0f0dceed1e122b55f0f029f813fa0 Reviewed-on: https://chromium-review.googlesource.com/1103140 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568479}
-
Ilya Nikolaevskiy authored
Bug: 690537 Change-Id: Ie75bd4040aee327431b01c676a221a8eb70410ae Reviewed-on: https://chromium-review.googlesource.com/1106146Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#568478}
-
Hans Wennborg authored
The DIA SDK normally lives in the Visual Studio installation dir. Bug: none Change-Id: I38c17fdc6e26a49eb4205aceb34e56e7be9d3a65 Reviewed-on: https://chromium-review.googlesource.com/1106138Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568477}
-
Rohit Rao authored
|reloadSessions| previously had code to trigger another sync refresh. The old sync sessions implementation would detect that nothing had changed and break the update cycle, but a new implementation notifies observers unconditionally. This was leading to an infinite loop of sync updates. BUG=854049 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I85dbf2810f5ff6e009812a33ad643fb54cfdc8c4 Reviewed-on: https://chromium-review.googlesource.com/1106001Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568476}
-
Mike Reed authored
See future Skia CL: https://skia-review.googlesource.com/c/skia/+/135566 Needs this to land first: https://skia-review.googlesource.com/c/skia/+/135622 Change-Id: I8f55332a74429750b89db4da5f9ce407df6bc222 Reviewed-on: https://chromium-review.googlesource.com/1105062Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#568475}
-
Mitsuru Oshima authored
ARC++ app may update the color programatically, which can result in noticable flashing. This will make the color change transition smooth by animating the color from currently used color". TBR=wutao@chromium.org BUG=b/88534690 TEST=manual. also covered by unit test Change-Id: Ia15976cb1ec425ddb4e23ec6a253667fa6f774d9 Reviewed-on: https://chromium-review.googlesource.com/1101504 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#568474}
-
Zhiqiang Zhang authored
- Added cast-framework and fido client for feature development. - Added auth-api-phone client, which is a missing dependency of auth - Updated BUILD.gn dependencies as they were out of date. Bug: 822826 Change-Id: I3076868f6607511ac911a26de482e4a645cedf56 Reviewed-on: https://chromium-review.googlesource.com/1105459Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568473}
-
Carlos Knippschild authored
The group was finally renamed in the experiment configuration so renaming it here again. Bug: 687364 Change-Id: I314b2993f27342054bbb423c80e16d2e7a8f886f Reviewed-on: https://chromium-review.googlesource.com/1105390Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568472}
-
Devlin Cronin authored
tabs.captureVisibleTab() is interesting. It used to work with every URL ever, and just checked for if activeTab or <all_urls> was present. However, this led to some issues where the extension could capture pages it shouldn't be able to, such as https://crbug.com/810220. Changing this to only allow access to pages that the extension had explicit access to also broke important use cases. For instance, taking screenshots of chrome:-scheme pages is important for filing bugs, tracking features, etc. This similarly broke use cases for other URLs that extensions don't have full access to, like other extensions' pages. An exception was added for chrome:-scheme pages, but this was insufficient for other cases. Adjust the permissions check to allow page capture of otherwise- restricted pages if the extension has activeTab granted. We require activeTab (rather than either <all_urls> or activeTab) because it gives a stronger guarantee that the user wants the extension to run on the given site. Note: this does not allow any other action on these restricted pages; only capturing the page is permitted. The new behavior enforces the following permission requirements for the host types: <arbitrary web page>: activeTab OR <all_urls> file:-scheme page: (activeTab OR <all_urls>) AND explicit file access from chrome://extensions. Pages restricted by enterprise policy: blocked Extension's own page: activeTab OR <all_urls> Another extension's page: activeTab chrome:-scheme page: activeTab Support for IPv6 pages and pseudo urls is dependent on these being properly supported with activeTab, which will be pursued in a followup. Bug: 839857 Change-Id: Ied3a71732cd5d41ad16f9b459f6fda9b1815edaf Reviewed-on: https://chromium-review.googlesource.com/1102902Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568471}
-
Justin Cohen authored
Previous CL was iPad only, but these tests are failing all over. TBR=olivierrobin@chromium.org Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I777f2677202564eb26a8b2735f3df55a1dfff3d9 Reviewed-on: https://chromium-review.googlesource.com/1106220Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568470}
-
Scott Violet authored
And updates the functions to better reflect what it is suppose to do. There was a race conditions with how the code was before. In particular, because access to content has to be on the io-thread care must be taken during destruction. Creation of the interfaces happens on the io thread, which means destruction of the object supplied to AddInterface() has to happen on the io-thread. I separated out the parts that happen on the io thread into a refcounted thread safe that is destroyed on the io thread. BUG=837686 TEST=covered by tests Change-Id: Ia3dce4894a3cf4b7a08cd5a9c4d1fae674d7e7c5 Reviewed-on: https://chromium-review.googlesource.com/1105611Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568469}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee3e3a4f3cba..a1ea4276f87f git log ee3e3a4f3cba..a1ea4276f87f --date=short --no-merges --format='%ad %ae %s' 2018-06-19 tsepez@chromium.org fxcrt::{Byte,Wide}String missing move-assign operator Created with: gclient setdep -r src/third_party/pdfium@a1ea4276f87f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifaa597fcb85a33cdd60f0cf0799170c1e7d76e4b Reviewed-on: https://chromium-review.googlesource.com/1106099Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568468}
-
Moe Ahmadi authored
After crrev.com/c/1078871 that updated FormSuggestionView and FormSuggestionLabel to use AutoLayout, autofill suggestions started showing in reverse order (i.e., the first suggestion was shown last and had to be scrolled to get to). This CL fixes that regression. Bug: 852910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6aebe579a8ec958ba9a12339396c2b0ddef45406 Reviewed-on: https://chromium-review.googlesource.com/1101482Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568467}
-
nednguyen authored
Bug: 849363 Change-Id: Ief8da1eda983c68c0db49f08cbca7d388c952741 Reviewed-on: https://chromium-review.googlesource.com/1102910Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568466}
-
rbpotter authored
Remove field trial configs for print scaling and print PDF as image, since these features have launched. Bug: None Change-Id: I667a797ebc4bdbe71fe37acf4a00ef0d34718223 Reviewed-on: https://chromium-review.googlesource.com/1103307Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568465}
-
Matt Menke authored
Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG=844950, 844951, 844952, 853251, 844928, BUG=843205, 844949, 844925, 844939, 821021, BUG=853798, 844973, 844927, 844926, 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464}
-