GitLab

Profiles: Fixed crash when avatar bubble is launched using ctrl+shift+m key press when there is only one default profile. Incorporated necessary condition check before launching avatar bubble.

BUG=105700
TEST=None


Review URL: http://codereview.chromium.org/8664028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8771030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23472
TEST=NONE

Review URL: http://codereview.chromium.org/8770040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23658
TEST=See issue


Review URL: http://codereview.chromium.org/8771019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112861 0039d316-1c4b-4281-b951-d872f2087c98

Minor Windows-only code cleanup. That also fixes broken sound on Windows Server 2003.

BUG=none

Review URL: http://codereview.chromium.org/8777003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112860 0039d316-1c4b-4281-b951-d872f2087c98

Adds XInput redist DLL which is a new dependency of recently added gamepad code,
and is required on Win XP. laforge has OK'd the size addition to the final
package (~100K).

BUG=79050

Review URL: http://codereview.chromium.org/8774023

TBR=scottmg@google.com
Review URL: http://codereview.chromium.org/8788009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87658
TEST=Have two machines with chrome, both with multiple profiles and each with one profile signed in to the same account. Change avatar/name on one, and it will change on the other.

Review URL: http://codereview.chromium.org/8771024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112856 0039d316-1c4b-4281-b951-d872f2087c98

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743

Review URL: http://codereview.chromium.org/8637006

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8785015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90898
TEST=none


Review URL: http://codereview.chromium.org/8744002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112852 0039d316-1c4b-4281-b951-d872f2087c98

exist. This is a regression from
http://codereview.chromium.org/8759017

BUG=106238
TEST=none
R=akalin@chromium.org,yfriedman@chromium.org


Review URL: http://codereview.chromium.org/8790008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112851 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=106248
TEST=browser_tests on aura should cycle green

Review URL: http://codereview.chromium.org/8772066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8771046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112849 0039d316-1c4b-4281-b951-d872f2087c98

The preference is controlled by the command line and enterprise policy.

R=mattm@chromium.org,mnissler@chromium.org
BUG=106077
TEST=Existing policy unit tests are updated.

Review URL: http://codereview.chromium.org/8772014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79520
TEST=

Review URL: http://codereview.chromium.org/8669014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112847 0039d316-1c4b-4281-b951-d872f2087c98

- both BookmarkBubble and BookmarkEditor now use single-line input for their names
- update nib to use IBOutlet to call the NSCell off of the NSTextField

BUG=100618


Review URL: http://codereview.chromium.org/8775042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112846 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: Ie6ee3ec84c126f46cdc34aea17bafa43cd49245c

BUG=chromium-os:23709
TEST=Chrome starts + VMTests pass


Review URL: http://codereview.chromium.org/8785011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:104530
TEST=PyAuto tests

Review URL: http://codereview.chromium.org/8772068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104360
TEST=covered by tests


Review URL: http://codereview.chromium.org/8772047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105445
TEST=PanelBrowserTest.AutoResize

Review URL: http://codereview.chromium.org/8785009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112842 0039d316-1c4b-4281-b951-d872f2087c98

We need to clear WebKit's in-memory cache after adding an event handler to be sure that when reloading a site the new event handler is active. 

BUG=none
TEST=no


Review URL: http://codereview.chromium.org/8772058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112841 0039d316-1c4b-4281-b951-d872f2087c98

- Call PSS::ShowLoginDialog directly from app notification code so that the dialog comes up even if the user is logged in.
- Small fix to PSS to avoid infinite spinner in cases where the sync backend does not really change anything (ahd hence does not call back PSS).
Review URL: http://codereview.chromium.org/8783001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112840 0039d316-1c4b-4281-b951-d872f2087c98

GdkGC is deprecated and will be removed in gtk3 and cairo should be faster anyway. This uses the new CairoCachedSurface in gfx::Image.

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8781001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106259
Review URL: http://codereview.chromium.org/8786011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105220

Review URL: http://codereview.chromium.org/8727014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112837 0039d316-1c4b-4281-b951-d872f2087c98

* Moved parts->PostMainMessageLoopRun call from PostDestroyThreads to the right place (PostMainMessageLoopRun() method)
* Renamed Shell::DeleteInstanceForTesting to DeleteInstance as this is no longer for testing.

BUG=106070
TEST=browser_tests on aura will not crash as described in the bug

Review URL: http://codereview.chromium.org/8774029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112836 0039d316-1c4b-4281-b951-d872f2087c98

Avoid a race condition in reordering of notification bubbles when canceling them.

BUG=89078
TEST=none

Review URL: http://codereview.chromium.org/8774027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112835 0039d316-1c4b-4281-b951-d872f2087c98

Shaving parallel authenticator yak to remove unnecessary dependency on this class from OAuth specific code. Moved system salt and supplemental key related methods to cryptohome and cert libraries instead.

BUG=chromium-os:23301
TEST=none

Review URL: http://codereview.chromium.org/8761016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=overflow test

Review URL: http://codereview.chromium.org/8776035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112833 0039d316-1c4b-4281-b951-d872f2087c98

Tested by comparing output of ./scons -n extra_sdk_update_header both before and after.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual


Review URL: http://codereview.chromium.org/8733014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112831 0039d316-1c4b-4281-b951-d872f2087c98

I recently landed a patch that defers the SelectFileDialog::Listener callback until the file picker window is closed.  The test needed to be updated to simulate closing the window so that the Listener would delete itself.

BUG=none
TEST=unit_tests, memory waterfall

Review URL: http://codereview.chromium.org/8787007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112830 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=103443
TEST=Try to print tiles in a build with the PDF plugin / print preview on.


Review URL: http://codereview.chromium.org/8772053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112829 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a race on startup. See issue for details.

BUG=chromium-os:20865
TEST=Ensure logging, including VLOG, works.
TBR=willchen@chromium.org

Review URL: http://codereview.chromium.org/8757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112828 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8789006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112827 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8784004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112826 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8788003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112825 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8787003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112824 0039d316-1c4b-4281-b951-d872f2087c98

They used to be children of the root.  This change makes
shadows track their windows' transforms and simplifies the
code (as we no longer need to track stacking or parenting
changes).  I am still slightly worried that shadows will
look strange if we scale windows up or down, but we can
figure out how to deal with that when we need to.

BUG=101977
TEST=added; also hacked up StackingController to rotate and scale windows and checked that shadows were drawn as expected

Review URL: http://codereview.chromium.org/8785005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112823 0039d316-1c4b-4281-b951-d872f2087c98

Use ppapi_sources.gypi for nacl trusted build.scons like the untrusted nacl.scons does (mirroring nacl.scons changes in http://codereview.chromium.org/8727029/)

R=noelallen@chromium.org,bradnelson@chromium.org
BUG= none
TEST= ppNaClPlugin builds in nacl via scons.

Review URL: http://codereview.chromium.org/8769052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112822 0039d316-1c4b-4281-b951-d872f2087c98