- 30 Oct, 2018 40 commits
-
-
Tommy Nyquist authored
The CL for updating the visuals of how a deprecated operating system should be displayed did not correctly pass along enough information to be able to always have an up to date content description, which is important for accessibility. The state of whether an update badge should be visible or not is always known at the time it has to be updated, so the state should be passed in. The reason is that whether the badge is really visible or not might be correct in all cases when the check happens. This CL therefore goes back to how things were before the visual update by passing the state in. In addition, the menu item itself did not always have a correct content description, but now it is forcefully set during decoriation of the item. Bug: 899695 Change-Id: I9f7e2d4cc6b60ccfaf95d7c07fc351c5c9e2a8ac Reviewed-on: https://chromium-review.googlesource.com/c/1306399 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#604022}
-
Akihiro Ota authored
Previously, Talkback would not report the new value of a slider when adjusted; in order to hear Talkback report the new value, user had to un-focus and re-focus the slider. Changed the AccessibilityEvent that is fired when detecting a slider value-change from TYPE_VIEW_SCROLLED to TYPE_VIEW_SELECTED, which triggers Talkback to report value of the focused item. This mimics Talkback behavior of native Android sliders. Bug: 836554 Change-Id: I4bb3bfafdb4d077f80e1ba4f3c9eecf8a7536497 Reviewed-on: https://chromium-review.googlesource.com/c/1308978Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#604021}
-
Ben Pastene authored
And also roll chromite. The latest roll is blocked due to the path changing slightly: https://chromium-review.googlesource.com/c/chromium/src/+/1306765 NOTRY=true Bug: 897540 Change-Id: Idc753e8b79dcf4c231e05fb9bb6ba3ad7b52592f Reviewed-on: https://chromium-review.googlesource.com/c/1308014 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#604020}
-
Egor Pasko authored
In http://crrev.com/596588 a few events were introduced to find out where time is spent on occasional slow runs (see the bug for more details). Remove the trace events that have proven to be quick (not noticed to take more than 1 frame on N5). On the other hand, in a trace from comment http://crbug.com/891797#c24 we observed these durations for the second startup: * ProcessInitializationHandler.initializePreNative(): 15ms of wall time (11ms CPU time) * ChromeBrowserInitializer.preInflationStartup: 55ms Keeping these events for now to keep the traces more informative. Bug: 891797 Change-Id: I543502973d19d768a94bbc5bec0a1446cc4338c5 Reviewed-on: https://chromium-review.googlesource.com/c/1305557 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604019}
-
Antoine Labour authored
Both CreateImageForGpuMemoryBuffer and CreateAnonymousImage take a BufferFormat which explains the format, and all callers pass a consistent internalformat (equal to the result of gpu::InternalFormatForGpuMemoryBufferFormat). Most GLImage implementations refuse a mismatch anyway. Bug: 900044 Change-Id: I7b1ba0711bc4242f263932c40644f884cbe081ce Reviewed-on: https://chromium-review.googlesource.com/c/1306780 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604018}
-
Robert Ogden authored
Requested by the server team. Added as a member to the pingback client impl which is constructed in the chrome layer, and is copied on every pingback request. Bug: 900224 Change-Id: Ic31ae471f09fc8cf9fe896ef42e9bffb3f6e9401 Reviewed-on: https://chromium-review.googlesource.com/c/1308078 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604017}
-
Oystein Eftevaag authored
Reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 TBR=skyostil@chromium.org Change-Id: I1b1ca495b8b7579bbfa46ced8de017d21e8d54e7 Reviewed-on: https://chromium-review.googlesource.com/c/1308415Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604016}
-
Ryan Hansberry authored
Add new team member hsuregan@, and remove an incorrect path. Change-Id: Ia823a4db42bcc87aa136fd6013507877381db59b Reviewed-on: https://chromium-review.googlesource.com/c/1308553Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604015}
-
Aiden Benner authored
Previously the @MainDex annotation would not be processed by the jni_generator for proxy natives. So method registrations that should be in main dex were incorrectly registered. This CL processes @MainDex annotations for proxy natives and properly splits up their declaration in generated registration headers. Bug: 898261 Change-Id: Iad9d3b3121085ef1427b958dcefc1acfb255312c Reviewed-on: https://chromium-review.googlesource.com/c/1303394 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604014}
-
Bailey Berro authored
This change is a part of an ongoing series of changes to pull the add SMB share dialog out of settings. - Moves SmbHandler from ui/webui/settings/chromeos to ui/webui/chromeos - Changes SmbHandler from implementing a settings-specific WebUIMessageHandler to the more general version - Removes unused overridden methods Bug: chromium:887135 Change-Id: If196d3bdf53ec69d46ea25f1314a0bafff6c296d Reviewed-on: https://chromium-review.googlesource.com/c/1285519 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#604013}
-
manuk authored
Certain omnibox inputs, such as `http:www.` produce matches with invalid urls. Invoking GURL::spec on these invalid GURL's caused a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. Bug: 898554 Change-Id: I89a27f902b77bf6b221c321ab396787e9249a4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1308260 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#604012}
-
Hubbe Hubinette authored
Not sure exactly what is affected by this, stumbled on it while working on fixing full-range video. Change-Id: I589e1b811ef5f10160111620b63f06492068f341 Reviewed-on: https://chromium-review.googlesource.com/c/1188968 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#604011}
-
Meilin Wang authored
Temporarily fix the Assistant UI flyout off the screen to the left when the container width grows larger than the screen width by explicitly setting x-axis value of container to be positive. But the side effect is when the screen is not wide enough, inside views will be clipped. Since it doesn't always make sense to apply a width restriction on Assistant UI to be less than the usable work area width (the workarea could be extremely narrow depending on the physical size and resolution combination), also the server side has assumptions about the card size, we may need a more comprehensive solution to resize the views correctly. In this CL, we just keep the 640 dip width assumption unchanged. Test: local compile and manually test. Bug: b:116807989 Change-Id: I257ac26cd28672ec284ff2555e46db5ab6a46246 Reviewed-on: https://chromium-review.googlesource.com/c/1250087Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#604010}
-
wutao authored
This cl fixes two descriptions of shortcuts. Bug: 896907 Test: manual. Change-Id: I035a4cab3e8315437111f0f72bcdf3bf681e2876 Reviewed-on: https://chromium-review.googlesource.com/c/1298475Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604009}
-
Matthew Jones authored
This patch removes unused swiple logic experiment flags and implementation from Chrome. Change-Id: Ic59a477a71291a355ac68538693f10b940e22d68 Reviewed-on: https://chromium-review.googlesource.com/c/1305814Reviewed-by:
-
Kevin Strohbehn authored
Bug: 896790 Change-Id: I2d8de828cea27caa210755a0de8304ee293e55f9 Reviewed-on: https://chromium-review.googlesource.com/c/1307233 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604007}
-
John Chen authored
SessionHandlingTest.testGetSessions appears to trigger some race conditions and is flaky. Disabling it until a fix can be found. TBR=zmin@chromium.org Bug: 899919 Change-Id: I3c532559477a3597f20984783eb36acf6355ad7b Reviewed-on: https://chromium-review.googlesource.com/c/1308657Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604006}
-
Jamie Madill authored
This should force DEPS changes in ANGLE to trigger all trybots. ANGLE's bot config is a bit special since we use recursive DEPS. Bug: 850100 Bug: 899737 Change-Id: Iab6e996663386f66f1fa05f2ee10531d6bd85224 Reviewed-on: https://chromium-review.googlesource.com/c/1307734 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
erikchen authored
Previously, local_device_test_run.py used SignalHandler() to catch SIGTERM, raise an exception, and then handle the exception. This prevents other SIGTERM handlers from ever receiving the exception. This CL changes local_device_test_run.py to instead use AddSignalHandler(), so that the exception is propagated to the previously registered SIGTERM handler. Bug: 895027 Change-Id: Ia6f84022ee4cf54e7dc36afad012acb3212b51e2 Reviewed-on: https://chromium-review.googlesource.com/c/1308753Reviewed-by:
-
James Hawkins authored
R=dpapad@chromium.org, hansberry@chromium.org Bug: 899324 Test: none Change-Id: I01b9786b3e5f49490660829bd1c3a7659e73f9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1306916 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604003}
-
Wez authored
- Expose WebContentRunner's constructor to derived classes. - Move the common Runner and Component implementations under "common". - Move the scoped service publishing binding into WebContentRunner. - Move the default web.Context creation helper to the WebContentRunner. - Rename the ComponentControllerImpl to WebComponent. - Rename WebComponent::RequestTermination to ...::DestroyComponent. Bug: 893229, 856416 Change-Id: Ia4b8036d5f1b6f00472d201b7cb9dcf063377122 Reviewed-on: https://chromium-review.googlesource.com/c/1301114Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604002}
-
Peter Kvitek authored
Process handle and cumulative CPU usage is returned for browser and all renderer processes. BUG: 899823 Change-Id: I6d44630df3ea9ef80bed17f30367dad929ecaa17 Reviewed-on: https://chromium-review.googlesource.com/c/1303074 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604001}
-
Sammie Quon authored
Test: none Bug: none Change-Id: Idf8dc27a75ccbf3040e0f5950565d1dc856cc9a8 Reviewed-on: https://chromium-review.googlesource.com/c/1306664Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604000}
-
Alexandr Ilin authored
Recent bug in GpuMemoryBufferHandle deserialization on Android (fixed in [1]) showed that there is no test coverage for seriazliation of native GMB, at least on Android. This CL adds a test checking serialization correctness for all subtypes of GpuMemoryBufferImpl. [1] https://crrev.com/c/1297469 Bug: 863011 Change-Id: I9688c1eed4b6dc7c5f2f7b1a20b08c2d62a35824 Reviewed-on: https://chromium-review.googlesource.com/c/1298209Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603999}
-
Tanja Gornak authored
In the new architecture Android will share most of the codebase with Desktop implementation. The queuing of the messages for the case when Chrome is in the background will be implemented separately, directly in the GCMDriver code on java side. (formerly desktop code) now compiles on Android, hence contributes to the binary size. After the invalidation feature fully launched, the significant part off previous implementation will be removed and binary size will be even smaller than now. Bug: 801985 Binary-Size: The significant chunk of the invalidation code Change-Id: I57009fd7cb83246305d06af13fb72c61fdae459f Reviewed-on: https://chromium-review.googlesource.com/c/1209583Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#603998}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7cba6be85a14..af9dd6080188 git log 7cba6be85a14..af9dd6080188 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 fjhenigman@chromium.org Fix UpdateAttribBindingByVertexAttribDivisor test. Created with: gclient setdep -r src/third_party/angle@af9dd6080188 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibf559a72661c4de1bb654229c41b0b2d8dc665b5 Reviewed-on: https://chromium-review.googlesource.com/c/1308176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603997}
-
Paul Miller authored
Create an empty "WebView Log Verbosifier" app. When installed, WebView will log all registered field trials and their assigned groups, for QA purposes. Check for the dummy app asynchronously, because PackageManager is slow. Skipping presubmit for LOG(INFO). BUG=892870 NOPRESUBMIT=true Change-Id: Ia4fee870aec84a60e9e70642405c5ff8b07da7cf Reviewed-on: https://chromium-review.googlesource.com/c/1266611 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the limit on the number of lines used to display the current version in the settings. Bug: 899700 Change-Id: Iab412b30c2e32f5212a05d8b799fdc4cd9777859 Reviewed-on: https://chromium-review.googlesource.com/c/1307439Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#603995}
-
Jimmy Gong authored
- SMB file sharing can still be disable through managed policies. Bug: chromium:896414 Test: end-to-end Change-Id: I4158249d14812a7e28a775af54cc6ed4ee35714f Reviewed-on: https://chromium-review.googlesource.com/c/1297640 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#603994}
-
Eric Aleshire authored
The glob statement in copy_trusted_certificate doesn't catch any simulators like I expect it to; I add a bunch of temporary logging so that I can figure out where it is failing. This only affects my WPR tests. Change-Id: I58e26deb41988d5a9ca2f75b090495aad99303f3 Reviewed-on: https://chromium-review.googlesource.com/c/1308574Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#603993}
-
Morten Stenshorne authored
Walking the ancestry during layout to figure out what size to use doesn't work in LayoutNG. Use the provided override size instead. Modified one test so that it would fail without this fix. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iac990aed33355ecd49d68cc51bd355d2139f3dcb Reviewed-on: https://chromium-review.googlesource.com/c/1307393Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#603992}
-
Owen Min authored
Disable tests on Mac10.12 and Win7 Bug: 899890, 891427, 626703 Change-Id: Iaf47b38dcf45f5fce734325450609a10a9c5d712 Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1308413 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603991}
-
Charlie Harrison authored
This is useful for debugging. Bug: None Change-Id: I8e6260f09b3c17f0a9952739387f70a431571011 Reviewed-on: https://chromium-review.googlesource.com/c/1308013 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603990}
-
Yuri Wiitala authored
This is a temporary code addition to help root-cause a rather elusive crash (see crbug for discussion). It: 1) adds extra checking of the AudioBus that, writing to, causes write access violations on Windows; and 2) adds crash key strings to expose lifecycle/event state leading up to the crash. Bug: 888478 Change-Id: Ie7866e69081623cac9833e59d0aaadf1671ad248 Reviewed-on: https://chromium-review.googlesource.com/c/1306656 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603989}
-
Owen Min authored
This reverts commit 199a6044. Reason for revert: NativeAppWindowCocoaBrowserTest.HideShowWithAppWithShim failed on Mac10.12 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16328 Original change's description: > MacPWAs: Decouple AppShimHost and AppShimHostBootstrap > > Update AppShimHandler::OnShimLaunch to take a AppShimHostBootstrap, > and use that to create an AppShimHost, rather than having the > caller create the AppShimHost. > * Have the method for AppShimHost creation be in the > AppShimHandler::Delegate class for overriding in tests. > * This sets us up to have the AppShimHost be created before the app shim > process has completed launching (and thereby be able to queue up > creating windows in the app shim process). > > Add to AppShimHandler::Host's public interface an OnBootstrapConnected > function, where the AppShimHandler::Host takes ownership of the app > shim process. > * This is currently always called immediately after the AppShimHost's > creation, but that will change in the next patch. > > Make the tests rely more heavily on the real classes instead of fake > stubs. In particular, I plan to remove AppShimHandler::Host as an > abstract interface because the tests cover much more ground when run on > the real test (and the one real implementation, AppShimHost, has no > other public methods). > > Make one subtle change in the tests. In the event of a duplicate app > launch, the app's windows will be focused by the existing AppShimHost, > because we don't create an AppShimHost in the event of any failure. This > has the same user-visible behavior (because the windows being focused > are the same). > > Bug: 896917 > Change-Id: Ideea05d00edc1bf4c11825e70ad44229b1174724 > Reviewed-on: https://chromium-review.googlesource.com/c/1305889 > Commit-Queue: ccameron <ccameron@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603821} TBR=ccameron@chromium.org,dominickn@chromium.org Change-Id: I1e60835172d2eac0e402b4de142d16e1edf54dc9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896917 Reviewed-on: https://chromium-review.googlesource.com/c/1308664Reviewed-by:
-
Eric Karl authored
This change adds a feature, EnableGpuRasterizationViewportRestriction, which, when disabled, allows us to enable GPU raster for all content independent of the viewport trigger. TBR=chrishtr@chromium.org, as pdr has reviewed, but owns the .h but not .cc part of features.* Bug: 899399 Change-Id: I986d6e40d93f149cb2d5fc11758ca8b3f0bc1a89 Reviewed-on: https://chromium-review.googlesource.com/c/1303397 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603987}
-
Xida Chen authored
In our previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1066630 We fixed the problem where an element with transform animation and fill-mode being 'forward' or 'both' should be containing block. This CL adds test to ensure that the style has IsStackingContext = true in those cases. Bug: 764783 Change-Id: Ib110c52f3afd5f68028569c528145162b4c48ed1 Reviewed-on: https://chromium-review.googlesource.com/c/1299203Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603986}
-
Gaurav Dhol authored
base/files/file_win.cc(276,40): error: non-constant-expression cannot be narrowed from type 'int' to 'BOOLEAN' (aka 'unsigned char') in initializer list Bug: 893460 Change-Id: Iab503865c0478c36d70fb8b7b9def152f70cfb7f Reviewed-on: https://chromium-review.googlesource.com/c/1301576Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfe69cae695e..2bc2ea919048 git log dfe69cae695e..2bc2ea919048 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 fmayer@google.com Merge "Bump libunwindstack version." Created with: gclient setdep -r src/third_party/perfetto@2bc2ea919048 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4b4191f6a6e92b1adea58070c22782d4bda64412 Reviewed-on: https://chromium-review.googlesource.com/c/1308175Reviewed-by:
-
Willie Koomson authored
This change adds memory footprint information for Arc processes into the chrome task manager. ArcProcessService requests a global dump from Android, and upon receipt provides it to the task manager (through ArcProcessTaskProvider) BUG=799538 TEST=Manual, compared memory footprint in task manager to top Change-Id: I5e10ba05e28185de750b6deb2f46d9227d4cc751 Reviewed-on: https://chromium-review.googlesource.com/c/1263335 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#603983}
-
