GitLab

TEST=manually run through release workflow and verify api endpoints return success.
BUG=none

Review URL: https://codereview.chromium.org/417703002

Cr-Commit-Position: refs/heads/master@{#292021}

until we fix the problem. rjshade is looking into the flakiness in the
internal source tree.

R=rch@chromium.org, rjshade@chromium.org
BUG=407756

Review URL: https://codereview.chromium.org/488233004

Cr-Commit-Position: refs/heads/master@{#292020}

An older implementation of the safe-browsing database code injected
prefixes when receiving full hashes, due to an incorrect reading of how
full-hash matches should happen.  Current code checks the full hashes
and prefixes independently, so the duplicate prefixes are no longer
generated.  This code removed duplicate prefixes found in existing
databases.  99.99% of runs over the past two weeks have not removed any
such duplicate prefixes.

In the current code hitting a full hash has the same end result as
hitting a prefix, so the primary downside of removing this code is
slight excess storage.  Insofar as full hashes are deleted by sub, there
may be stale prefixes left behind.  The stale prefixes will be deleted
when the chunk in question is deleted.  The result may be a small number
of unexpected gethash requests which will return misses (and thus not
affect the browsing experience other than adding a little latency).

BUG=361248

Review URL: https://codereview.chromium.org/507653003

Cr-Commit-Position: refs/heads/master@{#292019}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503253003

Cr-Commit-Position: refs/heads/master@{#292018}

Add a switch to enable it. This feature would fix the problem when a large notification moves downwards, it is partially obstructed.

asvitkine: Please review histograms.xml

BUG=

Review URL: https://codereview.chromium.org/493303002

Cr-Commit-Position: refs/heads/master@{#292017}

We're seeing the dbg builder have pending jobs so this should help reduce that.

BUG=109173
R=sky@chromium.org

Review URL: https://codereview.chromium.org/506273005

Cr-Commit-Position: refs/heads/master@{#292016}

Clear internal state information about a pending suspend attempt when
the power manager restarts to prevent chrome from sending bogus messages
to the new power manager.

BUG=none
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/507803002

Cr-Commit-Position: refs/heads/master@{#292015}

Instead of a hardcoded port that could be taken.

BUG=

Review URL: https://codereview.chromium.org/502503003

Cr-Commit-Position: refs/heads/master@{#292014}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506083002

Cr-Commit-Position: refs/heads/master@{#292013}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/511473002

Cr-Commit-Position: refs/heads/master@{#292012}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506093002

Cr-Commit-Position: refs/heads/master@{#292011}

Checking for existence of TopSites.

BUG=407527

Review URL: https://codereview.chromium.org/507653002

Cr-Commit-Position: refs/heads/master@{#292010}

It causes problems when running multiple Telemetries in parallel in
certain environments and also causes problems with certain devices.

BUG=

Review URL: https://codereview.chromium.org/499073005

Cr-Commit-Position: refs/heads/master@{#292009}

Allow the browser to Send messages to an embedded worker once the script as been loaded without having to wait for the initial eval to complete.

BUG=405701

Review URL: https://codereview.chromium.org/489253002

Cr-Commit-Position: refs/heads/master@{#292008}

Rolled src/tools/grit
    from revision 6a46b04d35eade32b1270392317dca516c9dd56d
    to revision 206c6aa4450db4e961d20f8367f33df42bba6a85

Summary of changes available at:
    https://chromium.googlesource.com/external/grit-i18n/+log/6a46b04d35ea..206c6aa4450d

BUG=333201

Review URL: https://codereview.chromium.org/502083003

Cr-Commit-Position: refs/heads/master@{#292007}

This brings in:
02e6ca4  Fix compile on mac: format string mismatch error.
1b04ea3  Set m_pLinearized to NULL after release
a3c7215  Perform better input checks in early steps of parser.
1dfbe60  Use number of components from ICC profile and alternate color space
187483a  Add GetValidBpc() check in CPDF_DIBSource::CreateDecoder()
c2442f9  Add GetValidBpc() check in CPDF_DIBSource::GetScanLine
a550e4c  Revert of Use number of components from ICC profile and alternateCS (patchset #1 of
c655167  Fix the issue 'SEGV on unknown address in CPDF_DataAvail::GetObjectSize'
aeacba4  Fix a hang issue due to inconsistent page number in the test file
02132dc  Bounds check in CFX_Font::LoadGlyphPath().
48f26c5  Fix confusion between length in bytes and length in characters in app::response().
e9bf0e9  Don't stretch bitmaps if destination size is empty.
ee6088e  Check the number of component in ICCBased colorspace
4fb24f3  For pattern colorspace, its base colorspace should not be a pattern colorspace
8f2c3dc  Check if user provided more than one option for pdfium_test.
93d0811  Fix bug in CPDF_PageContentGenerate constructor and destructor
8cf33bc  Fixed command line parting when no output is needed.
2d55db1  Font is used after release in CPDF_TextStateData::~CPDF_TextStateData
39a97ea  Fix a double-free issue in CFX_PathData::~CFX_PathData
a94019d  Check path point count overflow in DrawThisAppearance
91177a4  Add a null check before getting unicode text in CPDF_FormField::GetValue
4f38edb  Add a null pointer check before getting the family name of the given color space in

TBR=thakis@chromium.org
TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/494063003

Cr-Commit-Position: refs/heads/master@{#292006}

BUG=380961, 380962

Review URL: https://codereview.chromium.org/469613002

Cr-Commit-Position: refs/heads/master@{#292005}

TextInputClient returns a BrowserFrameAsh is the omnibar is clicked, and RenderWidgetHostViewAura if a textfield on the page is clicked. We always want to resize BrowserFrameAsh.

TEST=WorkspaceLayoutManagerKeyboardTest.ChildWindowFocused
BUG=407094

Review URL: https://codereview.chromium.org/504793003

Cr-Commit-Position: refs/heads/master@{#292004}

Converts input dependencies for binary targets to be order-only, rather than implicit. See added comments in the patch for reasoning behind this.

Long ago this was order-only, which is not correct for actions (which might directly depend on the output of previous actions). So I changed them to be implicit, which then caused unnecessary rebuilds. This change makes actions and binary targets behave differently. Actions remain implicit, binary targets are order-only.

Add unit test for input deps on binary targets.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/505353002

Cr-Commit-Position: refs/heads/master@{#292003}

We may want to watch a more targeted set of files, but the whole thing
is too much.

TBR=alexst

Review URL: https://codereview.chromium.org/513463002

Cr-Commit-Position: refs/heads/master@{#292002}

Review URL: https://codereview.chromium.org/503853002

Cr-Commit-Position: refs/heads/master@{#292001}

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/503973002

Cr-Commit-Position: refs/heads/master@{#292000}

This is part of the battery auditing feature, which will be surfaced in the Website Settings options page in the next patch.

BUG=372598

Review URL: https://codereview.chromium.org/472383002

Cr-Commit-Position: refs/heads/master@{#291999}

BUG=401187

Review URL: https://codereview.chromium.org/447863003

Cr-Commit-Position: refs/heads/master@{#291998}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/511483002

Cr-Commit-Position: refs/heads/master@{#291997}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503363003

Cr-Commit-Position: refs/heads/master@{#291996}

Send idle notifications for V8 to do garbage collection after
the commit. Behind a flag until V8 side of implementation is
complete and tested.

R=brianderson@chromium.org,skyostil@chromium.org,hpayer@chromium.org,danakj@chromium.org
BUG=

Review URL: https://codereview.chromium.org/429393003

Cr-Commit-Position: refs/heads/master@{#291995}

BUG=374763
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/502173002

Cr-Commit-Position: refs/heads/master@{#291994}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505293002

Cr-Commit-Position: refs/heads/master@{#291993}

Utilize the new gl_helper functionality to capture GestureNav screenshots
in grayscale, which drastically improves screencapture performance,
especially on hardware configurations with expensive RGBA readback.

Part 1: https://codereview.chromium.org/388953002/
Original review: https://codereview.chromium.org/384453002/

BUG=379983, 380779

Review URL: https://codereview.chromium.org/389683002

Cr-Commit-Position: refs/heads/master@{#291992}

R=estade@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/501153005

Cr-Commit-Position: refs/heads/master@{#291991}

After we load a <webview>, setting its display to "none" removes the
plugin <object> from the render tree. If we set the display back to "",
we need to properly detect the case and allocate new instance id
and call attach to make things work.

The problem is briefly described here:
https://docs.google.com/a/chromium.org/document/d/1ITPOxS97DsG1HkbTAlpH0YcaTXKZNYUs84p1MppaHg0/view

BUG=399060
Test=Load a <webview> in a chrome app. See it render.
Set <webview>.style.display = 'none', see it go away.
Set <webview>.stlye.display = '', see it render properly.

Review URL: https://codereview.chromium.org/440463002

Cr-Commit-Position: refs/heads/master@{#291990}

- Add a check for whether or not the favicon is valid before caching it
- Still return an invalid favicon (will be default)
- Updated caching logic a bit to be more robust

BUG=

Review URL: https://codereview.chromium.org/496733005

Cr-Commit-Position: refs/heads/master@{#291989}

Change API to match protocol that may allow sticker authentication
for devices. The PIN will not necessarily be available at provision
time, and the client will need to send a user-typed PIN at
code verification time.

BUG=

Review URL: https://codereview.chromium.org/468613003

Cr-Commit-Position: refs/heads/master@{#291988}

1. For DEPS file parsing, switching from svn to git.

2. For output of testcase https://cluster-fuzz.appspot.com/testcase?key=5097237064450048, now it is:

Lines 1103-1112 of file ThreadState.cpp which potentially caused crash are changed in this cl (frame #2, function "blink::ThreadState::performPendingSweep()").

Lines 1120-1136, 1170-1174 of file Heap.cpp which potentially caused crash are changed in this cl (frame #0, function "blink::ThreadHeap<blink::FinalizedHeapObjectHeader>::sweepNormalPages(blink::HeapStats*)"; frame #1, function "blink::ThreadHeap<blink::FinalizedHeapObjectHeader>::sweep(blink::HeapStats*)").
Minimum distance from crashed line to changed line: 0. (File: ThreadState.cpp, Crashed on: 1100, Changed: 1100).

NOTRY=true

Review URL: https://codereview.chromium.org/504443004

Cr-Commit-Position: refs/heads/master@{#291987}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/504273002

Cr-Commit-Position: refs/heads/master@{#291986}

SessionService::GetLastSession used a base::Unretained but there was
no guarantee that the SessionService would be valid by the time the
callback was processed.

BUG=399655
TEST=covered by test now
R=marja@chromium.org

Review URL: https://codereview.chromium.org/500143002

Cr-Commit-Position: refs/heads/master@{#291985}

NOTRY=true

Review URL: https://codereview.chromium.org/504503002

Cr-Commit-Position: refs/heads/master@{#291984}

Revert of Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages (patchset #2 of https://codereview.chromium.org/502233002/)

Reason for revert:
The fix (https://src.chromium.org/viewvc/blink?revision=180854) should be included by the Blink roll in http://crrev.com/ecb9875276ccd.

Original issue's description:
> Suppress an uninitialized read in ThreadHeap<>::sweepNormalPages
>
> BUG=407396
> NOTRY=true
> TBR=ager@chromium.org
> NOTREECHECKS=true
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/8da39ba

TBR=ager@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407396

Review URL: https://codereview.chromium.org/507833002

Cr-Commit-Position: refs/heads/master@{#291983}

Allow the ContentViewRenderView to request composites if UX components require it.

BUG=387177

Review URL: https://codereview.chromium.org/504553002

Cr-Commit-Position: refs/heads/master@{#291982}