- 27 Jul, 2020 40 commits
-
-
Peter Wen authored
Allow linting with a minSdkVersion that is different that the current APK/Bundle's min_sdk_version. This paves the way for using a single unified target for most lint runs. e.g. monochrome_public_bundle can set lint_min_sdk_version to 21 so that it lints against a lower minSdkVersion than its min_sdk_version (24). Bug: 1108791 Change-Id: I703d1ef19f7fc9182f52bc6ef0ae8535c024b10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316334 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791925}
-
Geoff Lang authored
Bug: chromium:1100599 Change-Id: I6c41ad568d09ffba4ddf2edd4ea2d0a44d047cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307656Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#791924}
-
Devlin Cronin authored
Update remaining tests under //content/browser/portal to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I7618db78b2d55c9919e91ab4c2c7ff7f9589e827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316449Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791923}
-
nancylingwang authored
When clicks the launcher button, AppServiceAppResult is created for each app, and call LoadIcon, which could genearte mojom calls to load the icon. Remove SweepReleasedIcons when the view is closed to keep the icon cache in IconCache. When the app is removed or the icon is updated, call RemoveIcon to clear the map in IconCache. BUG=1104650 Change-Id: I6f5bfb44c9892187976f89ecb3993430fb565f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318486 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#791922}
-
Adithya Srinivasan authored
This reverts commit ffc377fd. Reason for revert: Suspect that this CL is causing All/DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxNext/uia and All/DumpAccessibilityEventsTest.AccessibilityEventsListboxNext/uia to fail (https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/69290) Original change's description: > Fire UIA SelectionItem events on aria-checked changes for radio buttons > > According to the following spec radio and menuitemradio should expose > UIA SelectedItem.IsSelected when aria-checked is set : > https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table > > This CL ensures that radio / menuitemradio fire appropriate > SelectionItem events, and whenever a SelectionItem changes its > selection state that we also fire a Property Changed event for > SelectionItem.IsSelected. > > AX-Relnotes: Fire missing events for ARIA radio/menuitemradio when aria-checked changes. Narrator will now announce selected state changes for this scenario. > Bug: 1102580 > Change-Id: I72f479e25f61b0ddffc28f73d4a9c34e8dc4ecb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212982 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#791802} TBR=nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,iapres@microsoft.com,Adam.Ettenberger@microsoft.com Change-Id: I3b387e3202afb366f0f64671270524c4792e12ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321113Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791921}
-
John Lee authored
Fixed: 1098542 Change-Id: I44d2ea06756939a4d60d533b90d40c57e9e09a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318307Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#791920}
-
Pete Williamson authored
When we added the explore surface, we did not also override the navigateToHelpPage method. This change adds an override to fix the "Learn More" feature of the discover feed. The web page we direct the user to is for the NTP, reviewers might want to check that it still makes sense for the explore surface as part of this code reivew. Bug: 1106875 Change-Id: I45c572a5fc75e28bcc927d0625dd6179f6fafd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315184Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#791919}
-
Wei Li authored
Change the type of a menu separator to a property which can be set separately. Also add some basic unit tests for this class. Bug: 1108460 Change-Id: I7201e2b22c56e0b5efa366758bd217bba15ede10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314658 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#791918}
-
Richard He authored
Use vpython for `generate_gradle.py` and `list_java_targets.py` Change-Id: I39bb601add8cc1c019a3aab9bca60bee0e341084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315400 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Update tests under //chrome/browser/pdf to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I03badfdb5956066553b4d6d278aae6b34ad94715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316702Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791916}
-
Devlin Cronin authored
Update remaining tests under //chrome/browser to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: Ib6da6799bb906b7547ab8d4fce4066a0a976df24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316948Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791915}
-
John Lee authored
Bug: 1084620 Change-Id: Idde2fe2bc1ce4f387a20a00d01aa7c8ba13354a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311039 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791914}
-
Sophie Chang authored
Bug: 1108891 Change-Id: I627b0ca7aa08dbe3717654ff6ba1cb9233237540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316324Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791913}
-
Guillaume Jenkins authored
In preparation for bringing Chrome Browser Cloud Management to iOS, this adds a command-line switch to control whether CBCM is enabled. It needs to be a command-line flag because policy infrastructure is initialized before Finch / about flags and field trials. Bug: 1066495 Change-Id: I0bd27e5ee863deda949afa64b248ca5445f9ef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316620 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791912}
-
Liviu Tinta authored
Because word is highlighted the cursor position is lost. The fix moves highlighting after code knows if the event was 'preventdefaulted'. Bug: 1076078 Change-Id: I08ebece22beee7cc71dd6e8241cb42f7be2e0331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183174Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#791911}
-
Ian Kilpatrick authored
TBR: atotic@chromium.org Bug: 1108224 Change-Id: I29901956f130097aec56b1f37def05595c59664f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318550Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#791910}
-
Lijin Shen authored
Update email address in presubmit warning message Bug: 1109248 Change-Id: If55f0651bf1606a596dfb65733d01d23411e7db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317845Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Alexei Svitkine authored
Bug: None Change-Id: Id0981a264b247208a78ba0cddad59166528c53fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304974 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791908}
-
David Benjamin authored
Instead parent the sheet to the specified gfx::NativeWindow directly. This avoids a host of bugs around the native constrained dialogs machinery, but does mean the dialog is now window-modal rather than tab-modal. On Windows, where we also use the native dialog, the sheet is similarly window-modal and the certificate viewer only ever opens in response to the user clicking in browser-owned UI or DevTools, so there shouldn't be an abuse concern. See https://crbug.com/1098786#c4 Bug: 762915, 1078158, 1098786 Change-Id: Iafeee58fd04aff9f8b88e8c2f030fe18913f81f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313160Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#791907}
-
Ben Kelly authored
Previously BlobBytesConsumer would read the BlobData object by first create a DataPipeGetter and then passing the resulting pipe to a FormDataBytesConsumer. The FormDataBytesConsumer would then internally use a DataPipeBytesConsumer to read the pipe. This CL attempts to simply things by having BlobBytesConsumer use a DataPipeBytesConsumer directly. In addition, it uses BlobData->ReadAll() avoiding the need to create a DataPipeGetter. This removes one mojo call. Bug: 1076081 Change-Id: I0f270cd99c9808c85d43523ac700aafe75d49c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171017Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#791906}
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves PreviewsState from content/public/common/ to blink/public/common/. In addition, this merges WebURLRequest::PreviewsState into that. Notable changes in this CL: - PreviewTypes enums define both FOO_BAR and kFooBar styles to avoid non-essential diffs. FOO_BAR is used for the content side, and kFooBar is used for the blink side. Follow-up CLs will merge FOO_BAR into kFooBar. - This CL adds a new dependency rule in component/previews/content/DEPS to allow to include blink/public/common/previews_state.h from there. Change-Id: I5ce7e8bb844416ac2482143665925e08b7858746 Bug: 860403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319489Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#791905}
-
Evan Stade authored
Bug: 1097216 Change-Id: Ibdb9a50ea5f6a7313bd65f45cf9bd38744eb9469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317685Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#791904}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595789207-a5f1c4250bc5f6d42bdf1b980d8df879d82cd223.profdata to chrome-win32-master-1595851043-c14119a80137ce7090e196461287429806779e74.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id4a39f0baf4669bf2233c14ea24208e3fe4eb4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791903}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60cbf70944cf..4fd830acab6f 2020-07-27 landrey@webrtc.org Add possibility to adjust frames before comparison in pc level tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I05f3f0b46f26c18e8755e1f1e24387e8ff5273ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320043Reviewed-by:
-
arthursonzogni authored
A python server is used has a communication channel in between documents from different browsing context group and potentially cross-origin. There are two methods: - one for writing a message. - one for reading the message. I initially supposed we won't need to store more than one message in the stash. It turns out there are tests doing two write in a row without any read in the middle. It was throwing an exception when this happened. This patch makes the server to maintain a queue of messages instead. It doesn't throw errors anymore. Bug: chromium:1109194 Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791901}
-
Adithya Srinivasan authored
Bug: 1109714 Change-Id: If2ed226e624c78a97c8a7fe5434520464295eba9 No-Try: True Tbr: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320129Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791900}
-
Luis G Garcia authored
Update README.chromium to include instructions on creating a cloud bucket such as "chromium-webxr-test". Change-Id: I0e3e575be60d35436246dc6e67eb8cb104742552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314198Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Luis Garcia <luisggarcia@google.com> Cr-Commit-Position: refs/heads/master@{#791899}
-
Marc Treib authored
The original plan was to put all account-storage-related code into such subfolders, but that hasn't happened, and this factory was in fact the only thing in such a subfolder. So for consistency with all the other code, move it out of the subfolder as well. Bug: none Change-Id: I5dcccbb960203cafd46f13460ad784b1ca6de85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317962Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#791898}
-
Richard Coles authored
This reverts commit e44d3738. Reason for revert: It looks to have been necessary after all; crbug.com/1107830 Original change's description: > webview: don't use UI thread pool unnecessarily. > > Just use the general pool at best-effort priority for logging command > line and field trials during startup, since it doesn't need to be on the > UI thread. > > Change-Id: I73dfb14ae67bcc953fa7c90b5840354d5b4a84b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302946 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789538} TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Fixed: 1107830 Change-Id: If9f8038787cc0a16377aca599cbcb18efa055463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316414Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#791897}
-
Tanmoy Mollik authored
The parent cl should fix the failure Bug: 1102296 Change-Id: Iea806b0dc067a2966651482c112845d6c2be4c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317189Reviewed-by:
-
Nodir Turakulov authored
This builder is superseded by metadata-exporter builder. Depends on https://chromium-review.googlesource.com/c/chromium/tools/build/+/2313785 Bug: 1106176 Change-Id: Ia391aea0fc36fb55260f1289d30b789f23fb02a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314032Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791895}
-
Olivier Robin authored
After discussion with chrome-privacy, this can be enabled for users who have opted-in UMA. Bug: 1017434 Change-Id: I140dac0327206846127be4befa3e6c9fca8780fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292510 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#791894}
-
Maksim Sadym authored
Move IdleManager to RenderFrameHost for better isolation of simulating Idle Status. Bug: 1090802 Change-Id: Ia0e3ca436e612aaba29dc9880c69ae54305f13d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308722Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#791893}
-
Justin Cohen authored
Bug: 672917 Change-Id: Ie28e6de56bcfea09bf9462236665c31497e2494b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311116 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Mark Brand authored
https://chromium-review.googlesource.com/c/chromium/src/+/2302609 revealed that the dependencies are broken for the MojoLPM bindings generators. Suspect that this is also the root cause of the linked bug Bug: 1108739 Change-Id: I1cac1fbf2a2cc139f972f7e6e605bd4a70323c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315340Reviewed-by:
-
Kyle Horimoto authored
Provides a simpler mechanism for checking whether the associated flag is enabled. Bug: 1106937 Change-Id: I7b54cae69f52d25ea6aa50843ab2e0b7e88ed7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317768Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#791890}
-
Leonard Grey authored
This reverts commit 33253a15. Reason for revert: Broke PWA content fullscreen https://crbug.com/1109608 Original change's description: > Mac: modernize menu reveal tracking > > The fullscreen toolbar controller currently uses undocumented Carbon > events to track the menubar's reveal amount in fullscreen. In recent > macOS versions, the intermediate values are no longer send and we > only receive events when the menubar is fully shown or fully hidden. > > The Mac immersive code which is still behind a flag uses a different > technique, observing the reveal amount on a hidden titlebar accessory > view. This *does* provide correct intermediate values. > > This change extracts the reveal code from the immersive controller > and uses it in the current fullscreen code rather than the Carbon > event. Unfortunately, despite receiving the correct progress > notifications, the topchrome still does a discontinuous jump, but > we'll cross that bridge later. > > Bug: 1063417 > Change-Id: I6827cafbcad58eeaabf98c6facaeb85ce3439997 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314998 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791273} TBR=avi@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1063417 Change-Id: Ie70a1ce26feddaa6aec2e0f061b8dd7656fcf55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320409Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f23e4df5..2f54b1a2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If7c449219f01f3304d184bded2e8d3e7f34edf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320348Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791888}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84ab9b3dd3ae..f2780c629ddc 2020-07-27 hjd@google.com Merge "Investigate SaveTraceIntoDropboxAndIncidentOrCrash" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icc6d3b45d0c355afece4410dc436bb3a22c57c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320037Reviewed-by:
-
sauski authored
Create a generated preference to support the Password Leak Detection toggle within chrome://settings/security. This toggle has additional behavior based on profile state that currently requires additional front-end JS logic. This CL recreates this logic within C++ code and exposes it via a generated preference. Bug: 1063265 Change-Id: Iacf35ae323bfb22fbc24702e369bee866babb982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283610Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#791886}
-
