- 18 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09729d2ecf49..12971a22d265 2021-01-18 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-18T04:03:42). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I11d59b40548f0b3fd4dc8654f986c999b9e348b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844465}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4cc12ef65f56..a9f40de95873 2021-01-18 alexrudenko@chromium.org Round contrast ratio down If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166128 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba6c8b1511b2a171e41b59957c805851f4278e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635214Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844464}
-
Hitoshi Yoshida authored
In web tests, TestRunner checks if a test can finish successfully using the main window's main frame, and it is searched from a list of main frames. Internally, JavaScript code which tries to finish tests is invoked from CommitNavigation. But when we use back/forward navigation with BFcache, we update the list of main frames through OnFrameReactivated in OnFinishNavigation, that is called after CommitNavigation. This order makes frames' state inconsistent and tests fail with timeout. This CL moves the call of OnFrameReactivated into ReadyToCommitNavigation, which is called before CommitNavigation, and makes frames' state in the renderer consistent. Bug: 1150297 Cq-Include-Trybots: luci.chromium.try:linux-bfcache-rel Change-Id: Ib87a2d1c604e0013d3d93d5d679583e196d44eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581621 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844463}
-
Dominic Battre authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2627369/ as AutofillAccessibilityTest.TestAutofillState is still flaky. R=koerber@google.com Bug: 1162484 Change-Id: I564cad803d3950e8b156d28cbddb57e1625b5708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632952 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844462}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I28070ab41d0bf184f6c94ba7cf071d7ad74c5ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634823Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844461}
-
Alan Cutter authored
This CL makes the "capture_links": "navigate-existing-client" web app manifest setting open in scope navigations in existing web app windows. If no app window is open at the time a new one is opened (the same as "new-client"). This behavior is hidden behind the WebAppEnableLinkCapturing flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=485126&signed_aid=HbGtkKbvjuetuLqwFguItA==&inline=1 Bug: 1163398 Change-Id: I1bc673b2dc019b9ba9113ce71d2bbbdabac865b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635463 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844460}
-
Wanming Lin authored
setTimeout(..., 0) is clamping up to 1ms for historical reasons: crbug.com/402694, and the issue has been open for years which was blocked by the challenge of updating all test expectations accordingly. Chrome doesn't need the clamp for anything in particular and no 1ms clamp in the spec, moreover, we found Speedometer2 performance can boost ~1% on Windows without it based on Pinpoint perf. Most failure tests failed with this change had been fixed in separated CLs. Bug: 402694 Change-Id: I46196584b887513ca520221be68099116931d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578703Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#844459}
-
Miriam Polzer authored
Bug: None Change-Id: I6d6ca83fd518b9d455a16b44b8d068edfac0e613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621814 Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Arman Uguray <armansito@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#844458}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/26a84431ff72..1bb49a870088 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from aedd133cd85f to 149733cead63 (2 revisions) 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 50c82f42e33f to 68635b431b3c (24 revisions) 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e330bc98 to 1d3066a6 (498 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*real_gangster_crime* Change-Id: Ibb3faafe1eba3415e54aea1284d7367f063f0800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844457}
-
Yunke Zhou authored
Bug: 1159869 Change-Id: I503392bd82e8dd2f7a324da5df3b16ad07e76412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621756 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#844456}
-
Jérémie Boulic authored
In //ui/file_manager/image_loader/: - cache.js - cache_unittest.js - image_loader.js - image_loader_unittest.js - image_loader_util.js - image_request_task.js - piex_loader.js - scheduler.js - scheduler_unittest.js Bug: 1133186 Change-Id: Id23e03c916590830be342b2fda99e5701610a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631398 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#844455}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610926940-efa0e5121c3539a29c4cc2a8e2e370b1761f139f.profdata to chrome-mac-master-1610948968-472c5c5ed4005e92cd456548bcb91e146ae8a09f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab69ad070de1d8f7545ad81359405483301dab54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635213Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844454}
-
Harvey Yang authored
Supporting multiple sensor clients in FakeSensorService simplifies some unit tests of disconnections. BUG=b:172208566, b:172414302 TEST=unit tests Change-Id: I77ccbc79760e2a3833de6d39fadf4d5e00a4001b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631390Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844453}
-
Angela Gyi authored
This CL adds two stub classes (which are later to be extended) for the content previews feature on Chrome OS devices. Bug: 1167016 Change-Id: I380065471db7a6d123f7110f0d42bac122f782bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631548 Commit-Queue: Angela Gyi <angelagyi@google.com> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844452}
-
Glen Robertson authored
Seems to be possible on shutdown. For more context see attached bug. Also switched scoped_observ{er->ation} because we always observe a single source (no functional change here). Bug: 1167491 Change-Id: I675f0bc57abe7067960500a7e6607be3f7b8d36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631979Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844451}
-
Hiroki Nakagawa authored
A page that has a pop-up window should not activate a prerendered page. This behavior was already implemented by the previous CL (https://crrev.com/c/2560362). This CL adds a browser test for the behavior. Bug: 1138723 Change-Id: I205daba93d6998f03047f19aa5eb149e1dc6eb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635381 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#844450}
-
Gyuyoung Kim authored
crrev.com/c/2631705 removed the read of |text_track_text_color|. This CL restore to read the varialble in WebPreferences StructTraits. Bug: 1097943, 1166690 Change-Id: I1695551bc8eabe39bc8f129471a519af1ae42b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631557Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#844449}
-
Glen Robertson authored
As recommended by clang-tidy on crrev.com/c/2626814 Change-Id: Id895aa84ac23f7c1435da869047b38ed84d4e648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631816 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a799f6c37d4d..26a84431ff72 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 5a6fda1a6fcc to 04772515a8b6 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ic11ca0010db315a69223dbfb53a9e3085159a32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844447}
-
Kent Tamura authored
The logic of TruncateLineInTheMiddle() doesn't work well if the width of :after and/or its margins are saturated. After this CL, the function does nothing for such cases. This CL also adds a stream printer for NGLogicalLineItem. It's helpful to debug NGLineTruncator. Bug: 1162727 Change-Id: Ida603bd2a0e6e44df98cd49904da2b8f9b56d597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631551 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#844446}
-
Miras Myrzakerey authored
Currently, we're using only WebBundle token when matching a request with WebBundleHandler in NetworkService. For extra security, this change adds Renderer Process ID alongside WebBundle token as key in request matching. Bug: 1149255 Change-Id: I5521da6a1e7e03bc1f6d16683098982dfd054e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633486Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Miras Myrzakerey <myrzakereyms@google.com> Cr-Commit-Position: refs/heads/master@{#844445}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610926940-766c3e5956135ee07febf932ba294a3e6c0c02e3.profdata to chrome-win32-master-1610938647-590bb4866453137a0c0e295798fa59fea03a855f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8400001439268645b915d3b4e99bca79f8b72b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844444}
-
mlcui authored
Bug: None Change-Id: If4f49fc247f9d5086b370a12e2c441f5660567c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633484Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#844443}
-
Nancy Wang authored
This reverts commit b9a6819e. Reason for revert: <INSERT REASONING HERE> Fix the browser tests. Original change's description: > Revert "Add browser tests for AppLaunchHandler." > > This reverts commit dd223e70. > > Reason for revert: these tests have been failing constently on MSAN builders > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests > > Original change's description: > > Add browser tests for AppLaunchHandler. > > > > Add browser tests for AppLaunchHandler to verify the restoration > > process. > > > > BUG=1146900 > > > > Change-Id: Ibeaf262080a24c680718888ee081cc62c5b21a3a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619245 > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843901} > > TBR=xiyuan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org > > Change-Id: Icc6cc9ccbf6fcb0759bf2d03efd2d25a31d90d44 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1146900 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632606 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844015} TBR=xiyuan@chromium.org,apotapchuk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Bug: 1146900 Change-Id: I3b6706aa4dba74e8cf84426cc68cbf065e70748b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633481Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844442}
-
Alan Cutter authored
Only the Keep Chrome app was listed, this CL adds the Keep web app ID in preparation for Keep's migration over to a web app. Bug: 1167610 Change-Id: I69f4cc750d5733f4c4668458b2c0ec42b3649e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635243Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#844441}
-
Kenichi Ishibashi authored
Before this CL there was a mojo message validation error as a response of ReadData() is defined as non-nullable data pipe handle but ServiceWorkerResourceReaderImpl could return an empty handle when creating a data pipe fails. Allow a null handle since there isn't nothing for ServiceWorkerResourceReaderImpl to do anything other than returning an empty data pipe handle when creating a data pipe fails. Bug: 1156082 Change-Id: I1761db595bcc30665d0dcdf5c417f8f6dbcc173b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631817Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844440}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dfd9bdfd6567..beea40504747 2021-01-18 syoussefi@chromium.org Reland "Vulkan: Generate gl_Position.z correction in SPIR-V" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ic75ea7e97da2254d570a0d448542114fa6030271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844439}
-
Tal Pressman authored
Now that the ExecutionContext is on LocalDomWindow and not Document, it should _always_ notify listeners when it is destroyed. The CL also removes ObserverSetWillBeCleared() since it is only ever right before the context destroyed notification. Change-Id: Ia7fe39e23d0d029aa13ddb6a960638b69540d69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599781Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#844438}
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and adding BUILDFLAG(IS_CHROMEOS_LACROS) to defined(OS_LINUX) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. It also renames chromeos_is_browser_only with is_chromeos_lacros which was a gn var introduced to be used in place of chromeos_is_browser_only. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: Ic26b3db620b45e27e4f28e35a4015e08f4f2c6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631389Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844437}
-
tby authored
This is a run of proto_export.py plus minimal code changes to handle the deprecation of the ChromeUserMetricsExtension.structured_event. A follow-up CL will update the code to use the replacement field. The proto_export.py script also didn't delete structured_event.proto, so I've done that manually. Change-Id: I0ac699c1ef399674d9b3a92d41747076093f307c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631646 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844436}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb01823177ba..4cc12ef65f56 2021-01-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie6a9eb2d1ea390dd1959a8fe7c1cc000384a8633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844435}
-
Caitlin Fischer authored
The study is for only old versions. The feature seems to have launched. It's enabled on TOT. Bug: 1126640 Change-Id: I7519f2108740f93ea6604199b64f40970d281f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633721Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844434}
-
David Lei authored
Change-Id: I625f0d31f4764cc7e27d7e01611c41a6aa425e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635262Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Patti <patricialor@chromium.org> Auto-Submit: David Lei <dlei@google.com> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#844433}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I048f5e4f712550b844aaa86567b0303a76273df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633359Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844432}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I8bbb27d84ecfbcfa86e9fb637de69355ee9868a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601021Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#844431}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610914624-1610bdc5daba5cf1ff86cf3e029c4f349896fc4e.profdata to chrome-win32-master-1610926940-766c3e5956135ee07febf932ba294a3e6c0c02e3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9226fac044b93f112267e2f66a091f85d68e3930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844430}
-
Eugene But authored
Bug: None Change-Id: Ided81f2161892875e6af8b2d897dedc1ba2bb1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633977 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844429}
-
Eugene But authored
Bug: None Change-Id: Ic03331bde00cc1d23f12b98800a74e87eba3073c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633848 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844428}
-
Eugene But authored
Bug: None Change-Id: I5a6f5afaf8892abb49b59dc15dbfa4c29b6a31f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633847 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844427}
-
Eugene But authored
Bug: None Change-Id: I9463f5c2717d5e5227d8873129fbd5a78e07afc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633966 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#844426}
-