- 03 Mar, 2018 40 commits
-
-
Marijn Kruisselbrink authored
Bug: 813046 Change-Id: Ie8775a418059b5c69dd47ea06668101e69f6ee72 Reviewed-on: https://chromium-review.googlesource.com/939714Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540730}
-
Robert Iannucci authored
Bug: 818054,818230 Change-Id: Ia3c395bf89845c683bba74b4944e5c673ae3a0b0 Reviewed-on: https://chromium-review.googlesource.com/946747 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540729}
-
Devlin Cronin authored
Update chrome/test/data/extensions/api_test/system to manifest v2. This involved complying to manifest v2's CSP requirements. Bug: 816679 Change-Id: I14b3f139770722a7312786c582ca0e74fef892db Reviewed-on: https://chromium-review.googlesource.com/946906Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540728}
-
Emily Stark authored
We currently log a warning message for subresources that use Symantec certificates that have been distrusted. This message didn't fire, however, for iframe main resources because Blink isn't notified about them in the same way as it is other failed resource loads. To log for iframe main resources, the logging logic is moved in RenderFrameImpl (from LocalFrameClientImpl) and called when a frame fails to load. This doesn't work 100% reliably for OOPIFs because of https://crbug.com/817881. Bug: 815219 Change-Id: I961a3e664c0383a7ff81be7def6de17185501243 Reviewed-on: https://chromium-review.googlesource.com/943984Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540727}
-
Ella Ge authored
This cl remove setting cursor style to default cursor in HandleDrag. The SetCursor here is before reach drag threshold, we shouldn't do it here because drag may not going to start. We always update cursor style on mousemove events, setting cursor here may cause cursor blink when mousedown on a draggable item and slowly move. Drag-and-drop will control the cursor after start dragging, so no need to setting cursor. Bug: 799799 Change-Id: I9168d05f3b861a5e50dbb0b7e9e1bb5e5ebe19b1 Reviewed-on: https://chromium-review.googlesource.com/941504Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#540726}
-
Robert Sesek authored
Switch to using -exported_symbols_list with the specified saves file to preserve specific global symbols. Then use the strip command to remove all remaining local symbols. The strip command is now applied via //build/config/mac:strip_all rather than explicitly on specific executables. Bug: 805453 Change-Id: I8d21b12116842eda1f9eb5c0758f52d6198a116f Reviewed-on: https://chromium-review.googlesource.com/922987 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540725}
-
Jeremy Roman authored
Bug: 755727 Change-Id: Ief44c8e53de86bb86fa01f423da5bb59ec8b7105 Reviewed-on: https://chromium-review.googlesource.com/946124Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540724}
-
James Cook authored
The container holds the ChromeVoxPanel window, which is created by chrome. Future CLs will make the ash::ChromeVoxLayoutManager manage the bounds of ChromeVoxPanel and updates to the display work area. This is needed to support mustash, as the information needed to compute the window bounds is owned by ash, but ChromeVox is implemented with an extension owned by chrome. Bug: 628655 Test: ash_unittests, open and close ChromeVox via Ctrl-Alt-Z Change-Id: I02ac4384b949043eafc0578b06676b7e757888c5 Reviewed-on: https://chromium-review.googlesource.com/946517 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540723}
-
Pavel Feldman authored
Bug: 816688 Change-Id: I29beeae9ce49169204ec867cc9636b00a360a26a Reviewed-on: https://chromium-review.googlesource.com/941980Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540722}
-
xlai authored
A follow-up CL to do more cleaning on code duplication in WebGL rendering context, after https://chromium-review.googlesource.com/943761. Bug: 794706 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8c9de02c113a36b4c6b95bb1dd3af25079b4c4d3 Reviewed-on: https://chromium-review.googlesource.com/946899Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#540721}
-
Devlin Cronin authored
This reverts commit 4d546d6e. Reason for revert: this patch caused a bug where we leave extraneous windows around when coming out of sleep. TBR=sky@chromium.org (c/b/ui/browser - clean revert) Bug: 818351 Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd Reviewed-on: https://chromium-review.googlesource.com/947473 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#540720}
-
John Rummell authored
These new tests require a DRM sytem that isn't available to content_shell, so they can't be run. BUG=818254 Change-Id: I228864c991a452c86c465e388b03366fac0d7f12 Reviewed-on: https://chromium-review.googlesource.com/947564Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#540719}
-
https://pdfium.googlesource.com/pdfium.git/+log/71cdd20e9d74..9a7c2396705a $ git log 71cdd20e9..9a7c23967 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 thestig Make EmbedderTest::WriteBitmapToPng() work with grayscale images. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib2576939b2aa4b5b7980ee6b8c80e59327532c90 Reviewed-on: https://chromium-review.googlesource.com/947379Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540718}
-
Vitaliy Rebrov authored
SQL statements forbid binding another variable after "Step()" has been called, until "Reset()" is called. However, the Reset() call was sometimes being skipped due to early continue stmts used in the loop body. Change-Id: Icc2c13b0524d002e10e72a0cabb45d1d09c567c4 Reviewed-on: https://chromium-review.googlesource.com/939787Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540717}
-
Bruce Dawson authored
The switch to clang-cl has made many of the build instructions incorrect or misleading, and some build-speed tips are sorely needed. Cleanups include: - Correct the SDK requirements (FCU SDK doesn't work) - Clarify that VS is still needed even though we compile with clang-cl - Correct goma instructions and recommend it more strongly - Update linker options for the clang-cl world - Add troubleshooting instructions for slow builds including NINJA_STATUS, NINJA_SUMMARIZE_BUILD, ninjatracing, and -d stats. The results were tested with both https://dillinger.io/ and python tools/md_browser/md_browser.py docs\windows_build_instructions.md since neither one gives 100% correct results. Bug: 787983 Change-Id: Ic0d16d884439723dfb3feb610892d7e667e7ae3a Reviewed-on: https://chromium-review.googlesource.com/947573 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540716}
-
Penny MacNeil authored
For all child processes, only enable PreferSys32 after startup. TBR=forshaw@chromium.org TEST=sbox_integration_tests.exe, ProcessMitigationsTest.CheckWin10ImageLoadPreferSys32* Change-Id: I72d1e6fd2f88e14e1042832fc47663b0b7b76c8e Reviewed-on: https://chromium-review.googlesource.com/947503Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#540715}
-
Katie D authored
The event rewriter needs to allow mouse movement events to pass even when those events are used by Select-to-Speak. It should only cancel mouse click events used by Select-to-Speak. Another solution would be to re-write all used "drag" events to be simply "move" events, which may reduce the likelyhood that these events will be used by any other part of Chrome / Chrome OS besides Select-to-Speak and drawing the mouse. This bug also impacted some devices (like snappy) even without large mouse cursor on. Note: The additional "drag" and "move" events were manually tested and do not appear to cause any behavior problems on tabs, the launcher, system windows, etc. Bug: 818329 Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c Reviewed-on: https://chromium-review.googlesource.com/947210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540714}
-
Wez authored
The Shutdown() API was added to RenderProcessHost with parameters reflecting those of the underlying base::Process::Terminate() API, which include a synchronous |wait| option. We never use Shutdown(.., wait=true) in production code, and in tests we can instead use a RenderProcessHostObserver to wait for a process to crash or exit, so we can remove the |wait| parameter and simplify both callers and the implementation. Bug: 806451 Change-Id: I2aeae32a3d20488b4970cf96959eaa287642b7ed Reviewed-on: https://chromium-review.googlesource.com/936450 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540713}
-
Andrii Shyshkalov authored
R=jchinlee No-Try: True Bug: 731545 Change-Id: I4655d2aaa1f78ff350336743b19627bd4cfc1e2d Reviewed-on: https://chromium-review.googlesource.com/947572 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540712}
-
Fan Yang authored
In QUIC, replace ack_frame with largest_acked and ack_delay_time in QuicSentPacketManager::MaybeUpdateRTT. No functional change expected. Merge internal change: 187224206 R=rch@chromium.org Change-Id: Ibdae257e3b57c85a828f14a2e97df7869eade34a Reviewed-on: https://chromium-review.googlesource.com/946268Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540711}
-
https://chromium.googlesource.com/angle/angle.git/+log/888081d59aae..b27b03a2c9ea $ git log 888081d59..b27b03a2c --date=short --no-merges --format='%ad %ae %s' 2018-02-19 lfy GLES1: caps: GLES1-specific context limits 2018-02-26 xinghua.cao ES31: Implement memoryBarrier on D3D backend 2018-02-28 jmadill Rename signal utils to Observer. 2018-02-27 jiawei.shao ES31: Add link validations on geometry shader uniforms Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I80cd4b6ae98bd0f4490701c5c8b762a2a7dd8355 Reviewed-on: https://chromium-review.googlesource.com/946884Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540710}
-
Alex Moshchuk authored
After this CL, certain cross-site, main frame, browser-initiated navigations will use a new BrowsingInstance. This includes navigations initiated from the address bar (typing in the URL or searching) and bookmarks. Note that this works even if the navigated frame has an opener, since these user-initiated navigations indicate that it's ok to break the opener relationship. This change helps avoid unneeded process sharing. For example, after being on a A-embed-B page, any future browser-initiated navigation to B would've stayed in the same BrowsingInstance, SiteInstance, and process as the B subframe on the old page, and if the subframe reused another tab's process due OOPIF process reuse policy, this resulted in both tabs unnecessarily ending up in that process. Bug: 803367 Change-Id: I3a2461a67cb626329c20a887f993d4c9a1494236 Reviewed-on: https://chromium-review.googlesource.com/881836 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540709}
-
agrieve authored
This reverts commit f0d1cf1e. Reason for revert: Breaking bots with: C 1086.301s Main [FAIL] org.chromium.chrome.browser.offlinepages.OfflinePageApiFunctionTest#testError: C 1086.301s Main java.lang.VerifyError: org/chromium/chrome/browser/ClassRegister C 1086.301s Main at org.chromium.chrome.browser.init.ChromeBrowserInitializer.onStartNativeInitialization(ChromeBrowserInitializer.java:381) Original change's description: > [Android] Pass SurfaceView to HandleObserver for Chrome. > > Since Chrome uses SurfaceView for compositing, we will get nothing from > the ContentView passed to |SelectionPopupController| in > |HandleObserver|. > > In this CL, we are passing SurfaceView to HandleObserver from > |CompositorViewHolder| through |WindowAndroid| if it's Chrome's case. > > Bug: 805531 > Change-Id: I7dbf1bd16387eec76dc69031037530b3cb00e753 > Reviewed-on: https://chromium-review.googlesource.com/923021 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540675} TBR=mthiesse@chromium.org,boliu@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,changwan@chromium.org,ctzsm@chromium.org Change-Id: Ia7a183e28b05e5dd2f2156fcd3b956e8986686dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805531, 818370 Reviewed-on: https://chromium-review.googlesource.com/947602Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540708}
-
Matt Wolenetz authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/9ca66eafaf6f..ef99a5d2520f $ git log 9ca66eafa..ef99a5d25 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 wolenetz ffmpeg: Initialize a potential gap in ctts_data in mov_build_index 2018-02-26 dalecurtis Revert "Change the way the ffmpeg_branding gets its defaults." Created with: roll-dep src/third_party/ffmpeg BUG=816787,570754,795935 Change-Id: I44bcdd293b786cdc4e754f81e82695578b0ba6c3 Reviewed-on: https://chromium-review.googlesource.com/947386Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540707}
-
Xianzhu Wang authored
Now we always report the following metrics: - paint_op_memory_usage: Total memory used by cc::DisplayItemList - painter_memory_usage: Total memory used by blink::PaintController. - paint_op_count: total op count of cc::DisplayItemList. This is useful to evaluate efficency of PaintChunksToCcLayer. Removed total_size_of_pictures_in_piles which didn't look useful. (paint_op_memory_usage + painter_memory_usage) seems the better metric for total memory usage. R=vmpstr@chromium.org TBR=# passive changes and cleanups under tools/perf/measurements Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64a0fce5ef83d3d9812f0c9446989ffa1b700968 Reviewed-on: https://chromium-review.googlesource.com/944421 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540706}
-
Andrii Shyshkalov authored
R=jchinlee Bug: 731545 Change-Id: Ieeb3df10e3649063679cf66a8b9231813714b34b No-Try: True Reviewed-on: https://chromium-review.googlesource.com/947566 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540705}
-
Devlin Cronin authored
Update chrome/test/data/extensions/permissions_increase/* to manifest v2. This required changing background_page to background. Bug: 816679 Change-Id: I99afd26749acf1c7d8bf9b737200370de5324ba5 Reviewed-on: https://chromium-review.googlesource.com/946549Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540704}
-
Bailey Forrest authored
BUG=b/74038945 TEST=Manual Change-Id: Ia61729fa620e90ae6147ca426e433b78dd48c32e Reviewed-on: https://chromium-review.googlesource.com/947032Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#540703}
-
Andrii Shyshkalov authored
Also, stop experimenting with mac_chromium_dbg_ng. R=jchinlee Bug: 731545, 731476 No-Try: True Change-Id: I89d3b7eb95f4ec76909101e802f70d2627cf4602 Reviewed-on: https://chromium-review.googlesource.com/947469Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540702}
-
Eugene But authored
Install button is shown if download is sucessfully completed and Google Drive app is not installed. UI Mocks: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2eee39b982_0_0 Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib884a37a54ac77e22ff30c8c22a3cfaa530343f0 Reviewed-on: https://chromium-review.googlesource.com/938497 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#540701}
-
John Abd-El-Malek authored
Bug: 787614 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib78db05aabb5502977a8b08e2aee72a8481ca572 Reviewed-on: https://chromium-review.googlesource.com/946851Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540700}
-
James Hawkins authored
Bug: none Test: none Change-Id: I8a53e499f6c574b82f617092d91daa8fbfa3e2c7 Reviewed-on: https://chromium-review.googlesource.com/947322Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#540699}
-
Avi Drissman authored
This moves the various parts of the speech code to be frame- attached rather than view attached. It also moves responsibility for observing the lifetimes of the various page objects from the Chrome delegate to the manager itself. This is a resurrection of the CLs: Part 1: https://codereview.chromium.org/636863002/ Part 2: https://codereview.chromium.org/636863003/ Part 3: https://codereview.chromium.org/752303003/ and has additional changes. BUG=390749 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib85fd652d88ae9dc7ba1295eb23932dc1e8250fc Reviewed-on: https://chromium-review.googlesource.com/919309 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#540698}
-
Joshua Bell authored
Ensure coverage for these cases: * API exposure in a Dedicated Worker, inheriting the OT token from the page. * API exposure in a Service Worker, OT token served via PHP header. * API exposure in a Service Worker, no OT token. It ensures the feature is not available in the virtual test suite for origin trials that disables experimental features, and is skipped otherwise. Also, add a basic Service Worker interface test with the other locks tests as well. Bug: 161072,804548 Change-Id: I2ec5ae5c7c0a5a7e72978c08e06368cf760eb92e Reviewed-on: https://chromium-review.googlesource.com/944787 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#540697}
-
Scott Violet authored
This finishes components. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build TBR=dcheng@chromium.org Change-Id: I109f65c850229fc381ee70db2a6075f7fea05f31 Reviewed-on: https://chromium-review.googlesource.com/946519 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540696}
-
Yusuf Ozuysal authored
For cases where the experiment is enabled, don't create new child tabs if there are already tabs with the same urls. This avoid opening unnecessary tabs. BUG=814533 Change-Id: I76ed8d6e64049d76bfbd810169fb17ffe870f1ff Reviewed-on: https://chromium-review.googlesource.com/946894 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#540695}
-
David Bokan authored
This patch fixes compositor-touch-hit-rects-fullscreen-video-controls when run with root layer scrolls. This test was added for crbug.com/372314. An explanation of that is helpful to understand the fix here: When Blink calculates the touch event handler rects it has a special optimization when the document has a handler. In that case, it doesn't bother checking anything else and places a content- sized rect onto the document layer. However, in the case of an Android fullscreen video, the compositor detaches the document layer hierarchy and attaches the video and its controls. Because of the optimization above, the compositor doesn't bother calculating touch handler rects on these new layers, but because the document layer is detached it seems as though there aren't any touch handler regions at all. The fix in that bug was to disable the optimization when a fullscreen video overlay is active to force computing rects from the media control layers. This test uses Internals::touchEventTargetLayerRects to calculate the rects on the layer tree. This method uses PaintLayerCompositor::RootGraphicsLayer as its starting point. Pre-RLS, this would be the overflow controls host layer in the PLC. This was ok because the document layer was connected to it's descendants and disconnected when an overlay video was attached. With RLS, RootGraphicsLayer returns explicitly the graphics layer for the LayoutView which may not be attached at all. Thus the test was seeing that a handler still existed on the document because that's where it would start its search. The fix is to start the search from the painting root which is above the PaintLayerCompositor and thus, wont descend into the detached document layer. I don't think this test is a good guard against the regression. Since the document layer is detached we don't actually check that we correctly calculate the touch rects on the video controls. It appears that they've since been modified to not require touch handlers and the expectation reflects that. As such, this test can't tell the difference between the controls not having touch handlers and Blink failing to calculate touch handler rects. I've filed https://crbug.com/818330 for this problem. Bug: 816957 Change-Id: I088f960edb47af2d6d539e50a21b7e39067efb5f Reviewed-on: https://chromium-review.googlesource.com/947052Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540694}
-
Eric Roman authored
Adds NetLog instrumentation for how the network adapter list was read on Windows: * The enumerated network adapters * How long it took to schedule the task to worker thread * How long it took to schedule the reply task to origin thread * How long it took to query the adapters * Which "adapter fetcher" won the overall race for WPAD Subsequent CLS will add more logging for the individual "adapter fetchers". TBR=stevenjb@chromium.org Bug: 770201 Change-Id: I9f704614e4a991e9a56879fc81637d41782dce1f Reviewed-on: https://chromium-review.googlesource.com/876921 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540693}
-
Vladimir Levin authored
This patch ensures that if we remove a child frame's graphics layer from its parent, that we reattach its (possibly new) root graphics layer back to the parent it had before. The parent does not change during this, because we're in a stack processing the child frame, and the parent would reference the parent frame that is currently paused. This mimics pre-RLS code path where the child frame always had a parent accessible directly from the compositor (ie root_content_layer_), except here we save off whatever we were attached to already. R=chrishtr@chromium.org, skobes@chromium.org, pdr@chromium.org Bug: 815121 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9e63d2d513df24eaa13a30ee36582b5c807f4aff Reviewed-on: https://chromium-review.googlesource.com/946566 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#540692}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d5002715..e1de5c82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I815c21c9c5938ae9a33ee872f3c6ed6fb488aee4 Reviewed-on: https://chromium-review.googlesource.com/946270Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540691}
-