GitLab

This is a reland of 4df8a2dd

Original change's description:
> Add a Mojo-based transportation layer for Perfetto
>
> This adds a base layer that individual logging protocols (like tracing)
> can use to send their data to Perfetto, using Mojo messaging and
> shared memory.
>
> First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270
>
> A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808
>
> The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit
>
> R=primiano@chromium.org,skyostil@chromium.org
>
> Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552
> Reviewed-on: https://chromium-review.googlesource.com/980578
> Reviewed-by: oysteine <oysteine@google.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Commit-Queue: oysteine <oysteine@google.com>
> Cr-Commit-Position: refs/heads/master@{#551019}

Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7

TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@google.com,skyostil@chromium.org

Change-Id: Ic47afdb6c2e09924a5f540fa56552ceb6e29e6d7
Reviewed-on: https://chromium-review.googlesource.com/1015189Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551526}

Previously, storage::FileSystemUsageCache used a custom timer
implementation (TimedTaskHelper). Crash involving this custom timer
implementation have been reported (e.g. http://crash/e2c6ff1ef4863460).
Therefore, we are moving all uses of TimedTaskHelper to the well
maintained base::Timer.

Note: The TaskRunner passed to the TimedTaskHelper in
storage::FileSystemUsageCache was always the one on which the
storage::FileSystemUsageCache was used, so there is no need to
an explicit call to base::Timer::SetTaskRunner in this CL.

Bug: 760326
Change-Id: I4b0727e4f70c2560a2948015dd28236cd760a9f3
Reviewed-on: https://chromium-review.googlesource.com/1012586
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551525}

https://skia.googlesource.com/skia.git/+log/eedecc6046b2..c186e17a6b78

$ git log eedecc604..c186e17a6 --date=short --no-merges --format='%ad %ae %s'
2018-04-17 robertphillips Add handling to ViaDDL for images that are too large to be uploaded in one go
2018-04-17 herb Move node information to SkStrikeCache
2018-04-17 bungeman IWYU for some more test files starting with 'C'.
2018-04-17 reed detect if we made an infinite rect
2018-04-17 borenet [infra] Support recursive configs in builder_name_schema
2018-04-16 egdaniel No long require copy as draw for vulkan wrapped resources.
2018-04-17 caryclark path is rect diag test is required
2018-04-17 mtklein SkStrikeDifferences::operator() -> add()
2018-04-17 reed avoid overflow by using tmp 64bits
2018-04-17 brianosman Move external texture extension logic into SkSL
2018-04-17 benjaminwagner [infra] Add service account override in gen_tasks.go.
2018-04-17 caryclark path is rect bug number twelve
2018-04-17 bungeman Add paint flags to viewer GUI.
2018-04-17 mtklein skcms→3be11ac refactor a bit
2018-04-17 liyuqian Revert "Fix the fat rect bug in the threaded backend"
2018-04-17 reed only recheck fNeedsTiling if we computed fSrcBounds
2018-04-17 brianosman Add SkColorSpace::Make, taking an skcms_ICCProfile
2018-04-16 mtklein Reland "low-hanging bilerp_clamp_8888 wins"
2018-04-17 mtklein skcms→38f22d2 name types in skcms.h
2018-04-17 herb Reorganize strike cache and glyph cache code
2018-04-16 liyuqian Fix the fat rect bug in the threaded backend
2018-04-17 caryclark yet another path is rect exploit
2018-04-17 angle-skia-autoroll Roll third_party/externals/angle2/ 08b9e046c..86de76b69 (1 commit)
2018-04-16 halcanary SkColorSetARGB in constants
2018-04-16 caryclark a more involved path is rect bug
2018-04-16 egdaniel Update our config fallback switch in GrContext.
2018-04-17 borenet Revert "Reland "[infra] Run recipes through Kitchen""
2018-04-16 borenet Reland "[infra] Run recipes through Kitchen"

Created with:
  roll-dep src/third_party/skia
BUG=chromium:824145,chromium:824145,chromium:824145,chromium:824145


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I1489c857f9c6e71b8e55bd7deaa3230a33759926
Reviewed-on: https://chromium-review.googlesource.com/1015796Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551524}

Extends 8dp corners to ToolbarActionView which was missed in a previous
change. This makes them consistent with other toolbar buttons.

Bug: chromium:822069
Change-Id: Id894664ec698504e3ff997c1b12691821ab1062e
Reviewed-on: https://chromium-review.googlesource.com/1015286
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551523}

Following bot results are included.
4828 4834 4835 4836 4837 4838 4839 4846

2 lines were removed and 0 lines were deflaked by consecutive
results since 4772.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I21ecb8193d866c44d026528ffc7831dc7babe59b
Reviewed-on: https://chromium-review.googlesource.com/1013788
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551522}

This CL detects the case that a invisible composited layer may have bogus
subpixel accumulation on it, and ignore the DCHECK in such case.

BUG=816490

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iba98cb3a57dfe24f8a69f1f7469bf78482530d7e
Reviewed-on: https://chromium-review.googlesource.com/1012441Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551521}

Disabling all tests in CorrectEventFiringTest class.
Tests are flaky and we'll enable these tests again as soon as the bug is fixed.

Change-Id: I5b02e385869165cb2d2e7cfd87c5611fc81eb9fb
Reviewed-on: https://chromium-review.googlesource.com/1015973Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551520}

R=brettw@chromium.org, rsesek@chromium.org, sdefresne@chromium.org, sergeyu@chromium.org

Bug: 821738
Change-Id: Ib1dcca4070ad7019c082653217df48adda69ab32
Reviewed-on: https://chromium-review.googlesource.com/962282Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551519}

Bug: none
Change-Id: If04229d0caf53848f6dde4f0f7aabde053954f67
Reviewed-on: https://chromium-review.googlesource.com/1008526Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551518}

Power/battery related notifications were generated in TrayPower, whixh
is a SystemTrayItem.

We're going to get rid of SystemTrayItems as UnifiedSystemTray will
replace them, so we should generate the notification outside system
tray.

TEST=PowerNotificationControllerTest
BUG=none

Change-Id: Ie707770cd86964f496651d5ed840198890362b40
Reviewed-on: https://chromium-review.googlesource.com/1013784Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551517}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/888a7065b4ba..c46e7967a50f

$ git log 888a7065b..c46e7967a --date=short --no-merges --format='%ad %ae %s'
2018-04-16 moragues nocturne: Add master builder configuration

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I3ac448c88b4d01e1c86eee5eaa75b08475924f60
Reviewed-on: https://chromium-review.googlesource.com/1015651Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551516}

Bug: 830489
Change-Id: Ief2540485aa699a72ad9adccafa487a729e7fb08
Reviewed-on: https://chromium-review.googlesource.com/1015441Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551515}

We'd like to provide smaller tarballs with which one can build Chrome,
and such tarballs exclude //third_party/WebKit/Tools/Script. We're
moving //third_party/WebKit/Tools/Scripts to //third_party/blink/tools,
and would like to exclude //third_party/blink/tools as well. However,
some build scripts use name_style_converter.py in the directory.

This CL moves name_style_converter.py out from
//third_party/blink/tools, and enables to exclude
//third_party/blink/tools.

test-webkitpy includes //third_party/blink/renderer/build/scripts. So
the following existing tests run on buildbots in addition to
name_style_converter_test.py:
- in_file_unittest.py
- minimize_css_unittest.py
This CL fixes test failures of in_file_unittest.py.

Bug: 832283
Change-Id: I7d3b3524daa59291eaf7f323818a7b0e25163179
Reviewed-on: https://chromium-review.googlesource.com/1013768Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551514}

Temporarily disabling checkering of decode=async tag images to debug
entries in ukm logs for checkerboarded images in the control group for
checkerimaging finch study.

R=vmpstr@chromium.org

Bug: 833666
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib9a79262599efa17fd18e9cb71d7518492e9a7ee
Reviewed-on: https://chromium-review.googlesource.com/1014644Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551513}

This reverts commit f0acd4fc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 551483 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YwYWNkNGZjZjE5MzlhMTUyYzI3ODdmNjI1NjQ0YThlNTc5NDdkMjgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7001

Sample Failed Step: base_unittests

Original change's description:
> Fix SampleVector tests to expect CHECK rather than DCHECK deaths.
> 
> Bug: 832728
> Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f
> Reviewed-on: https://chromium-review.googlesource.com/1012732
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551483}

Change-Id: Ie2ad7fb9ebd4c214a7dd2cebe0763b2f41793f01
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832728
Reviewed-on: https://chromium-review.googlesource.com/1015194
Cr-Commit-Position: refs/heads/master@{#551512}

... so as to insure it's always destroyed on the correct thread even though it's passed
around through different threads.

Change-Id: Ieae597251f2836de73cc13cb39fa6d39b9645133
Reviewed-on: https://chromium-review.googlesource.com/1013379
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551511}

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I234a2cc037b78b11d08660b641f5524ed8171a0b
Reviewed-on: https://chromium-review.googlesource.com/1014601Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551510}

Previously, when the autocomplete engine did not provide any matches,
the OmniboxEditModel would generate a current match from the text
contents of the View.

This would lead to bad behavior when Steady State Elisions was on. For
example, if the user was at the full URL https://router/, and the
elided display text was simply "router", this would trigger a search
when the user pressed Ctrl+L, and then Enter.

This CL fixes that by only using the View text if user input is in
progress, and using the full formatted URL otherwise (if in display
mode).

This bug doesn't have an impact unless the Steady State Elisions flag
is on, so this doesn't require a merge.

This CL also adds a test.

Bug: 797354
Change-Id: Id27913f567313333e8a171a8040bf906a7a1cc52
Reviewed-on: https://chromium-review.googlesource.com/1013694Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551509}

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 781352
Change-Id: Ide6e641f8e9fed673bbf641074f33a05d238735a
Reviewed-on: https://chromium-review.googlesource.com/1014782Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551508}

https://chromium.googlesource.com/catapult.git/+log/055c0339565a..ca7ee7a2c7fe

$ git log 055c03395..ca7ee7a2c --date=short --no-merges --format='%ad %ae %s'
2018-04-17 simonhatch Dashboard - Use bot_configuration in /auto_bisect.
2018-04-16 simonhatch Dashboard - Update delete/migrate to also do histogram data.
2018-04-16 simonhatch Dashboard - Fix up diagnostics

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:779618


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ie5fbb5255dd417719043563f31e69bb61e633657
Reviewed-on: https://chromium-review.googlesource.com/1015762
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551507}

Bug: internal b/74159854
Test: Ran on Android Things speaker, verified bug is fixed.
Change-Id: I14b4f82c175f771cf7387d1bf6b2655221397edc
Reviewed-on: https://chromium-review.googlesource.com/1011297Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551506}

If ALPN protocol negotiation gives us an answer, use that directly;
otherwise, we assume HTTP/1.1 if any response headers were received.

Bug: 748549,833996
Change-Id: I33d6217ede6202358acf1a343296f5019a9b6052
Reviewed-on: https://chromium-review.googlesource.com/998021
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551505}

Currently AudioDestination starts with an empty PushPullFIFO, so
the first callback from the AudioDeviceThread always ends up with
a bogus "glitch report" on the histogram.

This CL fixes the issue by priming (prefill) the PushPullFIFO to cover
the first callback from the ADT.

Bug: 833766
Change-Id: I17e40df31586c9dd3e3678706d47f08693b96d45
Reviewed-on: https://chromium-review.googlesource.com/1015201Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551504}

Team drives only support retrieving change lists using the a start
page token, which currently is not supported at all by the drive
sync client.

This CL makes it possible to retrieve the start page token for either
the users changelog or a team drive changelog.

Today, the drive client uses startChangeId to retrieve change lists,
which has been deprecated in favor of pageToken. A follow up CL
will make this change so that the logic will be consitent when
retrieving either the users change list or a team drive change list.

Other Notes:
- In places fixed a few "git cl lint" errors.
- "git cl upload" complains about using base::Bind so I used
  base::BindRepeating, but I suspect we can change this to base::BindOnce in a
  followup cl.

Bug: 715355
Change-Id: Ie1a93b6919c3c179aeb68d5deb5fa3b367d02497
Reviewed-on: https://chromium-review.googlesource.com/1013819Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551503}

When entering VR we hide the browser controls. However, it can take some
time for this state update to reach the FullscreenManager. As a
consequence, hover move events may have a false offset depending on
whether the initial hover enter event was processed with the updated
browser controls state or not. To fix that, also update the top offset
for hover move events.

Bug: 822384
Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864
Reviewed-on: https://chromium-review.googlesource.com/1014708Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551502}

WKBasedNavigationManager does not yet inject session history into new
WKWebViews created by PrerenderService. Disable PrerenderService for
now so we can measure the load performance impact in Finch experiment.

Bug: 814789
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iad1db96832dc2e30ab85aa6b8939b8e5850ad250
Reviewed-on: https://chromium-review.googlesource.com/1012494Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551501}

SingleThread, not SingleTreaded (add one letter, remove two). Spelling
matters to allow searching for the referenced functions.

Change-Id: I46909856cd3540fe246d9d8a9db70aaee2ebe71f
Reviewed-on: https://chromium-review.googlesource.com/1012489
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551500}

This patch simplifies the code to scroll to fragment (i.e. scrolling to
an Element with id="foo" when navigating to http://ex.pl/index.html#foo)
code by moving more of it into LocalFrameView rather than in Document.

Previously, we kept some state whether rendering was blocked when the
URL fragment was processed and if it was we'd try to perform the scroll
later in the document lifecycle. This patch removes the state tracking
and relies entirely on the scroll happening in PerformPostLayoutTasks if
it can't be done immediately.

It also moves focusing on the fragment element into the method that
performs the scrolling, tying these together. This appears to have been
the original intent based on the comment in ProcessUrlFragment but
changes behavior slightly.

Re-land Note: This was originally reverting because script could run
inside the ScriptForbiddenScope in UpdateLayout
(https://crbug.com/796222). This patch removes the ScriptForbiddenScope
in Document::UpdateStyleAndLayout since both UpdateStyleAndLayoutTree
and UpdateLayout are guarded internally by ScriptForbiddenScope. It also
narrows the scope of the ScriptForbidden section in UpdateLayout to not
include the call to Document::LayoutUpdated and moves the scrolling and
focus related methods there.

Bug: 795381, 830881
Change-Id: I571932217a0664f21fae8463d26b2c807a5f565e
Reviewed-on: https://chromium-review.googlesource.com/1010264
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551499}

Change-Id: I32b5e7e37ff1b366a99de9ce5cd627ee5251490b
Reviewed-on: https://chromium-review.googlesource.com/1015900Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551498}

Destroy the MediaEngagementService object later. Should fix the
ToTLinuxUBSanVptr bot on the clang ToT waterfall.

R=beccahughes@chromium.org,mlamouri@chromium.org
BUG=chromium:827609

Change-Id: I9570279416a39d1018f714762d3df871cf2ce07a
Reviewed-on: https://chromium-review.googlesource.com/1015770Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551497}

This patch splits creating box fragments from computing inline
positions, in preparation of supporting text-overflow in
NGInlineLayoutAlgorithm.

No behavior changes in this patch.

Bug: 636993
Change-Id: I0e99a07128031a7085426ad53f91214df9c223a1
Reviewed-on: https://chromium-review.googlesource.com/1013779
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551496}

To support certain use cases the current upgrade strategy
can't be used. This cl changes all upgrades to N-1 strategy.

Bug: 461856
Change-Id: Ic7a7580e6e2e51b65428cddaca1209a3edc0af5b
Reviewed-on: https://chromium-review.googlesource.com/1013222Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: James Meade <mmeade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551495}

CDM_9 support has been shipped in Chomium for multiple releases. All new CDMs
should use CDM_9 and above. Hence removing support for CDM_8.

only cover CDM_9 and CDM_10.

Bug: 737296
Test: Removing support of old interface support. Currently our tests
Change-Id: I22facd6dc6e18933a295d3aece7ba2de1369cb79
Reviewed-on: https://chromium-review.googlesource.com/1015640Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551494}

The new name is kDisplayingNativeErrorForFailedNavigation. This change
is needed to support HTML based error pages which will use
kDisplayingWebErrorForFailedNavigation enum.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id68e8239d9706b8d98bc591a0d264609b13e23c0
Reviewed-on: https://chromium-review.googlesource.com/1015531Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551493}

This reverts commit 6db68698.

Reason for revert: Broke compile on Windows
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130690

FAILED: angle_shader_translator.exe angle_shader_translator.exe.pdb  E:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./angle_shader_translator.exe /PDB:./angle_shader_translator.exe.pdb @./angle_shader_translator.exe.rsp translator.lib(OutputVulkanGLSL.obj) : fatal error LNK1236: corrupt or invalid COFF sections

Original change's description:
> Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)
> 
> https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e
> 
> $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
> 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
> 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
> 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
> 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
> 2018-04-17 jmadill Vulkan: Fix build after roll.
> 2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
> 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
> 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18
> 
> Created with:
>   roll-dep src/third_party/angle
> BUG=chromium:833736
> 
> 
> The AutoRoll server is located here: https://angle-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=jmadill@chromium.org
> 
> Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
> Reviewed-on: https://chromium-review.googlesource.com/1015624
> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#551461}

TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: Ic8bf0038e7b39a6025ac24b65aa5a38f078f0ede
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:833736
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1015191Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551492}

This change includes the integration of the MacOS KeyboardHook impl in
the RenderWidgetHostViewMac and RenderWidgetHostViewCocoa classes.

RWHVMac handles the lock/unlock calls from RenderWidgetHostImpl and
forwards them to RWHVCocoa which handles the events and input routing.

The RenderWidgetHostViewMac and RenderWidgetHostViewCocoa integration
follows the same pattern I used for RenderWidgetHostViewAura and
RenderWidgetHostViewEventHandler. The main difference between this impl
and the Aura impl is that there is a bridge class between RWHVMac and
RWHVCocoa (RenderWidgetHostViewNsBridgeView).

BUG=680809

Change-Id: I524c98c059ae4883bf597704c326b5a0055f1212
Reviewed-on: https://chromium-review.googlesource.com/989618Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551491}

Nobody will pick them up anyway.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ice7a1f9ee743a1555f0fab00feca0b2eef97125f
Reviewed-on: https://chromium-review.googlesource.com/1012847Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551490}

Add a check that the parent FrameSinkId is registered before creating an
OffscreeCanvasSurfaceImpl, which is really a generic embedded surface
and not just used for offscreen canvas. The IPC channel that controls
the destruction of the parent CompositorFrameSink, and subsequent
invalidation of parent FrameSinkId, is different than the IPC channel
used to create embedded surfaces. We can't rely on ordering of messages
between them. It's possible the parent FrameSinkId is invalidated before
the browser gets the request to create an embedded surface.

If this state is detected then just drop the request for the embedded
surface. This will avoid triggering the DCHECK that the parent
FrameSinkId is registered and avoid doing work for something that is
about to be destroyed.

The experiment to enable UseSurfaceLayerForVideo, which uses
OffscreenCanvasSurfaceImpl, had tests running into this problem and
hitting a DCHECK in HostFrameSinkManager::RegisterFrameSinkHierarchy().

Bug: 830003, 829306
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4e8cb26548444ecbf941a87a984b21aa4c846580
Reviewed-on: https://chromium-review.googlesource.com/1014330
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551489}

This ports similar (internal) code used on systems not supporting CMA backend.

Bug: internal b/77986368
Test: Running on speakers, observing proper logs.
Change-Id: Ifde45f035e2f52096f82e9682bf5c60b170d2c47
Reviewed-on: https://chromium-review.googlesource.com/1014740Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551488}

This patch enables OOPIF pixel dumps behind a flag. The reason for the
flag is that this isn't working for 100% of cases yet. Specifically,
selection rects and dialogs windows aren't being captured correctly.

As well, there seem to be some pixel differences between existings tests
which will likely need to be rebaselined.

R=lukasza@chromium.org

Bug: 667551
Change-Id: Icfb98958e5b9d007b1bd3a554b32d55d545e04e6
Reviewed-on: https://chromium-review.googlesource.com/994240
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551487}