GitLab

This CL introduces feature_session_type.mojom and moves
extensions::FeatureSessionType to it in order to use
FeatureSessionType with mojo interfaces. It's a precursor
to moving ExtensionMsg_SetSessionInfo to mojo interface.

Bug: 1146103
Change-Id: Ied4b31e4010785e002610410217fede8ff31cb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526649Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#828516}

Resolve conflict with gesture navigation when dragging cursor handle view on the edge of the screen.

Since Android 10(API 29) has supported system gesture navigation, if users try to swipe the cursor handle on the edge of screen, which will conflict with system navigation back. We should resolve this conflict via `View.setSystemGestureExclusionRects()` in `PopupTouchHandleDrawable.onSizeChanged()`

Actually, it should be consistent with the behavior of the `Editor.HandleView`
```
@Override
protected void onSizeChanged(int w, int h, int oldw, int oldh) {
    super.onSizeChanged(w, h, oldw, oldh);
    setSystemGestureExclusionRects(Collections.singletonList(new Rect(0, 0, w, h)));
}
```

Bug: 1149803
Change-Id: Icd7669bcccfa975fbb97c0e3758a3648add0e3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543647Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828515}

Debug builds are seeing crashes after successful SyncMetadata responses,
when serialized protos and public keys are being stored in prefs. These
strings will likely contain non-UTF-8 characters, which are disallowed
in pref values. In this CL, we base64-encode these values before
persisting to prefs.

We manually reproduced the crash without this patch and verified that
this patch fixes the crash. We also updated unit test strings to
include non-UTF-8 characters.

Fixed: 1150031
Change-Id: I81d6f937110c8b010ce3bed3cad7c38c0099a025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545765
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#828514}

This reverts commit 1e6b827e.

Reason for revert: Tests are failing on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29

For example:

[ RUN      ] ResetShortcutsComponentTest.ResetShortcutChromeTargetPreserveArguments
[3748:3728:1117/162648.254:1947251:ERROR:reset_shortcuts_component.cc(62)] Number of shortcuts to reset: 1
../../chrome/chrome_cleaner/components/reset_shortcuts_component_unittest.cc(144): error: Expected equality of these values:
  found_shortcuts[0].target_path
    Which is: L"E:\\b\\swarm_slave\\w\\itk5vfdk\\5116_696520538\\0\\scoped_dir3748_371919881\\d8473183-ca73-484f-bbdf-d7df1deebbed.tmp"
  fake_chrome_path_.value()
    Which is: L"e:\\b\\swarm_slave\\w\\itk5vfdk\\5116_696520538\\0\\scoped_dir3748_371919881\\d8473183-ca73-484f-bbdf-d7df1deebbed.tmp"
Stack trace:
Backtrace:
	chrome_cleaner::ResetShortcutsComponentTest_ResetShortcutChromeTargetPreserveArguments_Test::TestBody [0x0017FAAD+1389]

[  FAILED  ] ResetShortcutsComponentTest.ResetShortcutChromeTargetPreserveArguments (172 ms)


Original change's description:
> Create a ResetShortcutsComponent in CCT.
>
> The ResetShortcutsComponent will use the
> existing sandboxed shortcut parser to retrieve
> modified shortcuts and then overwrites the
> existing shortcuts with new ones. The
> component will be hooked up to the CCT in a
> future CL.
>
> Bug: 1116017,1148930
> Change-Id: Ia6c8453af267b98884804eed3b18944afb0506ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520419
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Bettina Dea <bdea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828453}

TBR=ajwong@chromium.org,veranika@chromium.org,vakh@chromium.org,wfh@chromium.org,bdea@chromium.org

Change-Id: I87e55d98da30d41141ca5c09585c02e78aa64022
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116017
Bug: 1148930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545895Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828513}

https://chromium.googlesource.com/catapult.git/+log/ecb7a9bbb816..80f68fb067c7

2020-11-17 jonross@chromium.org Remove uma_metric Subtract

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1145731
Tbr: rmhasan@google.com
Change-Id: I689ea3e9e3418312fd0cdb95034d9bf24d8a3ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545428Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828512}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //content.

R=boliu@chromium.org

Bug: 1113033
Change-Id: I409968b2318bd07214affd931c3db1b07431403a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544853
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#828511}

Previously when determining the available size for distributing the
table-grid into we'd simply resolve our overall fragment block-size.

However when extrinsically sized (fixed, or stretched) we need to also
subtract the space taken by the captions to correctly determine what
space the distribute the grid into.

This change performs layout on the table <caption>s up front, before
computing the size of the sections/rows.

Bug: 958381
Change-Id: I912d2b92928e6114eb205867acc807568f5b408e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539339
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828510}

This test was disabled due to a change in the accessibility internals.
The change necessary to get this test to work was included in CL
https://crrev.com/c/2314758.

Bug: 1122806
Change-Id: I71045e0e432d07b259fc56ed31abedc2316a0b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544746Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828509}

I made a few mistakes at the last moment in the initial
implementation. 1.) CHECK the validness of ref_frame_map is
wrong in keyframe case. 2.) slice_data_offset in
VASliceParameterBufferAV1 is not filled.  This CL fixes them.

Bug: b:172214398
Test: video_decode_accelerator_tests on volteer
Change-Id: I24e9fada30dd56fe10a51fb3e5d8c448ee996666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542940
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828508}

Bug: 1114939
Change-Id: I912370270185cd18225242ead50010c50a4baee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545324
Commit-Queue: Jiewei Qian  <qjw@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Auto-Submit: Jiewei Qian  <qjw@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828507}

This is done by defining logging levels instead of just activating
complete hang watching per thread type. Hang watching a thread type can
be :

1) Deactivated.
2) Logging metrics to UMA only.
3) DumpWithoutCrashing on finding a hang.

Bug: 1135528
Change-Id: I98d04c24447129cd28e2d7d04ce26743e922fef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529192
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828506}

This reverts commit 842373f4.

Reason for revert: causing a crash for nearby share: https://crbug.com/1146293

Original change's description:
> [Sharesheet] Animate sharesheet open and close.
>
> This CL adds animation to Sharesheet appear and disappear.
> Appear has a opacity fade in from 0 - 100 in 100ms with linear curve
> and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1).
> Disappear is a 100-0 in 80ms linear opacity fade out.
>
> In this CL we also disable sharesheet close on deactivate
> when ShareActions have been selected.
>
> Bug: 1148692
> Change-Id: Id6a360438271ad62f5911ed97984c3230a448332
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537502
> Commit-Queue: Maggie Cai <mxcai@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828107}

TBR=pkasting@chromium.org,mxcai@chromium.org,melzhang@chromium.org

Change-Id: I4078300f21b2b9ab7f09563bf1bdcd3b17407f97
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545893Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#828505}

This CL adds the folder icon provided by UX designer. Converted from
svg file to xml in Android studio. The color is modified to use chrome
color.

Bug: 1133496
Change-Id: I1d8ecca180480653a078cdd1ab37bae8102c634e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538471Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828504}

http://screen/7XAbyfjQY2eXkcm

Bug: 1125150
Test: browser_tests --gtest_Filter=DiagnosticsApp*
Change-Id: I64c89a4feacfc74d718b6ed32de60f252aace750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538200
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828503}

Add new properties |progress| and |hasError| to nearby-progress, which
allow setting a specific progress percentage and disabling the spinner
during error states respectively.

|progress| defaults to null. When null, a waiting animation is shown
where the progress bar spins around the icon. |progress| will be used
in future CLs to set specific progress percentages, but for now, only
the default is used.

|hasError|=true causes the progress bar to be red, icons to be grey,
progress to be 100%, and stops any spinning animation.

Bug: b/163036847
Change-Id: I74d88a1e4efefb6a5e73ba1fd77880b3397bc353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542850
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#828502}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //content.

R=boliu@chromium.org, dtseng@chromium.org, kbr@chromium.org

Bug: 1113033
Change-Id: Id2c963398829473e034373d3dc7909d325c77c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543695
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828501}

Screenshot: https://screenshot.googleplex.com/BNCSFDoGHTmY6Wm.png
Reference: https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7d94e49b87_2_58

Bug: 1093185
Change-Id: Icb66ac3cc12331da0247e01fb84b4d36483d8ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537100
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828500}

Registers an a WebUIControllerInterfaceBinder for SystemRoutineController

Bug: 1128204
Change-Id: I2cc423a94c58211ccd4b7310933ed4c30ed93a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541814Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828499}

R=bdea

Fixed: 1140092
Change-Id: Ia00bf2f21dd41c4a69dc9d6e070ce0403ccd4e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541804
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828498}

If a launch or stop session request is made for a channel ID when
there still is an outstanding request for the same ID, then the
subsequent requests had their callbacks dropped, which was problematic
especially if the callbacks were Mojo callbacks. This change ensures
that we call them.

Bug: 1148083, b/173533007
Change-Id: Ie99b76ea0716913f91faac97bccff41418e4b25b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545263Reviewed-by: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828497}

Bug: 1150148
Change-Id: I7d46d119da527fd68f3c185cfade91d334c0ff3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545579Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#828496}

Bug: 1095379
Change-Id: I3c493ca3bf00f0fe8b5b123f3f4e140ccca95e5f
Tbr: masonfreed@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545776Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828495}

Change the decision to use the chrome user consent prompt to be based on
the actual backend that was used.

This is needed because the new AUTO backend may or may not require the
chrome consent prompt based on the actual GMS API used:
 - GMS user consent API does not need chrome consent prompt
 - GMS browser code API needs chrome consent prompt

So it is no longer possible to make the prompt decision based on the
flag alone. Instead the decision is made once we receive the OTP and we
know the actual method that was used.

Major changes:
 - Plumb the backend method to the provider
 - Determined user consent requirement based on the backend method
 - Plumb user consent requirement to webotp service
 - WebOTPService now creates the appropriate consent handler per each
   otp response and it companying requirement
 - The tests are updated to accommodate this.


Bug: 1141024
Change-Id: Ibd1a5ac970f73d1939d29d39769bd8d8986d70c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530272
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828494}

Extend the expiry date of the various smoothness metrics until Q3 2021.

BUG=1149467

Change-Id: Idacec5d27b8875fa25895b98c1d33c91900b7d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543372
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828493}

https://skia.googlesource.com/skia.git/+log/75c38f94efd6..8f46ecc84fab

2020-11-17 bsalomon@google.com Remove two YUV effect GMs: yuv_to_rgb_effect and yuv_nv12_to_rgb_effect.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: lovisolo@google.com
Change-Id: I55eb605201c173ce91db2d4b2a1d72d25a245a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545091Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828492}

This is a follow-up to https://crrev.com/c/2340295 to extend the work to
pre-R version of Android.

According to one experiment, if the keyboard is looking up the initial
surrounding text, the reduction was from 164.83ms to 0.07ms.

We expect a similar level of reduction for pre-R devices.

Note that it is possible that accessing the compat library can slightly
increase the time taken for the first keyboard activation, but overall
this should a significant win.

Bug: b/170464119
Change-Id: I3cbab8d04873a6773c7302ae9cd9064636619302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544064Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828491}

Change-Id: I474e8993f701227990db31aa825aa1c73345394e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542662Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#828490}

This CL converts DEFINE_RESOURCE_TYPE_CASTS() to DowncastTraits<> for:
- CSSStyleSheetResource
- FontResource
- ImageResource
- ScriptResource
- XSLStyleSheetResource

This CL has no behavior changes.

Bug: 891908
Change-Id: Ia2c2c951109f3c156bb5c94f16160d1ec801128d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544327
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828489}

This change enables the native AutocompleteMatch object to create and
retain a copy of its corresponding java counterpart.

The change essentially shifts code around, moving logic away from
AutocompleteController into AutocompleteMatch (both Java and Native).

The change optimizes slightly creation of the Java counterparts by
retaining an object if it's already created. This comes in handy for
every match that is backfilled on every keystroke (about 3 times every
time we call AutocompleteController::Start() to get new matches).

Java AutocompleteMatch objects are lazily constructed to reduce
penalty when native objects end up thrown away -- see:
* AutcompleteController#classify(),
* AutocompleteController#qualifyPartialUrlQuery()

Bug: 1138587
Change-Id: I8c5437cfb0203d5c7f5e1d79747eee3f15b7b0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538499
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828488}

The previous barrier was difficult to use, as it expected a call on
success or error. This barrier only expects to be called on error, and
will automatically call the completion callback when all instances and
callbacks are destroyed.

Change-Id: If5be817c419e0858b348fd75da8385700a02bb88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532906Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828487}

This reverts commit 6d681c88.

Reason for revert: Causing test failures on MSAN builds:

https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21346

Original change's description:
> ambient: support multiple displays
>
> Run ambient mode UI on each connected display.
> RootWindowController construction handles adding ambient widgets
> to new displays while ambient mode is running, and destructing them
> on display removed.
>
> BUG=b:139953389
>
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Change-Id: Ic57c33491098b66c7c0e90ef1f3d12c71f1fc303
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516968
> Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828329}

TBR=oshima@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,cowmoo@chromium.org

Change-Id: I255333ed722549fdc9d0e945c65cf3f742b1cabc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:139953389
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545752Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828486}

UX prefers this string.

Bug: 1142473
Change-Id: I0fb5d1ac20b9c0dc8b2e44eb7e87c28307fabf9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544881
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828485}

Every so often, the Rosetta installer will call back
the provided "installation done" block more than once.
Protect against that.

Fixed: 1150097
Change-Id: Ib12db225e7c7f5ec7c7fa69dccdd12693575a944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545076Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828484}

Add IPH globally scoped data and add trigger logic for install IPH that
doesn't show IPH unless site-engagement score is above 10 and IPH hasn't
been shown for this site for 90 days, and hasn't been shown globally for
14 days, and hasn't been ignored by user 3 days in a row for this site
and hasn't been ignored by user 4 days in a row globally.

Bug: 1149670
Change-Id: Idff12df63673f6e8e1fd63383f7fc57c07eb748a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530197
Commit-Queue: Phillis Tang <phillis@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828483}

This reverts commit 34ec1547.

Reason for revert: Tests are flaky, see linked bugs.

Original change's description:
> Add title visibility option to Incognito CCT.
>
> This CL gives ability to Incognito CCT to show title on toolbar.
>
> For screenshot:
> https://drive.google.com/file/d/1WQFhK3yhVsF-OazSSrUh9d8mfpNb1ZeK
>
> Bug: 1104180
> Change-Id: I195ba2200d0994bb0aea5f06ce017ec81172e2a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537677
> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
> Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828235}

TBR=peconn@chromium.org,roagarwal@chromium.org,sideyilmaz@chromium.org

Change-Id: I16ccce7ebb6bd0dc1692e530545f33ed5ccfcfd7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1104180, 1150150, 1150083, 1150056 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545258
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828482}

This reverts commit 94d2d696.

Reason for revert: Reverting the CL that added these tests rather than disabling the test

Original change's description:
> [Sheriff] Disable flaky CustomTabActivityIncognitoTest#ensureTitleBarIsVisibile
>
> TBR=roagarwal@chromium.org
>
> Bug: 1150085
> Change-Id: I698d73ba2ef50883ead5093eb1ba64407bac07b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545568
> Commit-Queue: Lijin Shen <lazzzis@google.com>
> Reviewed-by: Lijin Shen <lazzzis@google.com>
> Cr-Commit-Position: refs/heads/master@{#828470}

TBR=lazzzis@google.com,sideyilmaz@chromium.org

Change-Id: Ie73e3321c84f193b1fa13319f953b257a8a5b434
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1150085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545095Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828481}

Bug: chromium:1149490, chromium:1149491
Change-Id: If21180126089c7a7fe9d714a6a3c0cc09880f27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542045
Auto-Submit: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hugo Benichi <hugobenichi@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828480}

extra_input_methods is actually all the available input methods; there's
nothing "extra" about it.

Change-Id: I86e444aed7bec8660351dc9787147ee68341d49b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537452
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828479}

When we added support for versioned message we accidentally introduced a
behavior where messages can be shorter than expected. This is what the
behavior should be to allow older messages to be received. However,
we know the minimum size is the oldest message version. We should
never be allowed to go smaller than that.

BUG=chromium:1149805

Change-Id: I3a24dd62b6fafd742cd7ac155f863d33bb5c6de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545207Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Brian Geffon <bgeffon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828478}

Updates a few WebCodecs IDL dictionary types to use the 'required'
attribute where the draft spec indicates. In particular, it updates
AudioFrameInit, EncodedAudioChunkInit, and EncodedVideoChunkInit to
enforce the required fields are populated.

I also looked at making similar change to VideoDecoderConfig, but the
codedWidth and codedHeight fields' usage in the implementation already
has notes that go deeper (AVCC coherence is TBD, for example).

Also includes a change to make EncodedVideoChunkInit.duration _not_
nullable. It is not required, so its absence is sufficient to indicate
it is unset. Retains the nullable attribute on the readonly
EncodedVideoChunk.duration field.

BUG=1149028

Change-Id: If82c495d94ed9532007dfda614ec97bc88e773ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543126Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828477}