GitLab

will remove the flag from the skia side after this lands

BUG=

Review URL: https://codereview.chromium.org/396733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393266
For log only change to profile_io_data.cc (reviewed by mattm)
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/385993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283648 0039d316-1c4b-4281-b951-d872f2087c98

This CL handles create a helper method in browser_tests to dismiss the host-out-of-date warning if it is displayed.

BUG=393072

Review URL: https://codereview.chromium.org/389673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283647 0039d316-1c4b-4281-b951-d872f2087c98

build/grit_target.gypi does this for us, clients/consumers just need to define grit_out_dir variable and include grit_target.gypi for the magic happen.

Found these entries with the following command line:

$ for f in $(g ls-files | grep resources.gyp); do grep direct $f; echo $f;
done
$ for f in $(g ls-files | grep strings.gyp); do grep direct $f; echo $f;
done

BUG=None
TEST=None
TBR=keybuk@chromium.org,yoz@chromium.org,darin@chromium.org

keybuk for device/bluetooth/
yoz for extensions/
darin for webkit/

Review URL: https://codereview.chromium.org/389223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283646 0039d316-1c4b-4281-b951-d872f2087c98

Fix the MIPS Linux build that was broken by r282266 (and r282246).
Related r282266 review is at https://codereview.chromium.org/382743002

TEST= build Chrome Linux for target_arch=mipsel

Review URL: https://codereview.chromium.org/396243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283645 0039d316-1c4b-4281-b951-d872f2087c98

r280376 changed the button drag image painting code.
The label colors used make the text appear blurry.

Use label native theme colors instead of button colors.
(the black-on-white looks better than black-on-gray)

See before/after pics at http://crbug.com/394245#c4

BUG=394245
TEST=Bookmark/URL drag images look okay.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/400443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283644 0039d316-1c4b-4281-b951-d872f2087c98

If no override is given, simHomePath needs to be initialized or iossim
won't know where to find files (e.g. the simulator's sandboxed
system.log)

BUG=None

Review URL: https://codereview.chromium.org/398133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/395303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283642 0039d316-1c4b-4281-b951-d872f2087c98

Currently we associate touchscreen to display based on matching
resolution. But there could be cases the internal touchscreen
reports a resolution that does not match any display resolution,
or the internal display and external display have the same resolution
so we don't know which display to match the touchscreen to.

This patch adds a logic that if we have internal touchscreen and
internal display, we should match them first regardless of the
resolution.

We already have the information about which display is internal display.
For deciding internal touchscreen, we query X to get the touchscreen's
/dev/input/eventX  node, and call a script is_touchscreen_internal
(which checks if the device is a I2C device) to decide whether the
touchscreen is internal or not.

BUG=chrome-os-partner:29398
TEST=touch position is correctly mapped on Blaze in extending mode, with
     external monitor having 1920x1280 resolution.

Review URL: https://codereview.chromium.org/394063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283641 0039d316-1c4b-4281-b951-d872f2087c98

With https://codereview.chromium.org/331993009/, GetMenu() may return
NULL if running a native Cocoa menu.
This patch deletes GetMenu and updates call sites to no longer call it.

BUG=388455

Review URL: https://codereview.chromium.org/393943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337829

Review URL: https://codereview.chromium.org/402433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283639 0039d316-1c4b-4281-b951-d872f2087c98

In the "delete the only active profile and create a new one" case, the newly
created profile should use the placeholder avatar, and not one of the custom ones. 
The same should happen for the first run default profile.

BUG=NONE
TEST=Start Chrome with --new-profile-management. Delete all the profiles you have.
The newly created profile should use the default guest-looking avatar (which you
can check in the avatar bubble).

Review URL: https://codereview.chromium.org/392313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283635 0039d316-1c4b-4281-b951-d872f2087c98

KeygenHandler defaulted to use the persistent key slot. However, the Handler is also used in ChromeOS where no such global persistent slot exists.

This change removes this default behavior from KeygenHandler.
Instead only the slot provided by the CryptoModuleDelegate will be used.
If no CryptoModuleDelegate is set, then an error will be thrown on keygen usage.

The unit test of KeygenHandler now explicitly provides the slot through a StubCryptoModuleDelegate.
In a follow up, the crypto::GetPersistentNSSKeySlot() call will be removed from the unit tests as well and instead the test slot will be get()'ed from the ScopedTestNSSDB.

BUG=210525

Review URL: https://codereview.chromium.org/384413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283634 0039d316-1c4b-4281-b951-d872f2087c98

In particular, Widget::SetCapture() fails if the widget is not visible.

BUG=None
TEST=WidgetCaptureTest.FailedCaptureRequestIsNoop

Review URL: https://codereview.chromium.org/375593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283633 0039d316-1c4b-4281-b951-d872f2087c98

Adapts to changes in https://codereview.chromium.org/381113004.

R=lcwu@chromium.org,brettw@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/396733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/395503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283630 0039d316-1c4b-4281-b951-d872f2087c98

Rewrites the themes sync integration tests so they no longer depend on
AwaitQuiescence() or related functions.

Removes racy themes tests.  They don't offer significantly better
coverage than non-racy tests.  Most of them were flaky and partially
disabled.

Adds or modifies existing tests so we have some coverage of both model
association and ProcessSyncChanges().

BUG=97780,95742,84575,304554

Review URL: https://codereview.chromium.org/395503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283629 0039d316-1c4b-4281-b951-d872f2087c98

8f75c67  Disable warning 4267 in pdfium until it is fixed.
e76e823  Remove unused variable orig_size.
3d07b6f  Do not disable warnings-as-errors for pdfium.

BUG=375114
R=thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/400483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283628 0039d316-1c4b-4281-b951-d872f2087c98

Create bridge functions that converts arguments into Blink objects
(such as WebFileSystemEntry and WebFileInfo) after crossing threads
and then call WebFileSystemCallbacks methods.

BUG=393900

Review URL: https://codereview.chromium.org/391083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283627 0039d316-1c4b-4281-b951-d872f2087c98

The permissions section in the App Info dialog originally started with
'It can'. Changed it to start with 'Permissions', so it is consistent
with the other dialog headings.

BUG=386871

Review URL: https://codereview.chromium.org/395653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382489
NOTRY=True

Review URL: https://codereview.chromium.org/391643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394624
R=thestig@chromium.org
TBR=mmenke@chromium.org, thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/399013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283621 0039d316-1c4b-4281-b951-d872f2087c98

He's changing teams :'(

NOTRY=true
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/391293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/399433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283619 0039d316-1c4b-4281-b951-d872f2087c98

TBR=earthdok@chromium.org
BUG=340752

Review URL: https://codereview.chromium.org/398053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283615 0039d316-1c4b-4281-b951-d872f2087c98

Blech: Stuff fails. Shockingly.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/27268/steps/mojo_shell_tests/logs/stdio

> Mojo: Enable mojo_shell_tests on Windows (on the bots).
> 
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/398023002

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/398253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283610 0039d316-1c4b-4281-b951-d872f2087c98

ASan failure (use-after-free) looks like it's due to this change):

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

E.g.:

@@@STEP_LOG_LINE@ReloadEmbedder@SUMMARY: AddressSanitizer: heap-use-after-free content/renderer/render_frame_proxy.cc:168 content::RenderFrameProxy::OnMessageReceived(IPC::Message const&)@@@j

> Changes to RenderFrameProxy:
> 
> - Add accessors: web_frame(), routing_id(), render_view().
> - Remove accessor: render_frame(). Where we do need to touch the
>   RenderFrame, we'll look it up by its routing ID.
> - Small change to the CompositingHelper to use the new getters.
> - Add a map to allow finding a RenderFrameProxy by its associated
>   blink::WebFrame.
> - Introduce a second factory function and differentiate the two
>   factory functions according to the two ways RenderFrameProxies will
>   be created. The first is for when an extant local RenderFrame is
>   being swapped out and replaced with a new RenderFrameProxy. The
>   second is for when a RenderFrameProxy needs to be created without
>   displacing an existing RenderFrame, as shall occur once we mirror
>   the frame tree.
> - This second factory function, which is uncalled at the moment, will
>   create WebRemoteFrames. Also there is stubbed out code in the first
>   factory function to create WebRemoteFrames. This code is in
>   preparation for eliminating the RenderFrame (and its attendant
>   WebLocalFrame) and having instead just a RenderFrameProxy.
> - Add some defensive checks to prepare for when the render frame may
>   not exist, as will happen once the second factory function
>   enters use.
> - Add an Init function so that code can be shared between the two
>   factory functions.
> 
> As an adminstrative note, this patch is a chunk of nasko's 
> larger "use RenderFrameProxyHost" effor (issue 241223002)
> 
> BUG=357747
> TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process
> 
> Review URL: https://codereview.chromium.org/357043006

TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/397103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283608 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally left this out from r283441.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/394263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283606 0039d316-1c4b-4281-b951-d872f2087c98

Per review comment from https://codereview.chromium.org/398553002/. Note
that I'm keeping the |pass| and deleting the redundant assignment (so
now the |pass| is required). The alternative would be to nest the other
|if|s inside an |if ... is not None|, but I find that harder to read.

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/396243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283605 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/395243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283601 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/395203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283600 0039d316-1c4b-4281-b951-d872f2087c98

The PrerenderOmniboxAbandon test fails with a command line that is too long
for the windows RegisterApplicationRestart API.

TBR=mmenke@chromium.org,gavinp@chromium.org

NOTRY=true

BUG=394592

Review URL: https://codereview.chromium.org/400493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283599 0039d316-1c4b-4281-b951-d872f2087c98

Some files were compiled for both remoting_host and remoting_core. Also
moved some files to remoting_host so that they don't need to be listed
multiple times for different platforms

Review URL: https://codereview.chromium.org/393073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393388
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/396063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283595 0039d316-1c4b-4281-b951-d872f2087c98

oobe-skip-postlogin has been overloaded and it does a lot more than just suppress the postlogin screens.

We need session restore/merge and enrollment for gaia login, but not for fake telemetry login.

BUG=393011
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/384973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283594 0039d316-1c4b-4281-b951-d872f2087c98

Previously, infobars were shown at the bottom of the screen on phones,
but at the top of the screen on tablets.

BUG=375379
NOTRY=true

Review URL: https://codereview.chromium.org/396863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283593 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283592 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 283542.

This broke the WebView Android build.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283591 0039d316-1c4b-4281-b951-d872f2087c98