GitLab

R=erg

Change-Id: I7707cf02b88a08e416d2fc0a17bfd75b918fe42c
Reviewed-on: https://chromium-review.googlesource.com/894993Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533330}

io_thread's GetNetworkServiceOnUIThread() is removed in r525444.
This is to update the header file.

R=mmenke@chromium.org

Change-Id: I0ce2f34c68c333fa1a525952d43f6058329afe11
Reviewed-on: https://chromium-review.googlesource.com/895803
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533329}

Since native_client_sdk can't include base/ headers, and since
the sdk is always built by clang, just use the clang attribute
directly. (Alternatively, we could've disabled the warning for
this target.)

This CL was uploaded by git cl split.

R=binji@chromium.org

Bug: 177475
Change-Id: I14cf95478a0da89a8426e748ded165eb177c4c24
Reviewed-on: https://chromium-review.googlesource.com/891900Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533328}

Bug: None
Change-Id: I89c72bc8905a6a7dd8e339ba328e92e67f949b3e
Reviewed-on: https://chromium-review.googlesource.com/894504Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533327}

Theme colors will be enabled for Chrome modern design, so there is no
need to force the default theme color in LayoutTab.

BUG=803098

Change-Id: Iab41c5f7ba8250a3dd2a62433392428f305efca4
Reviewed-on: https://chromium-review.googlesource.com/894694
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533326}

This is an attempt to enable tests that had been disabled due to flakiness on
webrtc bots. There is hope that the flakiness is resolved by the tests now
being run sequentially since [1] and [2] have landed.

The test pass when I run them on my local machine.

[1] https://chromium-review.googlesource.com/872260
[2] https://chromium-review.googlesource.com/876003

Test: content_browsertests --gtest_filter=UsingRealWebcam* --run-manual --test-launcher-jobs=1

Bug: 733582
Change-Id: If536e4c0b87c0a7de50ffc35f8c0a1d9abc52359
Reviewed-on: https://chromium-review.googlesource.com/894883Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533325}

This code no longer appears to be touched at all. Removing
it will reduce the complexity of FindMouseEventTarget, and
facilitate removing the similarly dead code path associated
with BrowserPluginMsg_SetTooltipText.

Bug: 533069
Change-Id: I25927f17268e25d39edbe6586dfc37bae959eb7c
Reviewed-on: https://chromium-review.googlesource.com/894422Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533324}

This CL tags a subframe as an ad if its parent frame is tagged as well.
This extends the coverage of frames tagged as ads from just those that
match the ruleset to those that do not match but their parent frame is
tagged as an ad frame.

BUG: 807640
Change-Id: Ifee656298cdbe8bc16bcd24a16bc9a9905e2c2a3
Reviewed-on: https://chromium-review.googlesource.com/894542
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533323}

https://chromium.googlesource.com/angle/angle.git/+log/e13f7ebea887..79de62c665bd

$ git log e13f7ebea..79de62c66 --date=short --no-merges --format='%ad %ae %s'
2018-01-31 thakis Explicitly suppress -Wimplicit-fallthrough for angle and its deps.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ie3905a4b23589a3ffa6af08db2a816c42c538d4f
Reviewed-on: https://chromium-review.googlesource.com/894695
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533322}

https://pdfium.googlesource.com/pdfium.git/+log/4b0c5b935471..41b45a88f14e

$ git log 4b0c5b935..41b45a88f --date=short --no-merges --format='%ad %ae %s'
2018-01-31 rharrison Clean up CSS property table
2018-01-31 thestig Clean up FPDFPage_New() documentation.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1d1f78460b346c66b4d574c559e0f7ba7d343057
Reviewed-on: https://chromium-review.googlesource.com/894899Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533321}

https://webrtc.googlesource.com/src.git/+log/f9e012149f27..7c4dedade158

$ git log f9e012149..7c4dedade --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I156bb813c55350577a9787eb286afd99ac898040
Reviewed-on: https://chromium-review.googlesource.com/895407Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533320}

This transition (which is currently only possible with an experiment enabled)
can look messy/confusing when animated, so do not animate it.

Bug: 807075
Change-Id: I1dae69b64e0e9f457b87abf7c4ff45ba1f595dad
Reviewed-on: https://chromium-review.googlesource.com/891587Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533319}

Adds VrShellNavigationTestWebXr, which contains copies of all the tests
in VrShellNavigationTest that make use of WebVR. These will be merged
back in to VrShellNavigationTest once WebVR is removed.

Bug: 804043
Change-Id: I50c6a8618d9f1ef09de92a44b88aef5dff4bd46d
Reviewed-on: https://chromium-review.googlesource.com/887165Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533318}

This CL fixes a bug where the value of the currency amount was being
checked against the maximum allowed string length not the length of the
value string.

Bug: 806666
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8897c93f06e8cb590c5414497b53ab87fa291e77
Reviewed-on: https://chromium-review.googlesource.com/895546Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533317}

Adds bsheedy as an owner of chrome/android/BUILD.gn for changes related
to VR Javatests so that other owners don't have to be bothered by
VR-only changes.

Change-Id: I0d84468848d1e6a8b43f2a4844edfdbad3e78ca9
Reviewed-on: https://chromium-review.googlesource.com/894362Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533316}

location.replace changes the URL of WKBackForwardListItem. Update the
URL of NavigationItem to that of the host WKBackForwardListItem upon
access. It's done this way because location.replace cannot be reliably
distinguished from normal navigations in either WKNavigationDelegate
callback or URL KVO.

This fixes NavigationTestCase/testWindowLocationReplaceAndChangeHash.

Bug: 807428
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaef4ed5efd788283050b43a3b4e988311ec9cf76
Reviewed-on: https://chromium-review.googlesource.com/894490
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533315}

This is a reland of 53b1b7da.

Original change's description:
> Remove Dezippering from BiquadFilter
> 
> Remove dezippering from all of the attributes.  The value will now 
> change immediately instead of gradually changing from the old value
> to the new value.
> 
> Chromium Feature: https://www.chromestatus.com/features/5287995770929152
> Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YKYRrh0nWMo/aGzd3049AgAJ
> 
> Bug: 752986
> Test: BiquadFilter/dezipper.html
> Change-Id: I86840159709158fd52a69a7c3c5f279267277d44
> Reviewed-on: https://chromium-review.googlesource.com/612104
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532910}

Bug: 752986
Change-Id: Ia911c6e93d7dd7da1dea6290ac4201f81f42da3a
Reviewed-on: https://chromium-review.googlesource.com/894243Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533314}

This CL relands crrev.com/c/886543, enabling the GLImageBindTest for
GLImageIOSUrface with the BufferFormat BGRX_1010102.

The CL also adds a provision to swizzle the color channels when running
on nVidia on High Sierra to workaround some bug that can be repro'ed on
the bots and stand alone laptops.

Bug: 803473
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5472606a82b393fe1d2375b3c644e836ea7f12cf
Reviewed-on: https://chromium-review.googlesource.com/890007Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533313}

This transition (which is currently only possible with an experiment enabled)
can look messy/confusing when animated, so do not animate it.

Bug: 807075
Change-Id: Ib7bda303958739cd4840dbc57910c1c850c5e97a
Reviewed-on: https://chromium-review.googlesource.com/891630Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533312}

This reverts commit 871421fc.

Reason for revert: this change hasn't fixed the failing tests.

Original change's description:
> Fix SitePerProcessMouseWheelHitTestBrowserTest.* tests on Win official.
> 
> https://chromium-review.googlesource.com/865558 fixes this flaky tests
> on win7_chromium_rel_ng, but it only waits for dispatching of the
> first wheel event before sending the others.
> 
> This cl makes sure that each wheel event gets dispatched before sending
> the next one.
> 
> I haven't been able to reproduce the bug on my local windows official
> build but I suspect that after using async wheel targeting for wheel
> events some of the wheel events in RunTest get coalesced to each other
> before getting dispatched.
> 
> Bug: 800822
> Change-Id: Id693ef3beff19daf08c3e11c2119b2bf90ef6737
> Reviewed-on: https://chromium-review.googlesource.com/893803
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533002}

TBR=kenrb@chromium.org,nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org

Change-Id: I62fa9ba2075ffaf7ac685dad56af84bd06237214
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 800822
Reviewed-on: https://chromium-review.googlesource.com/894998Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533311}

https://wicg.github.io/picture-in-picture/

The API is currently not working. It is mostly about implementing the shell: it
exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and
video.requestPictureInPicture(). It also adds the "picture-in-picture" feature
policy. Everything is gated by the "PictureInPictureAPI" runtime feature.

Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ

Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb
Bug: 806249
Reviewed-on: https://chromium-review.googlesource.com/867915
Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533310}

Whenever any requests are running, ResourceDispatcherHostImpl polls for state
changes to running requests, so that these can be reflected in the UI. However,
ResourceDispatcherHostImpl doesn't remember the previous state of a request, so
it always calls LoaderDelegate::LoadStateChanged() for any running request, at
4Hz. This calls into WebContentsImpl::LoadStateChanged(), which *does* have
access to the previous state, which then notifies the UI of a change.

Instead, WebContentsImpl should check if the state notification is redundant,
and if so, should ignore it. This will save doing a bunch of work in the UI. In
principle, ResourceDispatcherHostImpl could do this de-duplication instead, but
that involves storing more data in RDHI for a very small further decrease in
work done.

This also fixes the root cause of an old bug where on Mac, the status bar would
be clobbered (at 4Hz) whenever there was a pending request in the current tab.
This bug was worked around in the Views status bar code by suppressing updates
with no text changes, but that workaround never made it to the Cocoa status
bar.

Bug: 147303
Change-Id: Idbaded695b161543d1750aa9e6253c3bdd0a145a
Reviewed-on: https://chromium-review.googlesource.com/895724Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533309}

TBR=vitalybuka@chromium.org

Bug: 539572
Change-Id: I1e7dbad47b8f5b4debfd4ab071ce946d07c0d93f
Reviewed-on: https://chromium-review.googlesource.com/885085Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533308}

Disable GL_EXT_disjoint_timer_query for Nexus5 and Nexus7v2, because
glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly.

Bug: 750306, 764526
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I752d51c05c26203a759b6c2ded961a84a90cc4cd
Reviewed-on: https://chromium-review.googlesource.com/895246Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533307}

With the new async hit-testing code, the RenderWidgetHostViewGuest-
specific code in RenderWidgetHostInputEventRouter::FindMouseEventTarget
no longer seems to be hit, and thus mouse events are bypassing the
embedder (and hence the BrowserPlugin) for PDFs.

This CL changes RenderWidgetHostViewGuest so that it refers tooltip
text requests directly to the root view, instead of sending them to
the BrowserPlugin.

Bug: 807236
Change-Id: Ic943e6bca70035fb5ac9198281412fbc6b7887f1
Reviewed-on: https://chromium-review.googlesource.com/894145Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533306}

When the main thread receives DidCommitAndSwap from the impl thread and
the main thread hasn't commited after resize, DidCommitAndSwap belongs
to the previous commit and should not be used for acking the resize.
In other words, (Resize,DidCommit,DidCommitAndSwap) should ack the
resize but (DidCommit,Resize,DidCommitAndSwap) should not.

Change-Id: Ib55c4acb82a90560e1a75d7327e08321b1bf7f0c
Reviewed-on: https://chromium-review.googlesource.com/883909Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533305}

No functional change.

Bug: None
Change-Id: Ie077b642c13f5b4b88f7940250912c6b032285cb
Reviewed-on: https://chromium-review.googlesource.com/873632Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533304}

Bug: 803372
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icdfc2ee6450ab03cf357792cc3ad6d0060baf58e
Reviewed-on: https://chromium-review.googlesource.com/891518
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533303}

Chrome Custom Tabs have a menu item allowing users to open that page in
their browser. Pass an extraCallback to the Custom Tab host to notify
them.

Bug: 806891
Change-Id: Ia67e8033d261f9be4735f446a3e5a96b58a24f6c
Reviewed-on: https://chromium-review.googlesource.com/890746
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533302}

https://chromium.googlesource.com/angle/angle.git/+log/199f42941ab5..e13f7ebea887

$ git log 199f42941..e13f7ebea --date=short --no-merges --format='%ad %ae %s'
2018-01-26 oetuaho Make NVIDIA constant register zero skip specific to VS

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: If456703efa422a9ee7fdf236d8e0cb365f7c4ad3
Reviewed-on: https://chromium-review.googlesource.com/894715Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533301}

One test that verifies fetching, filling, and clearing.

Bug: 778764
Change-Id: I77653f323941a66bc1ae3c490cebb4d92de29b02
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/841342
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532462}
Reviewed-on: https://chromium-review.googlesource.com/894483
Cr-Commit-Position: refs/heads/master@{#533300}

This would allow M66 cap in the Finch config. Removing the Feature and
OmniboxMode/etc will be slightly easier to do when Prerender gets
hard-disabled, postponing the cleanup until then.

Bug: 762489
Change-Id: Ica411ec05a211c8aa3bf779b6c8764403a36308d
Reviewed-on: https://chromium-review.googlesource.com/895764Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533299}

We are aiming to deprecate this feature in M67. This warning may have
some false positives (as it is legal to use '#' as a fragment
identifier), but I have yet to find a case in the wild of someone
actually doing that.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_g_HnAHkMPo/1DrejG5mAgAJ

Bug: 123004
Change-Id: Ibace7288ddb6a814f51faec85c47a49b0d69a273
Reviewed-on: https://chromium-review.googlesource.com/888762
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533298}

https://webrtc.googlesource.com/src.git/+log/bbf46c27538c..f9e012149f27

$ git log bbf46c275..f9e012149 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I047e0fff680ae5079284dfaa1008befe287a0a05
Reviewed-on: https://chromium-review.googlesource.com/894898
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533297}

No behaviour changes.

Change-Id: I758665a5dfb20dce35394d083f7f2a9fc82115c0
Reviewed-on: https://chromium-review.googlesource.com/894474
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533296}

From the header it's not obvious what Show/Hide means in terms of this
class' behaviour. This CL adds clarification as to their effect on
GetCurrentValue().

Change-Id: Ib5ebe34a687c6562442a27172b767b5d0f8fe3a7
Reviewed-on: https://chromium-review.googlesource.com/894862Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533295}

This CL adds a flag to SubresourceFilter which is currently set based
on the subresource filter rule set matching. Subsequently this will also
be set when the initiator of this frame is an ad resource even if
this does not match the subresource filter ruleset.

Note that the matching already takes place in the browser process and
this flag is set at commit time when the browser process communicates
the status of matching to the renderer process.

Note that this will work for both browser initiated and renderer
initiated subframes (in PlzNavigate) as is currently the case with
subresource filter matching.

BUG: 807640
Change-Id: If883be8209a7756c6024c1c9eda1a8d081f815a1
Reviewed-on: https://chromium-review.googlesource.com/868261
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533294}

When the user is viewing a preview page and selects "Show original",
the client asks the NavigationController to Reload(DISABLE_PREVIEWS).
It currently reloads the last committed URL which is a problem if
the preview caused a client redirect to occur so that the last
committed URL is a preview-specific URL. Really, we want to reload
the original requested URL to show the original page.

This CL updates the NavigatorImpl::NavigateToEntry() logic to use
the original request URL for ReloadType::DISABLE_PREVIEWS just as it
currently does for ReloadType::ORIGINAL_REQUEST_URL.

Bug: 795940
Change-Id: Ic167afa48dca9e40eac3f0dabaf0fb5c5b6ddcdc
Reviewed-on: https://chromium-review.googlesource.com/879026
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533293}

Once loading of an archive has been started, it should not start loading
the same file again.
Existing logic returns "EXISTS" error via fileSystemProvider API when
an archive is already mounted.
However, it missed handling of a case where user requested opening the
same archive while its loading is ongoing.
It typically happens when an archive is on Drive and not yet cached.

As a transitive fix, this change reuses the "scanning..." message to
indiacte that user need to wait operation finish in such case.

Bug: 807254
Test: manually tested on Files app as noted in the bug.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90d5b8b2c157ea40b40ad106bbcb85b1bd022ea7
Reviewed-on: https://chromium-review.googlesource.com/895424
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533292}

This CL adds a few things:
- autogenerated unittests
- associated mocks
- associated test drivers
- enough implementation in raster_decoder.cc to make the tests pass

No changes to GLES2 autogen.

Bug: 789238
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iac2ee4922a21f3bd11ff58693e2e5fb1fe26bd45
Reviewed-on: https://chromium-review.googlesource.com/891988
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533291}