- 05 Feb, 2020 40 commits
-
-
Changwan Ryu authored
Add an option to inspect system wide profiling (as opposed to profiling one app and one activity). Bug: None Change-Id: I4c1b5e98494216f3912932d141db9ae4a3433d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037023 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738589}
-
dalyk authored
This change introduces a toggle and radio buttons that are shown when the toggle is enabled. Future cls will introduce a dropdown menu and text field alongside the second and third radio buttons, respectively. The visibility of the setting is controlled by a new param, ShowUi, associated with the DnsOverHttps feature. The new param currently defaults to false. Change-Id: I9d9322cbdf64f9d66cd744de01829300446b8896 Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980480 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#738588}
-
Dave Tapuska authored
Move this binding into where the LayerTreeSink is created and pass the result in the callback along with the LayerTreeSink. Change-Id: I42ed0ae21316fda8974acbe85994bca62480b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036434 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738587}
-
Michael Ershov authored
Bug: 1045895 Change-Id: Ide014c5da95fe20847ea226ca9590e8884026ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038694Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#738586}
-
Leonard Grey authored
Turns out this actually matters in Mojave (but not Catalina). Bug: 1032704 Change-Id: I31dbf8fd0d7c6c1f99ab227a3c7158d8c64db89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962649 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738585}
-
Nazerke authored
This CL removes public properties for WebStateList, BrowserState and dispatcher values and updates the coordinators implementation to get them from self.browser. The refactored coordinators: - Adaptive Toolbar Coordinator - Primary Toolbar Coordinator - Secondary Toolbar Coordinator. Bug: 1029346, 1047873, 1048663, 1048674 Change-Id: I228ac98252cb315e84914bc5d5539168260b8faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013280 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#738584}
-
Rayan Kanso authored
The handler can now support checking for different types of digital asset links, including web targets. Also includes some minor stylistic improvements. Bug: 1043970 Change-Id: Icb651573a98201c810e53f74cea91a225a48cac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037673Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#738583}
-
Daniel McArdle authored
Also modifies DecodeBcd() to handle invalid inputs (and removes DCHECKs), since the inputs may come from an untrusted USB device. Change-Id: I387ec1fe51b6916fe7c097123936991d67f228aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033850 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738582}
-
Stepan Khapugin authored
Moves the implementation of BrowserStateStorageSwitching to BrowserViewWrangler and inverses the dependency so that MainController now needs BVWrangler to switch contexts. This makes sense in multiwindow world where BVWranglers are per-scene. Bug: none Change-Id: Idd9b76480c425a3508a476438126b656bf362cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036007Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id796443dbafb55b857f04a2e3204e3ce58c2478d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038721Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#738580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c631b7cc5f8c..c61d7e3d6e12 git log c631b7cc5f8c..c61d7e3d6e12 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 egdaniel@google.com Rename various getters related to GrSurfaceProxyView. Created with: gclient setdep -r src/third_party/skia@c61d7e3d6e12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I2175ef10442a2bf2c7c0cbdda033d470ad891d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738579}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f50e6be1c2a..51b5640863e8 Created with: gclient setdep -r src-internal@51b5640863e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045478,chromium:1049064 Tbr: jbudorick@google.com Change-Id: I6f3f2a830d1659c437f88bc18f9d5a9477e4b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039033Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738578}
-
David Tseng authored
Bug: 1047069 Test: manual (there isn't an easy stable way to test this in either js or interactive ui tests). Change-Id: Ia91a585ec314066a4cceea244e4872a15598cc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037731Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738577}
-
Zhenyao Mo authored
The data is then send back to browser process. This CL only adds mojo links. No data actually collected. Bug: 1039792 Change-Id: I11b1cb9876ebaff2b5fe164db476549e682412e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031857Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738576}
-
Paulo Warren authored
This CL incorporates new behavior into the wayland base client for testing udmabuf_create on the server side. If memfd_create succeeds, the client allocates a memory region using memfd_create instead of the chrome SharedMemoryRegion class. The returned buffer is page aligned, and sealed with F_SEAL_SHRINK due to the requirements of udmabuf_create on the server side. TEST=autoninja -C out_atlas/Release/ wayland_simple_client then scp the client to an atlas chromebook. To run add --use-dmabuf flag. BUG=None Change-Id: I27f6f04c1d577e172bbb68bd09718e6f0d6d65f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003267Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Paulo Warren <pwarren@chromium.org> Cr-Commit-Position: refs/heads/master@{#738575}
-
Elly Fong-Jones authored
This change moves these tests from Mac-only to all Views platforms, although they are currently disabled on Windows & Linux because of the linked bug. To do this, the tests are rewritten to use Views APIs rather than directly using NSWindow, and PermissionRequestManagerTestApi is modified to deal in Widgets rather than NativeWindows. This change also removes PermissionBubbleViewsInteractiveUITest, which was an incomplete copy of PermissionBubbleInteractiveUITest dating to the initial MacViews secondary UI work, and also has never run on any non-Mac platform. Bug: 866878 Change-Id: Id0cbf5e2e1ec54afed57fd74e2c4380c1003de40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038157Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738574}
-
Takuto Ikuta authored
This is to take crrev.com/c/2038910 Bug: 984869 Change-Id: Id41f3e6c499a6f9d0c849eb1447a6c9982399c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738573}
-
Liquan (Max) Gu authored
Context: PaymentRequestEvent.OpenWindow() promise should be resolved to be a window client. With ExpandablePaymentHandler enabled, OpenWindow is never resolved. This makes a payment app service worker fail to send a message to the payment app js since it relies on the resolved WindowClient. Before Change: With ExpandablePaymentHandler enabled, PaymentRequestEvent.OpenWindow() is never resolved. After Change: With ExpandablePaymentHandler enabled, OpenWindow is resolved upon initializing the WebContents of PaymentHandler. Change: Notify ServiceTabLaunch when Expandable PH UI has initialized WebContents, so that ServiceTabLaunch can resolve the OpenWindow() promise. Bug: 1045955 Change-Id: I3fae5f90d144d27e97044f175478072743de05aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037643Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738572}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I809b408ce2d18a725cacfa876b7c906f471e6d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028122Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738571}
-
Mark Schillaci authored
This CL addresses a regression that appeared as part of the change: https://chromium-review.googlesource.com/c/chromium/src/+/1998829 This CL fixes backwards navigation by granularity of line or word which was not announcing any traverse events due to a bug in the above CL. Bug: 1048246 Change-Id: I128f5e532bf6a6212daae41eb4d571fa7f10bdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037454Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#738570}
-
Tim van der Lippe authored
These need to be disabled for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2035936 to land Bug: 1006759 Change-Id: I021ce279a6bc4a586179eef36a2bfcc22972ec14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038730 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#738569}
-
ckitagawa authored
Adds support for paint previews to capture OOP subframes. This essentially mirrors the established path printing uses, but differs in that is uses Mojo and embedding tokens rather than IPC and routing ids. Part of landing: crrev.com/c/1786583 Bug: 1011828, 1014955 Change-Id: If1593ec23c66d9fd9e8b49aef6dde063e17ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985812Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#738568}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0335e6749943..01005814aa9a git log 0335e6749943..01005814aa9a --date=short --first-parent --format='%ad %ae %s' 2020-02-05 janscheffler@chromium.org Add Issues Drawer 2020-02-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-05 yangguo@chromium.org No longer check for experiments flag from backend 2020-02-05 tvanderlippe@chromium.org Add tests for various console.log interactions 2020-02-05 szuend@chromium.org Enable asynchronous {uiLocationToRawLocations} 2020-02-05 szuend@chromium.org Prepare BreakpointManager for source map asyncification Created with: gclient setdep -r src/third_party/devtools-frontend/src@01005814aa9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1039607,chromium:1047671,chromium:1048124 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f87222abd478ffa990cf417f8f4dc3a6cb88d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038189Reviewed-by:
-
Donn Denman authored
Detects the language of the selection whenever it is set instead of waiting for the resolve request to return. This allows the translation to be done during the Resolve request for the ContextualSearchTranslations experiment. Also update the logic for detecting the language. Try to detect the language of the selection first, and if that's not reliable then run the detector on the whole context. BUG=952401 Change-Id: I17886528f8b4c3468762fb1bcde0c27b234549d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029262 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738566}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/555a304caa85..f9b4bfac44f9 git log 555a304caa85..f9b4bfac44f9 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-05 lamontjones@chromium.org api: recompile protos 2020-02-05 vapier@chromium.org gerrit_unittest: fix cookies_path reference 2020-02-04 ahassani@chromium.org cros-update.py: Execute scripts out of /usr/local/tmp/cros-update Created with: gclient setdep -r src/third_party/chromite@f9b4bfac44f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I05edef749819d97142466699fd315be069a51558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039031Reviewed-by:
-
Friedrich Horschig authored
As described in the linked bug, the adapter assumed WindowAndroid to never be null which causes a crash. With this CL, the view will be initialized early on and if WindowAndroid is nullptr, the creation of the view (and the adapter) will be aborted. To do that, the unused constructor parameters for label width and length were removed. Bug: 1048849, 1049090 Change-Id: I60151a560907a984ba4e45ee949624400b8f86da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037672 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738564}
-
kylechar authored
Somehow ReadPixelsContext::request is null once it reaches OnRGBAReadbackDone() done. Add some checks to figure out how that can happen. Bug: 1048251 Change-Id: If74854b5b332b1af347647c4c1c234e995afa944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037846Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738563}
-
Daniele Castagna authored
|origin_rect| in RemoveOverdrawQuads is currently not used for anything useful. This CL removes it. Test: viz_unittests Change-Id: Ie60f6a57699f1c100a7966ed6bb80fcd271b71bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037856Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#738562}
-
Sebastien Marchand authored
This metric will be used to understand the state of the system when memory pressure happens. More metrics will be added to this new MemoryPressureMetrics class later on. Change-Id: I2551c1ae5a36913a339ebbe4724d1637044b34f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028170 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#738561}
-
Shakti Sahu authored
This CL separates the public interfaces from the internal code of background task scheduler's Java code. 1 - The public classes/interfaces are left at top level components/background_task_scheduler while the implementation code is moved to internal/ 2 - Internal code is moved to a separate package as well. 3 - The factory will be a separate target that depends on public and internal. 4 - Some classes need to be referenced from both chrome/ and internal code, e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal We should probably move the NativeBackgroundTask as well to components/ which will greatly help the dependent code to live in components/. Will think about it in a future CL. Bug: 1045765 Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b55270f60f58..1f50e6be1c2a Created with: gclient setdep -r src-internal@1f50e6be1c2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia2ad12a58508eb7a955b269b921547b789bf26e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038187Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c3a1fc08224..712ebbb5b73b git log 7c3a1fc08224..712ebbb5b73b --date=short --first-parent --format='%ad %ae %s' 2020-02-05 philipp.hancke@googlemail.com disallow pairing ICE-TCP with a local ip address Created with: gclient setdep -r src/third_party/webrtc@712ebbb5b73b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1038754 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie876a93f29a350a7ffb7416f4fca3566c57d90bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038751Reviewed-by:
-
Mark Yacoub authored
If the device supports atomic APIs, Disable the CRTC using Atomic Modeset Commit instead of legacy API. BUG=987274 TEST=HardwareDisplayControllerTest.CheckDisableResetsProps, HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterDisable Change-Id: I79350079c73aa4d852354244b0eca282a63ac632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037712Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#738557}
-
Navid Zolghadr authored
Feel free to revert if it causes any regressions. Bug: 1000682, 1043966, 1006789 Change-Id: Idff11fb11513cbdfc2249e7822a26f3649f7a22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024540Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738556}
-
Michael van Ouwerkerk authored
Bug: 1049055 Change-Id: Ic4d0ed82c68a3a9105a50b112f8472a4f8272392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036106Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738555}
-
Himanshu Jaju authored
Tests the public interfaces of WebRtcMessageHandler and its interactions with SharingServiceHost. Bug: 1021987 Change-Id: I6826dbf5ac6306ba2364517e19a06c142d9c13b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038695Reviewed-by:
-
Hitoshi Yoshida authored
We used to use a pseudo type "ScriptValue" instead of object type in code generator. But it doesn't work well in complex cases, e.g. sequence<object?>. This CL separate them, and makes "object" type work as it is. Bug: 839389, 1047081 Change-Id: I6dfa17459c1e88a2f441064afc11dca056169ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035480Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#738553}
-
Morten Stenshorne authored
The failure / skip expectation lines were copied from non-virtual TestExpectations, FlagExpectations/layout-ng-fragment-item and NeverFixTests. No failures were introduced by enabling LayoutNGFragmentTraversal itself. Bug: 1043787 Change-Id: I26a8cff3a700abbb076e309d5162c1da3440136b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036096Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738552}
-
arthursonzogni authored
There were two methods used to upgrade insecure requests: - ShouldModifyRequestUrlForCsp - ModifyRequestUrlForCsp This patch move them to the network service. A slight rename to make them clearer - ShouldModifyRequestUrlForCsp => ShouldUpgradeInsecureRequest. - ModifyRequestUrlForCsp => UpgradeInsecureRequest. Note: - IsOriginSecure is replaced by IsUrlPotentiallyTrustworthy. The previous one is deprecated. - This removes the dependency of content/common/content_security_policy/* over content/common/origin_util.h. This was preventing the first directory from being merged into the network service. - The argument |is_suresource_or_form_submssion| was always used with 'true'. It has been removed. Bug: 1021462 Change-Id: I10d200ec389242ac8854c97585bdc4c42010467c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038651 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#738551}
-
Oriol Brufau authored
Outside markers behave out-of-flowish, so their intrinsic contribution to the list item should be 0. In legacy, this is done by adding negative margins, so that the width of the marker plus its margins are 0. However, when calculating the intrinsic contributions of the children, the code uses the margins in the computed style, not the margins of the box. Therefore, the marker code used to replace the computed style with another one that had the changed margins. This approach was error-prone, for example special care was needed to reapply the previously calculated margins when the computed style changed, in order to avoid triggering unnecessary layout. However, this caused a problem: if 'list-style-position' changed, the old margins were preserved. But the margins depend on whether the marker is inside or outside! This patch fixes the problem and stops changing the computed style of the marker. For inside markers, margins don't depend on the size of the marker, and they were already applied to the computed style in style_adjuster.cc, so they work well. For outside markers, the patch skips them when calculating the intrinsic size of the list item. Bug: 1048672, 457718 TEST=external/wpt/css/css-pseudo/marker-intrinsic-contribution-001.html TEST=external/wpt/css/css-pseudo/marker-intrinsic-contribution-002.html The former test fails in LayoutNG because trailing marker spaces are not preserved, and fails in legacy due to the lack of 'content' support. Change-Id: Ic21603e9fe1b17b11237286dac3f207b1837a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035962Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
