- 26 Jun, 2018 40 commits
-
-
Jun Cai authored
Network Service: Fix VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromRequestUsingSimpleURLLoader* This CL adds a SimpleURLLoader wrapper CreateSimpleURLLoaderForVariations() so that it can add and remove headers for variations. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I45dcfa0d820168365cc834ae7af2cb37adfe0449 Reviewed-on: https://chromium-review.googlesource.com/1107208Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570580}
-
Ryan Hamilton authored
Introduce QuicInterval platform api. Merge internal change: 201634485 Change-Id: I02f644b1fd50575ef24bc5fbda7b76b384514333 Reviewed-on: https://chromium-review.googlesource.com/1111653 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570579}
-
Pedro Amaral authored
Remove the top toolbar buttons (home, tab switcher, and menu buttons) from their parent view and set them to null. Also add a bunch of null checks since now things can be null. Bug: 852117 Change-Id: I620f35f81388d1f4ac8791a9eb45576566474604 Reviewed-on: https://chromium-review.googlesource.com/1105569 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570578}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Ib2e3784ba2319bc0786fc086815e851e3fd11a77 Reviewed-on: https://chromium-review.googlesource.com/1115716Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#570577}
-
Michael Spang authored
Add some missing destruction functions to gpu::VulkanFunctionPointers so that we can cleanup imported images. Bug: 851997 Test: compile Change-Id: Ia93aada5909950f37af63d47eeff4b47af190f70 Reviewed-on: https://chromium-review.googlesource.com/1115568Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570576}
-
Qingsi Wang authored
WebRTC will add a factory getter SparseHistogramFactoryGetEnumeration so that Chromium can provide an implementation using base::SparseHistogram for the metrics macro RTC_HISTOGRAM_ENUMERATION_SPARSE. The current implementation of this macro uses base::Histogram that has a limit of maximum 16k bucket counts as defined by base::Histogram::kBucketCount_MAX, which does not work well with 16-bit counters. Bug: None Change-Id: Ib171f068d79b7ac95514755485444867da2a27f5 Reviewed-on: https://chromium-review.googlesource.com/1115503Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#570575}
-
Boris Sazonov authored
This CL fixes icon tinting broken by https://crrev.com/c/1092866. That CL removed app:chrometint attribute from styles.xml and added it to every TintedImageView/TintedImageButton to keep existing behavior. It turns out that BookmarkFolderSelectActivity doesn't use MainThemeBase (it uses DialogWhenLarge), so there's no need for an explicit app:chrometint. Bug: 856263 Change-Id: I7dd13529db93eff4861d2043c9ec7596e1517343 Reviewed-on: https://chromium-review.googlesource.com/1115224Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570574}
-
Chris Mumford authored
Moving NetworkConnectionTracker from common to browser because it is coupled to NetWorkService which cannot be used in a renderer for security reasons. Furthermore the network connection status is already sent to the renderer via RenderThreadImpl::OnNetworkConnectionChanged. Bug: none Change-Id: Idbd242e368d1e26c3390af568c021db8ab393198 Reviewed-on: https://chromium-review.googlesource.com/1115345Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#570573}
-
Fady Samuel authored
Shipping scroll offset every frame during a scroll to the browser process is very expensive. It has been shown to negatively impact performance. Instead, this CL will only ship the scroll offset if it's close to an edge of the root layer where glow needs to be calculated. Furthermore, blocking frames on top bar control synchronization introduces jank and can affect FPS during scroll. This CL moves over synchronization to best effort. All (best-effort) synchronized visuals are moved to OnRenderFrameMetadataChangedBeforeActivation (which is always called BEFORE OnDidUpdateVisualPropertiesComplete) and will be called even if the LocalSurfaceId does not change. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I63953227e49a6b5b1b543b4fa16bac2cb336f100 Reviewed-on: https://chromium-review.googlesource.com/1115590Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570572}
-
Dmitry Gozman authored
This reverts commit c40442f0. Reason for revert: Reason for revert: breaks compile of Fuchsia Cast Audio: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio. Original change's description: > [chromecast] Change LeScanManager to have ScanHandles > > If a client wants to enable BLE scanning, it should take a ScanHandle. > When all ScanHandles are destroyed, scanning will be disabled. > > This is to avoid clients from fighting with each other to determine if > BLE scanning should be enabled or not. > > Bug: b/110432359 > Test: cast_bluetooth_unittests, device_unittests, manual. > Change-Id: I23dbded8a5e1bd2f687b70d5d594140b4a23df8e > Reviewed-on: https://chromium-review.googlesource.com/1112585 > Commit-Queue: Bailey Forrest <bcf@chromium.org> > Reviewed-by: Stephen Lanham <slan@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570564} TBR=reillyg@chromium.org,slan@chromium.org,limlam@google.com,bcf@chromium.org,tiansong@google.com Change-Id: I43e768a2518e8e86a496543af9b77b0c72252343 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/110432359 Reviewed-on: https://chromium-review.googlesource.com/1115840Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570571}
-
Kyle Horimoto authored
This class provides an interface for fetching the current host status and, when applicable, the current host device. Additionally, this class provides an observer interface for being notified when the status changes. Bug: 824568 Change-Id: I6cdc9a12f2201d998aa99080c63cbb6e6d60a60b Reviewed-on: https://chromium-review.googlesource.com/1113020 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570570}
-
Ken Rockot authored
Introduces a MOJO_POINTER_FIELD macro and uses this to declare pointer-sized within any ABI structs. This ensures a consistent struct layout and sizing across architectures. Also gets rid of MOJO_STATIC_ASSERT_FOR_32/64_BIT. Bug: None Change-Id: Id6e3b3897d6d52eaff4294db7c6183023e71953d Reviewed-on: https://chromium-review.googlesource.com/1114323Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570569}
-
Daniel Murphy authored
This uses the (previously unused by SessionStorage) StorageArea's observer interface to notify the renderer when session storage is cleared by the browser. This change * Updates the service to notify observers in this way * Adds tests in the service (& cleans up old observer usage) * Modifies WebStorageNamespace to include a WebString namespace getter. This lets the IsSameNamespace comparision to not cause undefined behavior when comparing different subclasses of WebStorageNamespace. R=mek@chromium.org Bug: 856120 Change-Id: I97e2d7a8f7a2b660143bf37bcbd04f5a3985bce2 Reviewed-on: https://chromium-review.googlesource.com/1114300Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570568}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7c37ca183640..1ff0ee751d95 git log 7c37ca183640..1ff0ee751d95 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 ynovikov@chromium.org Skip MaxTextureSizeTest.SpecificationTexImage on Win Intel Vulkan 2018-06-26 geofflang@chromium.org Revert "RendererGL: Limit warning output to 5 per message type." 2018-06-26 fjhenigman@chromium.org Vulkan: add SCALED vertex formats to table. 2018-06-26 lucferron@chromium.org Ozone: Skip test failing just on GLES 2018-06-26 jmadill@chromium.org Vulkan: Fix unused sampler struct uniforms. 2018-06-26 jmadill@chromium.org Program: Sampler uniform query in front-end. 2018-06-26 fjhenigman@chromium.org Vulkan: enable some vertex data tests. 2018-06-26 tobine@google.com Move PlatformMethods constructor to header 2018-06-26 jmadill@chromium.org Vulkan: Remove expectations for passing/missing tests. 2018-06-26 jmadill@chromium.org Add kEmptyImmutableString. 2018-06-26 lucferron@chromium.org Vulkan: Edge case test and fix for alpha channel masks 2018-06-26 lucferron@chromium.org Context init should set DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING 2018-06-26 geofflang@chromium.org Partially revert "WGL: Support unvirtualized contexts and unsafe multithreading." 2018-06-26 jmadill@chromium.org Vulkan: Implement nested sampler structs. 2018-06-26 jmadill@chromium.org Vulkan: Sampler structs in arrays. 2018-06-26 ianelliott@google.com Initial Android implementation of GetSystemInfo Created with: gclient setdep -r src/third_party/angle@1ff0ee751d95 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:768943 TBR=ynovikov@chromium.org Change-Id: I2596bb1253fb3d500bfc2135d816c81d92c7f51e Reviewed-on: https://chromium-review.googlesource.com/1115739Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570567}
-
Andrey Lushnikov authored
SVG nodes require special handling to compute quads. BUG=800636 R=dgozman Change-Id: Ie9014ea54bdbae4685ce3ea7aef725c786079ae8 Reviewed-on: https://chromium-review.googlesource.com/1114342Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570566}
-
Michael Spang authored
This shouldn't be needed as VulkanSwapChain is handling synchronization internally. And remove a missing calling to Destroy(). Bug: none Test: ozone_demo --enable-vulkan on X11 Change-Id: I8f4be6dcefef9757ca6e51d5d85b1ede99c8ff35 Reviewed-on: https://chromium-review.googlesource.com/1115731Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570565}
-
Bailey Forrest authored
If a client wants to enable BLE scanning, it should take a ScanHandle. When all ScanHandles are destroyed, scanning will be disabled. This is to avoid clients from fighting with each other to determine if BLE scanning should be enabled or not. Bug: b/110432359 Test: cast_bluetooth_unittests, device_unittests, manual. Change-Id: I23dbded8a5e1bd2f687b70d5d594140b4a23df8e Reviewed-on: https://chromium-review.googlesource.com/1112585 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570564}
-
dpapad authored
Specifically fixing: CrSettingsCertificateManagerTest.All CrSettingsLanguagesPageTest.Spellcheck CrSettingsLanguagesPageTest.InputMethods CrSettingsLanguagesPageTest.LanguageMenu Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie79c53113577172fe6f55cecda9a22562606c9a5 Reviewed-on: https://chromium-review.googlesource.com/1114283 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570563}
-
Vadim Shtayura authored
The new version understands CIPD_PROTOCOL=v2 env var which will be used to verify the new protocol works for everything before it becomes default. R=iannucci@chromium.org, dpranke@chromium.org, bsheedy@chromium.org BUG=801423 Change-Id: Ic169831f427d0d718c15dde8481d689e71776a68 Reviewed-on: https://chromium-review.googlesource.com/1115468Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570562}
-
Peter Boström authored
Highlights the ToolbarButton inkdrop on platforms where focus rings are not used. Before this change toolbar buttons were not highlighted to reflect their focused state (outside of Mac where focus rings are used). Bug: chromium:856505 Change-Id: Iab3578ff75a12477afa11ce34a09836acc3514d9 Reviewed-on: https://chromium-review.googlesource.com/1115737Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570561}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb8e7ef84262..e58bd8a02b9c git log fb8e7ef84262..e58bd8a02b9c --date=short --no-merges --format='%ad %ae %s' 2018-06-26 devicentepena@webrtc.org AEC3: Reverb modeling: Including the freq shape of the tails when modeling the reverberation Created with: gclient setdep -r src/third_party/webrtc@e58bd8a02b9c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:856636 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6932ca0b3df1c430be9b54e9442bcdeaf8dec30d Reviewed-on: https://chromium-review.googlesource.com/1115409Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570560}
-
John Rummell authored
As there are only a few crashes from this CHECK, removing it. It appears that the crash happens due to the SharedBufferHandle not being able to be mapped into the current address space. Since this happens so infrequently, simply return a NULL frame and let upstream handle the error. BUG=829443 TEST=media_mojo_unittests pass Change-Id: I645839d1975e9ec0629fe4ff29b91db8c52bf44b Reviewed-on: https://chromium-review.googlesource.com/1114346Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570559}
-
Kenneth Russell authored
LUCI-deployed trybots show up automatically in the Gerrit UI at this point. Bug: 855660 Tbr: ynovikov@chromium.org Change-Id: I51b3ae05e30905fb03d5034098e79409043431ed Reviewed-on: https://chromium-review.googlesource.com/1115808Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570558}
-
danakj authored
Fishing for mis-use of DisplayResourceProvider causing a crash in DeclareUsedResourcesFromChild(). It seems that the DisplayResourceProvider has a resource in the child_to_parent_map that it doesn't have in its resource set. This means it was already deleted or the child id is wrong or something. From reading the code this points to misuse of the DisplayResourceProvider for me, but to help narrow down, adding some DCHECKs to deal with invalid child ids. R=piman@chromium.org Bug: 855785 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ab0d6e6f6651f710b57d5848225a92eab3409cf Reviewed-on: https://chromium-review.googlesource.com/1115366Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570557}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7269fa01fb54..38bc56124fb4 Created with: gclient setdep -r src-internal@38bc56124fb4 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie70eb9dd83b8e002ebc7ac239afb04665a64a947 Reviewed-on: https://chromium-review.googlesource.com/1115678Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570556}
-
wutao authored
This cl adds two missing navigation shortcuts to the shortcuts viewer. Bug: 845578 Test: manual. Change-Id: I7c645fc8d5252eeed9bd16890c6ba3cfc37f19aa Reviewed-on: https://chromium-review.googlesource.com/1115761Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#570555}
-
Matt Wolenetz authored
Renames this method, and renames its |type| parameter to |content_type|. Similarly renames ChunkDemuxer::AddId, ChangeType, and static helper methods' |type| parameter to |content_type|. BUG=605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8b94452732a39157b5ddeba9e563f69aee033690 Reviewed-on: https://chromium-review.googlesource.com/1115704Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570554}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 781955 Change-Id: Ia39eabba795cd4afec8bfec7cb49e763ce9bbb72 Reviewed-on: https://chromium-review.googlesource.com/1114312Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570553}
-
Pete Williamson authored
Bug: 842801 Change-Id: I69b9942765d7fb534e549872ce86abbe2f45a577 Reviewed-on: https://chromium-review.googlesource.com/1108478 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#570552}
-
Mike Wittman authored
Flakily times out on Chromium OS ASan and Windows. Bug: 512431 Change-Id: I358abf93cd6225a44477e1a83e1814ed4eb3b1da Reviewed-on: https://chromium-review.googlesource.com/1113916Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570551}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a6dbeffbc61..c4dce690f433 git log 0a6dbeffbc61..c4dce690f433 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 tsepez@chromium.org Use pdfium::span<> in cpdf_fontglobals.h 2018-06-26 hnakashima@chromium.org Assert that tab width assumption holds in CFX_RTFBreak. Created with: gclient setdep -r src/third_party/pdfium@c4dce690f433 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:844367 TBR=dsinclair@chromium.org Change-Id: I6ac929ade18a91057a923cfaa74a1f046f472b1b Reviewed-on: https://chromium-review.googlesource.com/1115411Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570550}
-
Varun Khaneja authored
R=jialiul Bug: 855202 Change-Id: I100381590c3d87b5aeae8711abe2a38c8a28d8a5 Reviewed-on: https://chromium-review.googlesource.com/1110949 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570549}
-
kylechar authored
Remove code for creating a RootCompositorFrameSinkImpl from FrameSinkManagerImpl. FrameSinkManagerImpl is already a complicated class and it just needs to be manage CompositorFrameSinks that have been created. The complexity of creating a RootCompositorFrameSinkImpl is now contained in the class itself. Add a static RootCompositorFrameSinkImpl::Create() that handles creating the BeginFrameSource, Display and RootCompositorFrameSinkImpl. Move all BeginFrameSource creation into this one function. Also split the intialization of RootCompositorFrameSinkImpl so it can be created before a Display exists. Bug: 856705 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5b24658232c40d5f4c7801cf6562611eb4a2c996 Reviewed-on: https://chromium-review.googlesource.com/1115340 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570548}
-
Zhongyi Shi authored
Finch config for "migrate_sessions_on_network_change"(used by QUIC Connection Migration V1) is removed in https://chromium-review.googlesource.com/c/chromium/src/+/1060285. This change also removes unused methods. Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc4642112a82158411078893e6780e77123e2cc2 Reviewed-on: https://chromium-review.googlesource.com/1114085 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#570547}
-
David Tseng authored
- capital personality was tuned for Google tts some years ago. It is too high for the current engine - re-do precedence logic. Do not set speech props if they were supplied by callers. Bug: 855257 Change-Id: I541021fa456c5283e943ecb71183e99c547a4f8a Reviewed-on: https://chromium-review.googlesource.com/1115517Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570546}
-
Bin Wu authored
If a QuicConnection is writer blocked, always add it to the write blocked list. Protected by --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked. If --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked is true, QuicConnection::ProcessPacket will also add the connection to write blocked list if it is write blocked, and will not attempt to write before the writer unblocks. Merge internal change: 201524024 R=rch@chromium.org Bug: 848178 Change-Id: I2e7087ccb6fe11d575ceb7bea57fbaa9b1aeb68c Reviewed-on: https://chromium-review.googlesource.com/1114923Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#570545}
-
Manu Cornet authored
* Add close buttons * Wire up events for previews and close buttons * Introduce a WindowPreview class and observer interface * Add base methods so that the tooltip manager can delegate some event handling to individual tooltips. The "default" type of tooltip remains simple and non-interactive (no change in behavior). Bug: 834392 Change-Id: I174c166fc1c3f50580448420af7bb1a71ab6a65d Reviewed-on: https://chromium-review.googlesource.com/1090852 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570544}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83a57e01cd02..7ccf2f0c21b3 git log 83a57e01cd02..7ccf2f0c21b3 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 ehmaldonado@chromium.org gclient: Report what dependencies were not processed. Created with: gclient setdep -r src/third_party/depot_tools@7ccf2f0c21b3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853010 TBR=agable@chromium.org Change-Id: I2114a967bdc99da371523385f2b019141c4575dd Reviewed-on: https://chromium-review.googlesource.com/1115414Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570543}
-
Christian Fremerey authored
[Video Capture Service, ChromeOS] Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory by extracting the startup calls from VideoCaptureDeviceFactoryChromeOS to MediaStreamManager (which is where VideoCaptureDeviceFactoryChromeOS gets instantiated in case the video capture service is not enabled). For ChromeOS builds that use the cros_camera_service for video capture, the CameraHalDispatcher must be started as part of Chrome startup. This startup has for now been tied to the instantiation of VideoCaptureDeviceFactoryChromeOS. With the move to the VideoCaptureService, the instantiation of VideoCaptureDeviceFactoryChromeOS no longer happens on Chrome startup, but instead happens on-demand and potentially more than once. Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Test: See test plan section in design doc. Bug: 820608 Change-Id: I257a9eaa6368144fd252e532d211dfa716e8c242 Reviewed-on: https://chromium-review.googlesource.com/1107008Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#570542}
-
Aaron Leventhal authored
The ax_dump_events tool is crashing when IA2 not supported on an object. This checks that the queryInterface succeeded and that we hold a non-null IA2 pointer, before trying to use the IA2 pointer. Bug: None Change-Id: I4e2e2b469b0d891eac920fac1273436d28702f85 Reviewed-on: https://chromium-review.googlesource.com/1115561 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570541}
-