GitLab

Migrate ContentSettingsCollectionViewController from CollectionViewController to ChromeTableViewController.

This CL migrates the ContentSettingsCollectionViewController from
CollectionViewController, which is based on MDCCollectionViewController,
to ChromeTableViewController, which is based on UITableViewController.

Bug: 894791
Change-Id: I8f389901aa11f4a19eb1049cfa6708ee8fb65c2b
Reviewed-on: https://chromium-review.googlesource.com/c/1335607
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608324}

BUG=chromium:901830

Change-Id: I009fe723027280283ddfb69ee0e04d98ef3fa79e
Reviewed-on: https://chromium-review.googlesource.com/c/1335578Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608323}

- testDeepLink
- testMainIntent
- testSourcePropagated
- testTargetShareActivityPreserved

More details in the bug.

TBR=hanxi@chromium.org

Bug: 902325
Change-Id: If7fdb99d03c2e8340a17a43425198984b55f5b5c
Reviewed-on: https://chromium-review.googlesource.com/c/1337334Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608322}

This CL was created automatically with tools/perf/update_wpr script

R=perezju@chromium.org

Bug: 878390
Change-Id: I4b8f8080baf09268333d5e7936522f241b8e7595
Reviewed-on: https://chromium-review.googlesource.com/c/1329746
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608321}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b0e3bc7d..de5944d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I84d4b43d524b0143dde91aa9c1aceac558e35762
Reviewed-on: https://chromium-review.googlesource.com/c/1337529Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608320}

This CL adds a component, namely JourneyInfoFetcher, to talk with the
Memex endpoint server. The JourneyInfoFetcher makes a request
to the server and gets a SwitcherJourney response in json format.
Then JourneyInfoFetcher parses the response accordingly
to create a list of pageloads for the given callback.

Bug: 853290
Change-Id: If31982dac57fbb795f72c09cc8914cfaa6b49bdb
Reviewed-on: https://chromium-review.googlesource.com/c/1155719
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608319}

Before this change TouchEventFilter filtering out touch events that
happen outside of the allowed area would not only filter out taps, but
also scrolls.

This was inconvenient, as users would need to know that they need to
scroll starting from the highlighted, touchable are. Users could also
fling the highlighted area completely out of view, which left them
unable to do anything.

With this change, TouchEventFilter does the scrolling when a touch event
hits a non-allowed area. This requires dealing with two kinds of
scrolling. Once started, scrolling is allowed to continue until the end,
even if the touch event leaves the touchable or non-touchable area.

This change also agressivel triggers update of the touchable area while
scrolling. With browser-controlled scrolling, this corrects any drift
that result from the UI and the page having different scrolling speeds.

Bug: 806868
Change-Id: I85e3fd1339fadf9efe43b793c62ab6ce81c9247b
Reviewed-on: https://chromium-review.googlesource.com/c/1335928
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608318}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52d757db392f..c52201b23b48


Created with:
  gclient setdep -r src-internal@c52201b23b48

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ifcb6b8f6a0a281fa378b7f517d99895017f306bc
Reviewed-on: https://chromium-review.googlesource.com/c/1337470Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608317}

This will switch over to LUCI on the existing buildbot machines.
This waterfall is a non-critical postsubmit waterfall so we
believe we can take a few days of downtime on it if necessary.
The machines in question have webcams and exotic configs, so
standing up a new waterfall is rather expensive.

The plan is
1) take linux bots out of the old master and restart
2) swarm-bootstrap current chromium.webrtc machines
2a) maybe delete old stuff off machines (?)
3) land CL to infradata that makes machines available as
   dimensions:<builder name>
4) Land this CL

Certainly, if the above fails it's going to be hard to go back
but I think it will work :)

Tbr: jbudorick@chromium.org
Bug: 877018
Change-Id: I7ddb3e8764e717b29de9c0eeb55cf6bc2ccb002a
Reviewed-on: https://chromium-review.googlesource.com/c/1288596Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608316}

The toggle for the sync data type USER_EVENTS, aka
"Activity and Interactions", is removed from the
settings page.

Bug: 905342
Change-Id: Ib1fb2b5e66658628bd12b7de2e2bd7db6c398b8c
Reviewed-on: https://chromium-review.googlesource.com/c/1336148Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608315}

Adds support for legacy_ftrace_output and legacy_json_trace fields,
which will later be filled by the respective system tracing agents.

Bug: 900603
Change-Id: I1fd201bf7c1d9110c5f8c1b7df6209948d11787a
Reviewed-on: https://chromium-review.googlesource.com/c/1335603
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608314}

This reverts commit 5ed5b3f4.

Reason for revert: <Fails build "Deterministic Linux" ( https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/17798)>

Original change's description:
> IndexedDB: Remove redundant Web* enums
> 
> The following structs were redundant with structs that Mojo
> auto-generates:
> - WebIDBCursorDirection
> - WebIDBDataLoss
> - WebIDBOperationType
> - WebIDBPutMode
> - WebIDBTaskType
> - WebIDBTransactionMode
> 
> This CL updates those references to refer to the equivalent
> blink::mojom:: type, instead.
> 
> References to kWebIDB* values are updated to point to the
> equivalent value in the associated Mojo enum type.
> 
> Bug: 717812
> Change-Id: Ie4bf482e4437ec9e5fa61c78086256bc84f8c6df
> Reviewed-on: https://chromium-review.googlesource.com/c/1303634
> Commit-Queue: Chase Phillips <cmp@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607823}

TBR=cmp@chromium.org,dmurph@chromium.org,reillyg@chromium.org,pwnall@chromium.org,dominickn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717812
Change-Id: I0a0abf71de45643dba0328ff8fe4b94c26aae750
Reviewed-on: https://chromium-review.googlesource.com/c/1337609Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608313}

https://webrtc.googlesource.com/src.git/+log/c25d23445748..7af4ac893721


git log c25d23445748..7af4ac893721 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ffd688e..92e84c81 (608180:608282)


Created with:
  gclient setdep -r src/third_party/webrtc@7af4ac893721

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9ab4adab58c625d638e59678a8c80502a20874c2
Reviewed-on: https://chromium-review.googlesource.com/c/1337471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608312}

This reverts commit ad793ba0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 608003 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWQ3OTNiYTAzYjA3M2U0N2U4NjVhYTI2MjVjOWJkMTIxMThkNmU3Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4906

Sample Failed Step: sync_integration_tests on Ubuntu-16.04

Sample Flaky Test: USS/TwoClientWalletSyncTest.ServerAddressConvertsToSameLocalAddress/1

Original change's description:
> [AF] Integration tests for changing additional info for wallet metadata
> 
> This CL adds more integration tests; it also fixes a bug that
> stopped local changes of billing address and local changes of
> has_converted to get propagated to sync.
> 
> Bug: 894001
> Change-Id: Idd91e6799afd3c936b76ac8b1a6851abc67b5ad7
> Reviewed-on: https://chromium-review.googlesource.com/c/1333819
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Commit-Queue: Jan Krcal <jkrcal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608003}

Change-Id: I6a879efbc643e4aa282ebe8d94c9e43566ab9eba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894001, 905606
Reviewed-on: https://chromium-review.googlesource.com/c/1337631
Cr-Commit-Position: refs/heads/master@{#608311}

SetSystemPagesAccess is more or less a wrapper around mprotect on posix
systems, and VirtualFree and VirtualAlloc on Windows.  We see crashes,
e.g. in the referenced issue, where the return value of mprotect is not
equal to 0. However, because we do not CHECK the return value of
mprotect directly, we cannot see the reason why mprotect failed. With
this CL I move the CHECK of the return value of mprotect to the
mprotect, so if the CHECK fails, we also see the error reason.

Some caller of SetSystemPagesAccess do not CHECK the result of
SetSystemPagesAccess but deal with it or forward it. For these callers I
introduced a new function, TrySetSystemPagesAccess, which does exactly
the same as SetSystemPagesAccess did until now.

Bug: chromium:839036
Change-Id: I774e648cc6968202805a495fc0b3c3b7d9974b02
Reviewed-on: https://chromium-review.googlesource.com/c/1336130Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608310}

Bug: 879306
Change-Id: Ibecaadbe13f27aa887426279efccaeab06defa2c
Reviewed-on: https://chromium-review.googlesource.com/c/1334671Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608309}

Flaky tests:
org.chromium.components.sync.notifier.InvalidationPreferencesTest.testReadWriteAndReadData
org.chromium.components.sync.notifier.InvalidationPreferencesTest.testReadWriteAndReadData

Bug: 905233
Change-Id: Iad0e641c19adf4d21eb37f2642d104537fdc2f48
Reviewed-on: https://chromium-review.googlesource.com/c/1337331
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608308}

Bug: 904538
Change-Id: If4099acc9e699c7d6dfc4478b24786cbf931133e
Reviewed-on: https://chromium-review.googlesource.com/c/1335606Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608307}

Change-Id: Ie5725cd32fff43807e6f4129d7234ecf1143e14b
Reviewed-on: https://chromium-review.googlesource.com/c/1335575Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
Cr-Commit-Position: refs/heads/master@{#608306}

It overloads operator==, !=, <<  for VideoFrameLayout.
Also, it removes VideoFrameLayout.ToString() as operator<<
can replace it.

BUG=b:110815424
TEST=pass media_unittests --gtest_filter=VideoFrameLayout.*

Change-Id: I634846e456a516695a8f792bebf726d1cea80465
Reviewed-on: https://chromium-review.googlesource.com/c/1333016
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608305}

This CL renames test files for TaskWorklet and WorkerTaskQueue from foo_bar.html
to foo-bar.html based on the layout tests guide:

"File names should use snake-case, but preserve the case of any embedded API
names. For example, prefer document-createElement.html to
document-create-element.html."
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/layout_tests_tips.md#file-names

Bug: 879306
Change-Id: I704665e48c3697205f079a2d2ba28428aa0cffa5
Reviewed-on: https://chromium-review.googlesource.com/c/1334673Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608304}

So far, v8 only implemented Liftoff on x86 and x64, and enabling it on
other platforms basically did not have any effect. Now we start porting
to arm. Until this is complete, we do not want this to be used in the wild.

R=titzer@chromium.org, hablich@chromium.org, jochen@chromium.org

Bug: chromium:787421
Change-Id: Ie7978dc579cbc9203647ea5395302cda57fc0403
Reviewed-on: https://chromium-review.googlesource.com/c/1331388Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608303}

It is no longer necessary to build without symbols to keep the
instrumented library size under 4G (a recent local instrumented build
with symbol_level=0 had an unstripped library size of ~500M). Removing
this custom arg will make future debugging of orderfile issues
easier as there will be fewer variations to account for.

Change-Id: I84078e7f0a2f3033031755e884c3e72049b2beed
Reviewed-on: https://chromium-review.googlesource.com/c/1317571Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608302}

And few minor things

Bug: <none>
Change-Id: Ib5ecffb725bfe5843acd3c46f34956a763b91876
Reviewed-on: https://chromium-review.googlesource.com/c/1329676
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608301}

Bytes greater than 0x7f should not be considered as unsafe.

This CL also replaces "utf8" character conversions in
blink/renderer/platform/loader/cors/cors.cc to "latin1" as it's what's
done when actually converting blink::HTTPHeaderMap to
net::HttpRequestHeaders.

Bug: 824130, 902681
Change-Id: I01aacf814f1fc8a3ab8f191e1a9ec2bd01c1efee
Reviewed-on: https://chromium-review.googlesource.com/c/1335049Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608300}

The goal is to make it obvious that the browser test testing
policy-provided CA certificates which are used as trust anchors
does not depend on device policy.
Use InProcessBrowserTest instead of DevicePolicyCrosBrowserTest as base
class for the test to achieve this.
To make this easier, move the common 'user policy provided CA cert' test
functionality to its own class, used by multiple tests.

Bug: 874937
Test: browser tests
Change-Id: I2be87daeafa7e21dd08de97958c2b66a8cb43271
Reviewed-on: https://chromium-review.googlesource.com/c/1178047Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608299}

Add class comments and some renames for PaintCache. Following up from:
https://chromium-review.googlesource.com/c/chromium/src/+/1321190/4

R=enne@chromium.org

Bug: 894200
Change-Id: Ie8a0629071f8156e26945be7e9c61e04742158e5
Reviewed-on: https://chromium-review.googlesource.com/c/1336040Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608298}

Bug: webrtc:7494
Change-Id: I0cdcf1ac0bb0726913a4fdd15fcdaa324c4e86b7
Reviewed-on: https://chromium-review.googlesource.com/c/1335488Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608297}

Bug: 845472
Change-Id: Iac666731ad90f3ac69ed668406ca80e722c9c5cb
Reviewed-on: https://chromium-review.googlesource.com/c/1335574Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608296}

https://skia.googlesource.com/skia.git/+log/e36f46461df6..1315333b6bfb


git log e36f46461df6..1315333b6bfb --date=short --no-merges --format='%ad %ae %s'
2018-11-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@1315333b6bfb

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I3da15f0b1e9b621ef6fa6b2191c1d319099ffd05
Reviewed-on: https://chromium-review.googlesource.com/c/1337274Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608295}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ad919faea83..52d757db392f


Created with:
  gclient setdep -r src-internal@52d757db392f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iedd6a593d23a1e26a7bce0f372d6625f74eeac87
Reviewed-on: https://chromium-review.googlesource.com/c/1337469Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608294}

Ash immersive mode is not quite right anymore: remove it.

Bug: 839243
No-Try: true
Change-Id: If25f8e3411006c694825a38841fd1ae92f287623
Reviewed-on: https://chromium-review.googlesource.com/c/1336951Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608293}

This patch moves the flag whether to force to create a box
fragment for LayoutInline or not from NGInlineItem to
LayoutInline.

This is part of an effort to reduce re-collecting
NGInlineItem when styles were changed. Re-collecting is
rather an expensive operation that changes in, for instance,
background should not require it.

Note, this patch itself does not reduce the collection,
because we require re-collection whenever NeedsLayout is set.
It is planned in future patches, but this change is needed to
make it happen.

Also benefits to keep the flag turned on once it's on, until
the LayoutInline is reattached.

The change has minor performance gain in most blink_perf.layout
https://pinpoint-dot-chromeperf.appspot.com/job/15f8c74be40000

Bug: 636993
Change-Id: I8d4e7c421d5fad26fee60832cdfbacd575f7ad34
Reviewed-on: https://chromium-review.googlesource.com/c/1333588Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608292}

Change-Id: I7ddbabf86c83256d608bd0f97736e8ead373a81d
Reviewed-on: https://chromium-review.googlesource.com/c/1337217Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608291}

Unshares a path previously shared, and removes path from prefs.

Bug: 878324
Change-Id: I9655c16851eed2eccca225fc3d9642db21b51dde
Reviewed-on: https://chromium-review.googlesource.com/c/1317212
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608290}

The following sequence is racy with the current ASAN checks in ParkableString,
on the main thread:

Park()
Lock()
ToString()
Unlock()

Park() poisons the string, ToString() unpoisons it, and Unlock() poisons it
again. If this last call happens while the compression is in progress, then this
is a use-after-poison.

This is not a real issue, merely an overaly eager poisoning, still making using
ASAN builds painful. Fix it by making sure the string stays unpoisoned during
compression.
Also adds a regression test.

Bug: 905137,877044
Change-Id: I5276b9ae6eee4abe2f2bf041818d1ba17358a80a
Reviewed-on: https://chromium-review.googlesource.com/c/1335585Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608289}

https://chromium.googlesource.com/catapult.git/+log/8a6451c727a2..d098799efb32


git log 8a6451c727a2..d098799efb32 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 sabbakumov@yandex-team.ru Fix race condition while handling errors


Created with:
  gclient setdep -r src/third_party/catapult@d098799efb32

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I4e4286213e559250c206b596b98fc3b0ab4343ef
Reviewed-on: https://chromium-review.googlesource.com/c/1337309Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608288}

This patch changes LayoutInline to use
|IsInLayoutNGInlineFormattingContext()| to determine whether
it's in LayoutNG inline formatting context or not.

This was revealed in crrev.com/c/1333588, tests will fail
with the CL without this fix.

Bug: 636993
Change-Id: I6ae4fb3bcaf18afceb4ab3486618a031b4a895c9
Reviewed-on: https://chromium-review.googlesource.com/c/1337212Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608287}

It's a simple test implementation of SyncUserSettings that mostly
forwards calls to the TestSyncService. It is not actually used yet, but
it unlocks the migration of tests over to SyncUserSettings.

Bug: 884159
Change-Id: Id9d9c03f639c6523bb6d6592517ba46d1f8f4566
Reviewed-on: https://chromium-review.googlesource.com/c/1335565
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608286}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb18f19dce17..5ad919faea83


Created with:
  gclient setdep -r src-internal@5ad919faea83

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie26dfafd1271a82eb4bea28cae1d65ed76a7e4f0
Reviewed-on: https://chromium-review.googlesource.com/c/1337310Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608285}