GitLab

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972

Review-Url: https://codereview.chromium.org/2307353002
Cr-Commit-Position: refs/heads/master@{#417176}

Document::attach/detachLayoutTree is confusing. It's indeed attaching/detaching
layout trees but doing more things than that. In particular, Document::detachLayoutTree
does a bunch of disruptive operations unlike other Node::detachLayoutTree.

It's better to rename Document::attach/detachLayoutTree to Document::initialize/shutdown
and make it clear that they can be called only once when the Document gets
initialized/shut down.

BUG=610176

Review-Url: https://codereview.chromium.org/2318913002
Cr-Commit-Position: refs/heads/master@{#417175}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644920

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320723004
Cr-Commit-Position: refs/heads/master@{#417174}

BUG=639095

Review-Url: https://codereview.chromium.org/2320563003
Cr-Commit-Position: refs/heads/master@{#417173}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7381c2dc..697e77ea

$ git log 7381c2dc..697e77ea --date=short --no-merges --format='%ad %ae %s'
2016-09-06 yyanagisawa@chromium.org cros_chrome_sdk: a flag to skip starting goma in cros_chrome_sdk.
2016-08-31 yunlian@chromium.org chromite: add peppy to the chromiumos-sdk bot

BUG=639432

Review-Url: https://codereview.chromium.org/2319513002
Cr-Commit-Position: refs/heads/master@{#417172}

https://pdfium.googlesource.com/pdfium.git/+log/7b68f616e492..8c2a8cda1bdb

$ git log 7b68f616e..8c2a8cda1 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 tsepez Fix spelling of "Formated" in several variables

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2324693002
Cr-Commit-Position: refs/heads/master@{#417171}

https://chromium.googlesource.com/chromium/src/+/397fa7cad

BUG=644122
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2325493003 .

Cr-Commit-Position: refs/heads/master@{#417170}

Using update-w3c-deps in Chromium cf4d11d6.

Review-Url: https://codereview.chromium.org/2309603003
Cr-Commit-Position: refs/heads/master@{#417169}

The browser process normally never needs to validate sync tokens unless
it's returning resources to a renderer, so it's possible the highest
verified flush ID will almost never be updated and the list of
unvalidated flush IDs will grow indefinitely. Force a validation if that
happens to avoid wasting memory.

BUG=635051
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2318933005
Cr-Commit-Position: refs/heads/master@{#417168}

https://chromium.googlesource.com/skia.git/+log/14fe8cc16d2a..828ed1777da7

$ git log 14fe8cc16..828ed1777 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 msarett Add color xform support to SkWebpCodec

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319723003
Cr-Commit-Position: refs/heads/master@{#417167}

This patch:
- removes WI.CSSWorkspaceBindings.pushSourceMapping. There's no need to
  push any source mappings - rawLocationToUILocation can always query
  SASSSourceMapping first and then StylesSourceMapping.
- removes WI.CSSWorkspaceBindings.HeaderInfo. The class was inlined into
  WI.CSSWorkspaceBindings.TargetInfo.

BUG=642583
R=dgozman

Review-Url: https://codereview.chromium.org/2300523002
Cr-Commit-Position: refs/heads/master@{#417166}

The test was crashing in the controller.GoBack() case with PlzNavigate enabled. Reason being we don't find a frame to navigate to. Thanks to clamy for pointing out
that the sequence numbers setting code in the frame navigation code caused that.

Fix is to add the item sequence number and document sequence number to the page state. Added a helper
function to the TestRenderFrameHost class called CreatePageStateForURL
which provides this functionality.

BUG=510836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2309583002
Cr-Commit-Position: refs/heads/master@{#417165}

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317913002
Cr-Commit-Position: refs/heads/master@{#417164}

https://chromium.googlesource.com/angle/angle.git/+log/5a7e20e..9df01f8

BUG=614178,chromium:638323,644846

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2320863002
Cr-Commit-Position: refs/heads/master@{#417163}

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage (SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484

Review-Url: https://codereview.chromium.org/2313593002
Cr-Commit-Position: refs/heads/master@{#417162}

This pulls out all of the lifetime logic for the WorkerThread into the base class ThreadedMessagingProxyBase.

This will allow us to re-use all of the lifetime logic (I've created a followup demo patch which does this https://codereview.chromium.org/2312493002/)

BUG=567358

Review-Url: https://codereview.chromium.org/2310673002
Cr-Commit-Position: refs/heads/master@{#417161}

* Fail if it finds a non-trivial AndroidManifest.xml
* Fail if it finds any .so files
* Fail if it finds any assets
* Support proguard.txt

This also tweaks the naming of the sub-jar targets to give them better
target names (which show up in .jar names).

TBR=bshe
BUG=640836

Review-Url: https://codereview.chromium.org/2309643002
Cr-Commit-Position: refs/heads/master@{#417160}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1

$ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults.

BUG=644270

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321813002
Cr-Commit-Position: refs/heads/master@{#417159}

Currently, it's impossible to work on remote module as it tries to load source from the cloud.

BUG=none

Review-Url: https://codereview.chromium.org/2324633002
Cr-Commit-Position: refs/heads/master@{#417158}

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2 (en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1: 247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July 12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.14393.0

BUG=627216,636468,427616,637456

Review-Url: https://codereview.chromium.org/2106203002
Cr-Commit-Position: refs/heads/master@{#417157}

BUG=590369

Review-Url: https://codereview.chromium.org/2315223002
Cr-Commit-Position: refs/heads/master@{#417156}

When a text is wrapped during layout, the leading space of the
text can be collapsed and a line break is inserted instead of
the space. In this case, we need to restore the collapsed space
when we copy the text.

This CL can handle the following case:
<div style="width: 2em;"><b><i>foo</i></b> bar</div>

BUG=318925
TEST=editing/pasteboard/restore-collapsed-space-for-copy.html

Review-Url: https://codereview.chromium.org/2320533002
Cr-Commit-Position: refs/heads/master@{#417155}

Revert of Apply first-line transform-text style (patchset #1 id:1 of https://codereview.chromium.org/2305833002/ )

Reason for revert:
see crbug.com/644733

Original issue's description:
> Apply first-line transform-text style
> BUG=129669
>
> Committed: https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658
> Cr-Commit-Position: refs/heads/master@{#416608}

TBR=eae@chromium.org,robhogan@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=129669,644733

Review-Url: https://codereview.chromium.org/2317303002
Cr-Commit-Position: refs/heads/master@{#417154}

R=hcarmona@chromium.org
BUG=643651
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2324523002
Cr-Commit-Position: refs/heads/master@{#417153}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/577d76122393936c6bb0633a903a3e58f1413ffd Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/abe83699eaa190e7dcb4cefc079e22cc27a284b9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/01e4d4b36567f77d36fd032614f9d8fd3049266c Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/d3c5b2efaa30b1928a1e7cad352851ec75e9d49b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/8a19fa3fb93e1cddbd10a26f6573aa7881fb6781 Add resource_sizes to chromium_perf steps for Android (agrieve@chromium.org)
  https://crrev.com/79ba02e28afc3d671571dfeb4ed0f8580a034189 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/7756645fbca0840d8ddb79f9ad0df0de29daaac9 Allow builder whitelisting from gatekeeper_trees.json. (stip@chromium.org)
depot_tools:
  https://crrev.com/925b910ac3e7a3560311f4ae7fe387d061bd5ee3 Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ ) (martiniss@chromium.org)
  https://crrev.com/8da412cf5a53d019136e6990b922471c12677ff9 Remove redundant output in git_cl.py tests. (tandrii@chromium.org)
  https://crrev.com/082267a659f94bf7bca5cb144e203ca0913abb3a Delete lots of svn logic from bot_update (agable@chromium.org)
  https://crrev.com/2a3e9913bec46ddaf1c82f3328202f7a6092df2f gclient: Prune dangling remote tracking refs when fetching with --force (bpastene@chromium.org)
  https://crrev.com/4dcad385f4b2d8a497affeea4c767910e1bc100b Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of https://codereview.chromium.org/2280213002/ ) (bpastene@chromium.org)
  https://crrev.com/eb20eaeced95cdb07ad711639a8958b8d78cf309 Copy over bot_update_coverage_test.py (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=472386,589168,628801,644722,609365,644609

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2317403002
Cr-Commit-Position: refs/heads/master@{#417152}

This prevents a malicious sender from sending deeply nested messages
that cause the receiver to blow the stack during message validation.

BUG=640298

Review-Url: https://codereview.chromium.org/2312813002
Cr-Commit-Position: refs/heads/master@{#417151}

Inline the tiny code left there into LayerTreeHostImpl, delete the
|renderer_| member and change references to the |output_surface_|
instead.

R=enne
BUG=641613
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323583002
Cr-Commit-Position: refs/heads/master@{#417150}

BUG=

Review-Url: https://codereview.chromium.org/2315923003
Cr-Commit-Position: refs/heads/master@{#417149}

This seems to sometimes be causing videos to initially display black.

BUG=635319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2314773003
Cr-Commit-Position: refs/heads/master@{#417148}

Revert of Video capture Android: enable unittests for Camera2 API (patchset #5 id:220001 of https://codereview.chromium.org/2286303003/ )

Reason for revert:
Caused WebViewLayoutTest#testMediaStreamApi and MediaAccessPermissionRequestTest#testGrantAccess to consistently fail.

Confirmed locally by reverting patch, commenting out @DisableIf and running:

ninja -C out/Release android_webview_test_apk android_webview_apk && out/Release/bin/run_android_webview_test_apk -f MediaAccessPermissionRequestTest.*

BUG=644910

Original issue's description:
> Video capture Android: enable unittests for Camera2 API
>
> This CL reenables a bunch of VideoCaptureDeviceTest
> test cases for Android and for the "new" APIs
>
> For this:
> - adds a |mTestMode| to VideoCapture.java, interface
>  of all camera java classes. VCCamera2.java tests this
>  flag and adds a capture thread if it's set.
> - the C++ correspondent classes get a method to configure
>  the java side for testing, and a method to test if the
>  underlying platform is using the new or the old APIs.
>
> Also:
> - Removes DeAllocateCameraWhileRunning because it was
>  equivalent to CaptureWithSize test case.
> - Cleans up/refactors some parts of the unit tests, adds
>  a few more comments etc
>
> BUG=626857
>
> Committed: https://crrev.com/7c32b70068c65b7bb372bb52a33d70b8e6653129
> Cr-Commit-Position: refs/heads/master@{#417015}

TBR=jbudorick@chromium.org,emircan@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626857

Review-Url: https://codereview.chromium.org/2320873002
Cr-Commit-Position: refs/heads/master@{#417147}

BUG=644953

Review-Url: https://codereview.chromium.org/2319963002
Cr-Commit-Position: refs/heads/master@{#417146}

On tablets it's possible to end up with a "dummy" tab selected if the
EmptyBackgroundView is showing when a merge is triggered and the currently
"selected" model has no tabs in it. In this case, do not reset
the tab model selection to the model that was selected before the merge.

BUG=644707

Review-Url: https://codereview.chromium.org/2317363002
Cr-Commit-Position: refs/heads/master@{#417145}

BUG=640116

Review-Url: https://codereview.chromium.org/2308973002
Cr-Commit-Position: refs/heads/master@{#417144}

::shadow and /deep/ combinator are deprecated.
We need to use CSS variables instead.

BUG=498405
TEST=manually confirmed that color/opacity doesn't change.

Review-Url: https://codereview.chromium.org/2317113002
Cr-Commit-Position: refs/heads/master@{#417143}

Reland of Mojo C++ Bindings: Additional support for associated binding sets (patchset #1 id:1 of https://codereview.chromium.org/2324623003/ )

Reason for revert:
It seems like linker just occasionally ran out of memory on the buildbot. The CL seems to be innocent.

Original issue's description:
> Revert of Mojo C++ Bindings: Additional support for associated binding sets (patchset #2 id:20001 of https://codereview.chromium.org/2309513002/ )
>
> Reason for revert:
> This broke compilation on Win x64 builder:
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/94511
>
> Original issue's description:
> > Mojo C++ Bindings: Additional support for associated binding sets
> >
> > Implements three orthogonal changes to the public bindings API:
> >
> >  1. Adds the ability to remove bindings from a binding set. Uses
> >     a new mojo::BindingId integer alias to identify added bindings.
> >
> >  2. Adds the ability to set a pre-dispatch hook on binding sets.
> >     In some cases simply making the dispatch_context() available
> >     is insufficient, for example when a consumer owns multiple
> >     binding sets and wants a common path for establishing context
> >     among any of them.
> >
> >  3. Adds mojo::GetDummyProxy, a helper that can bind an
> >     AssociatedInterfacePtr<T> so that it has some valid internal
> >     state and silently drops all outgoing messages. Unlike
> >     regular message pipe interfaces, without this feature
> >     associated interfaces are difficult to stub out in test
> >     environments.
> >
> > Part a series of CLs to enable and demonstrate WebContents associated
> > interfaces:
> >
> >   1. https://codereview.chromium.org/2301123004
> >   2. This CL
> >   3. https://codereview.chromium.org/2310563002
> >   4. https://codereview.chromium.org/2310583002
> >
> > BUG=612500
> > R=yzshen@chromium.org
> >
> > Committed: https://crrev.com/4b8bca190cdc55bae81974aa09cc10f422f022fb
> > Cr-Commit-Position: refs/heads/master@{#417126}
>
> TBR=yzshen@chromium.org,rockot@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=612500
>
> Committed: https://crrev.com/c08a3abcbc9d79e2a7031b116d0af9ee92d17459
> Cr-Commit-Position: refs/heads/master@{#417135}

TBR=yzshen@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612500

Review-Url: https://codereview.chromium.org/2320723003
Cr-Commit-Position: refs/heads/master@{#417142}

BUG=644122

Review-Url: https://codereview.chromium.org/2318033003
Cr-Commit-Position: refs/heads/master@{#417141}

Revert of DevTools: Allow clicks to register in SSP when swatch popover is open (patchset #2 id:20001 of https://codereview.chromium.org/2307463004/ )

Reason for revert:
This breaks editing color swatches within shadow swatches. If you edit the color, and then edit the shadow, it reverts to the original color.

We should further examine the effects of majorChange=true in applyStyleText.

Original issue's description:
> DevTools: Allow clicks to register in SSP when swatch popover is open
>
> Applying the style text to the tree element when the popover is hidden
> causes the section to update, not allowing clicks to register.
>
> It is unnecessary to apply the style text when the popover is hidden
> (unless reverting back to original property text) because the change
> has already been applied.
>
> BUG=644779
>
> Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
> Cr-Commit-Position: refs/heads/master@{#417109}

TBR=lushnikov@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644779

Review-Url: https://codereview.chromium.org/2320533005
Cr-Commit-Position: refs/heads/master@{#417140}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8e6fcd316b9f3551ec6618e39adb516accd0b0f9 Re-add perf-id and results-url. (dtu@chromium.org)

R=dtu@chromium.org
BUG=644370

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320843002
Cr-Commit-Position: refs/heads/master@{#417139}

https://pdfium.googlesource.com/pdfium.git/+log/f56d93f8ea1c..7b68f616e492

$ git log f56d93f8e..7b68f616e --date=short --no-merges --format='%ad %ae %s'
2016-09-07 tsepez Make Observers into a templated class

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2321493003
Cr-Commit-Position: refs/heads/master@{#417138}

Currently in these two functions, we are not using CheckedNumeric. This
CL uses CheckedNumeric to ensure that integer-overflow will not happen

BUG=644271
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310243002
Cr-Commit-Position: refs/heads/master@{#417137}