- 02 Dec, 2020 40 commits
-
-
Norman Rosas authored
also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: Ia8bfe8358484599fff4c5304f0f297b40d400d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570235 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#832998}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a791e7cf73f..d1655710f7a7 2020-12-02 vapier@chromium.org repo: avoid fstrings for Python 3.5 a little longer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I84a825e1f8693f5ab192e55c5087f4782d740763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569964 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832997}
-
Evan Stade authored
Set and unset the TestMediaRouterClient in each test so that each test will pass on its own instead of relying on or interfering with other tests. Bug: 1147740 Change-Id: Ie5145710e6da4fd8fa1e4dc534e1a1aa3279a821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568625Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#832996}
-
Kyle Horimoto authored
Fixes an issue where users who were opted into the trial on Canary/Dev/Beta and then switched to Stable could still be opted into the experiment. Bug: 1147325 Change-Id: I25e153323efc9108cdde2404785d637912d8b01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560909 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#832995}
-
Joel Hockey authored
This reverts commit 5e0522d6. Reason for revert: flaky test fixed by crrev.com/c/2568928 Original change's description: > Revert "Add restore and delete actions in Trash root view" > > This reverts commit 41132153. > > Reason for revert: Trash/FilesAppBrowserTest.Test/trashRestoreFromTrash failed on https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/38983/overview > > Original change's description: > > Add restore and delete actions in Trash root view > > > > http://go/chrome-ss/8aec11c357971886d745aa9ea5b89356399956d2 > > > > Added restore-from-trash command which is shown in the Trash root as > > both a top bar action, and a file context menu command. > > > > Modified delete action so that it shows for Trash root (even though the > > Trash root FakeEntry is read-only), and added remove() and > > removeRecursively() functions to TrashEntry which deletes both the > > filesEntry and infoEntry. > > > > Background restore() code previously expected the supplied TrashItem > > would come only from the TrashItem returned by removeFileOrDirectory(), > > but now that it can be set directly from the restore-from-trash > > command, it requires a change to the TrashConfig lookup and path prefix > > validation. > > > > Bug: 953310 > > Change-Id: I2cdf018fd1daab8f57f0ab7f679d47eeba2109b0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564841 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832700} > > TBR=noel@chromium.org,joelhockey@chromium.org,lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I73dcb3bca3453bd61c57eeba73098debcf52d99a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 953310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566958 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832784} TBR=noel@chromium.org,olka@chromium.org,joelhockey@chromium.org,lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 953310 Change-Id: If393cd36a6d3ab64808626c95dc4060f42a4e4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569432Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832994}
-
Dave Tapuska authored
Use the cc/input/browser_controls_state.h as the source of truth, remove the content/public/common variant. Move mojo definition into cc. BUG=1097816 Change-Id: I2a9763b8e591a7a1ad970c965d1ed614f239bd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568220Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#832993}
-
Ben Pastene authored
This reverts commit e69d4103. Reason for revert: GN-gen failures on chrome-branded CrOS bots https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome eg: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11420 ERROR at //content/gpu/gpu_child_thread_receiver_bindings.cc:15:11: Include not allowed. #include "services/shape_detection/shape_detection_service.h" Original change's description: > [ShapeDetection] Host Service in utility process on CrOS > > This CL updates ShapeDetection service to be hosted in a > utility process on ChromeOS. This is being done because > the ShapeDetection service implementation for ChromeOS > uses a third_party library and does not use any > accelerated native shape detection APIs that might need > to run in GPU process. > > Bug: 1093185 > Change-Id: I0042d309b6daeaa66798d25b70d5d1bba05b737b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444177 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832841} TBR=kinuko@chromium.org,reillyg@chromium.org,azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I278f5d33714903e4226a99e6d270cb58c12c904f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1093185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570237Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#832992}
-
Ben Pastene authored
crrev.com/i/3442383 allocates the machines for this. Bug: 1140727 Change-Id: I25d8be0fad0a7251453210393a72925e28cc38b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568629Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#832991}
-
Fabrice de Gans-Riberi authored
Bug: 1148034 Change-Id: Ifda35f0547e9b608a67e4fe77ffe9f59c9daecb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565831 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832990}
-
Sean Topping authored
`allow_circular_includes_from` does not build any dependencies in the target, so generated headers (such as mojom) may not be built before headers in the target are included by the dependent declared in `allow_circular_includes_from`. The workaround here is to add an explicit dep to the target that generates the headers. Bug: 1154721 Test: CQ Change-Id: I77b1f204a6583c6662290a5f86a03dedc00d70f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568892Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#832989}
-
Sajjad Mirza authored
Bug: 1146571 Change-Id: Ic77be2e669d60fd997078472f8decd341271ef16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569786 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#832988}
-
Mike Jackson authored
Per UX review, removing the option to run a PWA at OS login from the PWA install dialog. Bug: 1110407 Change-Id: I17999312a928fd85a0eae74f907f768c4028c022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558753 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#832987}
-
David Tseng authored
Enums in ui/accessibility/ax_enums.mojom automatically generate a kNone value (usually at value 0). Enums in chrome.automation omit such values in js even though they exist in C++. e.g. ax::mojom::DefaultActionVerb::kNone -> api::automation::DEFAULT_ACTION_VERB_NONE !-> chrome.automation.DefaultActionVerb.NONE (the last, does not exist either in externs nor in the runtime bindings). When mapping to chrome.automation, rather than converting to the stringified "none" value, simply drop it. This change starts with DefaultActionVerb, but other enums may be good candidates for this treatment. R=akihiroota@chromium.org Bug: none Change-Id: Iec137c0254e0a3322e41e959e377bb9b4158a13c AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568626 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#832986}
-
Norman Rosas authored
removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: Ie0157440d3bdb85c8aea77a7d131f5d4bd46bf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569981 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832985}
-
Peter Kotwicz authored
This CL: - Replaces //third_party/guava:guava_android_java dependencies with //third_party/android_deps:guava_android_java - Deletes //third_party/guava Change-Id: If5536c8f3685d66a9136c76be229f7f44cd4a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560401 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#832984}
-
Robert Kroeger authored
webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.14.6 is failing in conformance/ogles/GL/lessThan/lessThan_001_to_008.html Bug: 1154745 Change-Id: I5365aa119a0ec1fa0914da49c1f4525ab78c53f8 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569922Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#832983}
-
dpapad authored
Fixed: 1154617 Change-Id: I2d01945a9b9d23b8aa61eda52ef1a29af58bcf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567671 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#832982}
-
Liquan (Max) Gu authored
This CL does not involve any behavioural change. Changes: * Simplified WLPRService#showOrSkipAppSelector() * Moved the shouldSkipAppSelector() calls from WLPRService and CPRService into PRService. * Added getPaymentApps() and getSelectedPaymentApp() as they are needed by shouldSkipAppSelector(). Bug: 1152542 Change-Id: I5e0112d82a075de611f5085e4f34721804e94b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568444 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832981}
-
rbpotter authored
The backend call this resolver makes only exists on Chrome OS, and provisional destinations don't exist on other platforms. Remove the resolver and related code from the non-ChromeOS version of destination- dialog, now that the element has been forked. Bug: 1148906 Change-Id: I276e5128051e275346e7edd9b01a534f4cd7c42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568269 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832980}
-
Austin Sullivan authored
- Use mojom::blink::IDBCallbacks instead of IDBRequest - Allows for removal of last use of IDBAny::kDOMStringListType Bug: 992958 Change-Id: I028f75069d4ea5bd76382f279c85c842284dfb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557571 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#832979}
-
Robert Kroeger authored
Retry a GPU process crash on an invalid mojo message receipt that causes failure in: * deqp/functional/gles3/shadertexturefunction/textureprojgrad.html * conformance/ogles/GL/clamp/clamp_001_to_006.html Bug: 1154706 Change-Id: Iac9002ed5a5bb0bd20275e3383565187ce1393e7 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569935Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#832978}
-
Adam Langley authored
BUG=1002262 Change-Id: I2b5b5461655613231dcc47ba9e88d0bf4272d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551708 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#832977}
-
dpapad authored
Up/down arrows in Presentation mode should navigate to the previous/next page, similar to how left/right arrows behave in normal (non-Presentation) mode. Bug: 1148478 Change-Id: Ic6398116212715de1919a3a9cfbf3b37f1ee45b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568260 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832976}
-
David Bertoni authored
This Service Worker version of this test was disabled for flakiness. Adding kFlagEnableFileAccess to prevent the extension's being restarted fixes the issue. Bug: 1112903 Change-Id: If631aa13fb0030a1daa91311b7b26edbe88909eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555880Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832975}
-
Rune Lillesveen authored
Enabled by default for M87 and M88. Also removed now unused font_selector_version_. Bug: 441925 Change-Id: I01b0f615aeb8cf637d3e34585712a64e255ce231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550804Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#832974}
-
David Tseng authored
Test: manually verify that when SA is enabled, navigating to a Google Doc, and dumping the accessibility tree shows the content of the doc in the tree. Modify and make the (now) accessibility live test suite compile. The test has been failing and not run on bots. TODO'ed fixing. R=akihiroota@chromium.org Fixed: 1115978 AX-Relnotes: Switch Access can now navigate within the content of a Google Doc. Change-Id: I06d20cdef5705eed637609597ed34a33ce3cea39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569062Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832973}
-
Mohamed Amir Yosef authored
... store using the moving multiple passwords dialog in settings. Bug: 1139263 Change-Id: If5588a84cf876f1c5a72b50d9ab52b3a35aa9d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566934Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#832972}
-
Nancy Wang authored
This CL implements the default setting for the "restore_apps_and_pages" setting based on: https://docs.google.com/presentation/d/1kg1HAyjHc3l9EnaBehCQS3K_O7BmLpE6x_JWAAGUOMc/edit?ts=5faddd25#slide=id.g838f61fb61_2_5 For the new Chrome OS user, set the default value as 'Ask Every Time', or set the default value based on the browser's restore setting sync value. For the upgrading scenario, set the default value based on the current browser's restore setting. BUG=1146900 Change-Id: I2032547103a74fe9625bbd7cf47f422f0a52ab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563499 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#832971}
-
Nicolás Peña Moreno authored
Bug: 1146022 Change-Id: I71c726fdb85d432271220c66557a0fc64bdd341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552846 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832970}
-
Sinan Sahin authored
This CL adds a null check in the onClick callback to prevent a crash and also adds debugging statements to help find the cause of it. Bug: 1153706 Change-Id: Id39f7c990e90acc2c467639f85b2e38da490801e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568617 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#832969}
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I8a2710eced31fbf3b0b5ccc6d7b583d7223add23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555401 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#832968}
-
Dylan Cutler authored
constructor is private. This CL is part of a larger effort to make the default constructor of CanonicalCookie, which does no validation of the input, private. CreateUnsafeCookieForTesting is a factory method meant to create CanonicalCookies in tests where the default constructor is currently used. Bug: 1102874 Change-Id: I2bc2601e05dd1002e8bfb8ca0b5873e1ef2811a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567100Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#832967}
-
Joe Downing authored
Change-Id: I0527f29f46df832ab6595573b517994290a5c070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569682 Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#832966}
-
David Bertoni authored
These test were disabled for SW-based extensions due to flakiness. This CL uses a workaround to enable file access for the tests to avoid reloading the extensions to remove file access. The tests are not flaky if the extension isn't reloaded. Bug: 1111337, 1111536 Change-Id: I5fbcf91a0d25da7a3071f294a449bc79da6714d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561214 Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832965}
-
Mark Schillaci authored
This CL is the fifth part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. We have also hidden the entire feature behind a feature flag, so this CL is not visible to an average user. ---------- This CL adds the following: - Toasts on user interaction - "Only on Wifi" option / logic - Refined Profile usage to account for incognito - Associated strings etc for above ---------- AX-Relnotes: Adds feature to enable generating alt image descriptions, currently behind a feature flag. Bug: 1057169 Change-Id: Iea746564f71f8c75631654fa5a1951b663a459d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552569Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#832964}
-
Harry Cutts authored
This CL adds a new setting for pointing stick acceleration, with a corresponding slider on the pointers subpage. If the flag is disabled, changes to the equivalent mouse setting are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. Bug: 1114828 Test: Check the toggle changes acceleration Change-Id: If9dd9cbcffd064ab897abcbe551990e2862e08ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548687 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832963}
-
David Black authored
With the new holding space feature, the user has the ability to pin important files to dedicated system UI in the shelf. To inform users of this new capability, a welcome banner is being added to the Files app similar to the welcome banner which is shown for Google Drive. Note that this CL only roughs in the UI and implements the core logic for when it will show. Follow ups will be done to limit the number of shows and the volumes in which it is eligible to be shown. Screenshot: http://shortn/_ZXYLrR8slB Mocks: http://shortn/_P75yJNk5iG Bug: 1154347 Change-Id: Iea5bbf50d34846a016a791df4151ecaf3e8660f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568258 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#832962}
-
Bo Liu authored
Bug: 1084500 Change-Id: Ifb8bca0abe9c591ee006c53d0d18ba65701129b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568599 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#832961}
-
Michael Ershov authored
This allows Lacros-Chrome access to the system-wide TPM slot, the per-user TPM slot, and per-user storage for certificates and trust settings, for enterprise-managed devices where the logged-in user is an affiliate of that enterprise. Rather than Lacros-Chrome directly interacting with the login services, it requests that Ash-Chrome notify it when the TPM and Cryptohome are available, receiving the path to the per-user storage and the result of TPM initialization. Lacros-Chrome can then initialize initialize a connection to the TPM (via a PKCS#11 module) and initialize storage at the path provided by Ash-Chrome. For users that are not affiliated, Chrome today enables access to both the per-user TPM and per-user storage. However, for Lacros-Chrome, this is a known issue and not yet supported (crbug.com/1146430). This is because loading the TPM unconditionally loads both the system and user slot today, while non-affiliated users should not have access to the system slot. The per-user storage will be loaded for all users with this CL. Similarly, using the system slot on the login screen is not yet supported, and will be addressed in a follow-up (crbug.com/1146430). Bug: 1145946 Change-Id: I2edc6e04c2de09f4c8a4d3bdca9c9ba5a9dee3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435642 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832960}
-
Sky Malice authored
The problem is that for our experiment if trigger rate is relatively low, metrics are dominated by the non-triggering group. This CL activates users that were shown the IPH, or met the conditions to trigger but were tracking_only. These cohort groups make it easier analyze the less dilute data. Bug: 1116201 Change-Id: I74b30d84891ef7f6d2b487ec2b95cbcf4e240bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552572Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#832959}
-