- 10 May, 2018 40 commits
-
-
Conley Owens authored
This change removes all references to the Physical Web Service. BUG=826540 Change-Id: I75a85182798073648dc0f5356b4373dddb54a662 Reviewed-on: https://chromium-review.googlesource.com/1040353Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#557584}
-
Daniel Murphy authored
This reverts commit 48f503a8. Reason for revert: Failing the Linux Trusty Leak bot Original change's description: > Reland "Composite ScrollTimeline scrollSource when appropriate." > > This is a reland of ddd9f0ee > > Original change's description: > > Composite ScrollTimeline scrollSource when appropriate. > > > > This CL makes being the scrollSource of an active (i.e. the scrollSource is > > scrollable) and attached (i.e. it is being used by at least one WorkletAnimation > > as a timeline) ScrollTimeline a compositing reason. It does not change the > > requirement that the scrollSource must be composited for the WorkletAnimation to > > be sent to the compositor, nor does it change the case where a scrollSource stops > > being composited whilst a WorkletAnimation is running. Those will be addressed in > > follow-up CLs. > > > > Bug: 776533 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231 > > Reviewed-on: https://chromium-review.googlesource.com/1036934 > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556541} > > TBR=pdr@chromium.org > > Bug: 776533 > Change-Id: I36cde2bb53e4c24fc57caef1e33f8dcac159ec77 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1050547 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557347} TBR=pdr@chromium.org,majidvp@chromium.org,smcgruer@chromium.org Change-Id: Ia89e6d42ef89fceebb1630dcdcbe3b1af6c71964 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776533, 841844 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1054116Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#557583}
-
Dmitry Gozman authored
This mock clipboard host lives in browser process, essentially synchronizing clipboard between OOPIFs. In unit tests we instantiate the mock in-process and override the binder in Connector so that WebClipboardImpl connects to it. This patch discovered two issues with clipboard implementation which are being fixed: - Blacklisting text/uri-list clipboard items does not allow them to be copied to clipboard. Old mock implementation masked this issues, while the new one exposed the issue caught by multiple tests. - Unit tests sometime pass null strings to copy to clipboard, so we should ensure they are non-null in WebClipboardImpl. One more semantic change is a rewrite of unit tests which read image from clipboard to layout tests, where that functionality is available. The rest is just plumbing of a new mock. Bug: 775830, 607991 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie63552228a9038cfd5e677d9f1bec5a2184662ad Reviewed-on: https://chromium-review.googlesource.com/1034022 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557582}
-
Alexey Kozyatinskiy authored
These tests are failing already and with new V8 roll they will fail differently. TBR=dgozman@chromium.org Bug: chromium:839947 Change-Id: I03399a6528e88d41025d577c44feec08f245d1ba Reviewed-on: https://chromium-review.googlesource.com/1054187Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#557581}
-
Antoine Labour authored
This is not used in production anymore. Bug: 754872 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8b68715ccfdf7805cd2d6024148690638c7c9f98 Reviewed-on: https://chromium-review.googlesource.com/1053304Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557580}
-
Bill Orr authored
This reverts commit 1e0c32df. Reason for revert: Fix issue that caused revert. Tested unit tests on Windows with component and non-component build. Original change's description: > Revert "Enable device/vr unittests on non-Android platforms" > > This reverts commit 11ee8e61. > > Reason for revert: Suspected causing build failure on WebKit Win Builder (dbg) > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/131035 > > Original change's description: > > Enable device/vr unittests on non-Android platforms > > > > Change-Id: I76eed7cf354d7f55e5409035941b76100d772b96 > > Reviewed-on: https://chromium-review.googlesource.com/1053093 > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557320} > > TBR=mthiesse@chromium.org,billorr@chromium.org > > Change-Id: Ice684f6a36892c3b73c789617d40718a40d01745 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1053153 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557346} TBR=mthiesse@chromium.org,thomasanderson@chromium.org,billorr@chromium.org Change-Id: Icbeef0d1e1c9649cdebe9bdfa9a670399c7aa0c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1053248 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557579}
-
Xianzhu Wang authored
For consecutive clips in the same transform space, we combine the clips in following more cases: 1. A rectangular clip and a rounded clip can bombine if the rectangular clip contains the rounded clip; 2. A clip path clip can combine with previous clips (but not following clips) if other combination conditions are satisfied. Also no longer issue a pair of ClipRectOp and ClipRRectOp for one rounded clip rect. It was needed when we didn't antialias clip rects. Bug: 841227 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2daf83ede63e3d6f65bd3eb5f89d8d1ca52cd440 Reviewed-on: https://chromium-review.googlesource.com/1052859 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557578}
-
Rohit Rao authored
The only code remaining in BookmarksTableView is directly related to the UITableView or its loading and empty state backgrounds. BUG=840381 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79910f4d1bfbda5a586bb255c2b53f39ee20cb12 Reviewed-on: https://chromium-review.googlesource.com/1052905 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#557577}
-
Michael Lippautz authored
Includes incremental garbage collection infrastructure in regular builds. Does not enable incremental marking at runtime! Sheriffs: - This CL may cause throughput regressions and is an attempt to collect a broad range of potential performance issues. - Binary size regressions of up to 100kb are expected. The infra added here is the minimal base for any future incremental and concurrent marking changes. Long term we will save a bit of memory by removing trace methods. Bug: chromium:757440 Change-Id: I61f4dca6cb1933a9f10416bc6641aae3e8794455 Reviewed-on: https://chromium-review.googlesource.com/1052108Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557576}
-
Daniel Erat authored
Remove the --force-clamshell-power-button switch and related code from ash. This is no longer used starting with M67. Bug: 841669 Change-Id: Ifca6c0757f4dd077973b489b58030388251f250d Reviewed-on: https://chromium-review.googlesource.com/1053565Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#557575}
-
Becky Zhou authored
Add restrictions for auto peeking the bottom sheet based a minimum required scroll percentage on the web page which is sent from the server side. Bug: 833865 Change-Id: Ie16a4d30d7323046fc82c09963f5660576036d95 Reviewed-on: https://chromium-review.googlesource.com/1048111Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557574}
-
Moe Ahmadi authored
Renames the existing flag, kAutofillUpstreamUseGooglePayOnAndroidBranding, to kAutofillUpstreamUseGooglePayBrandingOnMobile as it also controls GPay branding in iOS. Adds an entry to the about flags page in iOS in order to control the flag. Bug:841758 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I40d961f0106e14f37c5091ffbda7ac72620dd43c Reviewed-on: https://chromium-review.googlesource.com/1053430 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557573}
-
Rohit Rao authored
This reverts commit f16dcd5e. Reason for revert: Breaks Fullscreen EGtests when UIRefresh is enabled. Original change's description: > [iOS] Show toolbar for load events when UI refresh flag is enabled. > > In the legacy UI, fullscren was disabled when the WKWebView was loading > so that the URL of the page is always visible. After the UI refresh, > the URL is always visible, so fullscreen does not need to be disabled. > However, the toolbar should still be shown (but not disabled) upon load > events to ensure that navigation to AMP pages allows access to the > navigation controls on these pages. > > Bug: 837254 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Icc9e54cd6972b481c9041fb547f4ab5e8ba40b81 > Reviewed-on: https://chromium-review.googlesource.com/1048635 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556908} TBR=justincohen@chromium.org,kkhorimoto@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837254 Change-Id: Iee7aa1a1c157015ba238fa18dbfde82e672a8b14 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1054047Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557572}
-
Mustafa Çamurcu authored
This cl unbreaks the Windows/Ozone build by not defining WatchFileDescriptor(). Change-Id: I690ae4cfe458b1fa570f70060520ba98aa8b449d Reviewed-on: https://chromium-review.googlesource.com/1048071Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Cr-Commit-Position: refs/heads/master@{#557571}
-
Brian White authored
This doesn't actually change the recording rate because doing so would make a lot of tests become "flaky" as expected results sometimes got dropped. Bug: 766909 Change-Id: I8aa8839ddf6628b89d0bbcffd7385a7c202b17da Reviewed-on: https://chromium-review.googlesource.com/1032888Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#557570}
-
Chris Nardi authored
Document#selectedStylesheetSet/preferredStylesheetSet are non-standard methods that are only implemented by WebKit and Blink. Their standard versions are no longer in the spec. Remove them entirely from our implementation. Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/w1Bv7YZxAco Bug: 690609 Change-Id: I796a6bc0693934eb308a4fe59b52e4a9d1269e6f Reviewed-on: https://chromium-review.googlesource.com/1049051 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#557569}
-
Nate Chapin authored
This reverts commit 0817c1db. Reason for revert: Canceling and redirecting causes a variety of small, strange behaviors, revert while landing a better solution (https://chromium-review.googlesource.com/c/chromium/src/+/1053237) Original change's description: > Do partial redirect handling in the renderer process for sync requests > > Historically, blink has not received any intermediate resource loading > callbacks for sync requests. It simply blocked until the load finished > or failed, which meant that redirect security checks performed by blink > would be skipped (and in some cases we would try to reconstruct or do > a partial security check after the fact). SyncLoadContext allows us to > do more of these security checks before the redirect is sent. This > allows us to come closer to doing the correct thing for sync request > in general, and allows us to move some worker requests off-main-thread, > where before they had to proxy sync requests through the main thread in > order to get both proper redirect handling and the correct synchronous > behavior. > > This CL "cancels" sync requests on redirect. WebURLLoaderImpl then > notifies blink of the redirect, which sends FetchContext callbacks (but > not ResourceClient callbacks). This allows us to do things CSP checking > on redirect. If blink permits the redirect, WebURLLoaderImpl manually > follows the redirect by issuing a new sync request. > > ResourceClient callbacks aren't performed becuase sync requests have > historically not been associated with a ResourceClient. Doing so would > be a much large refactor, and would require careful handling to make sure > we didn't enter JS inside what is supposed to be a synchronous blocking > function. > > We therefore need to continue to perform a rudimentary CORS check in > SyncLoadContext, which blocks cross-origin redirects if the > FetchRequestMode was anything other than kNoCors. This revealed a couple > of XML/XSLT callsites that should have been setting a FetchRequestMode but > weren't. > > Bug: 706331 > > Change-Id: I4ed54cb3ccd119b8a5d192b077bef8d03745e67e > Reviewed-on: https://chromium-review.googlesource.com/1015237 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556546} TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,yhirano@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 706331 Change-Id: Id42378ac08f67861aac524ab618b782010970577 Reviewed-on: https://chromium-review.googlesource.com/1054108Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#557568}
-
Robert Ma authored
TBR=foolip No-Try: True Bug: 841809 Change-Id: I4355f56ff832b43f62cabf9de76f41bf60ebf94d Reviewed-on: https://chromium-review.googlesource.com/1054100Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#557567}
-
Olga Sharonova authored
Change-Id: Id6cb550886ea6aa8e3ae48c9a72e4ac70b8db038 Reviewed-on: https://chromium-review.googlesource.com/1054069Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557566}
-
Robert Phillips authored
This reverts commit 035c0c8f. Reason for revert: compile failures Original change's description: > Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits) > > https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 > > $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' > 2018-05-10 reed allow divide by zero > 2018-05-10 fmalita Validate readByteArrayAsData size > 2018-05-07 enne Add driver bug workarounds to GrCaps > 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. > 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization > 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" > 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. > 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) > > Created with: > roll-dep src/third_party/skia > BUG=chromium: 829614 > > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=egdaniel@chromium.org > > Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc > Reviewed-on: https://chromium-review.googlesource.com/1053760 > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#557555} TBR=egdaniel@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I8f3ada64dc671959da55bc34763a706bcd7cf86d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1054048Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#557565}
-
Leonard Grey authored
Bug: 840456 Change-Id: Idf022ee3493207ab64dd72d25a70f2527f557fad Reviewed-on: https://chromium-review.googlesource.com/1048068Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#557564}
-
Guido Urdaneta authored
Bug: 823640 Change-Id: Iede7cc3d9a7b7f39b89810914dcda1cb61379cdc Reviewed-on: https://chromium-review.googlesource.com/1041865Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557563}
-
Ben Pastene authored
Also add a couple not-so-small gtests (base_unittests and net_unittests) to the fyi test bot. Current test pool has 20 bots. Will bump more if needed, but given how rarely I think analyze would trigger these specific tests, maybe not needed? Bug: 840967 Change-Id: Id71c7f0899790da95a8c3ff60ea62d3f831511ee Reviewed-on: https://chromium-review.googlesource.com/1053235Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#557562}
-
Rohit Rao authored
BUG=840381,839428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id20bd04c30c03bb98dbb9ac9c8c6013fc245b950 Reviewed-on: https://chromium-review.googlesource.com/1052904 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Becky Zhou authored
Adds a method to enable show request that wants to show the specified dialog as the next available of a specific dialog type. Bug: 838280 Change-Id: I41ac8b427fe21b27343fddc5f7dbeaf137be0063 Reviewed-on: https://chromium-review.googlesource.com/1053387 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557560}
-
Sebastien Marchand authored
For use in incognito sessions. Bug: 773382 Change-Id: I5222eeb2de25c4b5a87e5a41b261d99cbea6de54 Reviewed-on: https://chromium-review.googlesource.com/1053180 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#557559}
-
Peng Huang authored
The logic in viz::Display is for using VSync for presentation callback, it is not right when we can get the presentation feedback from GLSurface. This CL fixes the issue. This CL also change the logic of GLSurfacePresentationHelper to make sure the presentation callback is run after SwapBuffers is returned. Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifad2088316982e328bf56ef6b9c3eab6f478bb6d Reviewed-on: https://chromium-review.googlesource.com/1051967 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557558}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7c3ff1311a45..d3f2c8e78346 $ git log 7c3ff1311..d3f2c8e78 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 kkinnunen win_toolchain: Add another source dir for dbghelp.dll when packaging the toolchain Created with: roll-dep src/third_party/depot_tools BUG=chromium:834656 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I73791492e502ea9d0dca607a646154eecdf735d9 Reviewed-on: https://chromium-review.googlesource.com/1053762 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557557}
-
Koji Ishii authored
When a word in 'nowrap' element fits but its trailing space does not, issue 561997 fixed not to wrap before the 'nowrap' element. The fix, however, creates a wrap opportunity even if 'nowrap' content follows. This patch ensures the fix is valid only if no content follows or autowrap content follows; i.e., only when we really have a break opportunity after the space. Ideally, the original fix should have been done when the line breaker reads the next item. But we have a lot of places that call FitsOnLine() without 'ExcludeWhitespace' option and probably some of them are not correct. To make the fix safer, this patch limits the original fix instead of cleaning up all FitsOnLine() calls. Change-Id: I78c499cc6c1d7c30261e031ec19124ae9d3fbcf1 Bug: 561997, 840755 Reviewed-on: https://chromium-review.googlesource.com/1053341Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#557556}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 reed allow divide by zero 2018-05-10 fmalita Validate readByteArrayAsData size 2018-05-07 enne Add driver bug workarounds to GrCaps 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc Reviewed-on: https://chromium-review.googlesource.com/1053760 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557555}
-
Ryan Sleevi authored
When/where appropriate, the following conversions are made: - Range based for-loops when iterating - constexpr base::StringPiece for string constants - [std::]begin() / [std::]end() when copying - base::size() as last resort Bug: 837308 Change-Id: I640ced508edb0b12f44534e0173a9d9402e627b6 Reviewed-on: https://chromium-review.googlesource.com/1043687 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
-
Greg Kraynov authored
Bug: 841735 Change-Id: I8d87679e2c813b91a6c45981ef0cc0c73a90191e Reviewed-on: https://chromium-review.googlesource.com/1053808Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557553}
-
Greg Kraynov authored
Bug: 841735 Change-Id: I268a97109e95d435a3cb64e8d04f8741ebc60bda Reviewed-on: https://chromium-review.googlesource.com/1054028Reviewed-by:
-
Sebastien Marchand authored
This will be used as a part of the Site Characteristics Database to make sure that we don't record anything during incognito sessions. Bug: 773382 Change-Id: Ia4de800fde921ce04ce6612e80d34842b62ace8e Reviewed-on: https://chromium-review.googlesource.com/1053100 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Theresa authored
Remove a handful of feature flags that are no longer used. BUG=814528 Change-Id: Iaee99938d9aeac35c32477b590534a0359d62b12 Reviewed-on: https://chromium-review.googlesource.com/1053305Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557550}
-
Fernando Serboncini authored
Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic9ccf732ab6425c60fb3e2df4d53d239bde5d920 Reviewed-on: https://chromium-review.googlesource.com/1037921Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557549}
-
Devlin Cronin authored
Awhile back, we added logic to withhold all-hosts style permissions via sync if the user had withheld hosts on any machine. This was a mistake, since it resulted in the user being affected by an experiment across all machines, even if they only opted into the experiment on one. Remove the all_urls_enabled bit on the ExtensionSpecifics proto. A replacement will be added in a subsequent patch. We can't just re-use the existing one, because we need to prevent older machines from seeing the preference and automatically applying experimental behavior. Bug: 839681 Change-Id: I735b7005ca76b9abe3b61709083bb4f552d0a47f Reviewed-on: https://chromium-review.googlesource.com/1047850 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557548}
-
Kevin Bailey authored
A new file URL parsing routine was added in a previous CL (1025953) for detecting hash/pound refs in file URLs. This made file: schemes a bit of an exception. This CL removes that routine and leverages the existing routine, calling it from where the other URL types are parsed, treating file: schemes like the other schemes. Bug: 780835 Change-Id: Ic7f00b88e50801d00c609c1a92d00d1f1bf67808 Reviewed-on: https://chromium-review.googlesource.com/1043157 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557547}
-
Emily Hanley authored
Bug: 804982 Change-Id: Ib2f1de287654280bf24065f1873f6a901bcfc2e2 Reviewed-on: https://chromium-review.googlesource.com/1053800Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557546}
-
Jonas Olsson authored
Internally it uses a new, slightly simplified copy of MojoAudioInputIPC. Bug: 834702 Change-Id: I878ada69d82c72a431b7fdfe1905ae79b3d8963d Reviewed-on: https://chromium-review.googlesource.com/1041686Reviewed-by:
-
