- 11 Feb, 2020 40 commits
-
-
liberato@chromium.org authored
Bug: 1049192 Change-Id: I49ca6860718a2a015cfccf07150bd3aa4344b781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042042 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740406}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4fad85878aa6..da4dea33d709 git log 4fad85878aa6..da4dea33d709 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@da4dea33d709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9c8e036211bac92fe1eb269b2ad838fd1360ab78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740405}
-
Brandon Wylie authored
https://chromium.googlesource.com/catapult.git/+log/df7f6a4d2256..5b39823026a7 $ git log df7f6a4d2..5b3982302 --date=short --no-merges --format='%ad %ae %s' 2020-02-11 abennetts Consolidate time calculations into BqExportOptions, and snap those timestamps to UTC day boundaries to align with BigQuery's timestamp partitions. 2020-02-11 fancl Remove index.yaml from push on green 2020-02-11 abennetts Prototype beam pipelines for exporting dashboard data to BigQuery. 2020-02-10 ntfschr Devil: increase timeout when uninstalling WebView Created with: roll-dep src/third_party/catapult Bug: 1050705 Change-Id: I99d4cf1815586efcdb30878e6cbe12dbce53eed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050880Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#740404}
-
Kristi Park authored
Example flakes: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4292 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4297 TBR=kyleju@chromium.org Bug: 1047818 Change-Id: Ib486e39866f600e8ed20d4b09cfc7f7f1fc9fa8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050930 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740403}
-
Xing Liu authored
Currently a server time string is parsed by base::Time::FromString in announcement notification system. When not specify the time zone, then Chrome uses local time zone. We should use base::Time::FromUTCString that assumes UTC time when there is no time zone in the server time string. Bug: 1048437 Change-Id: Iba84f557fdcea19a5635f00c2f7ebc3c41279d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037013Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740402}
-
chromium-autoroll authored
Roll broadwell AFDO profile from chromeos-chrome-amd64-broadwell-82-4028.0-1581331201-benchmark-81.0.4044.15-r1-redacted.afdo.xz to 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If211e70afd271edeed561c21c31fea228e81c843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740401}
-
Andrew Xu authored
Bug: 1045269 Change-Id: Ieef000cfc0698dc6b50f8568ca0db7ca53ce79b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044881 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740400}
-
Alex Cooper authored
As part of the work to use the permissions prompt by default, instead of the custom consent dialogs, tests will need to be updated to use the embedded test server rather than directly navigating to a file. This is due to the fact that the Permissions code will DCHECK if saving the permission for a file-type URL. TODO:Revert changes to PermissionUtil and content_features, these are currently loaded to validate that the tests will pass with these changes. Bug: 1043241 Change-Id: Iaa820812fac0bc389af47c22f8e069e81929b05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047987 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#740399}
-
rbpotter authored
- Autogenerate Polymer 3 versions for files in appearance_page/* - Update closure compiler and polymer_modulizer/js_modulizer targets for these files - Autogenerate tests for the Polymer 3 files. Bug: 1026426 Change-Id: If58ea84995634c223b6e37af3e0c721461f9f63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045038 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#740398}
-
Jon Mann authored
This class handles the retrieval, filtering, and conversion of local networks to syncable protos. Bug: 966270 Change-Id: Ia722c5de2c694bf2cf240e4dfec3664c2c838961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033338 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#740397}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 123 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-09. Change-Id: Ie29829cef004df3c2a8ae50d42f54509ad11453c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050515 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#740396}
-
Lily Chen authored
This factors out the "superdomain" string manipulation into a separate util function. Bug: None Change-Id: I8eb6ceb6278519cb2a2cb2feb5d669cab0d2b7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049284 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#740395}
-
chromium-autoroll authored
Roll airmont AFDO profile from chromeos-chrome-amd64-airmont-82-4037.0-1581333121-benchmark-81.0.4044.14-r1-redacted.afdo.xz to 81-4028.0-1580123479-benchmark-81.0.4044.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I245a6ba1a68880c95942013e50fe085e374eafbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740394}
-
Andrew Moylan authored
Bug: 937063 Change-Id: I836d350cf492549f2c4f8590876d0170c5dbe1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048044 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#740393}
-
Dominik Röttsches authored
LruCache was added to WTF which allows us to remove the specific instance that was added for OOP font fallback caching. Bug: 1005234 Change-Id: Id20e7fb0b99128a4c3d5c4edc5bed5ffe881a17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050314Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#740392}
-
Kyle Horimoto authored
This class tracks completed user actions per session and records metrics laid out in go/cros-settings-user-metrics. Bug: 1047062 Change-Id: Icce6fa2c9aa2914aeea829fbc968cdf7161a1058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038282 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#740391}
-
Bo Liu authored
By doubling the timeout for polling scroll. Bug: 1035894 Change-Id: I6088799c8dd704965e9e9c571cdf4cb919ee745c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050566 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740390}
-
Maksim Ivanov authored
This allows to collect metrics to know whether the strict validation of the "device_id" field in device policy protobufs would be safe or not. Bug: 653849 Change-Id: Ie5157d00607ce2d76e0d20f1d5e273dc1f4c5f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047063Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#740389}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da612b8e3549..87e60d9c3b30 Created with: gclient setdep -r src-internal@87e60d9c3b30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042741 Tbr: jbudorick@google.com Change-Id: I4056111afac8791bdccad3faabbdd5f24bc47441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050943Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740388}
-
Sasha McIntosh authored
This check fixes the broken perf test: RemoveOverdrawQuadPerfTest.* Test: viz_perftests Change-Id: I4afcf5234feb6d810f066f3f5cb9eae7d2559740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047419 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#740387}
-
Garrett Beaty authored
The project settings for chromium/src requires all changes to be landed by submitting to CQ, but nothing happens if there is no CQ configured for the branch. Bug: 1044808 Change-Id: I21f007029c3dd6fbae95a157245eb81a7896d62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019704 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#740386}
-
Yulun Wu authored
Bug: 1034168 Change-Id: I8193b727e1635b0f5d368c74157f1ca0f1dd8197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025887 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740385}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc2257e06aa7..2c9bed613fc5 git log cc2257e06aa7..2c9bed613fc5 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 taylori@google.com Merge "perfetto-ui: Time preview on log hover" Created with: gclient setdep -r src/third_party/perfetto@2c9bed613fc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id54e50ca27d6612225416dc57c1042e000299d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740384}
-
James Cook authored
Fixed by adding preprocess=true to the grd entry for sync_account_control.js such that <if expr="chromeos"> directives will be applied in Debug. Original CL description: Browser settings for sync uses a "sign out" dialog to handle when the user clicks "Turn off". Depending on the use case the dialog title and buttons may say "Turn off" or "Sign out". Update the strings for SplitSettingsSync to use "Turn off". Because Chrome OS users cannot sign out, wire the dialog's "Turn off" button to a new method in PeopleHandler. The existing code path for sign out/disconnect assumes DICE, which Chrome OS does not support. Bug: 1050677 Test: manual, button labels are different (and match Linux) Change-Id: Iad8a89e3f9fccdc239d051e405a805a71b20a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047765Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#740068} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050610 Cr-Commit-Position: refs/heads/master@{#740383}
-
Alex Newcomer authored
This disables blur during animations, which improves the performance of hotseat animations. Bug: 1031266 Change-Id: I6f0fc2dc4a5a8f552d244ac5bd877761261c6799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044766 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740382}
-
Ahmed Fakhry authored
This is a preparation for desks renaming to be able to replace the mini views' labels with textfields. I'm splitting this as its own small CL because it may cause regressions. BUG=1040980 TEST=Manually, and all existing tests should pass. Change-Id: Idf1ba55382bd29fbd6de596341ea118f737f993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044644 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#740381}
-
Yu Han authored
This reverts commit b4cb14f3. Reason for revert: Getting ready to re-land The original fix for Bug: 538283 introduced a regression, Bug: 1045433. So it was reverted. This is another fix for the original issue and ensures anchor behavior does not regressed. To recap, the original issue is caused by DOMActivate event generated from inline elements. DOMActivate bypasses anchor, bubbles up to <summary>, and gets handled. The underlying event, click, stops propagating and terminates. The original fix for anchor looks at the underlying event and handles it if it's click. However, this logic is wrong because the anchor can preemptively handle a click that belongs to another element earlier in the event path. This example, in file label-inside-anchor.html, illustrate the problem. <a href="javascript:void(0)" target="_blank"> <label for="peas"><span id="text">peas?</span></label> <input type="checkbox" name="peas" id="peas"> </a> Clicking on 'text' generates DOMActivate, which is handled by <a>. Prior to my original fix, DOMActivate isn't handled, and click event bubbles up until it's handle by the <label> attribute. Bug: 1045433 is another example of the same behavior. Video element wrapped by anchor. In this fix, summary element uses the Node property HasActivationBehavior and does not handle DOMActivate if the target node or any of its ancestors up itself has this property set. This allows the click event to continue propagating until it gets handled by an node with ActivationBehavior. Original change's description: > Revert "Fixes click on inline element embedded in anchor inside <summary> breaks anchor." > > This reverts commit 4eb4df63. > > Reason for revert: Caused crbug.com/1045433. > > Original change's description: > > Fixes click on inline element embedded in anchor inside <summary> breaks anchor. > > > > Previous to this CL, clicking on an inline element embedded in an anchor placed > > inside a <summary> tag will expand the <details> section instead of navigating to > > the anchor's href. However, when the anchor is placed outside of <summary>, > > it behaves correctly. > > > > The error is caused by DOMActivate event generated by the inline element. As > > DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the > > <summary>, and is handled there. Once DOMActivate is handled, the original > > click event stops propagating and terminates. This behavior, however, differs > > from when the anchor tag is placed outside of the summary. DOMActivate isn't > > handled, and the original click event keeps bubbling up till it's handled by > > the anchor. > > > > DOMActivate event is deprecated: > > https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event. > > However, since blink still has code that depends on it, replacing it is outside > > of the scope for this fix. Instead, this fix is for the anchor element to > > handle the DOMActivate event as it bubbles up. The anchor event handler checks > > the underlying event of DOMActivate and handles it if it's a click. > > > > I also looked at an alternative fix by trying to prevent the DOMActivate event > > from bubbling up. But calling event.stopPropagation() doesn't work as the > > EventDispatcher::DispatchEventPostProcess doesn't check this status. > > > > > > Bug: 538283 > > Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Mason Freed <masonfreed@chromium.org> > > Commit-Queue: Yu Han <yuzhehan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718552} >> > Bug: 1045433 > Change-Id: I14b369beb04171ef846cb3a79ebb3fe268cf5c89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023267 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735575} Bug: 1045433 Change-Id: I0cdd7b48a2c4e9bf2b653edef9ce7970d7e64938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028455Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740380}
-
yilkal authored
Sets the application state to kAlwaysAvailable if the application is whitelisted. Bug: 1034551, 1022093 Change-Id: I51f0cc9ff37eda497a4916126192f8a46597edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047448 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740379}
-
Ben Pastene authored
Adds links to trunk, beta, & stable consoles to the header. That should make all 3 discoverable from most every console. Bug: None Change-Id: I269c07ba93f7599b5c9eab588dc1a698cfb9a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050867Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#740378}
-
Kyle Milka authored
Track the time taken to open the custom share sheet after a share entry point is clicked. Bug: 1009124 Change-Id: I2e3ffc821856bf606864c4af0865f241422d4f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989693Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#740377}
-
Tim van der Lippe authored
cpu-profiler-save-load.js can timeout as well TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I96efb3d2cf580e6ee4cc6f903fd1b29c00620870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050322Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#740376}
-
Min Qin authored
If a download is triggered by opaque origin, currently we create an origin from main WebContents' URL to determine if the download should be blocked. However, if main WebContents' URL is also an opaque origin, the newly created origin will be different from the previous origin. And making the download always allowed. This CL fixes the issue by using the originating opaque origin instead if the WebContents' origin is opaque. An alternative solution is to assign a dedicated opaque origin to the main WebContents. BUG=1044277 Change-Id: Ia38280f4237ba5cd35c7afcf350734833fb9d002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048843 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740375}
-
Christopher Cameron authored
Detect HDR capability and use it to populate DisplayColorSpaces. Add DisplayColorSpaces constructor that takes BufferFormat (we'll need it). Update ui::RecyclableCompositorMac to take DisplayColorSpaces instead of ColorSpace (they were dropping the data on the floor). Update HDRCopierLayer to use PresentsWithTransaction correctly. Bug: 1049334 Change-Id: I17a0f75ac08e75d0b38825a38ee0d738ca634059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049663Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#740374}
-
Scott Violet authored
Bug: 1050857 Change-Id: Idd840a66a7c521784a764bbe3923ad838933c87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050844Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740373}
-
yilkal authored
This CL reuses supervised_user_block_interstitial.css for web_time_limit_error_page.html Bug: 1015661 Change-Id: I0874139acf852c411e7cdfa2c8b459bda74f5811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047487Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#740372}
-
Reid Kleckner authored
Now that libc++ is always used on Windows, we don't need a dedicated bot to monitor this configuration. R=thakis@chromium.org Bug: 801780 Change-Id: I98916f516cc5d06ef9180efec331be86bbae114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048007 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740371}
-
Brandon Wylie authored
This will prevent TabPersistentStore from restoring a tab we're in the process of reparenting. Bug: 1042565 Change-Id: I1b7e505c0870e7c6b7d77eaf1012abde8cdd5c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042681 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740370}
-
Zhiheng Li authored
Implement method to set interaction ID to cast_content_window_android and pass it to CastWindowManager via intent. Bug: b/149024372 Test: cast_shell_junit_tests Change-Id: I84fcf60967cc77c79aa8c765a8a1d58fdaaa0bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048845Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#740369}
-
Takumi Fujimoto authored
Show a Cast icon at the top left corner of Cast notifications in Global Media Controls to make it easier to distinguish Cast notifications from local notifications, which have no icon. Screenshot: https://drive.google.com/file/d/1701V_-4ufHnYMF-e_pdD20AyC8V4HdC0/view?usp=sharing Bug: 1042008 Change-Id: I244564bef86d4209656cd60b377684dc205f8d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026413Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#740368}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a341dac0524..da612b8e3549 Created with: gclient setdep -r src-internal@da612b8e3549 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049671 Tbr: jbudorick@google.com Change-Id: I590012810349aae3944a7285e77d0d96c616650c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050506Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740367}
-