- 03 Jun, 2016 40 commits
-
-
nzolghadr authored
Whitelist pointer event manual tests in the import process Using update-w3c-deps in Chromium c517903e. BUG=612924 Review-Url: https://codereview.chromium.org/2020083002 Cr-Commit-Position: refs/heads/master@{#397754}
-
samuong authored
BUG= TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2039533002 Cr-Commit-Position: refs/heads/master@{#397753}
-
kulshin authored
Add tests and Win10 expectations for color emoji. Also fix an expectation for emoji fallback test to look for the color emoji font first, which will be present on Win10, but not on Win7. Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/ BUG=333011 Review-Url: https://codereview.chromium.org/2003853002 Cr-Commit-Position: refs/heads/master@{#397752}
-
cco3 authored
This change moves the close button to the far right in the Physical Web ListUrlsActivity. BUG=603132 Review-Url: https://codereview.chromium.org/2027033002 Cr-Commit-Position: refs/heads/master@{#397751}
-
raikiri authored
BUG=584660 Review-Url: https://codereview.chromium.org/2032943003 Cr-Commit-Position: refs/heads/master@{#397750}
-
bcwhite authored
BUG=546019 Review-Url: https://codereview.chromium.org/2036643004 Cr-Commit-Position: refs/heads/master@{#397749}
-
sky authored
BUG=616265 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2037033004 Cr-Commit-Position: refs/heads/master@{#397748}
-
chrishtr authored
BUG=616633 Review-Url: https://codereview.chromium.org/2037093002 Cr-Commit-Position: refs/heads/master@{#397747}
-
dcheng authored
The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Review-Url: https://codereview.chromium.org/2037703004 Cr-Commit-Position: refs/heads/master@{#397746}
-
sdefresne authored
In order to allow Chrome on iOS to use build/mac/tweak_info_plist.py, add options required to control the format of the generated plist file (--format), the product reported to breakpad (--platform) and a way to override some portion of the version string (--version-overrides). This is required to allow Chrome on iOS to migrate from it old fork of tweak_info_plist shell script and to incorporate tweak_info_plist.py in the GN build. BUG=502295 Review-Url: https://codereview.chromium.org/2037043002 Cr-Commit-Position: refs/heads/master@{#397745}
-
sunxd authored
As compositor will no longer know tree hierarchy information, it is expected to dump a layer list instead of a layer tree to chrome tracing. The value root_layer is also deleted because it is used to judge whether the dumped layer_tree_impl has a list or not on the FrameViewer side. Chrome://tracing will show a layer_tree_impl without depth, this is expected. This CL is blocked by Issue 1947553002, and potentially influenced by the LayerTreeImpl's JSON issue. Devtools need to deal with the new format information. On the devtools side, we make the first drawsContent layer "contentRoot" and treat all other layers as the contentRoot's child. BUG=605940 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1945813002 Cr-Commit-Position: refs/heads/master@{#397744}
-
eseckler authored
(based on patch from skyostil@, also sets default window size to 800x600 to enable basic snapshot support) With the --screenshot option, headless shell will save a PNG screenshot of the loaded page. patch from issue 2000723002 at patchset 1 (http://crrev.com/2000723002#ps1) BUG=546953 Review-Url: https://codereview.chromium.org/2035733002 Cr-Commit-Position: refs/heads/master@{#397743}
-
jmadill authored
This test is causing problems for the ANGLE CQ. BUG=617148 R=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2032413002 Cr-Commit-Position: refs/heads/master@{#397742}
-
chongz authored
The original DomCode+flags->DomKey mapping causes issue when the application generates mismatched keyCode + scanCode, or missing scanCode entirely. (e.g. keyboard-rewrite softwares that only modifies keyCode) A better solution is to use VK+flags->DomKey mapping (for both printable and non-printable keys). This CL is the first step for the non-printable keys, where a fixed table for general non-printable keys was introduced. And there will be follow up CLs to handle other language-specific cases and printable keys. BUG=612749 Review-Url: https://codereview.chromium.org/2025733002 Cr-Commit-Position: refs/heads/master@{#397741}
-
bauerb authored
BUG=616710 Review-Url: https://codereview.chromium.org/2032713004 Cr-Commit-Position: refs/heads/master@{#397740}
-
msw authored
Add wallpaper.mojom for ash_sysui<->chrome interaction. Implement WallpaperController in ash_sysui UserWallpaperDelegateMus. Implement minimal new ChromeWallpaperHelper in chrome. (lets chrome set mash wallpaper, mash trigger chrome wallpaper picker) Add SetWallpaper helper for WallpaperManager to work in mash too. Remove sysui_application.cc debug wallpaper initialization. Bail early on WindowStateManager::[Minimize|Restore]InactiveWindows. Workaround DesktopBackgroundController shell usage. TODO: Fix picker regression from codereview.chromium.org/2009853002 TODO: Fix wallpaper_manager.cc's other Shell::GetInstance uses. TODO: Fix DesktopBackgroundController display size checks in Mash. TODO: Implement window hide/restore for wallpaper picker. TODO: Implement missing UserWallpaperDelegateMus functionality. BUG=557405,613657,613707 TEST=Chrome OS wallpaper works with or without --mash flag; right click mash desktop -> "Set wallpaper..." works. R=jamescook@chromium.org,sky@chromium.org,dcheng@chromium.org Review-Url: https://codereview.chromium.org/1984433002 Cr-Commit-Position: refs/heads/master@{#397739}
-
ericrk authored
This change allows 1 additional frame of pipelining in ImageTransportSurfaceOverlayMac by switching from a glFinish based approach to a glFence based one. Tested for CA framerate regressions - the following cases starve CA when used with a simple glFlush. This solution (and the previous glFinish) appear to successfully prevent CA starvation: Animometer - bouncing png images: https://trac.webkit.org/export/HEAD/trunk/PerformanceTests/Animometer/developer.html?test-interval=20&display=progress-bar&controller=adaptive&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=SVGsuite&test-name=SVGbouncingPNGimages&complexity=200 Both glFinish and glFence produce ~50 fps in CA/Chrome. WebGL Liquid Face: http://alteredqualia.com/xg/examples/liquid_face.html For liquid face, note that with the glFinish, CA framerate is slightly higher than Chrome reported framerate (20 vs 15) - with the new approach, they match more closely (16 vs 15). This may be a negative, but is still much better than the starvation which is seen with glFlush (5 vs 15). Improvements: Telemetry smoothness.top_25_smooth: This change produces good improvements in first_gesture_scroll_update_latency, mean_input_event_latency, and mean_main_thread_scroll_latency, without any significant regressions. See: https://drive.google.com/file/d/0B2nwXDxTDpGGU215X2xYTE9Bdnc/view?usp=sharing Animometer Benchmark: This change produces good improvements in a number of animometer benchmarks. See: https://docs.google.com/spreadsheets/d/1qK6LfDVMKydbKfkGEi1DuGoSqY2wPJAjPiAL1CCUW-4/edit?usp=sharing CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2028303002 Cr-Commit-Position: refs/heads/master@{#397738}
-
dtseng authored
1. merge ignored containers and ignored leaf nodes into one predicate 2. only visit containers that are also visited by the provided predicate. For example, an element will match against a focusable toolbar, but a line won't. 3. scan the initial subtree of a node when moving to the next node if either of the following are true: the node is a container or the node doesn't match the predicate (e.g. element). This takes care of syncing when the current range is on an arbitrary position in the tree. When moving backwards, the leaf predicate restricts how deeply the backwards movement syncs downwards in the tree. BUG=613473 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2028173003 Cr-Commit-Position: refs/heads/master@{#397737}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/9d19cc6ca4de..2cee902847a9 $ git log 9d19cc6ca..2cee90284 --date=short --no-merges --format='%ad %ae %s' 2016-06-03 msarett Add color correction benchmark - with comparison to qcms 2016-06-03 msarett Fix uses of SkImageInfo in BRD to preserve color space info 2016-06-03 jcgregorio skiaserve: Add a flag to control hosted mode, i.e. when running on debugger.skia.org. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2037033003 Cr-Commit-Position: refs/heads/master@{#397736}
-
shanmuga.m authored
If SVG viewbox is explicitly empty, it should be treated as invalid value. BUG=608413 Review-Url: https://codereview.chromium.org/2037573002 Cr-Commit-Position: refs/heads/master@{#397735}
-
spqchan authored
BUG=613788,611113 Review-Url: https://codereview.chromium.org/2002103003 Cr-Commit-Position: refs/heads/master@{#397734}
-
bnc authored
* Remove the limit on amount of encoded HPACK data (kMaxDecodeBufferSize) from HpackDecoder, proteced by FLAGS_chromium_http2_flag_remove_hpack_decode_buffer_size_limit. * Implement limit in HeaderCoalescer. Same value, 256 kB. (Though counted somewhat differently.) * Add regression test. This CL lands server change 123642200 by rjshade. BUG=488484 Review-Url: https://codereview.chromium.org/2031523002 Cr-Commit-Position: refs/heads/master@{#397733}
-
tsepez authored
BUG=613689 Review-Url: https://codereview.chromium.org/2036493005 Cr-Commit-Position: refs/heads/master@{#397732}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/90899c6d475e..37cec23b5d25 $ git log 90899c6d4..37cec23b5 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2038093002 Cr-Commit-Position: refs/heads/master@{#397731}
-
petewil authored
Now that we are actually using the scheduler and GCM Network Manager, add the UMA to measure how long the user's request took from request until the network came back. BUG=597364 Review-Url: https://codereview.chromium.org/2032833002 Cr-Commit-Position: refs/heads/master@{#397730}
-
lukasza authored
BUG=615156, 616608, 616626 Review-Url: https://codereview.chromium.org/2037743003 Cr-Commit-Position: refs/heads/master@{#397729}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a110c042..a9e2bf5a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2030393002 Cr-Commit-Position: refs/heads/master@{#397728}
-
sdefresne authored
Chrome on iOS needs to use tweak_info_plist, so port support for info_plist_target from mac_info_plist to ios_info_plist. BUG=617134 Review-Url: https://codereview.chromium.org/2033403003 Cr-Commit-Position: refs/heads/master@{#397727}
-
dewittj authored
BUG=613761 Review-Url: https://codereview.chromium.org/2028263003 Cr-Commit-Position: refs/heads/master@{#397726}
-
geofflang authored
Use the build_gles2_cmd_buffer.py script to generate as many handlers as possible and hand-write the rest. BUG=602688 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2012533004 Cr-Commit-Position: refs/heads/master@{#397725}
-
johnme authored
It failed in builds 34692 34643 34619 34598 of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 BUG=616456 TBR=maxbogue@chromium.org Review-Url: https://codereview.chromium.org/2039463002 Cr-Commit-Position: refs/heads/master@{#397724}
-
eugenebut authored
Subclasses of WebTestWithWebController should use WebState where possible. BUG=616244 Review-Url: https://codereview.chromium.org/2032903002 Cr-Commit-Position: refs/heads/master@{#397723}
-
ikilpatrick authored
core/workers/WorkerOrWorkletGlobalScope -> core/workers/MainThreadWorkletGlobalScope -> modules/worklet/WorkletGlobalScope With ThreadedWorkletGlobalScope, not all global scopes will exist on the main thread. MainThreadWorkletGlobalScope exists in core/workers as the MainThreadDebugger & friends need to access it's LocalFrame from core/ The new inheritance is: core/workers/WorkerOrWorkletGlobalScope -> core/workers/WorkletGlobalScope -> core/workers/MainThreadWorkletGlobalScope This moves WorkletGlobalScope into core and a few other classes. ThreadedWorkletGlobalScope will exist in modules and inherit from WorkletGlobalScope. Implementation Doc: https://docs.google.com/document/d/14hEO_BqQRBne3tBD2xghEEo02nz2csLqY4SS6x6rmjA/edit BUG=567358 Review-Url: https://codereview.chromium.org/2029163002 Cr-Commit-Position: refs/heads/master@{#397722}
-
rouslan authored
Reland of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #1 id:1 of https://codereview.chromium.org/2033323003/ ) Reason for revert: Clankium failures should not revert Chromium. The correct course of action is to fix-up the Clankium code, into which Chromium developers have no visibility. Original issue's description: > Revert of [Autofill] Sort profiles and credit cards by frecency in PaymentRequest. (patchset #12 id:620001 of https://codereview.chromium.org/1982623002/ ) > > Reason for revert: > This broke the downstream clang-clankium-tot-builder, since PersonalDataManager at least is used by downstream autofill code to get profiles and credit cards: https://goto.google.com/kneae > > Original issue's description: > > Sorted the profiles and credit cards to be used in PaymentRequest. > > > > Also added test methods to set the use count and use date of profiles and cards. > > > > BUG=609864 > > TEST=PersonalDataManagerTestJava > > > > Committed: https://crrev.com/1df662834b5dec9a400f4cde1e6acdafd39fa1e2 > > Cr-Commit-Position: refs/heads/master@{#397562} > > TBR=mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=609864 > > Committed: https://crrev.com/d846c8087715c5c03c98cacdcf59575a81e9f52e > Cr-Commit-Position: refs/heads/master@{#397679} TBR=mathp@chromium.org,dfalcantara@chromium.org,sebsg@chromium.org,johnme@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609864 Review-Url: https://codereview.chromium.org/2039493002 Cr-Commit-Position: refs/heads/master@{#397721}
-
jkarlin authored
It would be good to know the correlation between an entry's age and its likelihood to be validated vs updated. This CL adds two new metrics which record the stale entry's age (as a percentage of freshness) when it's validated and when it's updated. BUG=614355 Review-Url: https://codereview.chromium.org/2036123003 Cr-Commit-Position: refs/heads/master@{#397720}
-
rockot authored
Two small fixes: - ProcessTasks was unintentionally scoping the interface id for a sync message task, so an unprocessed task would then get pushed back onto the queue for kInvalidInterfaceId - Unprocessed task pointer was being pushed back onto the sync message queue after moving the task ptr back into the task queue, so the sync message queue entry would always be null. Also minor cleanup to ProcessFirstSyncMessageForEndpoint to wipe out empty entries in sync_message_tasks_ when possible. R=yzshen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2035893003 Cr-Commit-Position: refs/heads/master@{#397719}
-
bungeman authored
This file was added when Skia was first converted to DEPS from being checked-in. It is no longer built and contains nothing of interest to modern Skia. Review-Url: https://codereview.chromium.org/2034783003 Cr-Commit-Position: refs/heads/master@{#397718}
-
yzshen authored
With this change, the Clone() and Equals() methods of structs/unions/maps/arrays call Clone() and Equals() of elements if available, otherwise fall back on copy and == operator of elements. BUG=616527 Review-Url: https://codereview.chromium.org/2031823002 Cr-Commit-Position: refs/heads/master@{#397717}
-
jbroman authored
The current expectation is for flaky failure, but a leak was observed. BUG=617137 TBR=vabr@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2032423002 Cr-Commit-Position: refs/heads/master@{#397716}
-
mahmadi authored
1) Call setTimeout after each test. user_manager.js includes a bunch of other js files that do operations asynchronously. This is to make sure those operations are done after each test. 2) Do not clear <body> before the tests execute. js files included in the user_manager.js expect some elements to exist on the page. Therefore we can't test MD User Manager Polymer elements in isolation. BUG=563722 Review-Url: https://codereview.chromium.org/2036763003 Cr-Commit-Position: refs/heads/master@{#397715}
-