GitLab

In HWNDMessageHandler::OnMouseRange() function, mouse events synthesized
in response to touch should be ignored if they are in the client area of
the window. The hit testing to decide if a point is in the client area
needs the point in screen coordinates, but, for most of the mouse events
the point is in window coordinates. So, the point should be converted to
screen coordinates if it is not.

BUG=312708

Review URL: https://codereview.chromium.org/83973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236921 0039d316-1c4b-4281-b951-d872f2087c98

This cl contains the parsing of the RTCP packets containing the log
messages. The callbacks sending the parsed data into our log system is
not wired up; that will be done in a seperate cl.
Additionally the sender does not generate these type of messages yet.

Review URL: https://codereview.chromium.org/83903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236920 0039d316-1c4b-4281-b951-d872f2087c98

While introducing the new AudioLog class, I encountered some WebRTC
and AudioRendererHost unittests abusing MediaInternals for internal
state observation.  https://codereview.chromium.org/68173025/

In the AudioRendererHost case, everything tested is already enforced
by various DCHECKs and the AudioManager (all streams closed, etc).

Similarly, in the WebRTC case, most checks are enforced implicitly or
tested via other means.

To remove the usage in AudioRendererHost I needed to switch over to
a TestBrowserThreadBundle which should have been done anyways.

BUG=260005
TEST=unittests still pass.

Review URL: https://codereview.chromium.org/81953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236919 0039d316-1c4b-4281-b951-d872f2087c98

When they are removed on unloading, they are in particular removed on disabling an extension. Re-enabling the extension then does not restore these rules.

BUG=313241

Review URL: https://codereview.chromium.org/52743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236918 0039d316-1c4b-4281-b951-d872f2087c98

Support URL fragment resolution against non-hierarchical schemes
As a result, data: about: etc now have 'query' and 'ref' components
parsed; as a result a new GURL::GetContent() convenience is added to
retrieve the spec with the scheme stripped off.

A complication in supporting this is that we now need to allow whitespace
to trailing whitespace to be preserved when transferring url_parse::Parsed
structs between KURL and GURL. Without this, the URL prior to the
#fragment can change (i.e. whitespace stripped) when following an anchor
link which breaks the page (causes reload from source). See
http://crbug.com/291747 for more details on this.

R=brettw@chromium.org
TBR=cbentzel@chromium.org
BUG=291747

Review URL: https://codereview.chromium.org/23835019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236917 0039d316-1c4b-4281-b951-d872f2087c98

* Remove code handling the case where the overlay doesn't include any text.
* Remove remnants of code handling opacity transitions.

BUG=none
TEST=none
R=groby@chromium.org

Review URL: https://codereview.chromium.org/82933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236916 0039d316-1c4b-4281-b951-d872f2087c98

* Add padding around the text.
* Use the same font as what's used in the notifications.
* Set the font color.

BUG=315975
TEST=Legal documents display to match notifications and mocks.
R=groby@chromium.org

Review URL: https://codereview.chromium.org/82913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318439

Review URL: https://codereview.chromium.org/82303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236914 0039d316-1c4b-4281-b951-d872f2087c98

default is off.

BUG=315317

Review URL: https://codereview.chromium.org/77083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236913 0039d316-1c4b-4281-b951-d872f2087c98

large as its border requires.

BUG=311269
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/82483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236912 0039d316-1c4b-4281-b951-d872f2087c98

Skip conformance/ogles/GL/control_flow/control_flow_001_to_008.html instead of marking it as fail.

BUG=322795
TEST=
TBR=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/82763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236910 0039d316-1c4b-4281-b951-d872f2087c98

This modifies install-build-deps.sh to require language packs needed for
running browser_tests. This also corrects a typo in
locale_tests_browsertest.cc where we wanted a '_' instead of a '-'.

BUG=316716

Review URL: https://codereview.chromium.org/84013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236908 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces telemetry.value, which factors out the different kinds of
data collected by telemetry benchmarks, currently scalar values, lists of
scalar values, and histograms. This factoring provides mechanisms for combining
together values --- value summarization, which was previously the job of the
results objects, is now part of the value system.

The actual interface between the page_measurement_results object and the
rest of telemetry is unchanged. A values_backcompat module exists to convert
the old interface to the new interface. A followup patch can remove this
backcompat path.

Most discussion of this is on https://codereview.chromium.org/27486002/

BUG=306944

Review URL: https://codereview.chromium.org/83813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236907 0039d316-1c4b-4281-b951-d872f2087c98

which should've been removed in https://codereview.chromium.org/23536051

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/83423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236906 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236905 0039d316-1c4b-4281-b951-d872f2087c98

This brings in recent changes that allow Syzygy to process VS2013 binaries.

BUG=318016

Review URL: https://codereview.chromium.org/83383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: https://codereview.chromium.org/83203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236902 0039d316-1c4b-4281-b951-d872f2087c98

We don't need them anymore after the video decode acceleration warmup cleanup.

BUG=321209
TEST=compiles.

Review URL: https://codereview.chromium.org/82993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236901 0039d316-1c4b-4281-b951-d872f2087c98

This brings the message into line with the new LOG policy, and
more closely reflects the reality of the warning.

Review URL: https://codereview.chromium.org/82973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236900 0039d316-1c4b-4281-b951-d872f2087c98

With the last input event, gestures often overshoot the specified distance,
e.g. scrolling distance. This patch makes sure that the final move event is
adjusted so that we cover exactly the specified distance.

BUG=322084

Review URL: https://codereview.chromium.org/81153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236899 0039d316-1c4b-4281-b951-d872f2087c98

Windows failures
  conformance_ogles_GL_atan_atan_001_to_008
  conformance_ogles_GL_atan_atan_009_to_012
  conformance_ogles_GL_control_flow_control_flow_001_to_008

BUG=322794,322795
TEST=
TBR=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/83953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236897 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162560:162565&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/82963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=peria@chromium.org

Review URL: https://codereview.chromium.org/82703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236895 0039d316-1c4b-4281-b951-d872f2087c98

Text fields in the requestAutocomplete dialog need to intercept several
key messages to allow controlling the autocomplete popup field. Most
notably, cursor up/down, page up/down, tab, and escape.

BUG=321319, 321330
R=rsesek@chromium.org
TEST=Bring up rAC dialog, click in textfield to show autocomplete popup. Verify keyboard shortcuts work

Review URL: https://codereview.chromium.org/82193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236894 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary since we don't have a native Ash replacement for the ssl
certificate dialog, and we need to be able to ship Ash with M-32.  We plan to
integrate support with the Win8 system charm at some point in the future, but
it's a significant chunk of work and we need to do something so that Chrome
doesn't become unusable if the user clicks this button.

BUG=255329

Review URL: https://codereview.chromium.org/79223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236893 0039d316-1c4b-4281-b951-d872f2087c98

Part of the on-demand feature see
https://codereview.chromium.org/25713007/ for more context.

BUG=none
TEST=none
R=sorin@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/55303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236892 0039d316-1c4b-4281-b951-d872f2087c98

Skip conformance/textures/texture-size-limit.html.

BUG=322789
TEST=
TBR=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/83073011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236891 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug in PrefMetricsService resulting from this issue occuring when RLZ is disabled on Windows.

BUG=322173

Review URL: https://codereview.chromium.org/81683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236889 0039d316-1c4b-4281-b951-d872f2087c98

This is because I need to create a new subclass of MessageView - a synthetic placeholder for multiple notifications from the same source. Hence the new enum, MesageViewTypes, which is not used in this patch but will in second... the derived classes override abstract methods of the MesageView to provide functionality.

NotificationView currently knows about MessageCenter but in the future refactorings it can yield this to MessageCenterView.

BUG=320827

Review URL: https://codereview.chromium.org/75133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236888 0039d316-1c4b-4281-b951-d872f2087c98

AudioDecoder and VideoEncoder objects inherited RefCountedThreadSafe
for no valid reason. AudioDecoder need no Refcounter or Weak ptr.
The VideoEncoder can accomplish the same using a weak ptr.

Review URL: https://codereview.chromium.org/74133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284934
NOTRY=true
TEST=tools/perf/run_benchmark -v --show-stdout --browser=debug mse_cases

Review URL: https://codereview.chromium.org/71303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236886 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236885 0039d316-1c4b-4281-b951-d872f2087c98

> Roll swarming_client @ 4727bd5a1a67726d5c64d292f970590ddb1b6a98.
> 
> $ git log e98b112..4727bd5a1a --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
> 2013-11-22 maruel Stop making the tree read-only when 'read_only': True is not set.
> 2013-11-20 maruel Simplify imports, simplifying pylint checks.
> 2013-11-20 vadimsh@google.com Make stack traces produced by exceptions from TaskChannel.pull() more useful.
> 2013-11-19 maruel Create .isolated files via isolateserver.py archive <directory>.
> 2013-11-19 maruel Move more path handling code from isolate.py into utils/file_path.py.
> 2013-11-18 maruel Add ThreadProolWithProgress.iter_results() support.
> 2013-11-18 maruel Move code around in preparation to move code from isolate.py to isolateserver.py
> 2013-11-12 maruel In r192392, I +x'ed WATCHLISTS by accident. Fix that.
> 2013-11-12 maruel Partially revert 8732761d59. This broke executable bit.
> 2013-11-12 maruel Move read_json and write_json from trace_inputs to utils.tools.
> 2013-11-12 maruel Remove x bit on subprocess32.py, move auto_stub.py into third_party.
> 2013-11-11 maruel Rework swarming.py option grouping to be more sensible.
> 2013-11-11 maruel Enable setting the cache files as read-only.
> 2013-11-11 maruel Make file deletion more coherent with the behavior of each OSes.
> 2013-11-10 maruel Extract subprocess code into subprocess42.
> 2013-11-10 maruel Add test to confirm assumptions about file deletability across different OSes.
> 2013-11-08 maruel Exit the test sooner when it will fail anyway.
> 2013-11-08 maruel Preleminary work to make the file in the run_isolated.py cache read-only.
> 2013-11-08 maruel Fix run_test_case's Popen on Windows once and for all.
> 2013-11-06 maruel Remove support for file mode for symlink.
> 2013-11-06 maruel Fix trace_test_cases_smoke_test.py to stop leaking temp files.
> 2013-11-06 maruel Surface flags more so more settings can be configured at request time.
> 2013-11-06 maruel Remove slave_os as an hardcoded Manifest() dimension.
> 2013-11-06 maruel Make the environment completely configurable in the Manifest.
> 
> R=vadimsh@chromium.org
> 
> Review URL: https://codereview.chromium.org/63523008

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/82623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236884 0039d316-1c4b-4281-b951-d872f2087c98

A few style guide cleanups and more usage of scopers.

BUG=316486
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/84183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236883 0039d316-1c4b-4281-b951-d872f2087c98

Mark conformance/context/context-attribute-preserve-drawing-buffer.html as fail on mac and win/intel

BUG=322770
TEST=
TBR=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/83693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236882 0039d316-1c4b-4281-b951-d872f2087c98

> Disable partial swap on Windows.
> 
> Partial swap may be causing some performance problems, so disable it.
> 
> BUG=313104
> 
> Review URL: https://codereview.chromium.org/79643002

TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/82523008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236881 0039d316-1c4b-4281-b951-d872f2087c98

This seems to be causing issues with some windows not being updated.

> Disable Vsync when Aero Glass is enabled.
> 
> The vsync is unnecessary for ratelimiting or tear prevention, and can cause issues when multiple windows are displayed.
> 
> BUG=313104
> 
> Review URL: https://codereview.chromium.org/75723004

BUG=313104,321979,322203
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/83173010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236880 0039d316-1c4b-4281-b951-d872f2087c98

> Makes FocusdController honor focus change if no previously active window
> 
> With desktop aura when a Window is made active the focus restore code
> kicks in and attempts to restore focus to the Window that had focus
> prior to losing activation. FocusController ignores requests to change
> focus if during the activation phase focus changed. Together this
> means the window that initiated the focus and activation change does
> not get focus.
> 
> Fix is to allow the focus change through if there was previously no
> active window.
> 
> BUG=321042
> TEST=covered by test now
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/75933005

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/82913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236879 0039d316-1c4b-4281-b951-d872f2087c98

Skip conformance/glsl/misc/large-loop-compile.htm as it's crashing

BUG=322764
TEST=
TBR=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/83973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236878 0039d316-1c4b-4281-b951-d872f2087c98