GitLab

BUG=388506

Review URL: https://codereview.chromium.org/386093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282768 0039d316-1c4b-4281-b951-d872f2087c98

This is so that callers can code against a TaskRunner interface
directly, rather than converting message_loop_proxy() into a TaskRunner.

BUG=391045

Review URL: https://codereview.chromium.org/389653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282767 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141

Review URL: https://codereview.chromium.org/378873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282766 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282765 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282764 0039d316-1c4b-4281-b951-d872f2087c98

1950: Edited wiki page GypHacking through web user interface.
1949: Fixes two bugs in analyzer

BUG=383609
TEST=none

Review URL: https://codereview.chromium.org/385283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282763 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346958

Review URL: https://codereview.chromium.org/385983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282762 0039d316-1c4b-4281-b951-d872f2087c98

See discussion on https://codereview.chromium.org/347183005/

BUG=none

Review URL: https://codereview.chromium.org/374053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282761 0039d316-1c4b-4281-b951-d872f2087c98

I started with CreateNode so that you can get a feel for how this
would look. I may need a couple of other error codes, but not many
more.

BUG=384437
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/383293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282760 0039d316-1c4b-4281-b951-d872f2087c98

The crash occurs because a scoped_ptr instance which holds the TestLegacyRenderWidgetHostHWND class
is left with a dangling pointer to the LegacyRenderWidgetHostHWND instance which is destroyed via
DestroyWindow.

Fix is to first reset the scoped_ptr which in turn destroys the legacy window and the instance.
The DestroyWindow call is removed as it is not needed anymore.

I also added a call to the CreateATLModuleIfNeeded helper function in BrowserAccessibility::Create as I was
hitting a crash due to a NULL AtlModule. We do this already in the ctor of the BrowserAccessibilityManagerWin
class. However that is too late as we have base classes which create COM objects.

This crash only happens in the component builds.

BUG=393228

Review URL: https://codereview.chromium.org/383263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282759 0039d316-1c4b-4281-b951-d872f2087c98

This is to facilitate overriding UI strings from the variations service.

BUG=370033

Review URL: https://codereview.chromium.org/322523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282758 0039d316-1c4b-4281-b951-d872f2087c98

1. Moved creation of ConnectionToHost to ChromotingClient. Previously
   ConnectionToHost had to be passed in the constructor.
2. Authentication now is created outside of ChromotingClient. This
   allowed to remove ClientConfig struct (it was used mostly to
   pass authentication parameters). This will also allow passing
   a fake authenticator for tests.
3. Removed ClientConfig.

Review URL: https://codereview.chromium.org/384523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282757 0039d316-1c4b-4281-b951-d872f2087c98

SocketLibevent release ref-count of read/write buffer before calling callback.
Need to hold ref-count of buffer in TCPSocketLibevent to make sure the buffer
alive in callback.

BUG=393221

Review URL: https://codereview.chromium.org/382143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282756 0039d316-1c4b-4281-b951-d872f2087c98

This deletes some assets that are now unused:
 - infobar_button_*
 - infobar_shadow
 - infobar_update_uma (not used in Chromium)

Updates some infobar icons with pretty new blue versions:
 - infobar_microphone
 - infobar_protected_media_identifier

And deletes icons for infobars that never appear on Android:
 - infobar_theme
 - infobar_cookie
 - infobar_desktop_notifications
 - infobar_didyoumean
 - infobar_plugin
 - infobar_plugin_crashed
 - infobar_restore

This also renames infobar_autofill.png to infobar_autofill_cc.png since
it always refers to credit card-related autofill.

R=dfalcantara@chromium.org, dtrainor@chromium.org, estade@chromium.org, oshima@chromium.org
TBR=oshima@chromium.org
BUG=375379
BUG=386359

Review URL: https://codereview.chromium.org/383123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369552

TBR=xiyuan

Review URL: https://codereview.chromium.org/387143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/386893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386403

Review URL: https://codereview.chromium.org/383283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282749 0039d316-1c4b-4281-b951-d872f2087c98

Currently PictureLayerTiling drops tiles when bounds change under the
assumption that these recordings have been dropped by the main thread,
however it misses some cases. For instance if the layer grows, and the
main thread has to drop recording tiles along the growing edge, but it
is outside the interest rect, then the PictureLayerTiling has no idea
that these recordings are gone, which leads to us having Tiles on the
compositor thread which can not be rastered.

Instead of having the impl side try to guess at these things, we now
have the PicturePile explicitly expand invalidation to cover every
recoding tile that has its picture dropped or that is removed from the
recording. Then the impl-side PictureLayerTiling only drops what the
main thread tells it to, and does not make any guesses of its own.

Perf sheriffs: This is expected to change results for "invalidation"
tests as it changes what code paths those tests execute.

R=enne
BUG=386998

Review URL: https://codereview.chromium.org/375923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282744 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Possibly-uninitialized local variable

This also contains a very small number of other cleanups to nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/388893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282743 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282742 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177974:177980&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391005

Review URL: https://codereview.chromium.org/372243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/367523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282739 0039d316-1c4b-4281-b951-d872f2087c98

This pathway is obsolete, and is removed in this CL.

BUG=392851

Review URL: https://codereview.chromium.org/388583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282738 0039d316-1c4b-4281-b951-d872f2087c98

ASSERT_TRUE only prints the first call frame in the error message. In our case, this is the _ASSERT_TRUE wrapper function, which is not useful.

To help with debugging, this CL dumps the full stack.

Review URL: https://codereview.chromium.org/382193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282737 0039d316-1c4b-4281-b951-d872f2087c98

Reformat the bisect results output to give detailed information regarding the bisect job.
Includes clear instructions to repro steps.

BUG=383669,383935
NOTRY=true

Review URL: https://codereview.chromium.org/388623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282735 0039d316-1c4b-4281-b951-d872f2087c98

The PutBytes() method in PnaclTranslateThread is used for two purposes: giving
data to the translator processes and signaling the end of the stream.  The way
it's currently done is a bit confusing; this breaks the method into two
for clarity. This is to make code review easier to read for an upcoming change
which removes FileDownloader from the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/383213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282734 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282733 0039d316-1c4b-4281-b951-d872f2087c98

Reverted for merge conflict

> Reland "Use upstream libaddressinput in Chrome."
> 
> Remove static initializer and reland https://crrev.com/282408 which was
> reverted in https://crrev.com/282426.
> 
> TBR=estade@chromium.org,thestig@chromium.org
> BUG=389918
> 
> Review URL: https://codereview.chromium.org/386873002

TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/387123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282732 0039d316-1c4b-4281-b951-d872f2087c98

On parse failure, FFmpeg does not always error out, so ensure the OPUS
initializer we construct is completely initialized.

BUG=389280
TEST=none

Review URL: https://codereview.chromium.org/382123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367595
NOTRY=true

Review URL: https://codereview.chromium.org/371643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282730 0039d316-1c4b-4281-b951-d872f2087c98

Callbacks can cause the ChildSharedBitmapManager to be used after the compositor is gone, so pass the ThreadSafeSender (which is refcounted) to the callbacks instead.

BUG=390563

Review URL: https://codereview.chromium.org/382133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392938
R=navabi@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/383933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282728 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282727 0039d316-1c4b-4281-b951-d872f2087c98

Remove static initializer and reland https://crrev.com/282408 which was
reverted in https://crrev.com/282426.

TBR=estade@chromium.org,thestig@chromium.org
BUG=389918

Review URL: https://codereview.chromium.org/386873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282726 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org
BUG=346958

Review URL: https://codereview.chromium.org/385253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282725 0039d316-1c4b-4281-b951-d872f2087c98

leak was fixed in r213560

BUG=175815
NOTRY=true

Review URL: https://codereview.chromium.org/383333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282724 0039d316-1c4b-4281-b951-d872f2087c98

DeviceMonitorMac: move CrAVFoundationDeviceObserver and most of SuspendObserverDelegate to UI Thread

(tl; dr : Move all operations to UI thread except device enumerations.)

CrAVFoundationObserver was located in Device Thread based 
on the assumption that OS KVO callbacks would come on that 
thread too, but instead they come from UI thread.
-observeValueForKeyPath:... is then called in UI thread, and since
the rest of the actions of the class are small, this CL moves the
whole class to UI thread. 

Its overlord SuspendObserverDelegate (best not use acronyms 
for its name :) ), however, lives a mixed life in UI and Device
 threads. The model is simplified by making it work always in
UI thread _except_ for device enumerations (done via
[AVCaptureDeviceglue devices]).

AVFoundationMonitorImpl will destroy SuspendObserverDelegate
in UI thread and that in turn destroys CrAVFoundationObserver
in that very thread, thus cleaning up the multi threading and
hopefully addressing the bug reports of a small but consistent
crash rate (~2 crashes every four canaries or so). 

UI Thread checks are added everywhere.

The code around CrAVFoundationDeviceObserver::dealloc and 
-stopObserving is refactored in order to avoid a redundant 
search-for-device in |monitoredDevices_|.

BUG=366087

Review URL: https://codereview.chromium.org/368613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282723 0039d316-1c4b-4281-b951-d872f2087c98

IDs can't begin with a digit. However, this syntax allows it.

BUG=361809
TBR=dtu@chromium.org,chrishenry@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/383263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282721 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/388723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282720 0039d316-1c4b-4281-b951-d872f2087c98