- 26 Aug, 2020 40 commits
-
-
Yuly Novikov authored
To prevent CQ flakiness like in crbug.com/1122044. Expecting 1 more build a day on average. Bug: 1122044 Change-Id: I03e97d18db63e75e966994234fbeceabc674cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378614Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#801954}
-
Kenneth Russell authored
Renderer process is intermittently hanging; minidumps do not show why. Bug: 1121476 Change-Id: If24d8618d7053061a51dc6acadec0c943b846a9f Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377653Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1111477 Change-Id: I4604ea00cd12cead7dcff72e2c4f615355320d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375599 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801952}
-
Kalvin Lee authored
This change implements ParseUsbVendorIdMap(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: I9606deaba47bac0e9359cbbe5bb2813e6febe6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340925 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#801951}
-
David Black authored
This is a reland of 57e175db Original change's description: > Remove HoldingSpacePresenter. > > No longer needed given evolution of feature requirements. > > Bug: 1112469 > Change-Id: Ic31d2a02fcc624ddc101447f68089cfff9bd2660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377535 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#801857} Bug: 1112469 Change-Id: Ic42f50fa1a8738020813d246ea7789ebfbdc78db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378451Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801950}
-
Elaine Chien authored
Bug: 938501 Change-Id: If9ff42d2d74d62bb031dc8a878212d853deaac7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378390 Commit-Queue: Elaine Chien <elainec@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Elaine Chien <elainec@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#801949}
-
adamta authored
Removes border with animation for Discover feed header, as per new UX suggestions. Adds new animation to ease in the "- Off" part of the title label. Video of the animation: http://shortn/_F1ALPqpuET. Bug: 1085419, 1122094 Change-Id: I65ee3894e1f1105c096115e48f41d30568b8ff94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377990Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#801948}
-
Anastasia Helfinstein authored
AX-Relnotes: Launch Switch Access on Chrome OS. Bug: 1016200,1121357 Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801947}
-
Ian Kilpatrick authored
Per: https://www.chromestatus.com/feature/5680142707851264 In M85 we switched -webkit-line-clamp over to LayoutNG which had the (indended) side-effect of removing support for: -webkit-box-flex -webkit-box-ordinal-group -webkit-box-align -webkit-box-pack -webkit-box-direction When used with -webkit-line-clamp. This patch removes the -webkit-box-align, and -webkit-box-pack from LayoutDeprecatedFlexibleBox Bug: 305376 Change-Id: I24a86ae3db854c80e6fa9a5a768bb6594ad253d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375732 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801946}
-
Collin Baker authored
After refactors and the introduction of FeaturePromoController, tab groups IPH logic no longer needs a dedicated class. This moves the remaining logic to BrowserTabStripController. Bug: 1106523 Change-Id: I3528da8b4c0d4d60ca033dfebb10c5a61564f036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369620 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#801945}
-
Jeroen Dhollander authored
This makes it easier to use these constants in the public code. Bug: b/165356952 Change-Id: I3eda2f175e99536de3958451c88a6d78bc84fedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378613 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#801944}
-
edchin authored
Updates the expiry of these histograms, which are still useful to keep around. IOS.EnterTabSwitcherSnapshotResult IOS.PageLoadedSnapshotResult Bug: 1097826 Change-Id: I13380744d114f17e3cabf947b166ca049a84800d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376416 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#801943}
-
danakj authored
Once they are swapped in, we can track and use them as the main frame. R=avi@chromium.org Bug: 1114382 Change-Id: I8f0b8c906a9dd5dd106dc1dc444aa24af4721347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378447 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801942}
-
Etienne Bergeron authored
see: https://bugs.chromium.org/p/chromium/issues/detail?id=973868#c41 Noticed in crash: 86abdd946339513d R=joenotcharles@google.com, martinkr@google.com Bug: 973868 Change-Id: Ifc4cae4458c5cbdb2aebaf852ffbaf280b2751fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376878Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#801941}
-
Ryan Hansberry authored
Keep BluetoothDevices discovered by BluetoothClassicMedium distinct from BlePeripherals discovered by BleMedium. Bug: b:154849033 Change-Id: I4f77a21b6a0f5fec29131cbc2c2d4e39d247baed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370093 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#801940}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic8ab815342749d2bddc4479c4d57e2d494abf746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377315Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#801939}
-
Marc Treib authored
Bug: 1109939 Change-Id: I3df1be760041a456214e8a8b4289db759d3f6b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376846 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 68d3758b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 801909 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY4ZDM3NThiMDEwZGMzZGIxN2NkNWU1MzdmMDAxNGE0N2Y0MDI5MDYM Sample Failed Build: https://ci.chromium.org/b/8870873385800887712 Sample Failed Step: compile Original change's description: > [base] Use getrandom on Linux. > > Fall back to reading from urandom only when that fails. > > Bug: 995996 > Change-Id: Id503ca2dc412a392d5a7e252fcfff65b61d0c20e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762604 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Julien Tinnes <jln@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801909} Change-Id: If682cc741bd401fc6ab2a3e9e8173ac8e20d6e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377418 Cr-Commit-Position: refs/heads/master@{#801937}
-
Ben Mason authored
This reverts commit 16e049fa. Reason for revert: No longer need this configuration. Original change's description: > Return WebView to 32-bit by default. > > Bug: 1119325 > Change-Id: I04727f349d0012a4a89ab93032530ccecf53e767 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364210 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799739} TBR=torne@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119325 Change-Id: Ib9b6182502b549a5b4e81aceb8b1370080419fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375647Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
danakj authored
Instead of crashing, which upsets clusterfuzz, deal with it more gracefully and just don't bind the gamepadController into the javascript window object. If this happens in the wild, we would have the test fail and retry, but it is probably an artifact of running clusterfuzz MSAN builds. R=avi@chromium.org Bug: 1108899 Change-Id: I2f14f6e75dcd182dbdc9a46d26892f548121054f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377655 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Gavin Williams authored
Using getPrinterTypeForDestination to always get the correct printer type allows us to remove the standalone PDF check in NativeLayer.getPrinterCapabilities. It is safe to use Destination and RecentDestination as arguments to getPrinterTypeForDestination because objects have |id| and |origin|. Bug: 1112416 Change-Id: Ic94d1834485fab72c941cfc914701c26b58752c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376383Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#801934}
-
Justin Cohen authored
This reverts commit c88fabeb. Reason for revert: Still failing in beta 6 on the bots: https://chromium-swarm.appspot.com/task?id=4e4543820c675010 Original change's description: > Revert "ios: Disable RemoveCookie test on iOS14." > > This reverts commit 163b6034. > > Reason for revert: Speculative revert for beta 6 > > Original change's description: > > ios: Disable RemoveCookie test on iOS14. > > > > TBR=mrefaat > > > > Bug: 1121425 > > Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705 > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801345} > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > Change-Id: Ideb21ea26cee61249444139f7a0c59735f1e5754 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1121425 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376314 > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801908} TBR=justincohen@chromium.org,mrefaat@chromium.org No-Try: true Bug: 1121425 Change-Id: I07719c7d73c83b5d288136ae4df9d57845b162d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378534 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801933}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46f5bd5e..54d60a59 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If51bb573b0f1ee71c01f33f806670d1141ba443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377430Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801932}
-
Xianzhu Wang authored
This simplies code, and allows us to control order of blink and chromium feature application at one place (runtime_features.cc). Bug: 1048656 Change-Id: Ib263bcc54488ff9caeae5001fd56783bb79cd959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376874Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801931}
-
Avi Drissman authored
Allow the major version to go above 10. Bug: 1121703 Change-Id: I01a6c804d626558ed5e6fcce3a00dc11c78a349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377559 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#801930}
-
Richard Knoll authored
Mojo pipes have a limit of how much data can be read or written to at once. Specifying *_FLAG_ALL_OR_NONE and requesting more than that limit results in blocking forever as we can't satisfy that requirement. Instead, write and read without that flag and keep track of how much data is left to read / write. Bug: None Change-Id: I381c78a4570dccb39078ef20b785815a75c65cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370628Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801929}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/media/webrtc/webrtc_event_log_uploader.cc This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 1110266 Change-Id: Ia97f38c0618c485c91dcd8dc60368eaa130cf699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371249Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801928}
-
Kalvin Lee authored
This change implements PpdMetadataManager::FindDeviceInUsbIndex(), which allows the caller to search USB index metadata for a printer of a given vendor ID and product ID. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: I1081d94065c07d63253fbb7ba0b71f2079859ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340571Reviewed-by:
-
Dominic Mazzoni authored
This change permanently disables AXMenuList on Chrome OS and adds a minimal fix to enable Switch Access to work with HTML select elements. Previously select elements were made accessible using the AXMenuList class and fake child nodes. With this patch, the actual accessibility tree for the pop-up menu is exposed instead. It already works with ChromeVox. To make it work with Switch Access, I removed the isGroup override for a combo box node, because the default heuristic now works correctly - when the menu is visible, the combo box will have interesting children, and when it's collapsed it won't. Then I added an event handler that automatically enters the group when it's expanded. Bug: 1110367 AX-Relnotes: Exposes bounding boxes of HTML select popup menus to accessibility on Chrome OS Change-Id: Ic4a37a173d27dab90473dab9c154812ee4b05271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376472 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#801926}
-
Xianzhu Wang authored
Bug: 1121955 Change-Id: I86c9a5a0251a71743d07206e396320403bdcf819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377234Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801925}
-
chrome://flagsDale Curtis authored
This will make it easier for users and early testers to check out the feature and verify it's working properly. chrome://flags/#videotoolbox-vp9-decoding Bug: 1103432, 1122109 Test: chrome://flags Change-Id: Id2e7d176e894c6b9866d8e112b83d362c2efd25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376378 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#801924}
-
David Roger authored
If the last active profile was deleted, a new browser was always opened. After this CL, no browser is automatically opened if there is a profile picker. Note: if the last profile was deleted, a new profile is still created and loaded in memory. This CL also fixes a few instances where the wrong user manager was opened (ProfilePicker opened instead of UserManager or vice-versa). Fixed: 1121545 Change-Id: Ifbcd02ec1b1015a5736dd1714e36d5cf61d043da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375211 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801923}
-
Xianzhu Wang authored
Bug: 1011914 Change-Id: I2978b8bd6c7ee94c133b4a133c9df311382fc963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377610Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801922}
-
Xianzhu Wang authored
This is based on the answer in https://docs.google.com/spreadsheets/d/1FeigUaKrTBKPx36U4v0hJMlQZ_DAq-tYlSiG-LvhWLg/edit. This prepares for letting blink feature status override chromium feature status. Bug: 1121839 Change-Id: Ia44d4cc167319cac267820e30bd5388836327e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377996Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801921}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa7dd9bb. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" 3dbd8ec2 "[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia4117d96a1231ba106785b58c8935c41521624ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377431Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801920}
-
Keishi Hattori authored
Moves frame tree from WebFrame to Frame. The parent frame is required in the Frame constructors (e.g. by AdTracker) so we set it there. After the constructor, the frame will be in a provisional state where the parent frame is set, but not attached to the frame tree. By calling InsertAfter, the Frame can be inserted into the frame tree. Bug: 1100056 Change-Id: I9a8226ef9611a7c0e453af3353781a9576ccdc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350208 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801919}
-
Evan Stade authored
This relands commit c4aceb16. Difference: updates to ContactsPickerDialogTest to fix L tester Original change's description: > Move Contacts Picker to //components/browser_ui/contacts_picker > > Bug: 1016938 > Change-Id: Ib3a86b4a3e3c0356c292ce55291ef0487e94c5ae > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325272 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801610} TBR=dcheng@chromium.org,finnur@chromium.org,tedchoc@chromium.org,wfh@chromium.org,lazzzis@google.com Skip-Translation-Screenshots-Check: True Exempt-From-Owner-Approval: TBRing Bug: 1016938 Change-Id: Ifa455c12c37b98120ad0bac2a75796eaa6ff2190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378211 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#801918}
-
Stephanie Kim authored
Bug: 1114291, 1072012 Change-Id: I8f2684aefba663538f42402c0be133cabed32993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377652Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#801917}
-
minch authored
Switch kAshColorMode was added to show prototype to UX before. Remove it now since we are going to add a dark/light mode switching UI at the system tray. Bug: 1106012 Change-Id: Id5cb946217530f2a21fdc1c139d3943b24959b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373950 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#801916}
-
Chris Lu authored
This change shows the default browser fullscreen promo on resumeSessionWithTabOpener: if the user's past behavior fits the categorization of potentially interested users or if the user is signed in. Do not show if it is determined that Chrome is already the default browser or if the user has already seen the promo UI. Creates a WhatsNewCommands for AppState to send signals to BVC. Video: https://chromium-review.googlesource.com/c/chromium/src/+/2363660 Bug: 1107489 Change-Id: I63c30b4a705faf2b1e729b8be167f9ef38815e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368156 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801915}
-
