- 06 Feb, 2019 40 commits
-
-
Kenneth Russell authored
Test has been observed flaky on the commit queue. Bug: 870856 Change-Id: I3840495ea0350417b0aa445c4bb969e05f3edc53 Tbr: enne@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1455619 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629429}
-
Sergey Berezin authored
Bug: 917346 Change-Id: Ia942e7d4da31f8c620c0609a240a1d6534e99eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1455275 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#629428}
-
Caleb Rouleau authored
Bug: 928928 Change-Id: Ie5483356efd7c60925b797a464515103d1b3a101 Reviewed-on: https://chromium-review.googlesource.com/c/1455466 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629427}
-
Christopher Lam authored
AppShortcutLauncherItemController::GetRunningApplications doesn't use any members aside from app id and refocus_url. This CL makes it a static helper function which prevents a full construction of an AppShortcutLauncherItemController. Bug: 836128 Change-Id: I29e2027c1278303108f95b17445ba90ed8f375b1 Reviewed-on: https://chromium-review.googlesource.com/c/1453399 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629426}
-
Nikunj Bhagat authored
Bug: 907674 Change-Id: Ifb04c9dd26568b4245782e723221f3930e3f1237 Reviewed-on: https://chromium-review.googlesource.com/c/1446775 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#629425}
-
Jun Cai authored
This CL modifies the network service performance tests to generate histograms instead of chartjsons so that the Pinpoint can automatic bisect CLs. Bug: 927155 Change-Id: I3619704882c3636e76790d610e719a97c045e165 Reviewed-on: https://chromium-review.googlesource.com/c/1454633 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Cr-Commit-Position: refs/heads/master@{#629424}
-
Bill Orr authored
This change adds MixedRealityRenderLoop, which contains an IHolographicSpace. This change doesn't implement getting poses or submitting graphics. Bug: 923508 Change-Id: I7acd6aba40a967d6e87c61fb5315dad1716197ea Reviewed-on: https://chromium-review.googlesource.com/c/1444671 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#629423}
-
Xianzhu Wang authored
This ensures that the link highlight effect is always non-null. Also reduces memory usage by removing one pointer from all ObjectPaintProperties. In a page there is only one object having link highlight. Bug: 923729 Change-Id: I19da3aa9c04ca6937b59b420ebdb9c6ad7de0538 Reviewed-on: https://chromium-review.googlesource.com/c/1454307 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629422}
-
Dan Beam authored
Dark mode overrides of shared variables weren't working: :root {...} :host-context([dark]) {...} After much headbashing, I figured out Polymer was magically rewriting the first (:root) rule to: :host > * {...} inside custom elements only. https://github.com/Polymer/polymer/commit/fea64b9b6a75bb39b7644fdfdd56e1224f43bf3d So I changed :root to :host > *, which broke the copious amounts of styled light DOM the user manager uses (it's not in Shadow DOM so :host doesn't match). So instead, let's avoid :root and just use: html, :host {...} html[dark], :host-context([dark]) {...} R=hcarmona@chromium.org BUG=928674 Change-Id: I262572215e7f481b44d9a4af20645b06a2480041 Reviewed-on: https://chromium-review.googlesource.com/c/1455274 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#629421}
-
Yuichiro Hanada authored
--enable-virtual-keyboard flag is used to force-enable VK for testing. This CL makes exo::Keyboard send the flag information to a wayland client. Bug: 852351 Test: manual - enable the flag and check VK is enabled on ARC++ apps Change-Id: I0ca7c895aa960ddbfa2118bcf2c14d506a184f19 Reviewed-on: https://chromium-review.googlesource.com/c/1454168Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#629420}
-
Takumi Fujimoto authored
Disabling the test for flakiness. I've accidentally disabled a different test of the same name in [1]. Disabling the correct one. [1] https://chromium-review.googlesource.com/c/1455525 TBR=dpapad Bug: 928924 Change-Id: Idd87ea43a3bd81e079660ece9a5079ea1c27cadf Reviewed-on: https://chromium-review.googlesource.com/c/1455657Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#629419}
-
Maggie Cai authored
After adding list repopulation whenever the All Sites page is loaded (r1428622), the feature that focus on last selected item stopped working. This CL fixes this issue. This CL also changes the Site Entry usage info fetching code slightly. This is because the change of the focus changes the items in the list that is rendered in the DOM. If the later focused item have 0 data, it will generate the string without sending request to C++ code, and the feedback from C++ code from the original request will overwrite the 0B string because it takes longer. BUG=835712 Change-Id: I0af72a67cd621b7e94941aac4e687103191fcc39 Reviewed-on: https://chromium-review.googlesource.com/c/1451485Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629418}
-
Tao Bai authored
ContentCaptureTask will run in Idle task queue and has the fixed BestEffortPriority. - This patch added BestEffortTaskQueue which has fixed BestEffortPriority. - ContentCapture task run in BestEffortTaskQueue. Bug: 924681 Change-Id: Iac93a983b4b82495e1e8e8f59be3677eaf9458c4 Reviewed-on: https://chromium-review.googlesource.com/c/1435840Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629417}
-
Peter Collingbourne authored
With this the uncompressed size of resources.pak + locales/*.pak decreases from 27664141 bytes to 26027031 bytes (1.6MB decrease) and the size of mini_installer.exe decreases from 48125440 bytes to 47843328 bytes (280KB decrease). Build times for "touch ../../chrome/app/chrome_main.cc && ninja chrome" (median of 3 runs) go from 8.3s to 12.1s. This works by scanning the PDB for instantiations of ui::WhitelistedResource in the symbol table. Bug: 684788 Change-Id: I989b01b45b46a746c3f1707f112be89f2c4cc182 Reviewed-on: https://chromium-review.googlesource.com/c/1176979 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629416}
-
Marijn Kruisselbrink authored
This attempts to capture various cases where the renderer lies about cache_document_was_loaded_from so we kill the renderer rather than end up associating it with the wrong cache. Bug: 923468, 918233 Change-Id: I697e51c3f8b13584dfe7f10e5cdd7874d7e93ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1453103 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629415}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/93a1fb3a5b06..4fbc755cc6bf git log 93a1fb3a5b06..4fbc755cc6bf --date=short --no-merges --format='%ad %ae %s' 2019-02-06 crouleau@chromium.org Unittest for making sure browser argument takes the last one provided. Created with: gclient setdep -r src/third_party/catapult@4fbc755cc6bf The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928928 TBR=sullivan@chromium.org Change-Id: Iec3818df0d13583646aa940f18953b42334a293f Reviewed-on: https://chromium-review.googlesource.com/c/1455597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629414}
-
Noel Gordon authored
Promise.all can race in step-by-step mode. Await each part instead, so they are done one after the other (RemoteCall is serial code, and does not support being called in parallel). Bug: 909056 Change-Id: I06ded3da721a2fbff265781fed94071682abf540 Reviewed-on: https://chromium-review.googlesource.com/c/1454106Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629413}
-
Eugene But authored
Tests reading from and writing to SessionCertificatePolicyCache. Change-Id: I3ae1a99b574aeeca28887cd47bf9c98d4f95b8cf Reviewed-on: https://chromium-review.googlesource.com/c/1454080 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629412}
-
Joe DeBlasio authored
This CL adds a custom interstitial for URLs suspected of being fraudulent lookalike domains of legitimate sites. This CL only adds the interstitial. Replacing the pre-existing infobar and proper testing will come in a subsequent CL. Bug: 927924 Change-Id: Ifc323bb034fafe684e0f13c041eb9ab1cdf68c22 Reviewed-on: https://chromium-review.googlesource.com/c/1450263Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#629411}
-
Hirokazu Honda authored
This introduces TRACE_EVENT and TRACE_COUNTER for decoder thread in V4L2SVDA. I also added one TRACE_EVENT for device poll thread as one exception. TRACE_EVENT * InitializeTask create input buffers. * DestroyTask destroy input and output buffers, and stop device poll thread. * EnqueueOutputRecord: GLFenceEGL::ClientWaitWithTimeoutNanos wait until a fence for an output buffer is released. * DecodeBufferTask perform AcceleratedVideoDecoder::Decode for as many buffers as possible. * AssignPictureBuffersTask start device poll thread. * CreateGLImageFor create GLImageNativePixmap (= allocate NativePixmap and bind GL). TRACE_EVENT_BEGIN/END * DecodeBufferTask AVD::Decode time to execute one AcceleratedVideoDecoder::Decode(). * V4L2SVDA Resolution Change time to process a resolution change. * Flush time to process Flush. * Reset time to process Reset. TRACE_COUNTER * The number of input buffers that are not processed by DecodeBuffer(). * The number of available/in-use VIDIOC_OUTPUT buffers * The number of available/in-use VIDIOC_CAPTURE buffers * The number of VIDIOC_CAPTURE buffers at device/client Bug: 721674 Test: chrome://tracing on kevin Change-Id: I7a15bab96fa73911ecd2e880da5f8d5738ee5214 Reviewed-on: https://chromium-review.googlesource.com/c/1447995 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#629410}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/94c603f200fa..7192fd51f570 git log 94c603f200fa..7192fd51f570 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 dgarrett@google.com chromeos_config: Mark most CQ builders important. 2019-02-05 dgarrett@google.com chromeos_config: Test affinity build pool is large enough. Created with: gclient setdep -r src/third_party/chromite@7192fd51f570 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6dd30398b63fd21785b5b7832931e7100a8ad2b8 Reviewed-on: https://chromium-review.googlesource.com/c/1455365Reviewed-by:
-
zhuowang authored
Bug: b/123780021 Test: build Change-Id: Id249bb98aad5b27d944fae3db9311e7c28cc5853 Reviewed-on: https://chromium-review.googlesource.com/c/1454092 Commit-Queue: Zhuo Wang <zhuowang@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#629408}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/220ef3d432bf..b11ecd3564d6 git log 220ef3d432bf..b11ecd3564d6 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 tsepez@chromium.org Create CXFA_FFDoc via static function. 2019-02-05 thestig@chromium.org Move a bunch of code out of testing/test_support.h. 2019-02-05 thestig@chromium.org Use span in TestLoader. 2019-02-05 thestig@chromium.org Remove unneeded testing/test_support.h includes. Created with: gclient setdep -r src/third_party/pdfium@b11ecd3564d6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I986ad1c82f87332134face53934a56fc32e9faeb Reviewed-on: https://chromium-review.googlesource.com/c/1455363Reviewed-by:
-
Noel Gordon authored
Use base::ReadFileToString to read the input image file and add //base dependency to BUILD.gn. Minors: make the metadata *name const, all_data_received/data_complete mean the same thing so remove one of them. No change in behavior. Bug: 601198 Change-Id: Icbe7097be75631a1f55e43b8589027ffaced7ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1453216Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629406}
-
Joe DeBlasio authored
This CL moves lookalike URL warnings into their own directory in preparation for the additional files needed for a dedicated interstitial, as interstitials do not relate to omnibox (and are file-heavy). Bug: 927924 Change-Id: Ia046a47a0fefdc2c8d81fa968879c3d8b5a8a1b0 Reviewed-on: https://chromium-review.googlesource.com/c/1452494 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#629405}
-
Dale Curtis authored
Looks like dav1d has introduced the ability to tag input buffers with timestamps, so instead of maintaining our own queue, use that instead. This prevents us from having issues when multiple frames come out of one packet and we exhaust our buffer queue too fast. BUG=928640 TEST=fuzzer passes R=sandersd Change-Id: I9e9e98f835a6762443d5a1b20be07abfc608d11c Reviewed-on: https://chromium-review.googlesource.com/c/1455637 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#629404}
-
Tom Anderson authored
BUG=927867 R=dpranke,thakis Change-Id: Ic7094d9d80a9dc2d7a3ac2e715c8dddfa4a1e0c8 Reviewed-on: https://chromium-review.googlesource.com/c/1450459Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#629403}
-
Kent Tamura authored
It is stored in a Vector data member of MarkupAccumulator. This CL has no behavior changes. Bug: 927166 Change-Id: I9d0576176adfaad1be5bc8b56c12401b75abdb34 Reviewed-on: https://chromium-review.googlesource.com/c/1454159 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629402}
-
John Williams authored
Change-Id: I7a8efdb361d2b806c0f326cb68db1654d6ba1f65 Reviewed-on: https://chromium-review.googlesource.com/c/1398790 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629401}
-
Nick Harper authored
The entire domain (including subdomains) now meets the requirements for automated inclusion. This removes the old manual entries for just the root and specific subdomains and adds an entry to the bulk entries section. Change-Id: I96104847e0b3f7734b5da45a0797ec472d267d4b Reviewed-on: https://chromium-review.googlesource.com/c/1453536 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629400}
-
Raymond Toy authored
The spec clarified this in https://github.com/WebAudio/web-audio-api/issues/1580#issuecomment-406354307 So replace the code that threw errors with a console warning. Adjust tests accordingly. Also took this opportunity to fix AudioHandler::NodeTypeName which was missing strings for some of the newer nodes. Bug: 865554 Test: internals/audiocontext-close.html Change-Id: I521d6073c08160f3ccc7800882123192dad7bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/1145236 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#629399}
-
Takumi Fujimoto authored
TBR=ryankans Bug: 928941 Change-Id: I565a8601d16ffdfc0b1f6b7494ad9eedd57db2ec Reviewed-on: https://chromium-review.googlesource.com/c/1455471 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/698f27858111..759afdb33fc6 Created with: gclient setdep -r src-internal@759afdb33fc6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b1840e0f8b3ae109172bd9bbea7c0508e448d3e Reviewed-on: https://chromium-review.googlesource.com/c/1455596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629397}
-
Stephen Chenney authored
The impl side only needs to know when the main frame update is deferred so that it can avoiding waking the main thread. Defer commits can be handled entirely within the proxies on the main thread. Clean up the TODOs and update names and call sites. BUG=805798 Change-Id: I1301b33cc62200eb17b13108a8b701e5513cf9b9 Reviewed-on: https://chromium-review.googlesource.com/c/1455035 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#629396}
-
Adrienne Walker authored
Bug: 928926 Change-Id: I0be75dacca0e7d75f96fbeb16df61be7d0b35b8d Reviewed-on: https://chromium-review.googlesource.com/c/1455464 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
In order to define custom UserStreamDataSources, we need a chromium-built crashpad_handler binary. This change refactors the crashpad_handler executable to be built within chromium as chrome_crashpad_handler and moved into it's final destination under the original 'crashpad_handler' name. Bug: 912286 Change-Id: I0f52028ae4c149823b30747589e2dd94225694c6 Reviewed-on: https://chromium-review.googlesource.com/c/1449330Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629394}
-
Emily Stark authored
This code was added to record console messages and UMA metrics for legacy Symantec certificates. The Symantec deprecation has now been completed, so this code is no longer needed. Bug: 766981 Change-Id: I97f0311509a7dbfd41ac848d21fafa4d3cc742c3 Reviewed-on: https://chromium-review.googlesource.com/c/1447046 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Sven Zheng authored
The test can 100/100 pass on linux. Change-Id: I72e99d4dfe132b72466cdb7e49ba6804f86bb0c0 Reviewed-on: https://chromium-review.googlesource.com/c/1448737Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Fuzhong Zheng <svenzheng@google.com> Cr-Commit-Position: refs/heads/master@{#629392}
-
Nico Weber authored
While the define changes how tests run on all platforms due to how LLVM's cmake files look, this only has an actual effect on the clang and lld (etc) binaries on Linux. PIC works differently on Windows, and the 64-bit clang driver always forces PIC on on darwin, independent of what compiler flag it's handed. compiler-rt always builds with -fPIC, so the asan (etc) runtimes in the package are not affected. Bug: 920687 Change-Id: I1acdbee44ea2fce785f726b4488ccd9bd939f468 Reviewed-on: https://chromium-review.googlesource.com/c/1412572 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#629391}
-
Dale Curtis authored
Turns out that clang doesn't like LTO + mstack-alignment, so disable alignment changes when use_thin_lto is true. BUG=928743 R=liberato Change-Id: Ibc2fb84acb515956c4bd1564c39728e0ecbc7801 Reviewed-on: https://chromium-review.googlesource.com/c/1455463 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629390}
-
