- 15 May, 2019 40 commits
-
-
François Degros authored
Bug: 778674 Change-Id: I70cced32faaf0577efe412bd8f7bbef837c2c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611423 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#659785}
-
Meredith Lane authored
The button for clearing an entered keyboard shortcut for extensions was unlabeled, causing it to have no accessible name. This change adds the Clear string to the grit resources. BUG=870718 Change-Id: I19699be4b845db27a70d54b91ebdcdb108e71694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599766 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659784}
-
Yusuke Sato authored
BUG=None TEST=manual, the callback is now called Change-Id: I24c2af2f154ef903667ebdedff6f8e436d01ae93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612514 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01cd5697760e..a32a0bef6d75 git log 01cd5697760e..a32a0bef6d75 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 spang@chromium.org Add fuchsia-angle-rel to the CQ Created with: gclient setdep -r src/third_party/angle@a32a0bef6d75 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Iab101a7cca290f57b60a8fae1ba4f27bf2fc1f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659782}
-
Bo Liu authored
Record the reverse rank of android killed child processes. Bug: 946216 Change-Id: I844bed1b8219b711a301952a808160f61ffab1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603056 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#659781}
-
Darren Shen authored
According to [1], enums created for UMA histograms should use the new style enum class and also declare a kMaxValue enum value. The new style allows us to call UMA_HISTOGRAM_ENUM without having to specify the max value. We change a legacy enum (KeyboardControlEvent) into the new style. We also change an existing call to UMA_HISTOGRAM_ENUM into the new style. Since the enum is generated by mojo, the enum already follows the new style, but we just haven't used the right macro call. TBR=yhanada@chromium.org [1] https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#enum-histograms Bug: 845780 Change-Id: Ic1eec46d2afe0b5cf2a851e43100df68a001dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609729 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#659780}
-
Bo Liu authored
Native can pass up std::numeric_limits<unsigned int>::max() as the frame depth. We store this in a long in java which does not overflow. However comparator currently does substracts two frame depths and casts it down to int to get the sign. This can cause int overflow and change the result. Use Long.signum instead. Change-Id: Id0591250d4ae588bd3f54964fd53e3211402133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610083Reviewed-by:
-
Andrew Xu authored
It is requested by oshima@. Bug: 911753 Change-Id: I1445c367d49cd5e57237f19c61e0305474cacc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606968 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659778}
-
Darren Shen authored
Now that keyboard code is part of //ash, we can move the public parts of keyboard to //ash/public (to follow the same structure as the other ash components). Bug: 961568 Change-Id: I698a1da4726705e03ae95bf15a410b52193bc28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610665 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#659777}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d86f06bc794..74ca692079cb git log 3d86f06bc794..74ca692079cb --date=short --no-merges --format='%ad %ae %s' 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@74ca692079cb The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2425b4385173072bd6f6f89cfef2615303637f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612498Reviewed-by:
-
Xiyuan Xia authored
Recent changes revealed a deps problem that app list type mapping depends on app_list_types.h/cc but it is not listed and causing "get_accessible_interfaces" fail to link on asan bots. Bug: 963132 Change-Id: Ie65d2abe0db751486d643bcb7ea0bebbad764f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612228 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1610484 It can be safely landed after 1. PRESUBMIT for issues is fixed https://chromium-review.googlesource.com/c/chromium/src/+/1612049 2. bot_platforms only include sharded_tests https://chromium-review.googlesource.com/c/chromium/src/+/1612359 TBR'ing since this is a clean reland of code that was already reviewed. TBR=jbudorick@chromium.org Bug: 961830 Change-Id: Idb5546958d57b1499d9410ec3ad60a3ad610f9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610984 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659774}
-
Alan Cutter authored
This CL: - Adds pwa_* and bookmark_app_* as PWA files - Makes chrome/browser/ui/views/extensions/OWNERS reuse chrome/browser/ui/extensions/OWNERS Change-Id: I88de2782cd1c4354426494c86058118f247677cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609001Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Chris Blume authored
The documentation for creating a new VM for the GPU bots says to run gen.star. That file no longer exists. It is now main.star. This CL updates the documentation to reflect this change. TBR=kbr@chromium.org Bug: 963242 Change-Id: Ie8cb26cf92bb59c38af12dca01934a536c299314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612346Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#659772}
-
Elly Fong-Jones authored
This change also removes the backing switches; after this change it is no longer possible to disable physical-keyboard-autocorrect. Bug: 961526 Change-Id: Id15dfe05a048e99c399ce5cf34c3bdd0b2b716e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611903 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659771}
-
tby authored
A CL modifying related code was submitted at the same time, causing a build failure, and this one got reverted. The reland fixes the incompatibility. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1604387 Bug: 959679 Change-Id: Ided4b1dc3165b6f89b7dcc75c144e88b83901ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610660Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#659770}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I4c27347c6a5a1f165e18df1ab9139163ef630464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608265 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#659769}
-
Achuith Bhandarkar authored
BUG=chromium:963182 TEST=manual Change-Id: I59e97e864060c4f4ce1dc1608b5b78f069b45000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612229Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#659768}
-
Yutaka Hirano authored
Define DetachableConsoleLogger in console_logger.h, rather than in resource_fetcher.cc, in order to make it possible to know whether it is detachable from the type name. Bug: 924024 Change-Id: I07e2f227c34050c515f973b46f167004e7c855f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609400 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#659767}
-
Renjie authored
When eliminate_static_stream_map() is true, all streams including static streams will be in dynamic_streams(). This week's merge flips the flag in version 99, so Chromium needs to be updated. Change-Id: I5669cefc680185912d2b61809e9e12d2a4348439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612321Reviewed-by:
-
Brandon Tolsch authored
This reverts commit f88d1246. Reason for revert: prime suspect in compile failure on linux-rel Original change's description: > Roll src/third_party/pdfium 726ece1b5340..0db20e0a220b (4 commits) > > https://pdfium.googlesource.com/pdfium.git/+log/726ece1b5340..0db20e0a220b > > > git log 726ece1b5340..0db20e0a220b --date=short --no-merges --format='%ad %ae %s' > 2019-05-14 thomasanderson@chromium.org Fix ODR violations in public fuzzers > 2019-05-14 thomasanderson@chromium.org Split public fuzzer static initializer into its own file > 2019-05-14 thomasanderson@chromium.org Add missing dependencies to fuzzers > 2019-05-14 thomasanderson@chromium.org Move pdfium sources into fpdfsdk > > > Created with: > gclient setdep -r src/third_party/pdfium@0db20e0a220b > > The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > > BUG=chromium:960288,chromium:960288,chromium:960288,chromium:960288 > TBR=pdfium-deps-rolls@chromium.org > > Change-Id: I3d67a73b565d90cb0e2266d5a0c052b3d8c30591 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612211 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#659753} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pdfium-deps-rolls@chromium.org Change-Id: Ib856afb3386de711fa2ab72e858c1d08cc23e6bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:960288,963243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612259Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#659765}
-
Andrew Moylan authored
This CL tries out an easier flow for keeping mojoms in sync introduced by crrev.com/c/1608980. Specifically, this CL is exactly the following: cd ~/chromium/src cp ~/chromiumos/src/platform2/ml/mojom/*.mojom \ chromeos/services/machine_learning/public/mojom/ sed --in-place --regexp-extended \ 's~^import "ml~import "chromeos/services/machine_learning/public~g' \ chromeos/services/machine_learning/public/mojom/*.mojom Bug: 937063 Change-Id: Ic73a96c93cfe3422f4a7de342cfe0dad02c42f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609000 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
Sinan Sahin authored
This is a reland of 310bb105 Original change's description: > Progress on the Revamped context menu > > This CL consists of: > - Improvements for URL formatting (i18n and emphasizing) > - Addition of grey background while loading > - Addition of favicons, monograms, and thumbnails > - Addition of checkered pattern behind the transparent PNGs > - Some visual polish and fixes > > Bug: 655359 > Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#659233} Bug: 655359 Change-Id: Ie3d559eb0c353aef2eecf56cf36bcc29d41ec4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610854Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#659763}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01010b5cd43c..013ffd95d645 Created with: gclient setdep -r src-internal@013ffd95d645 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:962653 TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I302e8d0b79f4525cced970a8145c1179965c19fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659762}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ea6122f18e6a..5ea0721b4537 git log ea6122f18e6a..5ea0721b4537 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@5ea0721b4537 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I2bdb17efda585dc6ecd4d31a44c1292374c9d859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612383Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
With Grid Tab Switcher, the only users of thumbnail cache are StaticLayout and ToolbarSwipeLayout. To avoid visible degradation, StaticLayout needs the cache size to be at least 1, and ToolbarSwipeLayout needs 2. Bug: 959054 Change-Id: I8f9bfd376e7b52bb61165b33b201cec09397a44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594427 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659760}
-
Wei-Yin Chen (陳威尹) authored
isTabGroupsAndroidEnabled() implies isGridTabSwitcherEnabled(), and all callers of isGridTabSwitcherEnabled() should also check isTabGroupsAndroidEnabled(). There's no visual difference because all the affected code paths are in the bottom toolbar, which is force disabled when isTabGroupsAndroidEnabled() is on. Bug: None Change-Id: I35542d90c7c5e8c1d3c9c9effd7567e16e3f088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594734Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As the first step to deprecate WTF::CString, the bug has suggested replacing EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ in the cases of both converting WTF::String to const char* to use EXPECTE_STREQ and the expected string is ASCII. Bug: 950077 Change-Id: I093991a0f863c45913e5456c45a019afec3aca0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609721Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#659758}
-
Devlin Cronin authored
Instead of having separate stores and getters for page and browser actions on ExtensionActionManager, have a single store for all actions. Similarly, remove the type-specific GetPageAction() and GetBrowserAction() methods from ExtensionActionManager, and only use GetExtensionAction(). Call sites that rely on a certain type of action (which is relatively rare) now check the action type through ExtensionAction::action_type(). Also clean up extension_action_manager_unittest.cc to use parameterized tests and more targeted cases. This CL does not yet hook up generic actions (specified through the "action" key in the manifest) to ExtensionActionManager; that will happen next. Bug: 893373 Change-Id: Ib82f2f71b27f1118f2c02b9376cc5849aafab50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585959 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#659757}
-
Wei-Yin Chen (陳威尹) authored
When switching to a Tab, before the live layer is available, a grayscale thumbnail would be shown instead. However, after the live layer is available, we still add the ThumbnailLayer with alpha = 0, which is transparent and invisible. That ThumbnailLayer is skipped in this CL. Bug: 959054 Change-Id: I15c9b6d9cb97f3183a30fe83991eb9c5fe3d1d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595295Reviewed-by:
-
Caleb Rouleau authored
https://chromium-review.googlesource.com/c/chromium/src/+/1589012 added the new android compilers which also upload resource_sizes data to bot_platforms. However, in generate_perf_sharding and elsewhere we assume that every bot_platform has a shard map. Also, the other platforms in this list are similar in that they run Telemetry benchmarks, whereas resource_sizes is running some math on the compiler builder to find the size of the APK and other related data. Bug: 961830 Change-Id: Ib3c1460923863f21c28e5bfb08ae170ef59565c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612359 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 400f6e82. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 223d6ec0 "Reland "[EventTiming] Fix programmatic click test"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I66f5a68c5b0cdcf4fc1738e29aa02ce8b211e6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659754}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/726ece1b5340..0db20e0a220b git log 726ece1b5340..0db20e0a220b --date=short --no-merges --format='%ad %ae %s' 2019-05-14 thomasanderson@chromium.org Fix ODR violations in public fuzzers 2019-05-14 thomasanderson@chromium.org Split public fuzzer static initializer into its own file 2019-05-14 thomasanderson@chromium.org Add missing dependencies to fuzzers 2019-05-14 thomasanderson@chromium.org Move pdfium sources into fpdfsdk Created with: gclient setdep -r src/third_party/pdfium@0db20e0a220b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:960288,chromium:960288,chromium:960288,chromium:960288 TBR=pdfium-deps-rolls@chromium.org Change-Id: I3d67a73b565d90cb0e2266d5a0c052b3d8c30591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612211Reviewed-by:
-
khmel@chromium.org authored
This detects framework version change and invalidate icons for installed packages. This also fixes flakiness in unit test when installing app icons and deleting invalidated icons could happen from different concurrent threads. TEST=Locally, unit test BUG=959028 Change-Id: Ifb2b9a857a07275df401fc9df988cf931219ba4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610845Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659752}
-
Lei Zhang authored
BUG=503643 Change-Id: I41becf134e3aecd20ce51e50571fff880703b348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611912 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659751}
-
Steven Bennetts authored
NetowrkState usage has been mostly removed from non test consumers of network_icon.cc. This removes the single remaining usage in GetSignalStrengthForNetwork, updates the tests and removes the NetworkState dependency entirely. This also includes a bit of cleanup to cros_network_config.cc to separate NetworkStateHandler dependencies from NetworkState/DeviceState dependencies in the file local helper functions. (These were temporarily used in the tests but that was reverted, but the cleanup still seems useful). Bug: 862420 Change-Id: I566505e5a4f22538d8a862eeb5fcfc9f3c3ffd79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600306 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659750}
-
Jim Bankoski authored
The rtree build_tree code is calculating two parameters num_strips and num_tiles that it used to iterate through the list but both are unnecessary. The iterated parameters were not used, and the ceil used on the sqrt insured that we go through every single branch. This patch removes the extra variables and converts the two loops going through strips and tiles, into one loop that goes through branches from the input. Bug: None Change-Id: I156a1607d81010f00523f0a6c60e45dfe3a88a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612047Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: James Bankoski <jimbankoski@google.com> Cr-Commit-Position: refs/heads/master@{#659749}
-
Jia authored
Bug: 881215 Test: unit_tests --gtest_filter=AboutFlagsTest*, AboutFlagsHistogramTest* Change-Id: Ia1749065e2b41bba2f402d7790e9e00d7592b144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610666 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659748}
-
Matt Menke authored
Chrome's network stack runs out of process in most places, so logging actions to the in-process NetLog accomplishes nothing. Cast should be grabbing a UDP socket using the NetworkContext interface, instead of creating an in-process socket (Which will also get its network events to appear in the out-of-process NetLog). Bug: 767450 Change-Id: I3c742689f0b4a29138fd63669928b3a55d5ee2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612056 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659747}
-
Adrienne Walker authored
These have been spiking a bit, and so to cut down on the noise, reduce the rate at which we emit these to 1% of the previous total. The UMA stats will still show the true numbers, and this should still allow us to get urls to try to reproduce these cases that are failing in the wild. Bug: 879110 Change-Id: Ice743cfa10f460deaf806cd1b28d534f446ce975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612225Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659746}
-
