- 03 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cb55010652b2..65a77757a2cb git log cb55010652b2..65a77757a2cb --date=short --no-merges --format='%ad %ae %s' 2019-10-03 robertphillips@google.com Only use GrRenderTarget for sample locations in GrGLSLProgramBuilder Created with: gclient setdep -r src/third_party/skia@65a77757a2cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ied19cf4a4adfc0feb0e4b193c503b7887dcf86cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702448}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d20a3158b1ca..830565958d2b git log d20a3158b1ca..830565958d2b --date=short --no-merges --format='%ad %ae %s' 2019-10-03 dproy@chromium.org Use chromium build on linux for dev server tests Created with: gclient setdep -r src/third_party/catapult@830565958d2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:973847 Change-Id: I24eeb0a8cd6a3d3c135ba4a5f93e47c7ac8fd53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837852Reviewed-by:
-
Etienne Pierre-doray authored
This CL implements - Methods to Join a job task source _ Logic to signal a joining thread - JobHandle - PooledTaskRunnerDelegate::RemoveJobTaskSource called from Join. Bug: 839091 Change-Id: Ida5463cd724ba5f07bfa5c31fb8952af592e078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752637 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#702446}
-
Fred Mello authored
Calling cached version instead. Related to: https://chromium-review.googlesource.com/c/chromium/src/+/1813520 Bug: 1010895, 1005802 Change-Id: I0dd35b3204da1712e92dba0ac1c711a8b522bd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837408Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#702445}
-
Brandon Wylie authored
I've simplified the padding logic for the dse icon experiment, so there's no need for specialty logic. Bug: 1008496 Change-Id: Ib2a88b3b47b37eb88a59f345c8be6d56a5464b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828126 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702444}
-
kylechar authored
There are threading problems if TestGpuServiceHolder is reused between tests that reset the global time override. There is a race between reading the current time and base::subtle::ScopedTimeClockOverrides changing. Bug: 1000251 Change-Id: I74e7776ea3dc0854d40fcd0fc7bb4bf0ecc5b5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800483 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#702443}
-
Geoff Lang authored
* When doing deferred binds, the texture was not bound while the image was binding/copying. * Shared images were not marking the TexturePassthrough as pending a bind which generated errors later when the texture was is as a source for copying. BUG=990368 Change-Id: Ide601d8ae3e0641891d75c6cd3cba8b173491b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831016 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702442}
-
Matt Menke authored
When using an HTTPS proxy, WebSockets would always try to use an established H2 session for WebSockets, even if H2 over WebSockets was disabled. Moreover, if H2 over WebSockets was disabled, it would even use an H2 session that hadn't advertised WebSocket support. These problems were a result of only checking the HTTPS proxy server type, and not the scheme, when deciding if a request should try and use H2, and using the wrong value when telling the H2 code that only a session supporting WebSockets was needed. This CL fixes these issues. Bug: 1009612 Change-Id: Ic8ffdac454f3e079e47b8c35b1a5b4d8cac807e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835253 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#702441}
-
Justin Cohen authored
Bug: 1007337, 1010609 Change-Id: I37e4ed0bcedff3cbaae2ffdb30501cf78ad514fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834923 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702440}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2328d65ab30d..1850492e30ce git log 2328d65ab30d..1850492e30ce --date=short --no-merges --format='%ad %ae %s' 2019-10-03 m.maiya@samsung.com Vulkan: Disable OES_vertex_type_10_10_10_2 on GLES 2.0 Created with: gclient setdep -r src/third_party/angle@1850492e30ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I24d32dbac4a08a552094d40657eb7b3218b34874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837851Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8200c5d1..8b7cc20e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad82e8499da2527f7ba1e4db48d4b8483926595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835800Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702438}
-
Abhijeet Kandalkar authored
This CL converts TracedProcessPtr and uses new Mojo types. Bug: 955171, 978694 Change-Id: Id634ececb5389b073d4a2424625bd36400ce53c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788120Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#702437}
-
liberato@chromium.org authored
There's no need to turn off hw video decoding anymore. Local testing shows that it works, minus one thing: - The video elements in the appr.tc page are marked as autoplay, which requires a user gesture. Without it, the remote player stays blank. Bug: 801501 Change-Id: I39786d70c5c2024bfb0fa4051af76771d1e014e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649413Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#702436}
-
Evan Stade authored
The lifetime is tied to that of the profile, so hang it off the profile as a piece of UserData. Bug: 268984 Change-Id: Id897dd7d09281df943722709499a9f769841e270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832650Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#702435}
-
Łukasz Anforowicz authored
This reverts commit d205c616. Reason for revert: Speculative fix for compile failure on Android - first failing build at https://ci.chromium.org/p/chromium/builders/ci/Android%20x86%20Builder%20%28dbg%29/41901 includes this CL in the blamelist. Original change's description: > Add native resource to dummy module and test loading in smoke test > > * Adds a new PAK file with a dummy resources. > * Refactors the TestDummyModuleProvider to to synchronously load the > module PAK file when retrieving the impl. > * Adds a friend to ScopedAllowBlocking in order to be able to memory > map the module PAK file on the main thread. > > Change-Id: I0a3b949b83b37a7089aa410a691de6ae28f9a36a > Bug: 989646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822847 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Fred Mello <fredmello@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702423} TBR=dcheng@chromium.org,huangs@chromium.org,cjgrant@chromium.org,twellington@chromium.org,agrieve@chromium.org,tiborg@chromium.org,fredmello@chromium.org Change-Id: Ibeb6ea44abe3cf0c7b99eec625143c0326fe0afa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837973Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#702434}
-
Andrew Grieve authored
Bug: 982762 Change-Id: I66b5c8ab536e9c1931776167f7fc9b390e68617d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837199 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702433}
-
Xianzhu Wang authored
The baselines are correct, but run_web_tests script seems to choose wrong expected files. TBR=huangs@chromium.org Bug: 1010946 Change-Id: Ie1b77bff10fb5e52ff3e22baf912793e6e7b990d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836990Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#702432}
-
Peter Boström authored
Removes the height constant from BrowserViewLayout. Prerequisite for animating the container as BrowserViewLayout should be unaware of that happening. Bug: chromium:992972 Change-Id: I15c42df8933b223ca225204fa449bee6ea9b865d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836713 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <xialinyan@google.com> Reviewed-by:
Charlene Yan <xialinyan@google.com> Cr-Commit-Position: refs/heads/master@{#702431}
-
Yue Zhang authored
* Make TabGridDialog component own a TabSelectionEditor to support ungrouping through selection mode for both dialog in tab switcher and dialog from strip. * Add a TabSelectionEditorLayoutPositionProvider to specify the position to show selection editor so that it always shows on TabGridDialog. * Add strings used in tab grid dialog selection mode ungrouping. Bug: 1000381 Change-Id: I78fb56fcfe3ae058f8a6b921a72326e9358f7175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829239 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#702430}
-
Kaan Alsan authored
Removed SnapContainerData tracking via HashMap in SnapCoordinator and instead attached it to its PaintLayerScrollableArea (for RootFrameViewport this is delegated to the layout viewport). Snap containers must now be explicitly added/removed to/from SnapCoordinator. This is done when a PaintLayerScrollableArea is created or destroyed. Also added DCHECKS to ensure that SnapCoordinator only maintains valid snap containers and that it does not update a layout box that is not a snap container. Also added a test to ensure that changing a layout box's overflow to visible will remove it from SnapCoordinator and destroys the SnapContainerData of the layout box's ScrollableArea (originally the SnapContainerData would persist after the layout box no longer had a ScrollableArea). Bug: 853295 Change-Id: I375ab4ab4dee30aa48ebde3dd8a7d2c87a13edb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801745Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#702429}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/24b55eee06de..448444596bbc git log 24b55eee06de..448444596bbc --date=short --no-merges --format='%ad %ae %s' 2019-10-03 primiano@google.com Merge "test: prefer trace_processor_shell from the host directory." Created with: gclient setdep -r src/third_party/perfetto@448444596bbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id37a6d59a670b776ee5c522887895f7ca7689ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836929Reviewed-by:
-
Samuel Huang authored
Disabling the test because it consistently fails in Win 7. The test was recently added in: https://chromium-review.googlesource.com/c/chromium/src/+/1829645 TBR=avi@chromium.org Bug: 1010924 Change-Id: I585e23172ce67ca573c23193cd2b63b8f4d7f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837225Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702427}
-
Theresa Wellington authored
BUG= Change-Id: I5db1239de048a2a2bf7f72f61588342061bc3294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836666Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702426}
-
Andrew Grieve authored
To save on binary size (~50 methods). Bug: 921413 Change-Id: I61ab4d0915c6ffef11721271aa12a6b277c4b254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831984Reviewed-by:
-
Ian Clelland authored
Several comments are left here in places where code should be generated; the two features which are defined here are hard coded in place for development purposes. Bug: 993790 Change-Id: I5e71c2bb7794a67aff54e220698d09be1f6edb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801305Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#702424}
-
Tibor Goldschwendt authored
* Adds a new PAK file with a dummy resources. * Refactors the TestDummyModuleProvider to to synchronously load the module PAK file when retrieving the impl. * Adds a friend to ScopedAllowBlocking in order to be able to memory map the module PAK file on the main thread. Change-Id: I0a3b949b83b37a7089aa410a691de6ae28f9a36a Bug: 989646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822847 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23f76a29aaf9..6cf9a9ef99f7 Created with: gclient setdep -r src-internal@6cf9a9ef99f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3fbdb18d06bf7dcd8c5fba83ab62c487dd20bf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702422}
-
Fernando Serboncini authored
This was leaking previous data on move and reset. Bug: 1006347 Change-Id: I0f0894c05637dafe14d34957baa7b55e58a6f8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836016 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702421}
-
Jérôme Lebel authored
Adding accessibility identifier for account cells in AccountsTableViewController. This is needed for crrev.com/i/1918748 Bug: 1010533 Change-Id: Ie4925aeefd29ff9a5adbe96a729642f66207a72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835622 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#702420}
-
Justin Cohen authored
This reverts commit 74640a89. Reason for revert: Indirectly broke official builds. See crbug.com/1010930. Original change's description: > [iOS] Make the leak detection backend available on iOS > > Bug: 986317 > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702059} TBR=vasilii@chromium.org,ioanap@chromium.org Change-Id: I0ea2f9c848cbcc4f60e10351f47fd317d4bca6ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836994Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702419}
-
Evan Stade authored
FontPrefChangeNotifier automatically unregisters all registrars on Profile destruction, so we can just delete this code. (This was originally necessary because it used a PrefChangeRegistrar, which isn't as smart.) Bug: 268984 Change-Id: I332c6ac6d2033783b88dca8d369770c336a3c236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832684 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#702418}
-
Rune Lillesveen authored
We have an optimization where we skip marking an element style dirty if both its own and the parent's ComputedStyle are null. The optimal check is to look at the flat tree parent, and not go directly to the shadow host from a shadow host's light tree child, since there may be a display:none in the flat tree between the shadow host and the light tree child. For FlatTreeStyleRecalcEnabled, we allow walking the flat tree even if it's dirty and we can use GetStyleRecalcParent() to check the flat tree parent instead. Bug: 972752 Change-Id: I955259bcbbbb4ab3dd91eca5f1dc3d631e26a921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836507 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#702417}
-
Toby Huang authored
We need to add "https://www.googleapis.com/auth/cclog" (Clearcut scope) to the list of requested child scopes so that Add Supervision dialog can have logs. Bug: 1010603 Change-Id: If268980a874caed9344ccbe0c510447b0c2bb040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835256Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702416}
-
Devlin Cronin authored
extension_test_util::SetGalleryURL() has no callers. Remove it. Bug: None Change-Id: I49eeeb1c6d760d581a6a14b5c89960bfc959f430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835100Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702415}
-
Ewann authored
If editing, display pen icon. Hide credit card icon when editing. Bug: 1010841 Change-Id: Ia2b28bbdd403cf999bc2374387482d61363bec8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837618Reviewed-by:
-
Boris Sazonov authored
Moves drag_handlebar.xml to the UI package to make it accessible from TouchToFill code. Bug: 957532, 1009331 Change-Id: I77449ffdc44d75800495fbaa0b0bf808057e591c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836192Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#702413}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ieb4ad9353b21226f6367819e6f47430d8d6b8225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836981 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#702412}
-
Maksim Sisov authored
This CL creates an X11CanvasSurface and moves the painting code from SoftwareOutputDeviceX11 to X11SoftwarePainter in ui/base/x. Also, XShmImagePool can be used by ozone now. However, PlatformEvent has different type for Ozone and non-Ozone builds. Thus, Ozone/X11 and non-Ozone/X11 impl has been added to handle events. Both non-ozone X11 and ozone/X11 utilize this painter now. Last but not least, the SoftwareOutputDeviceOzoneTest did not create platform windows, which resulted in kNullAcceleratedWidget passed to canvas and the XShmImagePool. This resulted in failures during initialization and the test could not pass. To fix the issue, I've added an ozone platform initialization and creation of a platform window. However, it required to use UI message loop pump to get the platform event source working. What is more, PostTask could not be run as executor was null. Thus, I needed to make the viz_test_suite initialize TaskEnvironment with the main thread being UI now as the tests run in a single mode. Bug: 1001497 Change-Id: I696b78cdec5c575d0c772ede5d375b0c3f5d4e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789525Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#702411}
-
Samuel Huang authored
[Sheriff] Disable PrecisionTouchpadBrowserTest.PreventDefaultPinchZoom and PrecisionTouchpadBrowserTest.PreventDefaultScroll These came from: https://chromium-review.googlesource.com/c/chromium/src/+/1806629 TBR=bokan@chromium.org Bug: 1010911 Change-Id: Ide84f38b5ef67e9d4e100ce10ea6c5a51747fadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836983Reviewed-by:
-
Arthur Hemery authored
Filtering extra regressions happening on content_browsertests with the BackForwardCache enabled. Bug: 1010870 Change-Id: I00ae8a1a78d682ca437456d82de5343f8a38a78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837623Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702409}
-
