GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Fewer leaks on the Mac valgrind UI test bots
Review URL: http://codereview.chromium.org/155190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14920
TEST=context menus on tabs.
Review URL: http://codereview.chromium.org/155173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98

Remove obsolete SupportsURL function from when we have TabContents types.

Review URL: http://codereview.chromium.org/155171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20154 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20153 0039d316-1c4b-4281-b951-d872f2087c98

the scope, this patch just contains those delegate functions implemented only
by TabContents, plus the favicon functions implemented by the FavIconHelper.
The only changes are re-ordering and moving the functions, and changes in the
way that the functions are called through the new optional delegate.
Review URL: http://codereview.chromium.org/149239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20152 0039d316-1c4b-4281-b951-d872f2087c98

Some code had been removed from FirstRun::IsChromeFirstRun() so that it may return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser.     Also test that the first run UI still works as expected.
Review URL: http://codereview.chromium.org/155168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20151 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149303

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20149 0039d316-1c4b-4281-b951-d872f2087c98

After this change it should correctly handle all cases of multiple 230 welcome responses. It also fixes some other related bugs.

TEST=Covered by net_unittests.
BUG=none

Review URL: http://codereview.chromium.org/149211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20148 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20147 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20146 0039d316-1c4b-4281-b951-d872f2087c98

Also, do some housekeeping for our current shortcuts.

* Command-Option-l - Downloads [same shortcut as Safari].
* Command-Shift-[/] - Back/forward tab.
* cntrl-pageup/pagedn - Back/forward tab.

Global Keyboard events are intercepted by a new BrowserWindow custom class.

BUG=12537,15486
TEST=Check that above keyboard shortcuts work as advertised.

Review URL: http://codereview.chromium.org/149325

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20145 0039d316-1c4b-4281-b951-d872f2087c98

adding custom words to the dictionary on platforms other than 
windows. This functionality has now been implemented on all
platforms. Patch from pwicks86@gmail.com (Paul Wicks)
BUG=None
TEST=Adding words to dictionary on mac and linux.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20144 0039d316-1c4b-4281-b951-d872f2087c98

Convert GetScreenInfo to be sync and routed.

http://crbug.com/13113
R=darin@chromium.org, jam@chromium.org, amanda@chromium.org
TEST=See bug.

Review URL: http://codereview.chromium.org/151130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20143 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE

TBR=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149328

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20142 0039d316-1c4b-4281-b951-d872f2087c98

Patch by Thiago Farina.

Review URL: http://codereview.chromium.org/155078


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20141 0039d316-1c4b-4281-b951-d872f2087c98

Still are a bunch of more complicated behavior that doesn't work, like hitting
backspace to remove the keyword.  The keyword hint and keyword display more or
less work, although things have gotten pretty complicated.

BUG=10965
TEST=Tab to search with a keyword.

Review URL: http://codereview.chromium.org/151209


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20140 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20139 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149317

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20138 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20136 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20135 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none.
TEST= none.

Review URL: http://codereview.chromium.org/149313

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20134 0039d316-1c4b-4281-b951-d872f2087c98

before LOADED. Frequently, this didn't matter because we post
a task to the message loop to quit and usually this would get
queued after the LOADED message.

But it is also possible for us to queue the quit task first,
I think.

TBR=mpcomplete

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20133 0039d316-1c4b-4281-b951-d872f2087c98

I'm not able to repro the crash, but this seems safer overall.

BUG=16081
TEST=Right click an image, Save as, Chrome should not crash.

Review URL: http://codereview.chromium.org/149244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20132 0039d316-1c4b-4281-b951-d872f2087c98

Originally I had split it into multiple files, but I think it's
cleaner to just use one.

(I want to use this for measuring plugin jank.)

BUG=8077

Review URL: http://codereview.chromium.org/155194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20130 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none


Review URL: http://codereview.chromium.org/155195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

TEST=None

Review URL: http://codereview.chromium.org/155200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20127 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mpcomplete

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20126 0039d316-1c4b-4281-b951-d872f2087c98

a follow up CL to http://codereview.chromium.org/149038 as well as to
https://bugs.webkit.org/show_bug.cgi?id=26699

With this change we use DragOperationNone (instead of DragOperationCopy)
and NoButton (instead of LeftButton) when the user presses Escape.

BUG=12018

TEST=On the new new tab page drag one of the thumbnails out of the
window and press escape. The thumbnail should move back to its starting
position.

Review URL: http://codereview.chromium.org/149296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20125 0039d316-1c4b-4281-b951-d872f2087c98

automation and use that to set the size of the window in the

"New Tab Cold" to ensure we are testing the normal case and not the
small case.

BUG=None

TEST=The NewTabUIStartupTest, PerfCold should still work.

Review URL: http://codereview.chromium.org/149233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16047
TEST=Go to a site that has css with font-family: sans on Debian Lenny.
Review URL: http://codereview.chromium.org/149292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20123 0039d316-1c4b-4281-b951-d872f2087c98

R=dglazkov
BUG=15989

Review URL: http://codereview.chromium.org/149193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20122 0039d316-1c4b-4281-b951-d872f2087c98

Add the keys used by the back/forward menu items to the accelerator map so that we can locate sensible shortcut text for them rather than asking Windows.

http://crbug.com/14070
TEST=see bug

Review URL: http://codereview.chromium.org/149302

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20121 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20120 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov

Review URL: http://codereview.chromium.org/155197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20119 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20118 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20117 0039d316-1c4b-4281-b951-d872f2087c98

ParamRenderDepthStencilSurface.

Review URL: http://codereview.chromium.org/149298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20116 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/149236

The change SourceBuffer to use scoped_array
and they add a test for Class::unqualified_name.

Review URL: http://codereview.chromium.org/149300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20115 0039d316-1c4b-4281-b951-d872f2087c98