- 19 Nov, 2018 40 commits
-
-
Maxim Kolosovskiy authored
Tests fail. TBR=yosin@chromium.org Bug: 906591 Change-Id: Idf84e8776005d0d00409f06816e930f6903f52a4 Reviewed-on: https://chromium-review.googlesource.com/c/1341521 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609253}
-
Corentin Wallez authored
This rolls both projects at the same time because the GLFW build files are in the Dawn repository and they had to be changed to account for renames of GLFW source files. Roll src/third_party/dawn/ 69b44ee6a..391c8a922 (4 commits) https://dawn.googlesource.com/dawn.git/+log/69b44ee6a126..391c8a9224e5 $ git log 69b44ee6a..391c8a922 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 cwallez Roll GLFW to pick up macOS Mojave fixes 2018-11-19 cwallez Roll Chromium's build system to fix Windows builds 2018-11-16 cwallez Run win-dawn-rel on the CQ 2018-11-16 jiawei.shao Support cube map and cube map array Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org BUG=dawn:35 Change-Id: Ied363fe9a74d655c690cefcecdc897c5abcf28ff Reviewed-on: https://chromium-review.googlesource.com/c/1341830Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609252}
-
David Jean authored
Bug: 845472 Change-Id: Ia214b22388823eee5baa82ffaeb0224981b63a12 Reviewed-on: https://chromium-review.googlesource.com/c/1337610Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#609251}
-
Yi Su authored
PasswordsSettingsTestCase.testManyPasswords is failing on (ipad 5th gen ios 11.4.1). It failed on this assertion every time: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm?rcl=e1d1f67d8f56f9f45b01db4d4f523dda21b05366&l=293 Not sure about the reason, cannot reproduce the failure locally. Has filed a bug(crbug.com/906551) to track this. TBR=noyau@chromium.org Change-Id: I1a4d0bc62e5b16c7c3bad69b7587166ccd509bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1341828 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d3b79ec881f..0c1a474a0142 Created with: gclient setdep -r src-internal@0c1a474a0142 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ice4ef1ab2e518e8a96f6cd816a5b29b4b233b07f Reviewed-on: https://chromium-review.googlesource.com/c/1341851Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609249}
-
Javier Fernandez authored
This reverts commit ebf3a528. Reason for revert: This change caused a regression in how caret is positioned in contenteditable areas with floats or multicolumns. Original change's description: > Consider floats as HitTest candidate for selection > > Selection with floats has a weird and unpredictable behavior. The root > cause is that floats are not considered valid HitTest candidates. > > There are many other cases where float elements are ignored when > traversing the tree looking for the closes element to a specific > LayoutPoint. > > This patch address just one of this cases, where floats are children > of a in-flow block-level box. > > Bug: 758526 > Change-Id: I918af3ee21aa1070fa03a9fe1073205cc0a57300 > Reviewed-on: https://chromium-review.googlesource.com/643106 > Reviewed-by: Philip Rogers (OOO) <pdr@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#523410} TBR=yosin@chromium.org,pdr@chromium.org,jfernandez@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758526, 888424 Change-Id: Iba0f1641eeae63a52ef914b334cb302e69b7e7d9 Reviewed-on: https://chromium-review.googlesource.com/c/1271102Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#609248}
-
Tanja Gornak authored
Bug: 895897, 801985 Change-Id: I3820e991ae28cefed045e143e2b199633d5d6514 Reviewed-on: https://chromium-review.googlesource.com/c/1328881Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#609247}
-
Mathias Carlen authored
This patch adds a title to the terms checkbox using the same style as the payment request section titles. R=arbesser@google.com, twellington@chromium.org Bug: 806868 Change-Id: Ia13f80491ad062dcdc1e84d4dcd0cd7fb504cf63 Reviewed-on: https://chromium-review.googlesource.com/c/1340314 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#609246}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/55d0017c..7aa42b4c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34a68c28a15da444d26bead022f05a27dd1f5c09 Reviewed-on: https://chromium-review.googlesource.com/c/1340509Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609245}
-
Clemens Arbesser authored
[Autofill Assistant] Backend changes to the autofill assistant payment request in order to support collapsing PR sections. This fixes a bug that prevented using expand(null) to collapse all PR sections. Bug: 806868 Change-Id: Ia67b2c7fb778d05356927524ddbcd5c93a5ffa22 Reviewed-on: https://chromium-review.googlesource.com/c/1337330Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#609244}
-
Mikel Astiz authored
It's unclear why the DCHECK removed in this patch is guaranteed to hold true, and in fact some tests run into it. Instead, let's defer application of updates until all pending ones can be decrypted. According to an old (previously deprecated) UMA metric, Sync.WorkerApplyHasEncryptedUpdates, the condition doesn't meet about once per million times. If this only affects the small subset of users with custom passphrase enabled, which is likely, then it's non- negligible. This may (in rare cases) differ from the cryptographer being ready, specially during sync cyles where NIGORI updates are not requested. Bug: 873902 Change-Id: Ic70efdad3b72e9387bac50e782a51da09e532857 Reviewed-on: https://chromium-review.googlesource.com/c/1335933Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609243}
-
Marc Treib authored
It's always true. Bug: 904782 Change-Id: I6cb979f5e168a33d100b3dfda00257f5d72438b5 Reviewed-on: https://chromium-review.googlesource.com/c/1341533Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609242}
-
Jacobo Aragunde Pérez authored
Two reasons for flakiness were identified: * Occasional lack of sync between the C++ and JS sides of the test. Sometimes, the JS side emitted signals before the C++ code was ready to listen to them, or the C++ side emitted keystrokes before listeners were ready in JS code. Fixed with slight changes in the order of the test code. * When checking the spatial navigation status immediately after changing it, the wrong state could be reported. When the system is under heavy load, it could happen that the changed state is reported before the change has been made effective in the render process. Fixed sending a message to the guest render process with postMessage, which uses the same IPC channel; when the message is answered we can be sure that the SetSpatialNavigationEnabled operation is complete. Bug: 884306 Change-Id: Iae227098cd36980357d8b747ddcb527df2317fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1327204Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#609241}
-
Andreas Haas authored
I made improvements to https://crrev.com/c/1336130 but I forgot to save them. With this CL we should get more information about crashes on Windows. R=haraken@chromium.org Change-Id: Ie1cea16e9e6574cb9028a165d8bf5a68465bd965 Reviewed-on: https://chromium-review.googlesource.com/c/1338099Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#609240}
-
A Olsen authored
There are two types of cros settings: 1. Device settings that are read by DeviceSettingsProvider and can be written by OwnerSettingsService 2. kSystemTimezone, which is the only system setting (or at least, the only writeable one). It is read by SystemSettingsProvider and can be written by TimezoneSettings. Both of these can also be written by CrosSettings, which delegates to either OwnerSettingsService or to TimezoneSettings. The write path is being removed from CrosSettings, and so must be replaced by calls to either OwnerSettingsService or TimezoneSettings. This CL special cases kSystemTimezone in prefs_util.cc so that the remaining call to CrosSettings can be replaced with a call to OwnerSettingsService. Bug: 433840 Change-Id: Ie3d954980dbffc9c850f5afa82bedf633c01f97f Reviewed-on: https://chromium-review.googlesource.com/c/1339940Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609239}
-
Christian Dullweber authored
Rebuild leveldb for SessionStorage when deleting all cookies. This will remove traces of deleted data from disk. This changes introduces a callback to DeleteSessionStorage to allow the caller to be notified when a deletion is finished. Bug: 823071 Change-Id: Ia0d13b3739b7aa379e8e2eb89a9e85c0b2365a53 Reviewed-on: https://chromium-review.googlesource.com/c/1202562Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#609238}
-
Ross McIlroy authored
Bug: V8:8405 Change-Id: Ia53c8d5d8842143f4e41b6b82149e58c70664062 Reviewed-on: https://chromium-review.googlesource.com/c/1341512Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609237}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e385fd60000..3d3b79ec881f Created with: gclient setdep -r src-internal@3d3b79ec881f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie2ceec5a77b6f36652de0bdbdd1182ea33718680 Reviewed-on: https://chromium-review.googlesource.com/c/1341849Reviewed-by:
-
Marc Treib authored
The retry task was plumbed back from SyncSchedulerImpl through SyncManagerImpl, SyncBackendHostCore, SyncBackendHostImpl to DataTypeManagerImpl, where it did nothing. Bug: 867425 Change-Id: I1788573635da7c12062ed8aea094b74ef8349b0d Reviewed-on: https://chromium-review.googlesource.com/c/1341532Reviewed-by:
-
Mikel Astiz authored
The SyncableService (SessionsSyncManager), the directory datatype controller and all abstractions required for accomodating two implementations are removed, together with the corresponding about flag and feature toggle (kill switch). Sync integration tests are updated because they also exercised the legacy codepath. TBR=rohitrao@chromium.org,pkasting@chromium.org Bug: 895455 Change-Id: Ifaca1696e97f88b70b0c61ad89fed2372b239e46 Reviewed-on: https://chromium-review.googlesource.com/c/1340814Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609234}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: Iee8f1ff42f8c76b7553ffce55d51ca5e54afd95b Reviewed-on: https://chromium-review.googlesource.com/c/1340818Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 8fcafe0e. Reason for revert: the CL caused test failure https://bugs.chromium.org/p/chromium/issues/detail?id=906577 Original change's description: > Add tests for sharing and managing items in team drives. > > Bug: 903637 > Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f > Reviewed-on: https://chromium-review.googlesource.com/c/1341287 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609191} TBR=noel@chromium.org,sammc@chromium.org Change-Id: I6385ca389f4f2e8807ee6a34c4a0a27744c5ac39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903637 Reviewed-on: https://chromium-review.googlesource.com/c/1341516Reviewed-by:
-
Kent Tamura authored
- Introduce empty ElementInternals interface - Add HTMLElement.prototype.attachInternals() - Add a flag to ElementRareData about ElementInternals attachment - Promote "ElementInternals" runtime flag to "test" All the change is behind the runtime flag. Some test cases in external/wpt/custom-elements/CustomElementRegistry.html fail by this CL because this CL enables GET() operation for "disabledFeatures", and these test cases doesn't expect it. We should update the testcases later. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/758 Change-Id: I7b3dbfd1d422c7eae5c7a6e01ddea50a00134a6e Reviewed-on: https://chromium-review.googlesource.com/c/1341734Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609231}
-
Friedrich Horschig authored
This CL introduces the new style of the keyboard accessory (clean white) to highlight is as part of the Chrome UI. It's also the base for IPH which will explicitly state the origin of suggestions and actions. Because the new design uses autofill suggestions as integral part, it is guarded by the #autofill-keyboard-accessory-view flag which isn't used in other way anymore. To keep the old implementation until the new design is fully approved and fleshed out, the KeyboardAccessoryModernView* classes extend the existing classes and replace them if the appropriate flags are set. For screenshots highlighting the differences, see: go/keyboard-accessory-v2 Bug: 853772, 876750 Change-Id: I44718a4e2269d17b002d7dc890784a847ed840e7 Reviewed-on: https://chromium-review.googlesource.com/c/1338087Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Add tests similar to BrowsingDataRemoverBrowserTest to Android. They verify that cookies and other data is counted and deleted correctly by Clear Browsing Data. To perform asynchronous calls to Javascript, this adds support for DomAutomationController.send on Android. Bug: 905612, 562487 Change-Id: I2c5d3929cf4e1eed704b21b55ad9988b5a09c53e Reviewed-on: https://chromium-review.googlesource.com/c/1339864 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#609229}
-
Sam McNally authored
When adjusting the search parameters, the data model briefly has no entries. Updating the image-dominant calculation during this interval causes the image-dominant to be disabled, causing a flicker of the file names if the contents is image-dominant. Bug: 483718 Change-Id: I099a013e5f05c36902be67aeffc40edbc718be26 Reviewed-on: https://chromium-review.googlesource.com/c/1341736 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01979132133e..e7b1a13a1e2a git log 01979132133e..e7b1a13a1e2a --date=short --no-merges --format='%ad %ae %s' 2018-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1c6b26a70f93..fde74c078f77 (1 commits) Created with: gclient setdep -r src/third_party/skia@e7b1a13a1e2a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@chromium.org Change-Id: I46c445d15a8701b0141cb60189c43f22c3b3cb3b Reviewed-on: https://chromium-review.googlesource.com/c/1341567Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609227}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: Ifc106e9166ef46fbb04a87dee98af72a55da31bb Reviewed-on: https://chromium-review.googlesource.com/c/1329925Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609226}
-
Vaclav Brozek authored
The old FormData -> PasswordForm parser runs in renderer process, before the data about forms is passed on to the browser process. The new parser runs in browser, after it receives the data from the renderer. For legacy reasons, the FormData (parsing input) is enclosed inside PasswordForm (output) during the inter-process transport. As a result, if the old parser fails to parse completely, the new one has no chance to run at all, because there is no valid PasswordForm to encapsulate its input FormData during the inter-process transport. The important case when this matters is if there are password fields present, but none of them is enabled. The old parser gives up, the new does not care about enabled vs. disabled, so can parse. This CL allows the old parser to produce a minimal PasswordForm if only disabled password fields are present, to allow transporting the FormData to the new parser. In PasswordManager, all these minimal PasswordForms are managed by at most one PasswordFormManager and only used as a fallback, so the functionality of Chrome under the old parser is not affected. Bug: 904908 Change-Id: Idaf569d39884375dc5942dea4349aeec41355c76 Reviewed-on: https://chromium-review.googlesource.com/c/1337497 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit aee1ee31. Reason for revert: Suspect this CL caused https://bugs.chromium.org/p/monorail/issues/detail?id=4576 Original change's description: > Make EndOfSentence stop at block boundaries > > This patch stops EndOfSentence from crossing block boundaries, since > block boundaries are also sentence boundaries. > > Bug: 778507 > Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993 > Reviewed-on: https://chromium-review.googlesource.com/c/1337432 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608850} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 778507 Change-Id: I7d48146bd7fb27c34427f543ad3b54443ae63715 Reviewed-on: https://chromium-review.googlesource.com/c/1340815Reviewed-by:
-
Ioana Pandele authored
This change separates the current text of the infobar into title and body. The latter contains a link pointing to where the user can find the saved generated password. Screenshot on the bug. Bug: 903257 Change-Id: Iadbfb68298b338d990c4be0b0ab3d11007b4b125 Reviewed-on: https://chromium-review.googlesource.com/c/1156586Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#609223}
-
Justin Cohen authored
Change-Id: Idd933d2bfcff3e136c4b2787a80d70b562068ceb Reviewed-on: https://chromium-review.googlesource.com/c/1341206 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609222}
-
Vaclav Brozek authored
The PasswordForm.FillOnLoad UKM aims at measuring the change in behaviour of Chrome with the new password form parser, if an explicit condition for filling on load is changed from A to B. It turned out that even if A is the explicit condition, B still can break fill on load. So the change is not so much A -> B as A && B -> B. This means that the metric's bucket recording the state when A is true and B false needs to be merged into the bucket when A == B, because in both cases the behaviour does not change. Bug: 895781 Change-Id: Ic3ab14d9a1e43c0312580d2dfe5bff34f2cdd20a Reviewed-on: https://chromium-review.googlesource.com/c/1340274Reviewed-by:
-
Hans Wennborg authored
This is part of cleaning up for a new Clang warning that's currently disabled: In file included from ../../ash/app_list/home_launcher_gesture_handler.cc:19: ../../ash/wm/window_transient_descendant_iterator.h:69:43: error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted] WindowTransientDescendantIteratorRange& operator=( ^ ../../ash/wm/window_transient_descendant_iterator.h:72:37: note: copy assignment operator of 'WindowTransientDescendantIteratorRange' is implicitly deleted because field 'begin_' has an inaccessible copy assignment operator WindowTransientDescendantIterator begin_; ^ Bug: 890307 Change-Id: Ic47bc989f9fe26e1387f9a6a8c00f19fcf6b91ce Reviewed-on: https://chromium-review.googlesource.com/c/1340331 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609220}
-
Yuki Shiino authored
The return type of OnBeforeUnloadEventHandler is DOMString?, so we should use V8StringResource<kTreatNullAsNullString> instead of V8String<kDefaultMode>. Change-Id: I6df9581cf5dd01ae8215d773c95a3e9dc6a78e08 Reviewed-on: https://chromium-review.googlesource.com/c/1341779Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Change-Id: I88b641bf356044ca94552273081af22c0fde1795 Reviewed-on: https://chromium-review.googlesource.com/c/1341530Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609218}
-
Yuki Shiino authored
This patch fixes a regression at https://crrev.com/c/1215512 , which doesn't run 'beforeunload' event listeners when one of the related execution contexts is paused. This patch adds an exceptional handling for 'beforeunload' event so that 'beforeunload' event listeners run regardless of pause. Bug: 903297 Change-Id: I92bb24a8fd16ee9f81a5082f5c561c97c1dd5348 Reviewed-on: https://chromium-review.googlesource.com/c/1333548 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This will remove the need to know about specific instances of SigninManager, AccountTrackerService, ProfileOAuth2TokenService and GaiaCookieManagerService from the calling places for those methods. Also move the SigninManagerForTest definition in identity_test_environment.h one level up, to allow sharing it among |IdentityManagerDependenciesOwner| and |IdentityTestEnvironment| without relying on such definition being also available from identity_test_utils.h (from where it's now being removed due to no longer being required by those test utilities). Bug: 904404 Change-Id: If96b0c7dea763030dc7372d58922f82a31eb5733 Reviewed-on: https://chromium-review.googlesource.com/c/1336127 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecb09be23157..7e385fd60000 Created with: gclient setdep -r src-internal@7e385fd60000 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifdfe2ed136d3a4440cc92cee9b8706b50e8c77ab Reviewed-on: https://chromium-review.googlesource.com/c/1341566Reviewed-by:
-
Julian Pastarmov authored
Some ph tags were incorrectly using the $1 placeholder and were replaced with the string Google Chrome instead of their content. BUG=none Change-Id: Idd9540861a44c124ad8ac5e9ccca6e588e98b74f Reviewed-on: https://chromium-review.googlesource.com/c/1337624Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609214}
-
