- 28 Sep, 2018 40 commits
-
-
Anand K. Mistry authored
These changes are necessary to eventually integrate the zip archivers unit tests. Changes include: - virtual -> override - Un-inlining overridden functions - Correcting types BUG=889703 Change-Id: I83030c6b77dda026c4a3fee50df2ecbcedb898f6 Reviewed-on: https://chromium-review.googlesource.com/1250281Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594972}
-
Anand K. Mistry authored
There's no reason to keep this flag, zip creation should always be enabled. BUG=None Change-Id: Id88aeeff60bf220f4a0457a807e7a321a1cc1f85 Reviewed-on: https://chromium-review.googlesource.com/1242644Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594971}
-
Shakti Sahu authored
Bug: 881499 Change-Id: Icbf4bdeabbe59f60ff4ca971fd7db868c13e9426 Reviewed-on: https://chromium-review.googlesource.com/1250138Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594970}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5e3ad45995ebe78a3abbce3b89d0cdaacc7f6441 Reviewed-on: https://chromium-review.googlesource.com/1250224Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#594969}
-
Scott Violet authored
This works better for hit testing with mash. BUG=879791 TEST=none Change-Id: Ie87e72933f80a77955f301da2195934109d7f569 Reviewed-on: https://chromium-review.googlesource.com/1250123Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#594968}
-
Jordy Greenblatt authored
Mostly fixing some vertical alignment. Here are screenshots of the real UI and one with long fake strings to mock a long translation: https://drive.google.com/drive/folders/13FE9SeGanXukvaICOqusW5S7GVgFfd5r?usp=sharing Bug: 878644 Change-Id: Iabe0ed9c7daaeef7b2929af37f3c869168cae4d3 Reviewed-on: https://chromium-review.googlesource.com/1249820Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#594967}
-
Tetsui Ohkubo authored
This CL adds following UMAs & histograms: * StatusArea_NightLight_Enabled * StatusArea_NightLight_Disabled * StatusArea_NightLight_Settings * StatusArea_QuietMode_Enabled * StatusArea_QuietMode_Disabled * StatusArea_Notifications_ClearAll * ChromeOS.SystemTray.IsExpandedOnOpen For the descriptions of UMAs, see the .xml. TEST=manual BUG=none Change-Id: I253a69578645f834a32f42fb7ba3aefbbd3bb112 Reviewed-on: https://chromium-review.googlesource.com/1245004Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594966}
-
John Chen authored
This test still fails on Mac with Chrome m68 and m69. TBR=crouleau@chromium.org Bug: chromedriver:1945 Change-Id: Ia4aa9d824e365655513a8a486c849b7d51193f33 Reviewed-on: https://chromium-review.googlesource.com/1249573Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594965}
-
Wenzhao Zang authored
This will be merged to M70 and reverted in M71. Bug: 890021 Change-Id: I4b6e940db961739ec938029d7ccd185b8f7441a9 Reviewed-on: https://chromium-review.googlesource.com/1250122 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#594964}
-
Sergey Berezin authored
This should save a lot of disk space on a Mac VM, and stop it from clobbering the caches after every build. Tested locally: $ tools/mb/mb gen -m chromium.mac -b 'Mac Builder' //out/ci Writing """\ ffmpeg_branding = "Chrome" is_component_build = false is_debug = false proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true symbol_level = 1 use_goma = true """ Bug: 888223 Change-Id: Ic4014f99232b1929e13dc0ca1e9b983e662a7733 Reviewed-on: https://chromium-review.googlesource.com/1249568Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594963}
-
Eliot Courtney authored
stayed upon resizing the window. Bug: b/112668689 Bug: 841886 Test: Created a PIP window and it had rounded corners. Rounded corners Change-Id: Ie57223d8c5a2701a0013eee0bce2cf5333d2c304 Reviewed-on: https://chromium-review.googlesource.com/1219426 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#594962}
-
Xiaohan Wang authored
This replaces the current WIDEVINE_CDM_IS_COMPONENT macro defined in widevine_cdm_common.h. Buildflag is safer, also this avoids tricky cases where widevine_cdm_common.h must be included before the define can be evaluated. Bug: 349182 Test: No functionality change Change-Id: Ifc26d2fa87b00997e9335a977cb6417c4ec4432d Reviewed-on: https://chromium-review.googlesource.com/1248132Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594961}
-
Alexei Svitkine authored
This is apparently now being hit on Android Chromium builds as a result of the field trial testing config. Bug: 889950 Change-Id: Id1beefe02127726e1198c8a4fdb679a019a6e62b Reviewed-on: https://chromium-review.googlesource.com/1249493Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594960}
-
Stephen Martinis authored
The test results format says that the key should be 'is_unexpected', not 'unexpected'. TBR=dpranke Bug: 890072, 890075 Change-Id: I49d49b9a0ee7ebaf2346658eb8f334cef1cf8a19 Reviewed-on: https://chromium-review.googlesource.com/1250202 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#594959}
-
Findit authored
This reverts commit 3225e1d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 594844 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzIyNWUxZDVlYTQ2MjZhNzcwZDgzNWRkMDNhMjViNmMwOTViNThiNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/72634 Sample Failed Step: events_unittests Sample Flaky Test: X11EventTest.AutoRepeat Original change's description: > Use accurate X11 event timestamp computation. > > X events have a timestamp which is only well defined relative to the X11 Server > time. The previous computation for timestamp for X11 events was making the > assumption that Server time and Chrome time were the same. This assumption is > not always true -- this is likely the root cause of "bad" timestamps observed in > https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 > > This CL changes event timestamp computation to make a roundtrip to the X11 > Server to get an accurate base::TimeTicks. This logic was lifted out of the > responsiveness calculator, which was already doing this computation. The latter > will subsequently be changed to use the computation in this CL. > > Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 > Bug: 859155 > Reviewed-on: https://chromium-review.googlesource.com/1249383 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594844} Change-Id: I911f8bd268739b5e91c550e3f6a6186ae4dfbecb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859155, 890121 Reviewed-on: https://chromium-review.googlesource.com/1250210 Cr-Commit-Position: refs/heads/master@{#594958}
-
Michael Giuffrida authored
Adds the Play Store app to the shelf and launcher in Demo Mode. Bug: 885370 Change-Id: I94b550e48fbd747f56d576005a29c52145b96479 Reviewed-on: https://chromium-review.googlesource.com/1247026 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594957}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de84e41c85f9..5315071e31be Created with: gclient setdep -r src-internal@5315071e31be The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaae64e45473a980146b6aaa186d3a228c2a876d1 Reviewed-on: https://chromium-review.googlesource.com/1250111Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594956}
-
Jordy Greenblatt authored
UX clarified they want the buttons to be indented by 32px on the right and left and the rest of the pages to be indented by 64px in non-OOBE Setup Flow. http://screen/mrTBhk6dTQe Bug: 889574, 878643, 878644 Change-Id: I04c9b2f7c5f2c850dee04462889823e95fee4dcd Reviewed-on: https://chromium-review.googlesource.com/1250133Reviewed-by:
-
Mike Wasserman authored
PointerWatcher is no longer needed with Ash hosting the Window Service. Some minor cleanup. Bug: 872450 Test: No regressions with shelf tooltip behavior. Change-Id: I8d1b2bf008c54ae921dcabc67dc236d7d5801e11 Reviewed-on: https://chromium-review.googlesource.com/1250048 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594954}
-
Jun Mukai authored
Bug: 883523 Test: none Change-Id: I482409f708c958103fb5667f6c124f0e02ccd601 Reviewed-on: https://chromium-review.googlesource.com/1250135Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594953}
-
Zhuoyu Qian authored
BUG=561800 Change-Id: Ie1676b820fe9260fbcf5ab9db6d07c875d92573f Reviewed-on: https://chromium-review.googlesource.com/1248143 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594952}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/920acc565706..7453eba4feb2 git log 920acc565706..7453eba4feb2 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 dtu@chromium.org [pinpoint] Add performance thresholds for smaller regressions. Created with: gclient setdep -r src/third_party/catapult@7453eba4feb2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:889551 TBR=sullivan@chromium.org Change-Id: Iaf3ebbb1e33d4148e0c9249a5d34d686b94c97c4 Reviewed-on: https://chromium-review.googlesource.com/1250109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594951}
-
Jinsuk Kim authored
This CL aims to remove all the references to SadTab (thus slim it down) by factoring the related methods out to a separate class SadTab. It is managed as Tab UserData, and takes care of creating/showing sad tab view on ContentView. Also got SadTabFactory folded into it. Note: Tab still has references to SadTab (isShowingSadTab) from handleTabCrash/notifyContentChanged. Removing them involves somewhat side-tracked changes as big as the main one. Will handle it in a follow-up CL. Bug: 877878 Change-Id: I94a03e8f9999809cf690339a16570cc538e0e18c Reviewed-on: https://chromium-review.googlesource.com/1235490 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594950}
-
James Cook authored
This is a step toward supporting multiple remote apps and widgets. We need this for browser windows under single-process-mash. Under mash the ash process is responsible for top-level window creation for remote apps. It will need to route accessibility actions (like hit testing) to the correct remote app. Likewise it manages window frames and focus. Therefore it should own the mojo AXHostService, not the browser. Accessibility events from the remote app must be routed out of ash into chrome to the accessibility extension. For now we do this with the in-process AccessibilityDelegate. I didn't introduce a new delegate because the mojo service is lazily created and it's hard to connect a new delegate at startup. Subsequent CLs will: * Always create the service at ash startup * Convert the delegate methods to mojo See go/mash-ax-node-tree for the full plan. Bug: 888147 Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92 Reviewed-on: https://chromium-review.googlesource.com/1249920 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#594949}
-
Sam McNally authored
LocationLine assumes DRIVE_OTHER entries will be of the form /other/path/to/file. With DriveFS, they are instead of the form /.files-by-id/<id>/path/to/file. Support correct breadcrumbs for directories within shared with me by treating /.files-by-id/<id> as the prefix instead of /other when the path starts with that pattern. Bug: 854481 Tbr: slangley@chromium.org Change-Id: I91b55c6fbae3458b4f0f4599fc969b3c1b1fa2e8 Reviewed-on: https://chromium-review.googlesource.com/1245343 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
David Tseng authored
LogStore through TreeDumper depends on chrome.automation (which is only available in the background page). Unfortunately, NavBraille and ConsoleTts require LogStore and are still currently included in the injected content script which pulls in all LogStore deps. This change: 1. removes ConsoleTts from the content script. Logging within a content script might have been useful in the past, but doesn't seem relevant today. 2. NavBraille logging was moved to BackgroundBraille. Test: load a page. Verify no errors come from access to automation api being undefined. Ensure there are no references to 'automation' in the compiled page script(s). Change-Id: Ief450600f4a23588900843678c40baf5efdfbf8b Reviewed-on: https://chromium-review.googlesource.com/1249270 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594947}
-
Chong Zhang authored
This patch affects tests only. We want to cache the |network_context_request_| to avoid triggering connection error handler infinitely. (Also organized unrelated BackgroundFetchBrowserTest.* tests) Bug: 889965 Change-Id: I9fc67b03f19b8a9575db7714ea57ec41fc0a7711 Reviewed-on: https://chromium-review.googlesource.com/1249727 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594946}
-
Trent Apted authored
- capture unittest_util.js's use of commandLinePrivate - audit remaining things using command_line_private.js unnecessarily (Only files in file_manager/common/js and file_manager/foreground/js use it directly.) - Remove an annoying dep that piex_loader_unittest.js has on webui (Use a custom element instead: cr/ui.js dislikes strictCheckTypes.). Bug: 882750, 879958 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I70c9e16b1ba7b9af64e0ce01b7177ef02500c948 Reviewed-on: https://chromium-review.googlesource.com/1245079 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: -
Zhuoyu Qian authored
This simplifies many conditions around the code in chrome/chrome_cleaner. Bug: 561800 Change-Id: I4918b2ba3d6de0c4dac47e5e79c684a1b5430020 Reviewed-on: https://chromium-review.googlesource.com/1248522Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#594944}
-
Jeremy Klein authored
This change moves the logic for installing the Android Messages PWA into a helper class which is a HostStatusProvider::Observer. This allows it to install the PWA when a host is set and also when signing into a new Chromebook if the account already has a valid host. Bug: 887775 Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b Reviewed-on: https://chromium-review.googlesource.com/1248130Reviewed-by:
-
Stephen Chenney authored
TBR=fs@opera.com BUG=529345 Change-Id: If867ae6936ccfadfd99e4cff4ea209c686f99382 Reviewed-on: https://chromium-review.googlesource.com/1249395Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#594942}
-
Christopher Cameron authored
This was accidentally dropped from crrev.com/594134 Bug: 859152 Change-Id: I159af36686ce07300969f2eaf79796be85f012e5 Reviewed-on: https://chromium-review.googlesource.com/1244886 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594941}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6aef4b11f6610e2edff6e4e9a685a360ba3e314e Reviewed-on: https://chromium-review.googlesource.com/1250110Reviewed-by:
-
Dan Sanders authored
If a GPU channel cannot be established, a WebMediaPlayerImpl can be constructed without a |context_provider_|. Handle that case correctly in CopyVideoTextureToPlatformTexture(). Bug: 819914 Change-Id: I620b602ee0c092cc31273b4f513133bf8af7e1d0 Reviewed-on: https://chromium-review.googlesource.com/1250137 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#594939}
-
Anand K. Mistry authored
BUG=889703 Change-Id: I901c546c8329ea7082e11eaaae0bced60f376bf4 Reviewed-on: https://chromium-review.googlesource.com/1242763 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0e1056a6c8e..de84e41c85f9 Created with: gclient setdep -r src-internal@de84e41c85f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4bf04887e364c799a01818399939c4e27f7ff5a2 Reviewed-on: https://chromium-review.googlesource.com/1250107Reviewed-by:
-
Wenzhao (Colin) Zang authored
This reverts commit 35b382aa. Reason for revert: crbug.com/890100 Original change's description: > [css-flexbox] Apply min-height: auto to nested flexboxes again > > To avoid the previous regression (see analysis in bug), we force > layout in the case where we otherwise would get an outdated result. > > Bug: 596743 > Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 > Reviewed-on: https://chromium-review.googlesource.com/1246730 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594752} TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 596743 Reviewed-on: https://chromium-review.googlesource.com/1250207Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594936}
-
Sergei Datsenko authored
Cloud queries are being retried indefinetely in drivefs backend when offline, which is a separate bug, but at least we shouldn't even try if we know that it won't work. BUG=chromium:854481 Change-Id: I5b1f182bf532864d01fc2c47740e72af0feddad4 Reviewed-on: https://chromium-review.googlesource.com/1249425Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#594935}
-
Lambros Lambrou authored
This adds the VP8/9 frame quantizer to the stats for each frame. This will enable the website to show a graph of these values over time. This also adds new FrameStats unittests, and fixes a capturer_id initialization bug discovered by the unittest. Bug: 888833 Change-Id: I2c48f9c024a0e64a6a5756a3371717d3491a8474 Reviewed-on: https://chromium-review.googlesource.com/1242398 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594934}
-
Karan Bhatia authored
Declarative Net Request API requires extensions to have access to both the request url and initiator to block/redirect a request. Currently any requests with an opaque origin as the initiator can't be intercepted by extensions. Correct this. BUG=889713 Change-Id: Ie86bf745da652d6f076e9d3076e06ec0c202f4d1 Reviewed-on: https://chromium-review.googlesource.com/1248541 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594933}
-
