- 18 Oct, 2019 40 commits
-
-
Lukasz Anforowicz authored
Before r694827, request_initiator for fetches from content scripts would be incompatible with request_initiator_site_lock, so CORB would safe-fail to treating request_initiator as if it was an opaque origin. This meant that no Access-Control-Allow-Origin would ever satisfy CORB. Since r694827 requests from content scripts set request_initiator to the origin of the frame/page where the content script was injected (not to the origin of the extension). This helps a tiny bit with https://crbug.com/920638 - now CORB will pass through responses with Access-Control-Allow-Origin that matches the origin of the frame/page where the content script runs. This CL adds a test that verifies this particular benefit of r694827. Bug: 920638 Change-Id: I139b12e4f46d48136e627a98b4f072cacc33b8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864827 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707594}
-
Pavel Yatsuk authored
This CL includes following changes: - Record user's interaction with IdentityDisc in a way that can be used in IPH triggering conditions. - Introduce IPH metrics - Enable IdentityDisc IPH in tests through fieldtrial_testing_config.json R=holte@chromium.org,twellington@chromium.org Change-Id: I6b1aa2b64d2d52173ad9e83ea2329287d7c28635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868833 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#707593}
-
Julie Jeongeun Kim authored
This CL converts SharedURLLoaderFactoryInfo to new Mojo types using PendingRemote and Remote and updates ContentBrowserClient::HandleExternalProtocol() with mojo::PendingRemote<network::mojom::URLLoaderFactory>. Bug: 955171 Change-Id: Ie0d3dec0d00f107d9b9eea84c7cd7e0a314b5445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861554 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a286fcc59c3a..6f8624c5117e Created with: gclient setdep -r src-internal@6f8624c5117e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04bbfa19e78f0d0843464c482a7b2e110668e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707591}
-
Dana Fried authored
This ensures that even at odd scaling factors we get a 1DIP separator between infobars. Fixes: 1014072 Bug: 1014072 Change-Id: Ib3e0deb6601b7c8f2b3949feabce9a35af45697c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867849Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#707590}
-
Nasko Oskov authored
This method on RenderFrameHostManager::Delegate is not really needed. It is a single line wrapper around NavigationController method and the delegate interface already has a method to get the NavigationController. As such, I'm removing it and replacing it with a direct call on the NavigationContoller. Bug: 1015882 Change-Id: Iffc68d2e3e42e102d115337c271a820a2b368707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869714 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#707589}
-
Sam Fortiner authored
The previous implementation assumed there was always a client and could crash attempting to retrieve the name of the layer. Instead, we are making DebugName always available and leveraging that. Bug: 1015727 Change-Id: I01ebcf5babd117ec2340a79064785ba4ba6b161d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869295Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707588}
-
David Tseng authored
This ensures we don't capture the Search key when there's no ChromeVox focus. This is important for cases like ARC++, where TalkBack needs to get Search. The ARC++ window explicitly clears focus in the case where TalkBack is in control. Bug: 1011894 Change-Id: I15f0b438f16397e92ee59ebd8bd0cb74b9a927e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862719 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#707587}
-
Ayu Ishii authored
This change changes the behavior of when multiple requests come from the same origin on one tab. Instead of cancelling requests that come later, this will be changed to prioritize the last request made for the origin and cancel requests previously made. This is consistent with the behavior in web USB. Bug: 985438 Change-Id: I76c0047fea8852346e13fc99a4d092ab80a5a24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860683Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#707586}
-
Yun Liu authored
Write profile data after Android apk-based gtests finished. Bug: 985574 Change-Id: If22313a6eca142226a3fa095a0f40b8d44c00e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867190Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#707585}
-
Robert Ogden authored
This is done by querying the cookie store on navigation start and on every redirect for the current navigation url. If any one of the requests had cookies, the boolean flag is set. Bug: 995437 Change-Id: If39c9b98ff35423bcb672f437d35d0b7aff9f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868329 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707584}
-
James Cook authored
This puts the pref registration closer to where the prefs are used. It also eliminates the duplicate "for_test" registration that we added for the now-cancelled mustash project. I fixed a few cases where the pref was registered with a different default value in tests than in production. This CL is cleanup, no behavior changes expected. Bug: 1013466 Change-Id: Ie8c36b0adc9d39ce1f3170ae8ff6983e831e030a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869770 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707583}
-
Nasko Oskov authored
This CL removes the ShouldTransitionCrossSite method on RenderFrameHostManager as it is no longer useful. It only checks for --single-process command line flag and that flag is not supported configuration. Bug: 1015882 Change-Id: I0b0443e9dce5db6165de1a5f40d4f9b685908767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866443Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707582}
-
Jinsuk Kim authored
This CL addresses a corner case where the new bottom sheet request is blocked by the currently hidden bottom sheet. Bug: 1009942 Change-Id: I4a6a58ff9c240dd82ef6300d9346f8a9f5c240ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866097 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#707581}
-
Clark DuVall authored
This reverts commit 442aea6e. Reason for revert: Reverting for now since ExecuteScriptTest.testBasicScript is flaky. Will reland after http://crrev.com/c/1869849 is landed. Original change's description: > [WebLayer] Implement executeScript() on BrowserController > > This adds a way to execute javascript in WebLayer. The script will be > executed in a weblayer isolate that will not be able to access any > scripts from the page. > > Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707455} TBR=sky@chromium.org,cduvall@chromium.org Change-Id: If6e7dfaf486a0974ae0a638e0861e7632178c934 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869885Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#707580}
-
Brian Ho authored
Currently, setting the use-vulkan flag both initializes Vulkan and enables Vulkan compositing/raster. WebGPU-on-Linux sets the use-vulkan flag so it can use Vulkan for rendering, but it also requires a bunch of other flags [1] despite having no dependencies on other Vulkan efforts. As such, we would like to be able to decouple WebGPU's development from that of the larger Vulkan-on-Chrome effort. The core issue is that while use-vulkan initializes the VkInstance, it also sets the |vulkan_context_provider| [2] for the GrContext. Vulkan Chrome codepaths then check for the existence of the |vulkan_context_provider| to decide whether the GrContext is Vulkan and thus, enable Vulkan compositing/raster. This CL adds a new gr-context-type flag so the type of the GrContext can be explicitly set instead of implied via the existence of |vulkan_context_provider| and |metal_context_provider|. For WebGPU, we can simply set --use-vulkan=true and --gr-context-type=gl to get the VkInstance without any side effects. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=976495#c21 [2] https://cs.chromium.org/chromium/src/gpu/command_buffer/service/shared_context_state.h?l=69&rcl=b405097b146118b345e2802b20d7df5d9a5ea908 BUG=996470,976495,1009029 TEST=unit tests and ran chrome with various permutations of the Vulkan flags Change-Id: I49cf84c65f58044446eadffabdaef7ab4db517d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829863 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#707579}
-
Raphael Kubo da Costa authored
The spec underwent many breaking changes this week, and the Blink implementation was also updated to follow suit. This CL makes README.md match the new API, the new classes and new separation of concerns (e.g. the WakeLockController class in Blink was merged into WakeLock itself). Bug: 1015359 Change-Id: Ibd52542ef7421714db2180d1aa6c962515004166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869213 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707578}
-
Steven Bennetts authored
mojom.NetworkConfig.type was eliminated when we switched to unions. A few places referencing it were not properly converted. This also renames securityType to securityType_ to properly reflect that it is a private member and converts configRequiresPassphrase_() to the preferred pattern of using members directly. Bug: 1014914 Change-Id: I9543f7831e950a343ba8ce6444fbbb3c51fe2bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864463Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707577}
-
Garrett Beaty authored
These changes simplify migrating to starlark by removing spurious diffs from the semantic diff. The header_id fields have no effect when builder_view_only is true because builder views do not display headers. The manifest_name field is ignored and cannot be set in starlark. Bug: 1011908 Change-Id: I92d1fd67ba41a68fefdc5524ee0acbc583cfc9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869684 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#707576}
-
Wei Li authored
The only custom action in HoverButton's manual layout is to position title label vertically in its parent. We create a small custom view class for its parent to change its position upon bound change. Therefore, we can remove the manual layout in HoverButton. BUG=1005568 Change-Id: Iea0f9a8236a519373e299b31550d4240551cda7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866981 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#707575}
-
Matt Menke authored
It was only being used on iOS, but the system handles wkWebView-initiated data URL requests there, and they aren't needed for internal requests, so this CL also removes all of iOS's uses of the class. I'll remove DataProtocolHander and URLRequestDataJob in followup CLs that make sure we don't lose test coverage of the data URL parsing code, which is still in use. Change-Id: I5e6789b36c457a7ab06f7a8e0c1cf1dcee2929b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868837 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707574}
-
Adam Ettenberger authored
With Narrator and UIA enabled if the user navigates to the end of a document, then the document is modified such that Narrator now has a range whos |start_| or |end_| position is at the end or start of the document respectively, |NormalizeTextRange| would have created a NULL_POSITION for that range edge. To avoid this, if there is no next/previous character for that edge of the range, then that edge position will not be modified. Bug: 1015593 Change-Id: If706057eaf533dfd0ab5e544eefd102d95ca767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869716Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707573}
-
Carlos IL authored
Bug: 1015501 Change-Id: Ifb0d0f12229ee37fe9abeecfbc46218a4314ea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865758 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707572}
-
gogerald authored
Bug: 1015976 Change-Id: Iffe5eb9fbde4c2abb666f174700699d0025b3c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869711 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#707571}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9bd9f4b3ed64..f28d5287c68b git log 9bd9f4b3ed64..f28d5287c68b --date=short --no-merges --format='%ad %ae %s' 2019-10-18 dneto@google.com Remove utils/build.py (#841) Created with: gclient setdep -r src/third_party/shaderc/src@f28d5287c68b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I01ea6b78988bcaeaafacdc16fe5aad5ff234b876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869764Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707570}
-
Christy Chen authored
The presubmit script did not warn about the missing example tag for placeholders. This Cl added more details to the error message. https://imgur.com/a/9I7hXfx Bug: 941561 Change-Id: I2a950e4dd1fecc0a4dfea7467216c71c964c97b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845580 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707569}
-
Nasko Oskov authored
The terminology we use in the SiteInstance and process model code is "site" not "web site", therefore it makes more sense for the IsSameWebSite method to be named IsSameSite and be more consistent with the rest of the code. Bug: 1015882 Change-Id: Icb4ba1464b8559ff07c10d2dc338014ec79522ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869761Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707568}
-
Manas Verma authored
Logging whether or not the user perceived any latency between selecting a card and being prompted for authentication. This would help us determine if our efforts to reduce user-perceived latency were successful. When the user is opted-out, it also determines how often we can actually present the user with the opt-in flow. Bug: 949269 Change-Id: I9ef2a34d05ec04e97d572f4d563fca92eeef9dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810022 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#707567}
-
James Cook authored
Chrome OS used to use the mojo preferences service, which required prefs used across the browser/ash boundary to be flagged as PUBLIC. Since mustash was cancelled we don't use the mojo service any more, so the flag isn't needed. This helps clarify which prefs are still actually using the mojo preference service (e.g. assistant). This CL is just cleanup, no behavior changes expected. Bug: none Change-Id: I4f53ff4f1dcaba600a797f61774c186459c751aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869672 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707566}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/13753e667da5..b5a8b9ebfa6e $ git log 13753e667..b5a8b9ebf --date=short --no-merges --format='%ad %ae %s' 2019-10-18 wub Internal QUICHE change 2019-10-17 renjietang Remove redundant handshake confirmed method. 2019-10-17 dschinazi Deprecate quic_reply_to_old_android_conformance_test 2019-10-17 renjietang Support GOAWAY in HTTP/3. 2019-10-17 bnc Do not track unacknowledged references on the encoder stream in QpackBlockingManager. 2019-10-17 wub gfe-relnote: (n/a) In QUIC BBR and BBRv2, add a flag for MaxAckHeightTracker to determine when to start a new ack aggregation epoch. No behavior change. 2019-10-17 wub gfe-relnote: (n/a) Reduce the rate limit a QUIC error log in BandwidthSampler. Logging only. 2019-10-17 quiche-dev Run quartc_peer_test cases until bandwidth targets are met. 2019-10-17 dschinazi Deprecate and remove v47 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic8f605ccba1f9f712fbaf3c31005a50035484435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869030 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#707565}
-
Henry Jian authored
Previously, the ideal size for WebAPK's adaptive icon is set to be 108dp. It neglects the fact that a total of 30% padding is needed to bridge the gap in safe zone percentage between the web spec (https://www.w3.org/TR/appmanifest/#icon-masks) and the Android spec (https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive). This CL changes it to the right value, 83dp. Bug: 977173 Change-Id: I99411d10751e410a87ae3946bfe5175fe295057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869372 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707564}
-
Wei-Yin Chen (陳威尹) authored
The string was wrongly translated in at least one locale. Add more context to help avoid that more systematically. Bug: 1014772 Change-Id: Ie7f56ee69bd7be7fc4ece189478ed12e24d68bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864016 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707563}
-
David Grogan authored
This only modifies the content size suggestion from https://drafts.csswg.org/css-flexbox/#content-size-suggestion, the transferred size suggestion https://drafts.csswg.org/css-flexbox/#transferred-size-suggestion isn't done yet. The 4th case from https://cs.chromium.org/chromium/src/third_party/blink/web_tests/css3/flexbox/minimum-size-image.html now passes. Bug: 845235 Change-Id: Id731437de2a116f94cdada1a93e6bcce86f5f9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842618Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707562}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72b2be2e56ff..0cb09633d68c git log 72b2be2e56ff..0cb09633d68c --date=short --no-merges --format='%ad %ae %s' 2019-10-18 lanwei@chromium.org Revert "Add more test_utils functions." Created with: gclient setdep -r src/third_party/angle@0cb09633d68c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: Iafda603eff91bf2b2c5af5d82b2d5337d1ed9460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868657Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fbf366d1dac..a286fcc59c3a Created with: gclient setdep -r src-internal@a286fcc59c3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib569330bd25829ac2077519c76968b6f996ca96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869027Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707560}
-
David Benjamin authored
I noticed this as I was poking at those tests. Splitting this out separately. Bug: none Change-Id: I449615d0af9a89fffaf40453bc9d9caca87d5790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869497 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707559}
-
Peter Kotwicz authored
This CL adds MockCertVerifierRuleAndroid#setResult() which enables individual tests to customize the certificate verification result. BUG=997796 Change-Id: I9efd46db72523049fd72754103dafaff33e75021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869763Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707558}
-
Chris Lu authored
Bug: 1014959 Change-Id: I72f36884a3bc36e7d39a93314ec3c4e770ddd10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869371 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707557}
-
Kevin Schoedel authored
Bug: b/141992733 Change-Id: Ifff0300df4c36ae8eed67541bda35a5fb0187013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869832Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#707556}
-
Daniel Rubery authored
Bug: 1015974 Change-Id: I643d415f8dca086461c54a4080286f27ef0929c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869028 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707555}
-