- 24 Jun, 2020 40 commits
-
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ib3c3a8e5778ed6ae44fe205db7e1707dda078e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262156Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#781738}
-
Richard Knoll authored
WidgetObservers need to be removed from all ObserverLists before destruction otherwise it will CHECK fail when iterating over the list. The CHECK is added to all subclasses to retain readable stack traces in release builds. The goal is to find all instances where the observer is not removed as that causes a hard to reproduce failure. AX-Relnotes: n/a. Bug: 1055483 Change-Id: I481ee30e681220ff697c7fbb2380470f17cfd465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254598Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781737}
-
Johann Koenig authored
This reverts commit d35a8977. Reason for revert: Causes test failures on Win 7 BUG=chromium:1098531 Original change's description: > [base] Experiment with only invoking ::PeekMessage when there are pending messages > > ::PeekMessage can process sent-messages and internal events. It seems > the kernel also uses it as a heuristic to deschedule the main thread when > it thinks it's out of messages. In MessagePumpForUI's design, it's > possible to have application tasks without pending native tasks > (kMsgHaveWork is dropped when running out of native tasks). > > This CL uses ::GetQueueStatus() to probe the presence of messages before > invoking ::PeekMessage(). > > Bug: 1075960 > Change-Id: I4a93b22adf225ae2d62aabeb1a7a734232cf7fb6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258456 > Auto-Submit: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781498} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: Ib1e700621eef27b1ed8cfd1c50b3019836f6c41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262160Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#781736}
-
Jia authored
InvertedIndexSearch is a search backend based on inverted index and TF-IDF ranking. This CL implements all APIs except search, which will be in the next cl. Bug: 1090132 Change-Id: I3ad4507fba907ed73c3b2b49d7ddb931d0421ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262101Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781735}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I366adcc7619ea36f5ff0ffa4b7807a9aa4f491bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781734}
-
Marc Treib authored
This CL introduces histograms PasswordManager.AccountStorage.OptedIn/OptedOut/ClearedOptInForAllAccounts which are recorded whenever a user opts in to, or opts back out of, the account-scoped password storage. Bug: 1063852 Change-Id: Ic780cf166b8942ce21f34b2d88935c0bc831941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257230 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#781733}
-
Donn Denman authored
Add support for fluent languages so we can better support users that are fluent in multiple languages. Ignore blocked languages that were flagged with "never translate" because that's for the whole-page translation, not the partial translations done by Contextual Search. Also extend the limit on the selection from 100 to 1000 to allow for longer phrase translations. BUG = 1095096, 1084600, 1093833, 1095090 Change-Id: Ife837aa965d501aaaab628013df2936beee58b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261445 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#781732}
-
Alice Boxhall authored
AX-Relnotes: N/A Bug: 1021939 Change-Id: I051ee8ff4deb08977a5319783bae5aced602d54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256942 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781731}
-
Adam Rice authored
Bug: 1090210 Change-Id: I4dfcc10eb8186c8405abe8e69b4a218d7b64c673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247983Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781730}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b2720383..9111c7e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia6cb6460bc1257d4cd7fb0b78fb1af5163611215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262496Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781729}
-
Henrik Boström authored
The OS mostly only generates OnThermalStateChange events when thermals changes. Without this CL, PeerConnection that are created after such event won't know what the thermal state is initially. This CL fixes that so that PeerConnections can respond to poor thermal signals even if they were created late. By getting the current thermal state when the PeerConnectionTrackerHost is constructed the host will never miss reporting a thermal state to the PeerConnectionTracker. By remembering the latest thermal state, the PeerConnectionTracker can make sure to tell any PeerConnections that were added late what it is by sending OnThermalStateChange as part of registration. Bug: chromium:1098247 Change-Id: Id26e9d9f94f4d0c285b9466cb55e98f0bbce0c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260552Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781728}
-
Yoshifumi Inoue authored
This patch changes "5071074.html" to utilize |selection_test()| and renames to "copy_and_paste_with_anchor_text.html" for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I002cb140f497fde0b07b027aee9f50f359f2a140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262080Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781727}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/57c2dfb200b6..f5062f6b5bcd 2020-06-24 chinglinyu@google.com Merge "Make standalone build work for Chrome OS" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4e26775d14d828a3fcc312b7399592e791c8e690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262636Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5156401-1.html" to utilize |selection_test()| and renames to "insert_into_link_in_table_cell.html" for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I1240251b5f9a93351fe39899ca1faa21d1067cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262360 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Replaces whitelist -> allowlist. Bug: 842296 Notry: true Change-Id: I81c2c719378b0e7d0caa83e3dc9b57983ffd0468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262118Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781724}
-
Yoshifumi Inoue authored
This patch changes "merge-no-br.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I31aada7f8b8698fc24c6d76641bc400ebf10cb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262158 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-012.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: I13732bbdbe0d268b5c2f1fe65b1b651c44324d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262157 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yusuf Sengul authored
Bug: 1097407 Change-Id: I80b0fa57cc19196b06b3cbec5afc7c4488ff7325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255113 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#781721}
-
Yutaka Hirano authored
Before this CL blink::mojom::FetchAPIRequestBody was typemapped to blink::EncodedFormData. This was not good for a request body made from ReadableStream because the body is implemented as blink::ResourceRequestBody::stream_body_ which is out of EncodedFormData. Hence this CL changes the type mapping. Now blink::mojom::FetchAPIRequestBody is typemapped to blink::ResourceRequestBody. - encoded_form_data_mojom_traits.{cc, h} are moved to platform/loader/fetch/fetch_api_request_body_mojom_traits.{cc, h}. - encoded_form_data_element_mojom_traits.cc is merged into platform/loader/fetch/fetch_api_request_body_mojom_traits.cc. blink.mojom.FetchAPIDataElement is no longer typemapped. - Add DataPipeBytesConsumer::CompletionNotifier::SignalSize so that it can work with a data pipe coming from ChunkedDataPipeGetter. - Support streaming body in FetchRequestData::Create. Bug: 688906 Change-Id: I8c4ed0f46946aff3f59733dd2138017ead724575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249205 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781720}
-
Alice Boxhall authored
This builds on https://crrev.com/c/2191975 by introducing a preference (also behind the same feature flag) to enable users to turn the focus highlighting feature on and off in Chrome Browser (excluding Chrome OS, which has its own OS-wide preference). When the preference is enabled, the user is also opted in to always matching :focus-visible on the focused element. AX-Relnotes: n/a Bug: 1075862 Change-Id: Iaa85ef5e39a24fdf2127edfecf35f340f6a88ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208480 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Jia authored
Bug: 881215,1094935 Change-Id: I9739565f89daa164e0054126d4eb270a3bdb967f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262095Reviewed-by:
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: I2ff9cbc2472c074ccb78ce141016cb2427c2594a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261481 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#781717}
-
Matthias Körber authored
Logs the overall status of an address import on submission time. This is a temporary histogram to assess the impact of features::kAutofillProfileImportFromUnifiedSection. Change-Id: I0d1cee574e99f6d430946f227f63eab735436595 Bug: 1098077, 1097692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258593 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#781716}
-
Gang Wu authored
Omnibox did not use normal UMA to do the log, they use protobuf to report metrics. So we can use existing way to report metrics, only need to update the window open disposition. https://source.chromium.org/chromium/chromium/src/+/master:components/omnibox/browser/omnibox_log.h;l=66 Then OmniboxLog will have it at https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/android/omnibox/autocomplete_controller_android.cc;l=311 Later on, when Omnibox creating protobuf to report at https://source.chromium.org/chromium/chromium/src/+/master:components/omnibox/browser/omnibox_metrics_provider.cc;l=68 server will know this action is switch to tab, and the Omnibox.SuggestionUsed.SelectedTabMatch will appear on UMA report. Bug: 1092269 Change-Id: I0bf7a94985d03c0c6271d71ee79c7303e7598ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259142Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781715}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592953173-dfa217e6d4c03de878e7e0d7393e7f5bccc2ec20.profdata to chrome-win32-master-1592960277-f901daea6b8075bb87053ccb79c202b2253e6908.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I84ff54df540a5eea023ac191af0f2514c2b60652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262227Reviewed-by:
-
Jeremy Roman authored
Use it in a handful of places to demonstrate. Bug: 1098539 Change-Id: I605705dead803b6534aa092ce5517f94df2c036e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260946 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781713}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15444a50b912..07a3ce625213 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070150 Tbr: johannkoenig@google.com Change-Id: I0899c95f7951b72b57050f6217a738c03f4731f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262222Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781712}
-
Tibor Goldschwendt authored
NewTabPageLogoTest.All was disabled for flakiness. Likely, because we embed iframes that do not finish or fail to load. However, it is not material to the test whether the iframe loads. <ntp-untrusted-iframe> provides capability to mock out loading. Therefore, make <ntp-untrusted-iframe> usable for non-chrome-untrusted URL and use it for the doodle iframe. Fixed: 1097035 Change-Id: Ic1008278b957da2873f7e1b2ed56a0c90bbb5707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261716 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#781711}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592953173-8fb0a7663f4cd8da151edd9da48fe9964b3af4db.profdata to chrome-win64-master-1592960277-bc23f7c6050a632e956b7539dc4edff3e9938101.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4c472685b250876350bd165aaeeb21b3835a4dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262225Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6659b733e7804f4ffad8bee952429902fe3bef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262593Reviewed-by:
-
Chris Sharp authored
This reverts commit 4fd81590. Reason for revert: Test is failing on linux-chromeos-dbg Original change's description: > Revert "Disabled flaky `fileDisplayWithoutDriveThenDisable` testcase" > > This reverts commit 8172d98f. > > Reason for revert: wrong culprit, change that caused this issue was > CL:2214908 and that was reverted. > > Original change's description: > > Disabled flaky `fileDisplayWithoutDriveThenDisable` testcase > > > > TBR=adanilo@chromium.org > > > > Bug: 1097013 > > Change-Id: I1ed5abccd73b2c8c2ad71dccca8fde5863232d15 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253762 > > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780258} > > TBR=andypaicu@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097013 > Change-Id: Id5232de5fe52efe7bdb508280b40e54124fb72b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259872 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781203} TBR=noel@chromium.org,andypaicu@chromium.org,adanilo@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097013 Change-Id: I7662f32a402a8da0ec77f3454eef6a04e63b1d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261035Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#781708}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/babfc6e9a020..57c2dfb200b6 2020-06-24 treehugger-gerrit@google.com Merge "Parse IRQ ftrace events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9da08a2330beba58d703d1492f66f5cb8a087d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262223Reviewed-by:
-
Alan Cutter authored
This CL addresses nits missed in https://chromium-review.googlesource.com/c/chromium/src/+/2251563/6 Bug: 1090227 Change-Id: Ief6c157d7cd53ab52e8267e661d7b65bbfab7cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261912 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#781706}
-
Kuo Jen Wei authored
Add 22th, 23th dimension to capture event with value 0/1 indicating whether it's a video snapshot photo and whether the video ever paused before its recording ended. Bug: 1054314 Test: Test through all related user scenario, check the format of sent out capture event. Change-Id: Ic21a893b1e6dff29f0eaa8b73dfda4299e87f45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255922 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#781705}
-
rajendrant authored
Bug: 1098423 Change-Id: Ib34f10604513f119544af3a4db243ac76af292e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262256 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#781704}
-
Robert Ogden authored
IsolatedPrerender handles cookies in the following way: * Cookies which are set on the prefetched mainframe are kept in the isolated NetworkContext's cookie jar. * Subresources fetched during NoStatePrefetch use the isolated NetworkContext's cookie jar and so send cookies as appropriate. * When the user navigates to a link that was prefetched, any cookies for that page are copied over to the normal profile. * Subresources that were not prefetched before the click use the prefetch cookie when they are made after the click with the normal profile. Note that copying the cookies over to the normal profile is a multi- step process during which the prefetched mainframe is blocked from committing to ensure page correctness. Important: Opaque IsolationInfo's block all cookies so this CL also transitions IsolatedPrerenders to a normal navigation-style NIK and IsolationInfo. This is ok because all prefetches are occuring in a separate NetworkContext from the rest of the browser and therefore were never at risk of having shared resources. Bug: 1096765 Change-Id: I090fc57d46936b4972bd799eab3e4b022019bbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253200 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#781703}
-
Scott Violet authored
This moves the voice ranking from chrome into content. TtsControllerDelegate is now optional, and *only* used on ChromeOS. The logic for looking up prefs remains in the chrome implementation, but is expressed differently so that all the ranking can be in content. BUG=1025626 TEST=covered by existing tests Change-Id: Ib105fe91452dea791e992eb6c70fa7f1d2789985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255314 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#781702}
-
James Cook authored
chrome/browser/BUILD.gn already sets it to an empty list, so we don't need to do it for lacros. Also tweak the comment in //chromeos/lacros/browser/BUILD.gn to match the other ones and mention docs/no_sources_assignment_filter.md This is followup to CL comments in: https://chromium-review.googlesource.com/c/chromium/src/+/2246121 Bug: none Change-Id: I6f868d82b3e5cfc75720ab9affc3a2aa7a1a3037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262114 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781701}
-
Hirokazu Honda authored
This fixes a bug of EncodedDataHelper in reading ivf frame header. Bug: 1098142 Test: video.DecodeAccelSanity.vp9_1 Change-Id: Icaa6d6a41784bbc1b3bc1f7d967a35abb5635743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262022 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#781700}
-
Adam Rice authored
The "cancel should abort a pending read()" subtest of http/tests/streams/transferable/readable-stream.html was flaky because it expected a delay(0) call to complete sending all pending messages, which occasionally didn't happen on the bots. Switch to waiting explicitly for the call to cancel() to happen to ensure that the test is complete. BUG=1073431 Change-Id: I66c2f8b726a5bb6c56596eb9b7327c1458423a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260094Reviewed-by:
-
