- 21 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3663ed3ad678..82a3f0ad7f2b git log 3663ed3ad678..82a3f0ad7f2b --date=short --no-merges --format='%ad %ae %s' 2019-10-21 danilchap@webrtc.org Replace SingleThreadedTaskQueueForTesting::SendTask usage with ::webrtc::SendTask 2019-10-21 danilchap@webrtc.org Stop using gtest internal macro GTEST_ARRAY_SIZE_ 2019-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision db43fd36..8587b26e (707597:707701) Created with: gclient setdep -r src/third_party/webrtc@82a3f0ad7f2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ica8c70dc84a6d47000cc6e56e9a92b4b06a0ba1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707765}
-
mark a. foltz authored
Add myself as a backup OWNER to miu@ for features related to Cast, to review changes in case miu@ is OOO. Change-Id: Id44fa744f70db2843385b06c58457fbbf5725f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867206Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707764}
-
sandromaggi authored
Before this change the server had no knowledge of whether or not the onboarding was shown to the user in this run. To be able to log this, a new flag is now sent to the server in the requests for getting scripts. Adding unit tests to check new behaviour. Bug: b/142846407 Change-Id: Ic77bbc70c8add122beaff80a47e3cf7dca4454d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866631 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#707763}
-
Jan Wilken Dörrie authored
This change implements suppressing the Autofill popups when the Touch To Fill sheet is shown. Touch To Fill provides more information than a password autofill dropdown, which is why it should take precedence. Bug: 948062, 1015789 Change-Id: I052c0f4d85f79da8818cc3b848d078efed4253f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868956Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#707762}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8bbd6af6..65397626 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibadbc6f0a5a294d7f476eb05715182c61440ccea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871889Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707761}
-
Omer Katz authored
Allocations during the atomic pause were never supported. Enforcing it using scopes helps debugging issues were this invariant is violated. Bug: 986235, 993415 Change-Id: I5fd8ecd147403e2a7a89185b55057550d135bac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869225 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707760}
-
Greg Thompson authored
The User Data dir cannot be cleanly deleted at the end of the main test function, as there remain files in-use within the directory at that point. Rather, scope the temp dir to the lifetime of the test harness so that it can be cleaned up after the test has been spun down. Bug: 546640 Change-Id: Id942c785bb6c84c40079bc4bde10fad4c7b16d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870113 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#707759}
-
Takashi Sakamoto authored
Bug: 1007769 Change-Id: I3fcf6d89e0bb50fdb9cabe737cb15ebb6a894b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868929Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#707758}
-
nancy authored
BUG=1009248 Change-Id: I9253de4ba310849dc52d0615c211ca11bb9dc548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859418Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707757}
-
Raphael Kubo da Costa authored
Adjust the comments in source and IDL files to match the latest version of the spec (5155c2030bf at the time of writing) following the implementation update commits that landed earlier this week. Bug: 257511 Change-Id: I5d7b89e7f878a70af08f0dddf399685d496e6fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869215 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707756}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3cdd6444cf91..e8c3f9b0b463 git log 3cdd6444cf91..e8c3f9b0b463 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 chris@chris-lamb.co.uk Ensure timestamp does not vary with timezone. (#2982) 2019-10-18 stevenperron@google.com Keep NOPs when comparing with original binary (#2931) 2019-10-18 alanbaker@google.com Check that derivatives operate on 32-bit values (#2983) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e8c3f9b0b463 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Bug: None Change-Id: I0b6fcbdf85cd103957df75aa29821f803919066d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871335Reviewed-by:
-
Nikita Podguzov authored
This extension demonstrates how chrome.printingMetrics API can be used to fetch print job metadata. This extension will be used for external documentation as well. Bug: 992889 Change-Id: I7b874e8961b02ebc8332ef804d9496e6fed35d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852252 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707754}
-
Miyoung Shin authored
This CL converts CameraModuleCallbacks{Ptr, Request} in media to the new Mojo type, and uses pending_remote<CameraModuleCallbacks> in camera_commom.mojom. Bug: 955171 Change-Id: I3184cb445f9211033af7176c9d97352b2edb849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862913 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#707753}
-
Peter Kasting authored
Bug: 82078 Change-Id: Id788fda5d89981544129fc9a9025c06378fcbd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870417 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707752}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fac64fcd1ec..f0a4d95ef687 git log 8fac64fcd1ec..f0a4d95ef687 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 eseckler@google.com Merge "processor: Move ftrace parsing and descriptors to importers/ftrace" Created with: gclient setdep -r src/third_party/perfetto@f0a4d95ef687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0d350aac43a5b2ce1a9510582427f880d481b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871334Reviewed-by:
-
Marc Treib authored
This updates lots of tests that explicitly enabled the feature, or that were parameterized to run with it both enabled and disabled. It does not remove all the now-dead code yet; that's left for followups. Bug: 933756 Change-Id: I9dfab6e304eeb0f7e63a0479c12e8e155a6a08f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863028 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707750}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser and renderer processes for the media::mojom::VideoDecoder, media::mojom::VideoDecoderClient and media::mojom::VideoFrameHandleReleaser to the new mojo types. Bug: 955171, 978694 Change-Id: Idbf067fa0d374ec8c52abd22774e9e2a29c4ed99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865214Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#707749}
-
Raphael Kubo da Costa authored
We were previously only checking if a WakeLockSentinel had any registered event listeners to decide whether it should be kept alive in HasPendingActivity(). This is not enough, as if the sentinel has been released, either by release() being called or because the WakeLock class ended up calling WakeLockManager::ClearWakeLocks(), it should also be eligible for garbage collection even if it still has one or more event listeners (as they will never be called again anyway). Bug: 1015788 Change-Id: I2fa328915e4e1d39344ef3ed5e56c985ef7ad451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868875 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c9fa747..8bbd6af6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I892afe9f3275e003792e4a6e4c5bccb894c2981e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871172Reviewed-by:
-
Jan Scheffler authored
This is a reland of 12915a69 Original change's description: > [devtools] Add Url and Path Column to Network Log > > This patch adds url and path as available columns to > the network log view and allows the name to be removed > because it is not needed if the user decides to show > the path or the whole url. > > Bug: chromium:993366 > Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jan Scheffler <janscheffler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698891} Bug: chromium:993366 Change-Id: I0061afbb7bdbc03cf3a7bd567530d21b66fa6d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823859Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707746}
-
Guido Urdaneta authored
Fix type and replace "audio stack" with "audio subsystem". Bug: 1009332 Change-Id: I6b4b80eca15c7e0ae2dc74c03f039a429e857d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869652 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#707745}
-
Hiroki Sato authored
When android clickable nodes are nested, currently only the outer nodes are clickable. In this case, even if there are multiple clickable inner nodes, only the outer node was clickable. This CL changes to set clickable property only when the node that is clickable in Android and there is no clickable descendant node of it. menu is accessible from ChromeVox.) Bug: b:141969848 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually (open PlayStore and confirm that search box and hamburger Change-Id: I6f62658f8d620d650678162d3547d86af66efa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849548 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#707744}
-
Javier Ernesto Flores Robles authored
The disabled test was checking a workaround for when the keyboard had a cycle of hide/show notifications without actually hiding itself. On iOS 13 this is fixed. Mark deprecated API as deprecated. Reenable test on iOS < 13. Bug: 1015550 Change-Id: I22931b1df71638bbebb4b11c1a1017317b446c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807325 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#707743}
-
Fergal Daly authored
Without this, isolate.py fails. python tools/swarming_client/isolate.py check -i out/Android-arm-dbg/android_browsertests.isolate -s out/Android-arm-dbg/android_browsertests.isolated Failed to find an input file: Input directory /usr/local/google/home/fergal/chromium/src/components/test/data/payments must have a trailing slash -> returned 1 Change-Id: I624016f2711038ad0f7920cac645e1b2c3d0f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871159Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707742}
-
Peter Kasting authored
Bug: 82078 Change-Id: I6c2e5ed7712540ac43f5b8db55e9a258c31778b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870601 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Supports UnlikelyExitNode (will be used frequently) and LikelyExitNode (will be used rarely). SymbolScopeNode now inserts SymbolDefinitionNodes much smarter than before. Bug: 839389 Change-Id: I4d0b708c39ea97ae1c500b69cf0d16158f748659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868578Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4c80c322597..c70966b3505e git log f4c80c322597..c70966b3505e --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6dee176c8d7d..4a80ba25e67b (13 commits) Created with: gclient setdep -r src/third_party/skia@c70966b3505e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: I83adf702dd44d988f2f75b26f206d680c86984db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871333Reviewed-by:
-
Takashi Toyoshima authored
Because of performance implication, we decided to require 'extraHeaders' option to intercept CORS preflights. Bug: 1002884 Change-Id: I00678e265a0488d18bd44451e5b2b1c6c71ad31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847607 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707738}
-
Henrik Boström authored
This unblocks https://webrtc-review.googlesource.com/c/src/+/155621 from landing and rolling into chromium. TBR=asapersson@chromium.org, hta@chromium.org NOTRY=True Bug: webrtc:7065 Change-Id: I59f9779c265bd3e1c6f24ae3a377a0d18cf95fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871430Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707737}
-
Francois Beaufort authored
This CL renames NFCReader to NDEFReader, NFCWriter to NDEFWriter, NFCReadingEvent to NDEFReadingEvent, NFCScanOptions to NDEFScanOptions, NFCPushOptions to NDEFPushOptions, and NFCError to NDEFError as suggested in Web NFC spec at https://github.com/w3c/web-nfc/pull/392 Bug: 520391 Change-Id: Ifc7d26d68b76bbf771a83cba94fc275819c28cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869227Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#707736}
-
Alexey Baskakov authored
We don't know the app_id of an install URL ahead of time. Sync-initiated installs should fail if expected client tag (global app id) doesn't match a publisher's app_id. This functionality will be used in dependent CL: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 Bug: 860583 Change-Id: I74588fdc3e675553a30eaf85f647a22ab786137a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866124 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707735}
-
sandromaggi authored
* terms requires review * thirdparty privacy notice Previously these texts were set from Android resource strings that had a parameter for the domain. To avoid discrepancies in displaying said domain, we aim to set it from the backend instead of evaluating and formatting it on the frontend. Add UI tests for texts newly being set by model changes (i.e. from the backend). Bug: b/142621971 Change-Id: Iffa48f200eeaa26c0c4b47ade4f2ea0dc330da19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862685 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Yang Guo authored
Bug: 1011259 Change-Id: If6a80fa169c5286ed536688ab39f67c37a27faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855938Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707733}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/acf922ce48cf..77780358011f git log acf922ce48cf..77780358011f --date=short --no-merges --format='%ad %ae %s' 2019-10-21 ukai@google.com put goma client in depot_tools Created with: gclient setdep -r src/third_party/depot_tools@77780358011f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: Ie57db75c380dde755fe425afc8eb77afd56bab31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871194Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/554a876f7e75..f4c80c322597 git log 554a876f7e75..f4c80c322597 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@f4c80c322597 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: If6b3efcc1138f55b4dfa518b303029acba8ec01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871193Reviewed-by:
-
Yang Guo authored
This adds external devtools frontend as DEPS, but does not start using it except for scripts and documentation. Build and tests are not affected. Bug: 1011259 Change-Id: I3b6173582bf88974784f6d758ad91b6f740b1b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855740 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707730}
-
Peter Kasting authored
Bug: 82078 Change-Id: I27457fb30c8f78060cdcc2bfdae18fd5d78c3920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870048 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#707729}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b32cc651..8c9fa747 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iccadf2d2d5536635abd93109483e1caec79f595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871170Reviewed-by:
-
Keith Lee authored
Change-Id: I47ddf6f917faff92a1b639c1f09cab3191d79f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833028Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#707727}
-
Matt Giuca authored
- Add mgiuca as owner for these histograms. - Remove logging of Manifest.IsEmpty (it is not useful). - Fixed enum names and histogram description: s/unique/opaque origin. Bug: 1006971 Change-Id: I649a752df64e460701c3989ee5f606057932d54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826066 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#707726}
-
