- 22 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2c8b5c637028..7b3cc35cb6e5 git log 2c8b5c637028..7b3cc35cb6e5 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 enga@chromium.org D3D12/Vulkan: Insert storage buffer barriers between compute pass dipatches Created with: gclient setdep -r src/third_party/dawn@7b3cc35cb6e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic132fdb46c1e31235a37005961ab647079fcb1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708294}
-
Richard Knoll authored
Before: Number initiated from <origin> After: Number from <origin> Bug: 1016771 Change-Id: I5e8bf255c42b3fa2c86cd0d564f63bc500045346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871602Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708293}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13a8e162476b..a043b2ba46b9 git log 13a8e162476b..a043b2ba46b9 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 thaloun@chromium.org Support case where win32socketserver's window class is not unregistered properly. 2019-10-22 gustaf@webrtc.org AnalyzeReverseStream with StreamConfig 2019-10-22 kron@webrtc.org Add per frame decode time histograms for 4k/HD and VP9/H264 Created with: gclient setdep -r src/third_party/webrtc@a043b2ba46b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/140961297,chromium:1007526 Change-Id: I98321daa4f025b92f013ca794a90a158bc48df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873494Reviewed-by:
-
Ken Rockot authored
Bug: 977637 Change-Id: I3571dc612fe3d2c1e99094e1a65c755411ec09e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867442 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708291}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I549acc341bed90899ae9da460faa5cbb7d68216e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873127 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708290}
-
Ian Struiksma authored
Test recipe capture_update_pass_nexon expects the username to be stored on password update, which will only happen with new feature. Updating test code to ensure the feature flag is set on test setup. If it is preferred to not use this feature in the tests for now, let me know and I will update the test recipe. Bug: 959776 Change-Id: I306886fbb9daa0e434e5011ebd6aa80c1dfeac5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872732Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#708289}
-
Eric Karl authored
In cases where a SurfaceDrawQuad's root render pass was not merged into its parent, we did not correctly handle cases where the root render pass represented a subset of the SurfaceDrawQuad's area. This was possible in OOPIF cases where the root render pass was clipped to visible bounds. This CL adjusts the root render pass so that it always represents the full SurfaceDrawQuad area. While it's possible to hit this bug without de-jelly, this is much more common with de-jelly, so the change is restricted to reduce merge risk. A follow-up will implement this change more generally. Bug: 1016677, 995965 Change-Id: If733065277128d53f0b59483f167d177aa777f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873277 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#708288}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f2b86c54d32..2638f3d44b02 git log 9f2b86c54d32..2638f3d44b02 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 bsalomon@google.com rename atlassize->atlasdimensions 2019-10-22 robertphillips@google.com Add creation-time POD memory pool for GrOps 2019-10-22 kjlubick@google.com [canvaskit] Expose various canvas features 2019-10-22 michaelludwig@google.com Revert "Enable Programs (formerly GLPrograms) test for other APIs" Created with: gclient setdep -r src/third_party/skia@2638f3d44b02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I0bbec02dd3d16355b6fa0e2249b390b4f4c126e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873492Reviewed-by:
-
liberato@chromium.org authored
Bug: 1016831 Change-Id: I11664e3a43e3eafae8fbc4db48d507e94cc119d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872576 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708286}
-
Joe DeBlasio authored
This CL removes everything Chrome-side for updating the Safety Tips component. It also addresses some nits in the proto file identified during internal review. See go/safety-tips-component-update for the updated instructions. Bug: 994270 Change-Id: Ic8d2b1573315f124728845078556307496e62f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873270 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708285}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0ce88df477b017468f27baa466f1744b6fa03eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873493Reviewed-by:
-
Lukasz Anforowicz authored
chrome.tabs.update is treated as renderer-initiated to address omnibox/url spoofing problems (see r698617). All renderer-initiated navigations need to have a non-null |initiator_origin| - the extension origin is used in case of chrome.tabs.update. The problem fixed by this CL, is that without explicitly specifying LoadURLParams::source_site_instance, the old SiteInstance of the navigated web contents might be used. In particular, when navigating a tab with https://example.com to about:blank, reusing the SiteInstance of https://example.com means that about:blank (with an origin associated with the extension) would commit in a process locked to https://example.com - this is undesirable from Site Isolation perspective. The CL fixes the problem above, by making sure that chrome.tabs.update populates LoadURLParams::source_site_instance in a way consistent with 1) initiator_origin and 2) the BrowserContext of the target tab. Note that when discussing this CL, we've explicitly decided against setting the |initiator_origin| to the (old/current) origin of the target tab. This is because such initiator would prevent the extension from being able to use chrome.tabs.update to navigate to non-web-accessible-resources owned by the extension. Additionally, using the origin of the target tab is subject to races with other navigations of the tab that might be happening in parallel. Note that this CL does *not* change the fact that using chrome.tabs.update to navigate a non-extension tab to about:blank will commit an *opaque* origin (with precursor set to the extension origin), rather than committing about:blank with the (non-opaque) extension origin. This aspect of behavior is not changed because: 1. There are no compelling reasons to make a change at this point. 2. Changing this behavior is possible when chrome.tabs.update is called from an extension frame in the same BrowserContext as the target tab (in this case |source_site_instance| can be set to the SiteInstance of the extension frame calling chrome.tabs.update). Unfortunately sometimes there is no extension frame (when chrome.tabs.update is called from an extension service worker) and sometimes the target tab is in a different BrowserContext (e.g. in an Incognito profile). Relevant tests: - (new) ExtensionApiTest.TabsUpdate_WebToAboutBlank - (new) ExtensionApiTest.TabsUpdate_WebToNonWAR - IncognitoApiTest.Incognito - ServiceWorkerBasedBackgroundTest.FilteredEvents - ServiceWorkerBasedBackgroundTest.TabsEvents Change-Id: I31b298d9a118de45ba4a255d2384d82f029c8b7a Bug: 991607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850355 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708283}
-
Steven Bennetts authored
This isn't a huge gain, but it's something, and I'm not aware of any reason not to compress these. Bug: 965089 Change-Id: I3931f406f7d78b8e01ed25324dfa89f675874ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872993 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708282}
-
Manas Verma authored
Even if the user has opted-in for FIDO authentication, an expired card should invoke the CVC prompt in order to update the expiration date. Bug: 949269 Change-Id: I814a21113d13187520260535c47d57b1bb1e5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869759 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#708281}
-
rbpotter authored
third_party/polymer/v1_0/minify_polymer.py was using --in-html and --out-html arguments to Polymer bundler when minifying polymer. These arguments are no longer valid in bundler v4, so the script was broken by: https://chromium-review.googlesource.com/c/chromium/src/+/1857568 Update the script to work with the new version of bundler. Bug: 921285 Change-Id: I52f82ef3cfb36ec79c61e69aec7185098d19226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873372Reviewed-by:
-
Yue Zhang authored
* Add one indicator line below dialog title to show that the title is editable. The line is grey by default and blue when editing title. * When user exits editing mode with an empty string as title, restore the default "# tabs" title in both dialog and tab switcher. Bug: 1001738, 1014004 Change-Id: Id6c13f887f2f6ce5aaa5f50a237e38ddb6cd341f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863109 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708279}
-
Peter Kotwicz authored
This CL disables TrustedWebActivityTests#testStatusBarColorCertificateError() TrustedWebActivityTests#testToolbarVisibleCertificateError() TBR=pkotwicz,alexilin BUG=1016743,1016746 Change-Id: I74ac6eb22c98d561d2ab03589eea3b7b51176786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874190Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#708278}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1b1491b05a2..e6207efbf4c2 git log e1b1491b05a2..e6207efbf4c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 tneda@google.com Merge "perfetto-ui: uncollapse tracks with heap profiles" 2019-10-22 treehugger-gerrit@google.com Merge "Allow messages from corp.google.com origins" 2019-10-22 treehugger-gerrit@google.com Merge "perfetto-ui: Fix async_slices track queries" Created with: gclient setdep -r src/third_party/perfetto@e6207efbf4c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Icdf4d33ae2660a4dc45c46987bef8764819eeb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873287Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 246 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-19. Change-Id: Ia4e161c7125b8d76f4d480716a8bbe19b9cb53e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872809 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#708276}
-
Ella Ge authored
This reverts commit 516cf22e. Reason for revert: compile failure on windows https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/6356 Original change's description: > Reland: SuperSize: 3x speedup by minimizing string allocations > > Use runtime endianness check to avoid system-dependent header files. > > Bug: 1011921 > Change-Id: I1870db11d986eb8a805c5105ed67750cb8ce2c96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873395 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708269} TBR=agrieve@chromium.org,jaspercb@chromium.org Change-Id: I98b4abcfdfff28bbad60b11c4cd406b4ff89c6ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873722Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708275}
-
Allen Bauer authored
It was virtual at some point, but never overridden. The virtual was removed in a previous CL, which rendered its intent as moot. Change-Id: Ia6c4ac1a5cd657e0ccc682508b35fc652e4b7e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872754 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#708274}
-
Mohamed Amir Yosef authored
Primary keys of the login database are used as storage key for Password USS Sync. Currently, they are recycled and hence are causing Sync to commit entities with wrong client tags. This CL fixes that by adding the AUTOINCREMENT flag to the primary key column. Since the SQLTableBuilder is currenly only used for creating PasswordManager databases, and for simplicity, this CL is restricting the primary key to be a single INTEGER column. Bug: 1016718,902349 Change-Id: I931826547b92566f631b4ca12b53039be3ceb491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872099 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708273}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62b5cdc733cc..8017a6a7fc26 git log 62b5cdc733cc..8017a6a7fc26 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org use enumerate in a few more places 2019-10-22 vapier@chromium.org virtualenv_wrapper: fix string handling Created with: gclient setdep -r src/third_party/chromite@8017a6a7fc26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2377d22ef65ad8e146e9a4510a46d1c35b095cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872934Reviewed-by:
-
Synthia authored
If user click on Cancel button in dialog,then Dialog should be disapper and display a error message Bug: 1006820 Change-Id: I5a75da76c4b5403a824f49855f9f939de74bd984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860734Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708271}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0dbd897b2d65..2ba136292e50 Created with: gclient setdep -r src-internal@2ba136292e50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Id9b170376df7452f60c76e4809bb13d394237da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708270}
-
Jasper Chapman-Black authored
Use runtime endianness check to avoid system-dependent header files. Bug: 1011921 Change-Id: I1870db11d986eb8a805c5105ed67750cb8ce2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873395Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708269}
-
Chris Mumford authored
ChromeAndroidBase.version, AndroidWebview.find_binary, and ChromeAndroidBrowser._adb_run were not using the device serial supplied by the --device-serial command-line option. Additionally the device serial number was not being passed to the webdriver when running tests for Chromium on Android. Bug: None Change-Id: I3f79191a9cb556f119f7b167f363bf596591c2c8 TESTING: Manually for both Chromium and WebView. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860676 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#708268}
-
Scott Little authored
Before this CL, the VisibleLoadTime metrics for image elements are recorded when the image finishes loading. This means that: (a) Images that finish loading before the image element's visibility observer triggers for the first time will have their VisibleLoadTime recorded as being below-the-fold, even if the image is actually above-the-fold, (b) When automatic lazyloading is disabled, VisibleLoadTime samples will be recorded for images that finish loading even if the viewport is never scrolled near the image, meaning that many more samples will be recorded than when automatic lazyloading is enabled. To solve this, this CL changes VisibleLoadTime for images to be recorded after the image becomes visible, instead of being recorded when the image finishes loading. This also makes the metric consistent with how VisibleLoadTime is recorded for frames. Bug: 1010761 Change-Id: I2d89d413df1d49a2aa0d8974fcc188d86e0e6d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870109Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708267}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/66aae7e647fd..9122bec28506 git log 66aae7e647fd..9122bec28506 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mihu@microsoft.com Fix EXT_multisample_render_to_texture perf regression 2019-10-22 jmadill@chromium.org Metal: Move ldflags to Metal backend config. Created with: gclient setdep -r src/third_party/angle@9122bec28506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015031,chromium:1014228 Change-Id: I347f991a0a19706680cb3c47bfd9357dc66d7ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872320Reviewed-by:
-
danakj authored
The renderer doesn't expect emulation to be disabled if already disabled, and no need to do any work. R=yangguo@chromium.org Bug: 1015926 Change-Id: Ib35f232761ec096519af777752d327be5de99b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868656 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708265}
-
Ahmed Fakhry authored
This reverts commit 561b1956. Reason for revert: This solution is broken, will land a proper fix soon. Original change's description: > Fix regression that dev-shortcut to enable tablet mode doesn't show overview button > > This was a rgression caused by a previous CL of mine https://crrev.com/c/1865543. > Using the developer keyboard shortcut to enable tablet mode should > force the overview tray button visible even though the internal > input events are not being blocked. > > BUG=1016594, 925087 > TEST=Manually, added a new test. > > Change-Id: Ic9046c07dcce9de03c5fc5acd10a2077d599c711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872468 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708222} TBR=xiyuan@chromium.org,afakhry@chromium.org Change-Id: I98c49ad99d804242adaa7172de9e74337bdecda1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016594, 925087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874199Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708264}
-
Ella Ge authored
TBR=xidachen@chromium.org No-Try: true Bug: 1008826 Change-Id: I91b36c8395da6096c553a5c3a5efee31de5cf4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874195Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708263}
-
David Black authored
Query source should be set in |AssistantInteractionMetadata| so that we have the most accurate information possible when setting the pending query source in |AssistantInteractionController::OnInteractionStarted|. This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1869811 Bug: None Test: Built locally Change-Id: I18280710fc48d623c303453ab860c0b0331f071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870989 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#708262}
-
Tomasz Wiszkowski authored
This change introduces Android specific ZPS configuration variants. Bug: 1016557 Change-Id: I036474be17b657d608fed7f9225a0b5ace41408f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873085 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708261}
-
Guido Urdaneta authored
The old heuristic checked that the title of all windows was readable, but it failed in some corner cases where an application creates a window whose title cannot be read even with screen capture permissions. The new heuristic checks that the title of at least one normal, dock or status window running on another process is readable, which is less susceptible to failures. Drive-by: return SYSTEM_PERMISSION_DENIED instead of PERMISSION_DENIED when the system permission check fails in getDisplayMedia(). Bug: 993692 Change-Id: Ie127d1e2d6bd29dd8885b0c461bdab838559fcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871885 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708260}
-
Elly Fong-Jones authored
This dialog gets its strings from a CredentialLeakDialogController. The only subclass of that class, CredentialLeakDialogControllerImpl, returns a string depending solely on its leak_type_ member, which is const. It is therefore safe to fetch the strings once at construction time and keep them. Bug: 1011446 Change-Id: I795b98548e084b1c3cf9ae389d2f41017452fb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872571Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708259}
-
Dana Fried authored
That's it! Change-Id: I6f4fefd046345834bc68aea69e59f7bbd7574b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873913 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#708258}
-
Maks Orlovich authored
We will restrict cookies from 3rd party contexts when they don't explicitly grant such access, and require those accessible there to be secure, so some tests need updated to mark their partiness correctly, and to not try to use insecure 3rd-party accessible cookies. Bug: 1016512 Change-Id: I86659cf72d64d26597a0be3b74793b009d5c8a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872572Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#708257}
-
Wei-Yin Chen (陳威尹) authored
Bug: 991888 Change-Id: I9cf0ff45a08532377f16cbee6c063ed71fa38bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808582Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708256}
-
dpapad authored
This is in preparation of converting the remaining parts of PDF Viewer to JS modules. Fixed: 1011585 Change-Id: I904ec1b03268e9d11881f4055173bcea5c952326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842625 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708255}
-
