- 03 Dec, 2016 30 commits
-
-
thanhph authored
To reduce IPC calls between window_tree_client.cc and window_tree.cc. BUG=632049 Review-Url: https://codereview.chromium.org/2520093003 Cr-Commit-Position: refs/heads/master@{#436115}
-
Lucas Garron authored
Normally, regenerating this file is deterministic. I can't find a discrepancy between the JSON and the behaviour of the generated data, but this updates the .h so we can debug without blocking further changes right now. BUG=670139 TBR=palmer@chromium.org Review URL: https://codereview.chromium.org/2549903003 . Cr-Commit-Position: refs/heads/master@{#436114}
-
rockot authored
Instead of immediately tearing down the image_decoder service once it's idle, wait 5 seconds in case there are going to be more requests soon. This mirrors the behavior of utility process image decoding prior to servicification, and is intended to address latency issues with multiple image decodes happening in quick (but not quite immediate) succession. BUG=669835 Committed: https://crrev.com/0798a4585e6cb5df5e5596b8692656fca669cc28 Review-Url: https://codereview.chromium.org/2538833004 Cr-Original-Commit-Position: refs/heads/master@{#435815} Cr-Commit-Position: refs/heads/master@{#436113}
-
twifkak authored
This brings it in sync with components/precache/OWNERS. BUG= Review-Url: https://codereview.chromium.org/2541163002 Cr-Commit-Position: refs/heads/master@{#436112}
-
vakh authored
Doing TBR so that we can get some information from the minidumps over the weekend. BUG=660293 TBR=csharrison Review-Url: https://codereview.chromium.org/2542373002 Cr-Commit-Position: refs/heads/master@{#436111}
-
dmazzoni authored
If WebContentsImpl::IsNeverShown() is true, like for an extension background page, then there's never a reason to enable accessibility. Update WebContentsImpl::SetAccessibilityMode to check for this, and also update the UI page for chrome://accessibility to avoid exposing such views. BUG=365370 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2544993002 Cr-Commit-Position: refs/heads/master@{#436110}
-
sczs authored
BUG=666732 Review-Url: https://codereview.chromium.org/2550813002 Cr-Commit-Position: refs/heads/master@{#436109}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/51d77ffdc635..d87fbee77524 $ git log 51d77ffdc..d87fbee77 --date=short --no-merges --format='%ad %ae %s' 2016-12-02 scroggo Do not create an SkRawCodec with zero dimensions Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@google.com Review-Url: https://codereview.chromium.org/2549943002 Cr-Commit-Position: refs/heads/master@{#436108}
-
erg authored
BUG=665074 Review-Url: https://codereview.chromium.org/2525563003 Cr-Commit-Position: refs/heads/master@{#436107}
-
dbeam authored
R=dschuyler@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2544453003 Cr-Commit-Position: refs/heads/master@{#436106}
-
jeffcarp authored
These tests were failing around 17% of the time on Windows. BUG=670846 R=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2550733002 Cr-Commit-Position: refs/heads/master@{#436105}
-
eugenebut authored
This matcher will be used to check that interstitial was dismissed after going back or proceeding. BUG=531721 Review-Url: https://codereview.chromium.org/2546193002 Cr-Commit-Position: refs/heads/master@{#436104}
-
dbeam authored
R=dschuyler@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2538373002 Cr-Commit-Position: refs/heads/master@{#436103}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8d05c456e60b..ca719be61d32 $ git log 8d05c456e..ca719be61 --date=short --no-merges --format='%ad %ae %s' 2016-12-02 aiolos Make telemetry use the same chrome stable build as tracing/dashboard. 2016-12-02 aiolos Update Chrome Cannary/Dev channel reference builds. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2550783002 Cr-Commit-Position: refs/heads/master@{#436102}
-
tbansal authored
Initialize data reduction proxy (DRP) bypass stats on IO thread, and register as a network change notifier on the IO thread. This ensures that network change notifier does not notify DRP bypass stats on IO thread after DRP bypass stats has been destroyed. This prevents the use after null crash. Also, add thread checker to some of the other DRP classes. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=669929 Review-Url: https://codereview.chromium.org/2546023002 Cr-Commit-Position: refs/heads/master@{#436101}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/372ee1fb..6e549d18 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2544423002 Cr-Commit-Position: refs/heads/master@{#436100}
-
toyoshim authored
NOTRY=true BUG=na Review-Url: https://codereview.chromium.org/2549763002 Cr-Commit-Position: refs/heads/master@{#436099}
-
watk authored
This deletes things that are very VDA specific and will not be reusable. BUG=660942 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2550523003 Cr-Commit-Position: refs/heads/master@{#436098}
-
paulmiller authored
This grows standalone WebView APKs by ~1MB. Ameliorating the growth is tracked in the same bug. BUG=662166 Review-Url: https://codereview.chromium.org/2541993002 Cr-Commit-Position: refs/heads/master@{#436097}
-
fgorski authored
* Small refactoring to ChangeRequestsStateTask to use a more efficient method to query requests (which was not available at the time it was originally created). BUG=651238 Review-Url: https://codereview.chromium.org/2541423002 Cr-Commit-Position: refs/heads/master@{#436096}
-
jcivelli authored
RenderMessageFilter interface (it has to be part of the associated interface for now because of ordering issue with other CC messages). As part of that, unified the bitmap allocation behavior in ChildSharedBitmapManager on all platforms, by allocating shared memory with the generic shared memory allocation code path and then registering it as a bitmap. Also moved ChildSharedBitmapManager from the ChildThreadImpl to RenderThreadImpl as it is not common to all child processes. BUG=612500 TEST=content_shell should run normally with the --dissable-gpu flag. Review-Url: https://codereview.chromium.org/2488913003 Cr-Commit-Position: refs/heads/master@{#436095}
-
dschuyler authored
This CL cleans up the test setup and adds a test for the toggle control in settings. BUG=None Review-Url: https://codereview.chromium.org/2517753002 Cr-Commit-Position: refs/heads/master@{#436094}
-
thakis authored
Also add a comment about the current state of ubsan. BUG=669642 Review-Url: https://codereview.chromium.org/2550593004 Cr-Commit-Position: refs/heads/master@{#436093}
-
csharrison authored
SameDomainOrHost does not require Origins. In fact, we just convert the origins back to GURLs to do the check, which just looks at the host piece of the url. This conversion is not free in either direction, as we need to do allocations, copies, and in some cases, url-related policies (e.g. in constructing the underlying SchemeHostPort of Origin). BUG=664174 Review-Url: https://codereview.chromium.org/2542843009 Cr-Commit-Position: refs/heads/master@{#436092}
-
dpapad authored
BUG=669261 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2544723002 Cr-Commit-Position: refs/heads/master@{#436091}
-
zmo authored
BUG=662644 TEST=GPU FYI bots NOTRY=true R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2549513003 Cr-Commit-Position: refs/heads/master@{#436090}
-
kumarniranjan authored
The test HandsOffNetworkScreenTest.RequiresNoInput was flaky. Made some changes to fix that. BUG=668054 TEST=browser test Review-Url: https://codereview.chromium.org/2526423002 Cr-Commit-Position: refs/heads/master@{#436089}
-
jamescook authored
Now that we don't support Ash on Windows we don't need all the conditional code in this test. The reason I'm cleaning up this one first is because it contains the string "ash_unittests.exe" and I'm eliminating all references to Windows-specific binaries. BUG=670351 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2529293014 Cr-Commit-Position: refs/heads/master@{#436088}
-
fdoray authored
This CL replaces base::WorkerPool::PostTask() with base::PostTaskWithTraits(). The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). With File IO: The task waits on synchronous file IO operations. With Wait: The task waits on things other than synchronous file IO operations (e.g. WaitableEvent, ConditionVariable, join a thread, join a process, blocking system call that doesn't involve interactions with the file system). BUG=659191 Review-Url: https://codereview.chromium.org/2533473002 Cr-Commit-Position: refs/heads/master@{#436087}
-
carlosk authored
If a second offline snapshot starts for the same page load where a previous one was saved, it should not immediately delete it: as it might fail the user would end up with no offline copy of the page. This change fixes this issue. Three new tests are added: one to cover this precise case and a couple more to check for related situations. Also many comments were added or updated. BUG=655697 Review-Url: https://codereview.chromium.org/2542833003 Cr-Commit-Position: refs/heads/master@{#436086}
-
- 02 Dec, 2016 10 commits
-
-
crouleau authored
Added e9ff58f7acde29c4e53c761da775293e776bcc23 to internal repo. BUG=665305 Review-Url: https://codereview.chromium.org/2547203002 Cr-Commit-Position: refs/heads/master@{#436085}
-
majidvp authored
- WTF::TimeDelta aliased base::TimeDelta - WTF::{Time,TimeTicks} are a thin wrapper around base::{Time,TimeTicks} this is mainly because we want to control the API surface we expose in particular we want to avoid exposing string parsing functions at this time. Once we have these types we can start replacing usage of double and int to represent time in blink with more accurate and type safe representations. Relevant discussion: https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/7kg1FAsXkng/l19cEeBPBAAJ BUG=625680, 402027 TEST=Critical functionality is already covered in base/time/time_unittest.cc but added a smoke test in TimeTest.cpp Review-Url: https://codereview.chromium.org/2543663002 Cr-Commit-Position: refs/heads/master@{#436084} -
yusukes authored
This is a follow-up CL for https://codereview.chromium.org/2487623002/. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2547163002 Cr-Commit-Position: refs/heads/master@{#436083}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2421983002 Cr-Commit-Position: refs/heads/master@{#436082}
-
jamescook authored
BUG=none TEST=none Review-Url: https://codereview.chromium.org/2549733002 Cr-Commit-Position: refs/heads/master@{#436081}
-
kbr authored
There are two high-level goals for the handling of WebGLObjects: 1) When they are GC'd, the underlying graphics resource is deleted promptly. 2) When the context is destroyed, all of the underlying graphics resources are reclaimed. The WebGLContextObject and WebGLSharedObject maps were an attempt to implement (2) before WebGL contexts were in their own client-side share group, separate from the compositor. Unfortunately, with the introduction of Oilpan, it's become clear that there are longstanding bugs in the lifetime management of WebGLObjects. These bugs recently began manifesting frequently on the bots. To fix these bugs, WebGLObjects are now eagerly finalized, rather than the WebGLRenderingContextBase. WebGLObjects maintain a strong reference either to their context or share group, depending on whether they're per-context or shared objects. WebGLContextGroup becomes an Oilpan object which maintains weak references to all of its contexts (currently, just one). WebGLRenderingContextBase maintains a strong reference to its context group. Because WebGLObjects can no longer be enumerated, their invalidation during context loss needs to be rewritten. This is handled by tracking the number of context losses on a per-share-group basis, and comparing this with a cached version in each WebGLObject instance during its validation. As a consequence of this change, most of the work in WebGLRenderingContextBase's destructor, as well as in the destructors of corollary types like WebGLExtension, becomes useless, and it has been removed. The destructors of the WebGLObject subclasses have been made more uniform to prevent errors. More fixes around wrapper tracing are probably both needed and enabled by this CL, but they can follow this necessary fix. BUG=537054, 666061 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2547813002 Cr-Commit-Position: refs/heads/master@{#436080}
-
ltian authored
1. Add the last_visited field in template_url_data to monitor last visited time of each search engine. 2. The last_visited will be updated to current time each time the OpenSearch description document is detected. 3. For now, last_visited will not be synced if the template_url is existed. BUG=348360 Review-Url: https://codereview.chromium.org/2498053002 Cr-Commit-Position: refs/heads/master@{#436079}
-
rob.buis authored
It was decided to rename canMakeActivePayment to canMakePayment: https://github.com/w3c/browser-payment-api/pull/316 Note that this feature is still behind a runtime flag, now named CanMakePayment. BUG=587995 Review-Url: https://codereview.chromium.org/2545523004 Cr-Commit-Position: refs/heads/master@{#436078}
-
wangxianzhu authored
This ensures that the bounds of scroll is updated. BUG=645667 Review-Url: https://codereview.chromium.org/2545093002 Cr-Commit-Position: refs/heads/master@{#436077}
-
dtapuska authored
Some pages have a zero width/height embedded flash element. They should not request touch/wheel event listeners if they don't have a size. This is the easiest way to let blink know that pepper doesn't require the events. BUG=670103 Review-Url: https://codereview.chromium.org/2551493002 Cr-Commit-Position: refs/heads/master@{#436076}
-